History log of /3.0.2-MP2/couchdb/ (Results 1 - 25 of 3723)
Revision (<<< Hide revision tags) (Show revision tags >>>)Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
Revision tags: v4.6.0, v4.5.0
19551d2b26-Nov-2014 harsha <hhs.couchbase@gmail.com>

Revert "MB-11917 Async couch_view_parser implementation"

This reverts commit 3bf0b23892a11299ff5cc25e3d1ebf83e3beec9f.
Reverting async couch_view_parser implementation as it is
resul

Revert "MB-11917 Async couch_view_parser implementation"

This reverts commit 3bf0b23892a11299ff5cc25e3d1ebf83e3beec9f.
Reverting async couch_view_parser implementation as it is
resulting in lexical error and also not helping in resolving
erlang scheduler collapse issue.

Change-Id: I94f1cc5c0eb78bcbd95e321b0ed4d43870cc439b
Reviewed-on: http://review.couchbase.org/43633
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Nimish Gupta <nimish@couchbase.com>

show more ...

44d4d9b226-Nov-2014 harsha <hhs.couchbase@gmail.com>

Revert "MB-12697 Serialize parse_json requests chunks per query context"

This reverts commit cede9fe0761aa36eec2488103485c7b985e08f77.

Change-Id: Ieee9ccf680b1e627c4d6e0d30377ca8600

Revert "MB-12697 Serialize parse_json requests chunks per query context"

This reverts commit cede9fe0761aa36eec2488103485c7b985e08f77.

Change-Id: Ieee9ccf680b1e627c4d6e0d30377ca860040f7de
Reviewed-on: http://review.couchbase.org/43632
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Nimish Gupta <nimish@couchbase.com>

show more ...

cede9fe021-Nov-2014 harsha <hhs.couchbase@gmail.com>

MB-12697 Serialize parse_json requests chunks per query context

The order of processing json parsing request chunks
was assigned randomly to an execution thread which
resulted in lex

MB-12697 Serialize parse_json requests chunks per query context

The order of processing json parsing request chunks
was assigned randomly to an execution thread which
resulted in lexical error while processing json
parsing request during view querying. It is now
serialized, such that the request chunks per query
is processed in the same order of their arrival by
queueing every chunk to same execution thread.
However different query requests are assigned
randomly to a thread in the thread pool.

Change-Id: I16c89f7d4d422e9521ffc2a98d1d035b40e9b0fa
Reviewed-on: http://review.couchbase.org/43494
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Reviewed-by: Sriram Melkote <siri@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

6f2f1af218-Nov-2014 Artem Stemkovski <artem@couchbase.com>

do not return url in the "from" field of view_merger error record

because it can contain user:pasword@ and overall contains too much
internal info for user to know

return host:p

do not return url in the "from" field of view_merger error record

because it can contain user:pasword@ and overall contains too much
internal info for user to know

return host:port instead so the user knows which node had a problem

Change-Id: Ia7d401ba70161cf79afabe899b0e24e6331c30a2
Reviewed-on: http://review.couchbase.org/43382
Tested-by: Artem Stemkovski <artem@couchbase.com>
Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

3bf0b23805-Nov-2014 harsha <hhs.couchbase@gmail.com>

MB-11917 Async couch_view_parser implementation

Scheduler collapse in Erlang R16 is observed due to changes made
in R16 version with regard to erlang thread scheduler in general
and

MB-11917 Async couch_view_parser implementation

Scheduler collapse in Erlang R16 is observed due to changes made
in R16 version with regard to erlang thread scheduler in general
and to scheduling NIF threads in particular. couch_view_parser is
a json stream parser NIF and takes variable amount of time to parse
incoming data depending on the incoming stream length. This resulted
in reporting improper reduction count to erlang scheduler, which in
turn caused scheduler collapse. This NIF is now implemented in
asynchronous fashion, where NIF queues the incoming tasks and returns
to erlang world immediately.

Change-Id: I9e87fe63b78b10a31aba70aba31913d60331b5d7
Reviewed-on: http://review.couchbase.org/42821
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: Harsha H S <hhs.couchbase@gmail.com>

show more ...

7f6f0e2810-Nov-2014 Nimish Gupta <nimish@couchbase.com>

MB-12572 Sync the view group after upgrade

During offline upgrade of couchbase, if seqs are empty([]) in the
group, initial build will happen after upgrade and that will set
partitio

MB-12572 Sync the view group after upgrade

During offline upgrade of couchbase, if seqs are empty([]) in the
group, initial build will happen after upgrade and that will set
partition version list to nil.We should sync the group after upgrading
the header, so that partition version list will not be nil after
initial build.

Change-Id: I3eb5114d69dc2c8087310b59d28ff3e01e6ef5e2
Reviewed-on: http://review.couchbase.org/43048
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

e34cf8e207-Nov-2014 Volker Mische <vmx@couchbase.com>

MB-12048: Add test for upgrading header from 2.x to 3.x

There was a unit test missing that the upgrading from a Couchbase 2.x
to a 3.x view file really works.

Change-Id: I819f7a

MB-12048: Add test for upgrading header from 2.x to 3.x

There was a unit test missing that the upgrading from a Couchbase 2.x
to a 3.x view file really works.

Change-Id: I819f7a1594e73765223871da5f1652826f1b926c
Reviewed-on: http://review.couchbase.org/42933
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Nimish Gupta <nimish@couchbase.com>
Tested-by: Volker Mische <volker.mische@gmail.com>

show more ...

232747b406-Nov-2014 Volker Mische <vmx@couchbase.com>

Make test logging more verbose

With the `--verbose` set the test logging output is more verbose.
The output on the screen is still the same it only changes what
gets written to the l

Make test logging more verbose

With the `--verbose` set the test logging output is more verbose.
The output on the screen is still the same it only changes what
gets written to the log file.

Change-Id: Iedaf4612d406450a2fc25e6066e325aa137915cf
Reviewed-on: http://review.couchbase.org/42893
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>

show more ...

529883ba12-Aug-2014 harsha <hhs.couchbase@gmail.com>

MB-11755 Receive memcached messages in bulk

Receive worker in DCP client handled memcached messages
individually, reading header first and any extra bytes
as indicated in header. Thi

MB-11755 Receive memcached messages in bulk

Receive worker in DCP client handled memcached messages
individually, reading header first and any extra bytes
as indicated in header. This resulted in making several
thousands of tcp receive calls per design doc and
resulted in timeouts while handling stat responses from
memcached. This behavior is modified to receive all the
available data for memcached from socket and process each
individual response from the stored binary, which results
in far few tcp receive calls. Socket connection is made
active and buffer size is set to 64K, same as TCP window
size. More than 2x increase in speed is observed for
accesses to stat responses from memcached.

Change-Id: I5b25f3ed15b6825b8e88fac6e1eb4d1e5dbe3c5f
Reviewed-on: http://review.couchbase.org/40570
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: Harsha H S <hhs.couchbase@gmail.com>

show more ...

1cf5cbe331-Oct-2014 Volker Mische <vmx@couchbase.com>

MB-12251 Don't log stacktrace on query parse errors

Change-Id: I437f736a9e268244450de0538e93a102b2c2d38e
Reviewed-on: http://review.couchbase.org/42672
Reviewed-by: Volker Mische <vo

MB-12251 Don't log stacktrace on query parse errors

Change-Id: I437f736a9e268244450de0538e93a102b2c2d38e
Reviewed-on: http://review.couchbase.org/42672
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>

show more ...

c34007e315-Oct-2014 Volker Mische <vmx@couchbase.com>

MB-12357 Make customs errors in updater possible

When there was an error in the updater it is not possible to send
a custom error. So if you throw a custom error:

throw({cus

MB-12357 Make customs errors in updater possible

When there was an error in the updater it is not possible to send
a custom error. So if you throw a custom error:

throw({custom_error, <<"this is the reason">>)

Such an error was always wrappen into another error tuple, hence
ending up as:

{error, {custom_error, <<"this is the reason">>}}

This lead to a user visible response of:

{"error":"error","reason":"{custom_error,<<\"this is the reason\">>}"}

This is not user-friendy or what you would expect. With this commit
the response is:

{"error":"custom_error","reason":"this is the reason"}

Change-Id: If68ffb9d5b8d70de338a9441ed74edb2aa28f33a
Reviewed-on: http://review.couchbase.org/42163
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

f0c69b1602-Oct-2014 Volker Mische <vmx@couchbase.com>

Make geocouch's dialyzer happy

geocouch uses some of the couchdb functions, hence some type specs
need to be adapted in order to make the dialyzer run on geocouch
happy.

Cha

Make geocouch's dialyzer happy

geocouch uses some of the couchdb functions, hence some type specs
need to be adapted in order to make the dialyzer run on geocouch
happy.

Change-Id: Iaea98815ac8670d7222c181f6d11d406ff5295a9
Reviewed-on: http://review.couchbase.org/41951
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>

show more ...

2897407824-Sep-2014 Volker Mische <vmx@couchbase.com>

MB-12112 Add option to add search paths to unit test run script

It's now possible to add additional search paths for beam files via
the "-f" option. It expects a format that can be used

MB-12112 Add option to add search paths to unit test run script

It's now possible to add additional search paths for beam files via
the "-f" option. It expects a format that can be used in ERL_FLAGS.

This makes it possible for geocouch to add additional modules needed
to run the unit tests. It's about test helpers residing in the the
`test` subdirectory of the geocouch apps.

Change-Id: I339ff146a4920db0d59a8eafb02cf910e2dc02a1
Reviewed-on: http://review.couchbase.org/41762
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

82a9257002-Oct-2014 Volker Mische <vmx@couchbase.com>

Check whether PLT file is outdated or not

Erlang's dialyzer creates a PLT file for static analysis. Creating
such a file takes a long time, hence it's preserved between builds
on the

Check whether PLT file is outdated or not

Erlang's dialyzer creates a PLT file for static analysis. Creating
such a file takes a long time, hence it's preserved between builds
on the build bots.

It can happen that the PLT file is outdated and needs to be
regenerated. This commits adds the automated regeneration.

Change-Id: I1194c8db44a662821e8f55d435ee2e34d4c61707
Reviewed-on: http://review.couchbase.org/41814
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

efc2e92823-Sep-2014 Volker Mische <vmx@couchbase.com>

MB-12112 Simplify unit test runner

The unit test runner `runtest.py` needed the source as well as the
build directory of couchdb. This didn't work well as ERL_LIBS picks
the first ap

MB-12112 Simplify unit test runner

The unit test runner `runtest.py` needed the source as well as the
build directory of couchdb. This didn't work well as ERL_LIBS picks
the first application it encounters without checking if there might
be one which contains missing files later in the path.

The build system was changes so that the build directory also includes
the header files, hence only the information about the build path is
needed.

The `source` parameter got renamed to `libsdirs` and now takes a
directory as input that will be added to the ERL_LIBS environment
variable. This enables geocouch to use the same test runner.

All the subdirectories from the supplied couchdb build directory are
now added to erl_flags. This way you don't need to supply as many
modules as previously.

Change-Id: I07d5c40071ea85342ef72d2e64acf9feda0fb25c
Reviewed-on: http://review.couchbase.org/41581
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

3824c9a002-Sep-2014 Volker Mische <vmx@couchbase.com>

MB-12112: Streamline CMake files

With an improved ERL_BUILD_OTP macro less code is needed within
the individual CMakeLists.txt files.

Change-Id: I9b03b82194dc787715730d3adb2bc59

MB-12112: Streamline CMake files

With an improved ERL_BUILD_OTP macro less code is needed within
the individual CMakeLists.txt files.

Change-Id: I9b03b82194dc787715730d3adb2bc599af162d0a
Reviewed-on: http://review.couchbase.org/41147
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Chris Hillery <ceej@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

8b066e9304-Sep-2014 Sarath Lakshman <sarathlakshman@slynux.com>

MB-12128 Add a unit test to verify RYOW property of stale=false query

When a user issues a stale=false query, it should ensure RYOW property.
That means if a document is modified and a s

MB-12128 Add a unit test to verify RYOW property of stale=false query

When a user issues a stale=false query, it should ensure RYOW property.
That means if a document is modified and a stale=false query is issued,
the user should see atleast his change or changes that happened later
in the corresponding view index entries.

Added a unit test case to validate read your own write (RYOW) property
statisfied by stale=false queries.

Change-Id: I1c07c9f7a622e76abda55fb0775f72270679308d
Reviewed-on: http://review.couchbase.org/41192
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

cfade5fb01-Sep-2014 Sarath Lakshman <sarathlakshman@slynux.com>

MB-12128 Revert "Optimize for improving stale=false query latency"

The reverted commit breaks stale=false query's RYOW property

This reverts commit e866fe9330336ab1bda92743e0bd99453

MB-12128 Revert "Optimize for improving stale=false query latency"

The reverted commit breaks stale=false query's RYOW property

This reverts commit e866fe9330336ab1bda92743e0bd994530532cc8.

Change-Id: I051833e3ddad39ae28e93fff1eff4f79e36b18f4
Reviewed-on: http://review.couchbase.org/41193
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

c2af28d203-Sep-2014 Sarath Lakshman <sarathlakshman@slynux.com>

MB-12110 Extract snapshot marker type correctly

Snapshot type is determined by extracting the corresponding bits
in the marker type bit fields from snapshot marker upr message.

MB-12110 Extract snapshot marker type correctly

Snapshot type is determined by extracting the corresponding bits
in the marker type bit fields from snapshot marker upr message.

The current implementation checked for equality of snapshot marker
type field with on-disk or in-memory marker type. But, EP-Engine
may send snapshot marker with other bits set as well. In that case
snapshot marker is ignored and snapshot boundaries are missed out
by the updater. Since the snapshot merger fails to detect the
snapshot boundary, multiple entries for a document ends up in
the updater pipeline and duplicates are added into the index.

Change-Id: Ic58df6ec438dc3b2791fe4225a95748737c781e2
Reviewed-on: http://review.couchbase.org/41167
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Sriram Melkote <siri@couchbase.com>
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Reviewed-by: Nimish Gupta <nimish@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

3d30674921-Aug-2014 Volker Mische <volker.mische@gmail.com>

Revert "MB-11919 Log sequence number difference in indexing"

This change was for debugging purpose and doesn't add much
value. Hence it would make sense to revert it to have the
logs

Revert "MB-11919 Log sequence number difference in indexing"

This change was for debugging purpose and doesn't add much
value. Hence it would make sense to revert it to have the
logs less noisy.

This reverts commit ce07551ae81163f8645373c062468e932bee953a.

Change-Id: I8cdd8fa49ca4928dd8165d8787f476d34233e4b1
Reviewed-on: http://review.couchbase.org/40790
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Nimish Gupta <nimish@couchbase.com>

show more ...

c9196b7826-Aug-2014 Volker Mische <vmx@couchbase.com>

MB-12048: Make 3.0 mapreduce view group signature backwards compatible

The view engine uses a list of view records (#set_view{}) to calculate
the signature of a view group. Whenever this

MB-12048: Make 3.0 mapreduce view group signature backwards compatible

The view engine uses a list of view records (#set_view{}) to calculate
the signature of a view group. Whenever this record is modified, the
signature will change.

In 3.0 the #set_view{} record changed in order to accommodate the
spatial views as well. This change lead to a different group signature
even if the design document didn't change. This rendered the views
created by Couchbase 2.x unusable. Those views would've been removed
and the indexing would've been started from scratch.

With this change the view groups in Couchbase 3.0 will have the same
signatures as they would have in 2.x.

NOTE: With this change the signatures of view groups change, this
means that all indexes created with a Couchbase 3.0 prior to this
commit will be rebuilt.

Change-Id: I901f6044cde5848eaaf18f63234e339cf3c80c82
Reviewed-on: http://review.couchbase.org/40915
Reviewed-by: Sriram Melkote <siri@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

708ba24326-Aug-2014 Volker Mische <vmx@couchbase.com>

MB-12048: Upgrade mapreduce headers from 2.x to 3.0

The mapreduce index header change in Couchbase 3.0 due to the introduction
of DCP. The header now also contains the partition versions

MB-12048: Upgrade mapreduce headers from 2.x to 3.0

The mapreduce index header change in Couchbase 3.0 due to the introduction
of DCP. The header now also contains the partition versions. As 2.x
headers don't have that information, `nil` is stored as a placeholder
whenever a 2.x header is parsed.

When the view group is created and it contains such a placeholder, the
partition versions are requested from the server. From then on the view
engine can proceed as usual. The next time the header is written to disk,
it will contain the correct information.

Change-Id: I2b3f1068613dd4a814b7479b4a36cb48dd6eb19e
Reviewed-on: http://review.couchbase.org/40914
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Sriram Melkote <siri@couchbase.com>

show more ...

b75c1fd218-Aug-2014 Sarath Lakshman <sarathlakshman@slynux.com>

MB-10921 Add a test for fdleak during queries for views with a reducer

Change-Id: I23c3e8c1861e05c5154840e226132baa775c87c1
Reviewed-on: http://review.couchbase.org/40688
Reviewed-by

MB-10921 Add a test for fdleak during queries for views with a reducer

Change-Id: I23c3e8c1861e05c5154840e226132baa775c87c1
Reviewed-on: http://review.couchbase.org/40688
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Sriram Melkote <siri@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

eaf6756016-Aug-2014 Sarath Lakshman <sarathlakshman@slynux.com>

MB-10921 Release fds properly for views with reduce queries

View group file descriptors are reference counted by the number of callers.
When refcount becomes zero, fd is internally close

MB-10921 Release fds properly for views with reduce queries

View group file descriptors are reference counted by the number of callers.
When refcount becomes zero, fd is internally closed by the refcounter.

Interested callers acquire view_group using request_group() and refcount for
the fd is autoincremented. The caller who has acquired the view_group should
call release_group() explicitly to decrement the refcount or the caller process
should die to get refcount decremented.

For reduce enabled views, fd reference count is not decremented correctly
after the query path discards that fd. The http server implementation spawns
one worker process per connection. If a connection is reused, queries served
through that connection is processed by the same erlang process.
A missing fd decrement after use of requested group causes fd leaks in
the case of keep-alive connections used for queries.

The leak can be reproduced by using the following steps:
1. Create a view with reduce function and build the view with sufficient data
2. Send the following http request through netcat and keep the netcat open to
simulate reuse of connection.

$ nc localhost 8092
GET /default/_design/test/_view/test?stale=update_after HTTP/1.1

3. Now trigger manual compaction
4. $ echo beam | xargs -n1 pgrep | xargs -n1 -r -- lsof -n -p | grep deleted
beam.smp 27922 ubuntu 41r REG 202,1 2054213 167136 /home/ubuntu/couchbase-2.5/ns_server/data/n_0/data/.delete/5d79134a257d5866532ddef4d9827780 (deleted)

Change-Id: I20a74202587198da46b81e2e722dcbf9821d7b08
Reviewed-on: http://review.couchbase.org/40679
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Sriram Melkote <siri@couchbase.com>

show more ...

ce07551a14-Aug-2014 Nimish Gupta <nimish@couchbase.com>

MB-11919 Log sequence number difference in indexing

Due to MB-11589, we are suspecting that view indexer has to do more
work. Added a message to log how many extra mutations we are getti

MB-11919 Log sequence number difference in indexing

Due to MB-11589, we are suspecting that view indexer has to do more
work. Added a message to log how many extra mutations we are getting
in indexing during rebalance.

Change-Id: Ibd6fb2e43d384ecfe98174fce5f296159aaefe42
Reviewed-on: http://review.couchbase.org/40617
Tested-by: Nimish Gupta <nimish@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>

show more ...

12345678910>>...149