History log of /3.0.2-MP2/geocouch/ (Results 1 - 25 of 350)
Revision (<<< Hide revision tags) (Show revision tags >>>)Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
2f4508ab20-Nov-2014 Artem Stemkovski <artem@couchbase.com>

MB-8872 allow ns_server to implement auth for _spatial_merge handler

needed for http://review.couchbase.org/43428/

Change-Id: I2f0900459269746a51819478285e19fd02b56804
Reviewed-

MB-8872 allow ns_server to implement auth for _spatial_merge handler

needed for http://review.couchbase.org/43428/

Change-Id: I2f0900459269746a51819478285e19fd02b56804
Reviewed-on: http://review.couchbase.org/43429
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: Volker Mische <volker.mische@gmail.com>

show more ...

106f827b06-Nov-2014 Volker Mische <vmx@couchbase.com>

Make split candidate creation non-fatal

There are cases when there is no split cases, due to the maximum chunk
threshold. It can happen when a single node is bigger than that threshold.

Make split candidate creation non-fatal

There are cases when there is no split cases, due to the maximum chunk
threshold. It can happen when a single node is bigger than that threshold.
Instead of having a fatal error, create a node that is bigger than that
maximum threshold. This is a trade-off to make. It's better to have a
running system with potentially nodes that are bigger than defined, rather
than a hard crash where no further inserts are possible.

Change-Id: Ic0e4149a5ff967c4e0378532fefdec34b8cf5e05
Reviewed-on: http://review.couchbase.org/42903
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

d0ef4c0b06-Nov-2014 Volker Mische <vmx@couchbase.com>

MB-12251: Make inserts into vtree more robust

When inserting several nodes at the same time, the code contained a
special case when the size of the nodes to be inserted was larger than

MB-12251: Make inserts into vtree more robust

When inserting several nodes at the same time, the code contained a
special case when the size of the nodes to be inserted was larger than
the maximum threshold, but still less than two times the threshold.

The idea for this special case was that the normal split algorithm could
be used. This assumption was wrong, as it could well be that no valid
split candidate can be found. This resulted in the fatal error
"No split candidates found. Increase the chunk threshold.".

Hence that special case got removed.

This commits also adds a test that would fail with the old logic. Some
other tests used that spatial case also needed to adapted.

Change-Id: Ia4f9e416d5b7b7f27937c7fc9d2a967352d1e6c9
Reviewed-on: http://review.couchbase.org/42896
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

b952783906-Nov-2014 Volker Mische <vmx@couchbase.com>

Make test logging more verbose

With the `--verbose` set the test logging output is more verbose.
The output on the screen is still the same it only changes what
gets written to the l

Make test logging more verbose

With the `--verbose` set the test logging output is more verbose.
The output on the screen is still the same it only changes what
gets written to the log file.

Change-Id: Id93658c0c683941e0f3bfb38cd8e9af29929f8c6
Reviewed-on: http://review.couchbase.org/42895
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>

show more ...

ce037b9b31-Oct-2014 Volker Mische <vmx@couchbase.com>

MB-12251: Use the common function to parse the query parameters

Instead of extracting the stale and debug parameter manually, use the
existing parse function to get the parameters. This

MB-12251: Use the common function to parse the query parameters

Instead of extracting the stale and debug parameter manually, use the
existing parse function to get the parameters. This makes things less
fragile and error prone.

Change-Id: I4949447dd37305531bc41bde78d0e0424e5b4d00
Reviewed-on: http://review.couchbase.org/42761
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

37a81c7031-Oct-2014 Volker Mische <vmx@couchbase.com>

MB-12251: Throw error when only `start_range` or `end_range` is given

You need to supply both, `start_range` and `end_range` if you supply it
at all.

Change-Id: I62ffb4557124510

MB-12251: Throw error when only `start_range` or `end_range` is given

You need to supply both, `start_range` and `end_range` if you supply it
at all.

Change-Id: I62ffb4557124510d076bc3fefc3f5461f5843a49
Reviewed-on: http://review.couchbase.org/42760
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>

show more ...

5b0dd82629-Oct-2014 Volker Mische <vmx@couchbase.com>

Encode ranges properly

The index merger needs to convert the query parameters from their
Erlang representation back to the HTTP API one. Ranges use `null`
as a wildcard which is conv

Encode ranges properly

The index merger needs to convert the query parameters from their
Erlang representation back to the HTTP API one. Ranges use `null`
as a wildcard which is converted to a `nil` in the Erlang world.
This commit makes the proper conversion back.

Change-Id: I471b5a95011b10082ed82d7056dcdaec37966ccc
Reviewed-on: http://review.couchbase.org/42759
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

b7ef606828-Oct-2014 Volker Mische <vmx@couchbase.com>

MB-12476: Spatial views don't support real reduce

Spatial views don't support real reduce. The reduce value is used
to store the "original MBB" which is needed by the RR*-tree algorithm.

MB-12476: Spatial views don't support real reduce

Spatial views don't support real reduce. The reduce value is used
to store the "original MBB" which is needed by the RR*-tree algorithm.
It is the MBB the node had on creation time.

Change-Id: I42102f22af7207c883cdec5a8f10e923f318f49b
Reviewed-on: http://review.couchbase.org/42758
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

18598ed004-Nov-2014 Volker Mische <vmx@couchbase.com>

MB-12546: Fix maximum node size calculation

When inserting a node, only the size of the existing node
was taken into account, without taking the newly added item
into account.

MB-12546: Fix maximum node size calculation

When inserting a node, only the size of the existing node
was taken into account, without taking the newly added item
into account.

Change-Id: Ibc93ee1ea9bab292d74e8f63416fcf46c9564b80
Reviewed-on: http://review.couchbase.org/42832
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>

show more ...

d26f986e21-Oct-2014 Volker Mische <vmx@couchbase.com>

MB-12251: Throw dimensionality error early

Throw the error when the query dimensionality doesn't match the index
dimensionality as early as possible. This way you get a proper HTTP
r

MB-12251: Throw dimensionality error early

Throw the error when the query dimensionality doesn't match the index
dimensionality as early as possible. This way you get a proper HTTP
response back from a single node. Else it would first send the 200 OK
header, and then also the 500 headers which isn't valid HTTP..

Change-Id: I051361ed6b63e5d11bd0e43ff235564722faf1aa
Reviewed-on: http://review.couchbase.org/42757
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>

show more ...

0736029a21-Oct-2014 Volker Mische <vmx@couchbase.com>

MB-12251: Use original MBB for dimensionality comparison

The key of the root node can be be unset. Hence use the original MBB
for the comparison between the query and the index dimension

MB-12251: Use original MBB for dimensionality comparison

The key of the root node can be be unset. Hence use the original MBB
for the comparison between the query and the index dimensionality.
The original MBB is always set and has the same dimensionality the
index has.

Change-Id: I9b33219fa1640d126013704899fa8c3457810530
Reviewed-on: http://review.couchbase.org/42756
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

b7a1606428-Oct-2014 Volker Mische <vmx@couchbase.com>

MB-12476: Set reduce correctly

The reduce in the spatial views is the original MBB (needed by the
RR*-tree allgorithm).

Change-Id: Ia566633a1b814e5e2df676f6c4ff8455ed10caac

MB-12476: Set reduce correctly

The reduce in the spatial views is the original MBB (needed by the
RR*-tree allgorithm).

Change-Id: Ia566633a1b814e5e2df676f6c4ff8455ed10caac
Reviewed-on: http://review.couchbase.org/42755
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

31b0097028-Oct-2014 Volker Mische <vmx@couchbase.com>

MB-12476: Set original MBB correctly

The RR*-tree algorithm uses a so-called "original MBB". It is the
bounding box of the node when it was first created.

Change-Id: I24c5f57a0d

MB-12476: Set original MBB correctly

The RR*-tree algorithm uses a so-called "original MBB". It is the
bounding box of the node when it was first created.

Change-Id: I24c5f57a0dacb352c3f2777b0c1a23e0ac15ac90
Reviewed-on: http://review.couchbase.org/42754
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

16cdbf7d21-Oct-2014 Volker Mische <vmx@couchbase.com>

MB-12251: Better error messages during emit

The errors on emit now are more specific. Their error atom is `key_emit`
instead of just `error`.

Change-Id: Id45f1a0a837ae2ddda12a7f

MB-12251: Better error messages during emit

The errors on emit now are more specific. Their error atom is `key_emit`
instead of just `error`.

Change-Id: Id45f1a0a837ae2ddda12a7f9fd0cedf6a7359a91
Reviewed-on: http://review.couchbase.org/42753
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>

show more ...

ab75805c17-Oct-2014 Volker Mische <vmx@couchbase.com>

Encode/decode original MBB correctly

The original MBB wasn't encoded/decoded correctly.

Change-Id: Ifeef36509ab8388c6d13c0737ec116633213d92d
Reviewed-on: http://review.couchbase

Encode/decode original MBB correctly

The original MBB wasn't encoded/decoded correctly.

Change-Id: Ifeef36509ab8388c6d13c0737ec116633213d92d
Reviewed-on: http://review.couchbase.org/42305
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

f4753a3f07-Oct-2014 Volker Mische <vmx@couchbase.com>

MB-12251: Improve query parsing errors

Add more end-user friendly error messages when the query parameter
are invalid. This commit also adds tests.

Change-Id: I1a6902aa62750e7e5

MB-12251: Improve query parsing errors

Add more end-user friendly error messages when the query parameter
are invalid. This commit also adds tests.

Change-Id: I1a6902aa62750e7e5109d1a6956bc15f486904e1
Reviewed-on: http://review.couchbase.org/42304
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

82a4ba0a06-Oct-2014 Volker Mische <vmx@couchbase.com>

MB-12251: Throw error when range has wrong dimensionality

In case you query with a range that doesn't have the same dimensionality
as the index it throws a proper error now:

MB-12251: Throw error when range has wrong dimensionality

In case you query with a range that doesn't have the same dimensionality
as the index it throws a proper error now:

The query range must have the same dimensionality as the index.

Change-Id: I6606753fc14e0d86cce5522f18cdf1fcbad126fa
Reviewed-on: http://review.couchbase.org/42303
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>

show more ...

57d20b4e29-Sep-2014 Volker Mische <vmx@couchbase.com>

MB-12251: Better error messages for emits

When there were non-valid emits the error messages weren't meaningful.
This commits adds nicer error messages and tests accordingly.

Ch

MB-12251: Better error messages for emits

When there were non-valid emits the error messages weren't meaningful.
This commits adds nicer error messages and tests accordingly.

Change-Id: I9950866667f9a9990cb29aed3f260e4f4564fdbe
Reviewed-on: http://review.couchbase.org/41773
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>

show more ...

2ed65b0926-Sep-2014 Volker Mische <vmx@couchbase.com>

MB-12251: Add tests for emit

The emit can emit either a single geometry, multiple dimensions or
a geometry and multiple dimensions. This commits adds tests for all
cases.

Ch

MB-12251: Add tests for emit

The emit can emit either a single geometry, multiple dimensions or
a geometry and multiple dimensions. This commits adds tests for all
cases.

Change-Id: Ifa9055e68691d4660bb956f268f7b1061e6920d2
Reviewed-on: http://review.couchbase.org/41772
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

9b267f1926-Sep-2014 Volker Mische <vmx@couchbase.com>

String instead of binary was returned

GeometryCollection returned the property `geometries` as a string
and not as a binary.

Change-Id: I3d17afd97e92b1ec2b50ccc8cbde94a66a417d37

String instead of binary was returned

GeometryCollection returned the property `geometries` as a string
and not as a binary.

Change-Id: I3d17afd97e92b1ec2b50ccc8cbde94a66a417d37
Reviewed-on: http://review.couchbase.org/41771
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>

show more ...

481be89324-Sep-2014 Volker Mische <vmx@couchbase.com>

MB-12251: Add tests with open ranges

The multi-dimensional index supports open ranges, either on start,
end or both sides. Add additional tests for such cases.

Change-Id: I44031

MB-12251: Add tests with open ranges

The multi-dimensional index supports open ranges, either on start,
end or both sides. Add additional tests for such cases.

Change-Id: I440318d2d414cea36f5706e5f13cad150e8df8a0
Reviewed-on: http://review.couchbase.org/41770
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

79503af116-Oct-2014 Volker Mische <vmx@couchbase.com>

Always use minor version 1 for binaries

When converting Erlang terms to binary, always use minor version 1.
Also use minor version 1 when determining the size of a term.

Change-

Always use minor version 1 for binaries

When converting Erlang terms to binary, always use minor version 1.
Also use minor version 1 when determining the size of a term.

Change-Id: I3de9e3960509a7e0939375e5140a35f0176674a9
Reviewed-on: http://review.couchbase.org/42226
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>

show more ...

f6eb43ee20-Oct-2014 Volker Mische <vmx@couchbase.com>

Only set CMAKE_MODULE_PATH if not set

The tlm sets the CMAKE_MODULE_PATH. If a geocouch build is run without
the tlm (e.g. for the special build for the unit tests) then the module
p

Only set CMAKE_MODULE_PATH if not set

The tlm sets the CMAKE_MODULE_PATH. If a geocouch build is run without
the tlm (e.g. for the special build for the unit tests) then the module
path is set.

Change-Id: I439eaef8ad3a6ffed447b1dbf83fa2a8263f3756
Reviewed-on: http://review.couchbase.org/42290
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: Volker Mische <volker.mische@gmail.com>

show more ...

e3fbee9e09-Oct-2014 Volker Mische <vmx@couchbase.com>

Build geocouch in a special way for the unit tests

The unit tests also test non-exported functions, hence the source needs
to be compiled with the `+export_all` flag. As we don't want to

Build geocouch in a special way for the unit tests

The unit tests also test non-exported functions, hence the source needs
to be compiled with the `+export_all` flag. As we don't want to have
everything exported in the normal build, a special build is needed.

With this change it's possible to compile geocouch again with
`GEOCOUCH_BUILD_FOR_UNIT_TESTS=1` set. In order to have everything
work, you need to perform the usual compilation steps frist, which
will create a `build` directory. You then create a subdirectory
(e.g. `geocouch-for-tests`) which will contain the special build.

From within that directory simply run:

cmake -G "Unix Makefiles" -D BUILD_FOR_UNIT_TESTS=1 ../../geocouch

To run the unit tests, simply run a `make`, followed by a `make test`.

Change-Id: I0d932bd80dd31f355e48cfa15d55fc8bfa3f6b95
Reviewed-on: http://review.couchbase.org/41991
Reviewed-by: Chris Hillery <ceej@couchbase.com>
Tested-by: Volker Mische <volker.mische@gmail.com>

show more ...

618ea5a401-Oct-2014 Volker Mische <vmx@couchbase.com>

Add dialyzing to geocouch

With `make geocouch-dialyzer` within the build directory it's possible
to run dialyzer on the geocouch code. The `make geocouch-chech` target
will also run

Add dialyzing to geocouch

With `make geocouch-dialyzer` within the build directory it's possible
to run dialyzer on the geocouch code. The `make geocouch-chech` target
will also run the dialyzer first before running the tests.

This commit also fixes some problems found during dialyzing.

Change-Id: I4cb4bd0f9184f0cbc98b1a74a8fdd76a6be6bee9
Reviewed-on: http://review.couchbase.org/41990
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: Volker Mische <volker.mische@gmail.com>

show more ...

12345678910>>...14