History log of /3.0.2-MP2/memcached/ (Results 1 - 25 of 1687)
Revision (<<< Hide revision tags) (Show revision tags >>>)Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
Revision tags: v4.6.3, v4.6.2-MP3, v4.6.5, v4.6.2, v4.5.1-MP1, v4.6.0-DP, v4.1.2-MP2, v4.5.1, v4.6.0, v4.5.0, v4.1.1, v3.1.4, v3.1.5, v4.1.0, v3.1.2, v3.1.1, v4.0.0, v3.1.0, v3.1.6, v3.0.2-MP2
4424e90314-Feb-2015 Trond Norbye <trond.norbye@gmail.com>

MB-13286: Update conn_new_cmd

Change-Id: I8edaaa81f786cbc7bc6f32ed4076cc0c820b0f0f
Reviewed-on: http://review.couchbase.org/46845
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>

MB-13286: Update conn_new_cmd

Change-Id: I8edaaa81f786cbc7bc6f32ed4076cc0c820b0f0f
Reviewed-on: http://review.couchbase.org/46845
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

8792bc0a12-Feb-2015 abhinavdangeti <abhinav@couchbase.com>

MB-13286: State change to conn_ship_log for DCP regardless of nevents

Change-Id: I3ada2a963cb112b9d4901fef45e2c382950d0dfc
Reviewed-on: http://review.couchbase.org/46726
Reviewed-by:

MB-13286: State change to conn_ship_log for DCP regardless of nevents

Change-Id: I3ada2a963cb112b9d4901fef45e2c382950d0dfc
Reviewed-on: http://review.couchbase.org/46726
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...

Revision tags: v3.0.2
be691c3b26-Nov-2014 Trond Norbye <trond.norbye@gmail.com>

MB-12762: Fix build break introduced with backport

Change-Id: Ica414b586f9f1e154fa01e478e3e2b939945b638
Reviewed-on: http://review.couchbase.org/43624
Reviewed-by: Trond Norbye <tron

MB-12762: Fix build break introduced with backport

Change-Id: Ica414b586f9f1e154fa01e478e3e2b939945b638
Reviewed-on: http://review.couchbase.org/43624
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

908acf7825-Nov-2014 Dave Rigby <daver@couchbase.com>

MB-12762: Close SSL connection on error during handshake

If a receive error occured during SSL handshake (e.g. received
incorrect handshake data) then instead of closing the connection (

MB-12762: Close SSL connection on error during handshake

If a receive error occured during SSL handshake (e.g. received
incorrect handshake data) then instead of closing the connection (as
expected) memcached would belive it needed to retry and return the
connection to the conn_read state. This resulted in the state machine
for the connection essentially looping forever attempting to read
data. This has two observabl side-effects:

1) A connection slot is essentially consumed (forever) by the failed
connection attempt.

2) The frontend thread that the failed connection was assigned to will
spin (at 100% CPU), if no other connections owned by the worker have
any events waiting.

(Note for (2), the CPU isn't "consumed" - other connections if present
*will* be serviced as normal, the issue is simply that the failed
connection immediately posts an event to retry the read, which
libevent will immediately schedule if there are no other events
(i.e. other connections) ready).

Fix is to ensure that the ssl.error status is checked after draining
the SSL recv pipe, and if set then reseting the connection.

Change-Id: I1775b7ad16c6e12fc619da2ba15c93f6e07cd096
Reviewed-on: http://review.couchbase.org/43608
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

28e825f710-Nov-2014 Trond Norbye <trond.norbye@gmail.com>

Backport of fix for MB-11642

This is a minimum implementation of the patch provided
for Sherlock (all configuration methods removed).

Change-Id: I5be0b7247e13d55570d662f2470ffd8

Backport of fix for MB-11642

This is a minimum implementation of the patch provided
for Sherlock (all configuration methods removed).

Change-Id: I5be0b7247e13d55570d662f2470ffd841a3a7c65
Reviewed-on: http://review.couchbase.org/43047
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

Revision tags: v3.0.1
9658c49713-Oct-2014 Mike Wiederhold <mike@couchbase.com>

[Backport] MB-12328: Convert the dcp mutation flags field to network order

Change-Id: I9feda82beff4e930e18d6127f538622225b86d8f
Reviewed-on: http://review.couchbase.org/42373
Reviewe

[Backport] MB-12328: Convert the dcp mutation flags field to network order

Change-Id: I9feda82beff4e930e18d6127f538622225b86d8f
Reviewed-on: http://review.couchbase.org/42373
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

Revision tags: v3.0.0-beta3, v3.0.0
410effde25-Aug-2014 Trond Norbye <trond.norbye@gmail.com>

Split the generated test suite into multiple units

Change-Id: I01c28cbc6dd6f193034d3c345e15a8702a7f1606
Reviewed-on: http://review.couchbase.org/40931
Reviewed-by: Chris Hillery <cee

Split the generated test suite into multiple units

Change-Id: I01c28cbc6dd6f193034d3c345e15a8702a7f1606
Reviewed-on: http://review.couchbase.org/40931
Reviewed-by: Chris Hillery <ceej@couchbase.com>
Tested-by: Chris Hillery <ceej@couchbase.com>

show more ...

3bc6b8c015-Aug-2014 Trond Norbye <trond.norbye@gmail.com>

MSVC does not support %zu

Change-Id: Iedc909a654137cd7b471dbc97edeaf6941d02ecb
Reviewed-on: http://review.couchbase.org/40652
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested

MSVC does not support %zu

Change-Id: Iedc909a654137cd7b471dbc97edeaf6941d02ecb
Reviewed-on: http://review.couchbase.org/40652
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

c358829d12-Aug-2014 jim <jim@couchbase.com>

testapp failure observed when linked against a newer OpenSSL (seen on OSX).

The fix though is not actually a library issue but just an issue with our send
code returning the wrong send l

testapp failure observed when linked against a newer OpenSSL (seen on OSX).

The fix though is not actually a library issue but just an issue with our send
code returning the wrong send length, we must return the SSL_write number,
not the send number (the send number will be bigger as SSL inflates the data
by some amount).

Change-Id: I93f33c9ec791f3f174f624afd8d8adaf6c5f5d48
Reviewed-on: http://review.couchbase.org/40532
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

91febbbe11-Aug-2014 Trond Norbye <trond.norbye@gmail.com>

Fix compile warning from clang

Change-Id: If5bfed8fd995f4feeceafe4f6cd618e5a259dd81
Reviewed-on: http://review.couchbase.org/40488
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

Fix compile warning from clang

Change-Id: If5bfed8fd995f4feeceafe4f6cd618e5a259dd81
Reviewed-on: http://review.couchbase.org/40488
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

6410c8f707-Aug-2014 jim <jim@couchbase.com>

[MB-11203] SSL-enabled memcached will hang...

A large pipeline input lead to memcached effectively
performing a under-read of the input buffer. This occured
when memcached moved to

[MB-11203] SSL-enabled memcached will hang...

A large pipeline input lead to memcached effectively
performing a under-read of the input buffer. This occured
when memcached moved to conn_waiting as part of yield, we
only check rbuf for data when a SSL_peek is needed for SSL
connections.

Also on the drain_recv code we could get into a situation
where we'd read everything off the network but didn't quite
handle the SSL_read -1 error correctly. Again we could end up
yielding and never wake up again because there's no more data
on the network, yet there's data in our intermediate ssl read
buffer.

testapp changes are required because this defect occured when
a large single sendto occurs. The old SSL code in testapp
used openssl methods to send/recv, which actually chunked up
large pipelines using smaller writes, hiding the bug because
we kept stimulating memcached.

New code allows testapp to take full control of sends using
whatever chunking scheme we wish.

Also removed some time tests which weren't needed and were
causing some occasional failures because they were a little
intolerant.

Change-Id: Ie2a3374fc32ad57a122040ad359e3148d6bdeffd
Reviewed-on: http://review.couchbase.org/40417
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

7fb8cafb08-Aug-2014 Chiyoung Seo <chiyoung.seo@gmail.com>

Check if the send buffer is full or not for an DCP mutation.

Change-Id: I4401cda9b16ced3278f505169ed1f4658e18dcfa
Reviewed-on: http://review.couchbase.org/40397
Reviewed-by: Chiyoung

Check if the send buffer is full or not for an DCP mutation.

Change-Id: I4401cda9b16ced3278f505169ed1f4658e18dcfa
Reviewed-on: http://review.couchbase.org/40397
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

Revision tags: v3.0.0-beta2
f4b802c829-Jul-2014 jim <jim@couchbase.com>

[MB-11203] Enable SSL for all tests that use a socket.

Add some more focused stream/pipeline tests.

Overall increase of about 2% code coverage in memcached.c

Change-Id: Ia0

[MB-11203] Enable SSL for all tests that use a socket.

Add some more focused stream/pipeline tests.

Overall increase of about 2% code coverage in memcached.c

Change-Id: Ia0b8ffbb84e53e0bd38eaf3d3641ae92161e2d92
Reviewed-on: http://review.couchbase.org/40185
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

01347b5901-Aug-2014 jim <jim@couchbase.com>

[MB-11548] Perform a less strict check on the current time

Perform a less strict check on the current time as we may see
59/61 seconds which isn't neccesarily a clock change.

Al

[MB-11548] Perform a less strict check on the current time

Perform a less strict check on the current time as we may see
59/61 seconds which isn't neccesarily a clock change.

Also update warning message to show the difference in time.

Change-Id: I524640de83de0159733d2813d55fec523b774e65
Reviewed-on: http://review.couchbase.org/40172
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

2be3904d31-Jul-2014 Chris Hillery <ceej@couchbase.com>

MB-11846: Un-disable optimization as it causes compiler memory explosion (partial revert of 4bb252a2a7d9a369c80f8db71b3b5dc1c9f47eb9)
Change-Id: I0840515f6e29c3daddb66f8622d2d46a3492e596
Revi

MB-11846: Un-disable optimization as it causes compiler memory explosion (partial revert of 4bb252a2a7d9a369c80f8db71b3b5dc1c9f47eb9)
Change-Id: I0840515f6e29c3daddb66f8622d2d46a3492e596
Reviewed-on: http://review.couchbase.org/40153
Reviewed-by: Chris Hillery <ceej@couchbase.com>
Tested-by: Chris Hillery <ceej@couchbase.com>

show more ...

5cc2f8d931-Jul-2014 Trond Norbye <trond.norbye@gmail.com>

Fixup dtrace build of default_engine

Change-Id: Ib2af3784c130d9d8e951aebbc942c789e9d1f0a9
Reviewed-on: http://review.couchbase.org/40131
Reviewed-by: Trond Norbye <trond.norbye@gmail

Fixup dtrace build of default_engine

Change-Id: Ib2af3784c130d9d8e951aebbc942c789e9d1f0a9
Reviewed-on: http://review.couchbase.org/40131
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

9de7f95d31-Jul-2014 Dave Rigby <daver@couchbase.com>

MB-11772: Install mcctl into bin/ directory

Change-Id: I712bea5b32479d0df5127d98c0cef27f0075072d
Reviewed-on: http://review.couchbase.org/40109
Reviewed-by: Trond Norbye <trond.norby

MB-11772: Install mcctl into bin/ directory

Change-Id: I712bea5b32479d0df5127d98c0cef27f0075072d
Reviewed-on: http://review.couchbase.org/40109
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

835f030824-Jul-2014 Dave Rigby <daver@couchbase.com>

Tweak file_logger unit test buffer sizes

Increase the buffer size (relative to the expected message length) so
the producer thread isn't blocked waiting for the flusher thread to
tim

Tweak file_logger unit test buffer sizes

Increase the buffer size (relative to the expected message length) so
the producer thread isn't blocked waiting for the flusher thread to
timeout (as the flusher high watermark hasn't been reached, yet there
isn't enough space for the producer to write into).

Change-Id: Icea983a841abe1e64858c92cc67eb5bc6b3a805c
Reviewed-on: http://review.couchbase.org/39812
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Dave Rigby <daver@couchbase.com>

show more ...

d6f3b95c29-Jul-2014 Dave Rigby <daver@couchbase.com>

jemalloc: Ensure stats are up-to-date

jemalloc can cache it's statistics. Add a call to mallctl("epoch")
when fetching allocator stats to ensure that we have up-to-date stats
values.

jemalloc: Ensure stats are up-to-date

jemalloc can cache it's statistics. Add a call to mallctl("epoch")
when fetching allocator stats to ensure that we have up-to-date stats
values.

Change-Id: Ie466e193e442a8b9dbb75367c3cc44e4cdbef90f
Reviewed-on: http://review.couchbase.org/39996
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

e73832dc22-Jul-2014 jim <jim@couchbase.com>

[MB-11548] Memcached does not handle going back in time.

1) Update testapp so that we can expose the bug.

The idea here is to move us to using a platform method that abstracts getti

[MB-11548] Memcached does not handle going back in time.

1) Update testapp so that we can expose the bug.

The idea here is to move us to using a platform method that abstracts gettimeofday.
With that in place we can apply time shifts in a programmatic fashion using the
memcached protocol extension framework.

Testapp uses testapp_extension.so to send time offset values into memcached and
cause a jump in time.

2) Add mc_time module and move memcached.c methods + add bug fix.
- This module provides the legacy API but
a) current_time is now monotonic and immune to system clock changes
b) allow correct absolute system time calculations without the I/O path needing
a system call. This works alongside real system clock changes.
c) validate that existing expiry tests and new expiry tests are now operational.

3) Remove any gettimeofday reference from memcached so that we use the new platform method.

4) As part of final testing, some system tests were performed where I manually
changed the real system clock using "sudo date" commands.

Change-Id: I2048c536f344050191feeed16635196f44b70b37
Reviewed-on: http://review.couchbase.org/39813
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

4bb252a228-Jul-2014 Trond Norbye <trond.norbye@gmail.com>

Do not optimize generated_breakdancer_testsuite

Change-Id: I5055a08ccc32b0a68e75458ce4262147bd571a15
Reviewed-on: http://review.couchbase.org/39969
Reviewed-by: Aliaksey Kandratsenka

Do not optimize generated_breakdancer_testsuite

Change-Id: I5055a08ccc32b0a68e75458ce4262147bd571a15
Reviewed-on: http://review.couchbase.org/39969
Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>

show more ...

261154c029-Jul-2014 Trond Norbye <trond.norbye@gmail.com>

Fix unit test failure in cbsasl

Introduced when adding more return statuses

Change-Id: I7f43d117d47f481c89d32f777ce014f2520dca9b
Reviewed-on: http://review.couchbase.org/39992

Fix unit test failure in cbsasl

Introduced when adding more return statuses

Change-Id: I7f43d117d47f481c89d32f777ce014f2520dca9b
Reviewed-on: http://review.couchbase.org/39992
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

12c58e5215-Jul-2014 Dave Rigby <daver@couchbase.com>

MB-11735: mem allocator: Report both mapped and unmapped free bytes

From the tcmalloc documentation [1] we see that tcmalloc free memory
is sub-divided into two statistics:

* tc

MB-11735: mem allocator: Report both mapped and unmapped free bytes

From the tcmalloc documentation [1] we see that tcmalloc free memory
is sub-divided into two statistics:

* tcmalloc.pageheap_free_bytes: Number of bytes in free, mapped pages in page heap.
* tcmalloc.pageheap_unmapped_bytes: Number of bytes in free, unmapped pages in page heap.

However at present we only include `pageheap_free_bytes` in the free
calculation.

Rename "total_free_bytes" to "total_free_mapped_bytes", and
"tcmalloc_unmapped_bytes" to "total_free_unmapped_bytes".

Update the calculations of total_fragmentation_bytes to account for
unmapped_bytes.

Change-Id: I3364b732175da25fa9f45490cc4af81e3812836a
Reviewed-on: http://review.couchbase.org/39416
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

ca4ab0ea23-Jul-2014 Trond Norbye <trond.norbye@gmail.com>

Log more information with sasl errors

Change-Id: I9c278ea2005c9c9535e9485c23340ef75bdfb0df
Reviewed-on: http://review.couchbase.org/39738
Reviewed-by: Daniel Owen <owend@couchbase.co

Log more information with sasl errors

Change-Id: I9c278ea2005c9c9535e9485c23340ef75bdfb0df
Reviewed-on: http://review.couchbase.org/39738
Reviewed-by: Daniel Owen <owend@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

6ae7c28b23-Jul-2014 Trond Norbye <trond.norbye@gmail.com>

Removed unused compression support

Change-Id: I322f168941a5ae57d5c31dbee8fe3381845776fe
Reviewed-on: http://review.couchbase.org/39730
Reviewed-by: Dave Rigby <daver@couchbase.com>

Removed unused compression support

Change-Id: I322f168941a5ae57d5c31dbee8fe3381845776fe
Reviewed-on: http://review.couchbase.org/39730
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

12345678910>>...68