History log of /3.0.2-MP2/memcached/daemon/memcached.c (Results 1 - 25 of 762)
Revision (<<< Hide revision tags) (Show revision tags >>>) Date Author Comments
Revision tags: v4.6.3, v4.6.2-MP3, v4.6.5, v4.6.2, v4.5.1-MP1, v4.6.0-DP, v4.1.2-MP2, v4.5.1, v4.6.0, v4.5.0, v4.1.1, v3.1.4, v3.1.5, v4.1.0, v3.1.2, v3.1.1, v4.0.0, v3.1.0, v3.1.6, v3.0.2-MP2
# 4424e903 14-Feb-2015 Trond Norbye <trond.norbye@gmail.com>

MB-13286: Update conn_new_cmd

Change-Id: I8edaaa81f786cbc7bc6f32ed4076cc0c820b0f0f
Reviewed-on: http://review.couchbase.org/46845
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>

MB-13286: Update conn_new_cmd

Change-Id: I8edaaa81f786cbc7bc6f32ed4076cc0c820b0f0f
Reviewed-on: http://review.couchbase.org/46845
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


# 8792bc0a 12-Feb-2015 abhinavdangeti <abhinav@couchbase.com>

MB-13286: State change to conn_ship_log for DCP regardless of nevents

Change-Id: I3ada2a963cb112b9d4901fef45e2c382950d0dfc
Reviewed-on: http://review.couchbase.org/46726
Reviewed-by:

MB-13286: State change to conn_ship_log for DCP regardless of nevents

Change-Id: I3ada2a963cb112b9d4901fef45e2c382950d0dfc
Reviewed-on: http://review.couchbase.org/46726
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...


Revision tags: v3.0.2
# 908acf78 25-Nov-2014 Dave Rigby <daver@couchbase.com>

MB-12762: Close SSL connection on error during handshake

If a receive error occured during SSL handshake (e.g. received
incorrect handshake data) then instead of closing the connection (

MB-12762: Close SSL connection on error during handshake

If a receive error occured during SSL handshake (e.g. received
incorrect handshake data) then instead of closing the connection (as
expected) memcached would belive it needed to retry and return the
connection to the conn_read state. This resulted in the state machine
for the connection essentially looping forever attempting to read
data. This has two observabl side-effects:

1) A connection slot is essentially consumed (forever) by the failed
connection attempt.

2) The frontend thread that the failed connection was assigned to will
spin (at 100% CPU), if no other connections owned by the worker have
any events waiting.

(Note for (2), the CPU isn't "consumed" - other connections if present
*will* be serviced as normal, the issue is simply that the failed
connection immediately posts an event to retry the read, which
libevent will immediately schedule if there are no other events
(i.e. other connections) ready).

Fix is to ensure that the ssl.error status is checked after draining
the SSL recv pipe, and if set then reseting the connection.

Change-Id: I1775b7ad16c6e12fc619da2ba15c93f6e07cd096
Reviewed-on: http://review.couchbase.org/43608
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


# 28e825f7 10-Nov-2014 Trond Norbye <trond.norbye@gmail.com>

Backport of fix for MB-11642

This is a minimum implementation of the patch provided
for Sherlock (all configuration methods removed).

Change-Id: I5be0b7247e13d55570d662f2470ffd8

Backport of fix for MB-11642

This is a minimum implementation of the patch provided
for Sherlock (all configuration methods removed).

Change-Id: I5be0b7247e13d55570d662f2470ffd841a3a7c65
Reviewed-on: http://review.couchbase.org/43047
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


Revision tags: v3.0.1
# 9658c497 13-Oct-2014 Mike Wiederhold <mike@couchbase.com>

[Backport] MB-12328: Convert the dcp mutation flags field to network order

Change-Id: I9feda82beff4e930e18d6127f538622225b86d8f
Reviewed-on: http://review.couchbase.org/42373
Reviewe

[Backport] MB-12328: Convert the dcp mutation flags field to network order

Change-Id: I9feda82beff4e930e18d6127f538622225b86d8f
Reviewed-on: http://review.couchbase.org/42373
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


Revision tags: v3.0.0-beta3, v3.0.0
# 6410c8f7 07-Aug-2014 jim <jim@couchbase.com>

[MB-11203] SSL-enabled memcached will hang...

A large pipeline input lead to memcached effectively
performing a under-read of the input buffer. This occured
when memcached moved to

[MB-11203] SSL-enabled memcached will hang...

A large pipeline input lead to memcached effectively
performing a under-read of the input buffer. This occured
when memcached moved to conn_waiting as part of yield, we
only check rbuf for data when a SSL_peek is needed for SSL
connections.

Also on the drain_recv code we could get into a situation
where we'd read everything off the network but didn't quite
handle the SSL_read -1 error correctly. Again we could end up
yielding and never wake up again because there's no more data
on the network, yet there's data in our intermediate ssl read
buffer.

testapp changes are required because this defect occured when
a large single sendto occurs. The old SSL code in testapp
used openssl methods to send/recv, which actually chunked up
large pipelines using smaller writes, hiding the bug because
we kept stimulating memcached.

New code allows testapp to take full control of sends using
whatever chunking scheme we wish.

Also removed some time tests which weren't needed and were
causing some occasional failures because they were a little
intolerant.

Change-Id: Ie2a3374fc32ad57a122040ad359e3148d6bdeffd
Reviewed-on: http://review.couchbase.org/40417
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


# 7fb8cafb 08-Aug-2014 Chiyoung Seo <chiyoung.seo@gmail.com>

Check if the send buffer is full or not for an DCP mutation.

Change-Id: I4401cda9b16ced3278f505169ed1f4658e18dcfa
Reviewed-on: http://review.couchbase.org/40397
Reviewed-by: Chiyoung

Check if the send buffer is full or not for an DCP mutation.

Change-Id: I4401cda9b16ced3278f505169ed1f4658e18dcfa
Reviewed-on: http://review.couchbase.org/40397
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


Revision tags: v3.0.0-beta2
# e73832dc 22-Jul-2014 jim <jim@couchbase.com>

[MB-11548] Memcached does not handle going back in time.

1) Update testapp so that we can expose the bug.

The idea here is to move us to using a platform method that abstracts getti

[MB-11548] Memcached does not handle going back in time.

1) Update testapp so that we can expose the bug.

The idea here is to move us to using a platform method that abstracts gettimeofday.
With that in place we can apply time shifts in a programmatic fashion using the
memcached protocol extension framework.

Testapp uses testapp_extension.so to send time offset values into memcached and
cause a jump in time.

2) Add mc_time module and move memcached.c methods + add bug fix.
- This module provides the legacy API but
a) current_time is now monotonic and immune to system clock changes
b) allow correct absolute system time calculations without the I/O path needing
a system call. This works alongside real system clock changes.
c) validate that existing expiry tests and new expiry tests are now operational.

3) Remove any gettimeofday reference from memcached so that we use the new platform method.

4) As part of final testing, some system tests were performed where I manually
changed the real system clock using "sudo date" commands.

Change-Id: I2048c536f344050191feeed16635196f44b70b37
Reviewed-on: http://review.couchbase.org/39813
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


# ca4ab0ea 23-Jul-2014 Trond Norbye <trond.norbye@gmail.com>

Log more information with sasl errors

Change-Id: I9c278ea2005c9c9535e9485c23340ef75bdfb0df
Reviewed-on: http://review.couchbase.org/39738
Reviewed-by: Daniel Owen <owend@couchbase.co

Log more information with sasl errors

Change-Id: I9c278ea2005c9c9535e9485c23340ef75bdfb0df
Reviewed-on: http://review.couchbase.org/39738
Reviewed-by: Daniel Owen <owend@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


Revision tags: v3.0.0-beta1
# 85ad3ec7 20-Jun-2014 Dave Rigby <daver@couchbase.com>

MB-11326: Not possible to enter dcp_stream_req_executor() with ENGINE_ROLLBACK

Change-Id: I68464071fd6d19d9f06ce0194b61346174dee032
Reviewed-on: http://review.couchbase.org/38560
Tes

MB-11326: Not possible to enter dcp_stream_req_executor() with ENGINE_ROLLBACK

Change-Id: I68464071fd6d19d9f06ce0194b61346174dee032
Reviewed-on: http://review.couchbase.org/38560
Tested-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


# f1818198 23-Jul-2014 Trond Norbye <trond.norbye@gmail.com>

Refactor: rename UPR to DCP

Change-Id: Idc9f5c4561fbf5bf011ca1dbed5ad00a64c67fa0
Reviewed-on: http://review.couchbase.org/39747
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

Refactor: rename UPR to DCP

Change-Id: Idc9f5c4561fbf5bf011ca1dbed5ad00a64c67fa0
Reviewed-on: http://review.couchbase.org/39747
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


# b449bca0 21-Jul-2014 Dave Rigby <daver@couchbase.com>

MB-11772: Add `release_free_memory` ioctl and `mcctl` program to access them

Add two new binary protocol commands:

* PROTOCOL_BINARY_CMD_IOCTL_GET - Retrieve a property from the s

MB-11772: Add `release_free_memory` ioctl and `mcctl` program to access them

Add two new binary protocol commands:

* PROTOCOL_BINARY_CMD_IOCTL_GET - Retrieve a property from the server
* PROTOCOL_BINARY_CMD_IOCTL_SET - Modify a property on the server.

Using these, implement a `set release_free_memory` command which will
request the memory allocator to return to the OS any free memory
inside the process.

To access this new functionality, add a `mcctl` command to set/get CTL
properties. Example usage (and currently only supported
functionality):

./mcctl -h localhost:12000 set release_free_memory

Change-Id: I35c40ff9c41c0f00802ff9db9202865ec146f46c
Reviewed-on: http://review.couchbase.org/39608
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


# 481bf9cb 21-Jul-2014 Mike Wiederhold <mike@couchbase.com>

Fix breakage in build to to invalid rebase

Change-Id: I9381d2c6da70242a0d18d01bfbca401fb2f52bf4
Reviewed-on: http://review.couchbase.org/39641
Reviewed-by: Aliaksey Kandratsenka <alk

Fix breakage in build to to invalid rebase

Change-Id: I9381d2c6da70242a0d18d01bfbca401fb2f52bf4
Reviewed-on: http://review.couchbase.org/39641
Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>

show more ...


# deee6a90 15-Jul-2014 Mike Wiederhold <mike@couchbase.com>

MB-11721: Add a snapshot marker respnose api to upr_message_producers

We will be sending acks for some snapshot markers and need an api to
put the bytes on the wire.

Change-Id:

MB-11721: Add a snapshot marker respnose api to upr_message_producers

We will be sending acks for some snapshot markers and need an api to
put the bytes on the wire.

Change-Id: Ib0a2d8443fd1fb800319fca9160f38df8661deae
Reviewed-on: http://review.couchbase.org/39378
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


# b0ad6021 30-Jun-2014 Mike Wiederhold <mike@couchbase.com>

Don't respond to a buffer ack unless there is an error

Change-Id: I751d387c3ece85574610dc0b8f4542506b509f89
Reviewed-on: http://review.couchbase.org/38993
Reviewed-by: Trond Norbye <

Don't respond to a buffer ack unless there is an error

Change-Id: I751d387c3ece85574610dc0b8f4542506b509f89
Reviewed-on: http://review.couchbase.org/38993
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


# b4a135a2 02-Jun-2014 Mike Wiederhold <mike@couchbase.com>

MB-11259: Buffer acknowledgment should have extlen of 4

Change-Id: Ic020e7260db1138f607fb5b3e068f9955f3e5c58
Reviewed-on: http://review.couchbase.org/38790
Reviewed-by: Trond Norbye

MB-11259: Buffer acknowledgment should have extlen of 4

Change-Id: Ic020e7260db1138f607fb5b3e068f9955f3e5c58
Reviewed-on: http://review.couchbase.org/38790
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


# 04ae04db 25-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

Initialize control cas to 0xdeadbeef

If its default value is 0 there is no way to change it without
using 0 as the cas value (which means override) introducing
the possibility for ra

Initialize control cas to 0xdeadbeef

If its default value is 0 there is no way to change it without
using 0 as the cas value (which means override) introducing
the possibility for race conditions. With a non-null value it
may be changed by someone who requested its value and protects
against race conditions.

Allow for using cas value 0 to override cas for setting the cas
(to make it behave consistently with the rest of the cas usage)

Change-Id: I637104df4f65527d8ad10636c01a0e7f53930c53
Reviewed-on: http://review.couchbase.org/38784
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


# c00c8665 24-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

MB-10287: Add backwards compatibility for some options

Change-Id: Ib93b5b16fcb491f1a95226e91a236f08b5ce627f
Reviewed-on: http://review.couchbase.org/38763
Reviewed-by: Dave Rigby <da

MB-10287: Add backwards compatibility for some options

Change-Id: Ib93b5b16fcb491f1a95226e91a236f08b5ce627f
Reviewed-on: http://review.couchbase.org/38763
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


# 7ffd406a 23-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

Reset auth_data when called for an invalid connection

Change-Id: Icd9d8b14e51e12348f2702f1ea60bf543a6255d6
Reviewed-on: http://review.couchbase.org/38690
Reviewed-by: Michael Wiederh

Reset auth_data when called for an invalid connection

Change-Id: Icd9d8b14e51e12348f2702f1ea60bf543a6255d6
Reviewed-on: http://review.couchbase.org/38690
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


# 9eddce56 17-Jun-2014 Dave Rigby <daver@couchbase.com>

Correctly NUL-terminate log buffer

Change-Id: If19ef570617f3a841da87f3f08d3fb51a71ece36
Reviewed-on: http://review.couchbase.org/38543
Reviewed-by: Trond Norbye <trond.norbye@gmail.c

Correctly NUL-terminate log buffer

Change-Id: If19ef570617f3a841da87f3f08d3fb51a71ece36
Reviewed-on: http://review.couchbase.org/38543
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


# 48f69ba1 13-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

Protect "unknown_command" to introduce datatype

The client need to call HELLO in order to be allowed
to use the datatype field of the header. This patch returns
EINVAL if the client

Protect "unknown_command" to introduce datatype

The client need to call HELLO in order to be allowed
to use the datatype field of the header. This patch returns
EINVAL if the client suddenly decide to use it anyway for one
of the engine-specific commands.

Change-Id: I1534e5d24cff69824abd006b0daa742bb3db83ff
Reviewed-on: http://review.couchbase.org/38226
Tested-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


# 71c3fd66 13-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

MB-11394: Disable use of the datatype feature

Introduced a new configuration attribute in the configuration
to enable it: "datatype_supported" : true

Change-Id: I0de2f5315de94ee

MB-11394: Disable use of the datatype feature

Introduced a new configuration attribute in the configuration
to enable it: "datatype_supported" : true

Change-Id: I0de2f5315de94eec14670218505dc36406303f3d
Reviewed-on: http://review.couchbase.org/38228
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


# 87bfbfab 13-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

Fixed incorrect break for unsupported TLS

Change-Id: Iabc48f756567adab0ba5f283207d51a7608c0f13
Reviewed-on: http://review.couchbase.org/38225
Tested-by: Trond Norbye <trond.norbye@gm

Fixed incorrect break for unsupported TLS

Change-Id: Iabc48f756567adab0ba5f283207d51a7608c0f13
Reviewed-on: http://review.couchbase.org/38225
Tested-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


# 1add1661 10-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

MB-11360: Don't ack successful mutations

Change-Id: I2b09fc07a2063a53d82e10477c500be1bed88847
Reviewed-on: http://review.couchbase.org/38068
Reviewed-by: Michael Wiederhold <mike@cou

MB-11360: Don't ack successful mutations

Change-Id: I2b09fc07a2063a53d82e10477c500be1bed88847
Reviewed-on: http://review.couchbase.org/38068
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


# 83a24bff 10-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

Cleanup conn_shrink

All that extra casting just makes the code hard to read.

Change-Id: I2ab8bd1599d26b7ce670c51d4ab06f7fbd0bf09f
Reviewed-on: http://review.couchbase.org/38066

Cleanup conn_shrink

All that extra casting just makes the code hard to read.

Change-Id: I2ab8bd1599d26b7ce670c51d4ab06f7fbd0bf09f
Reviewed-on: http://review.couchbase.org/38066
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


12345678910>>...31