History log of /3.0.3-GA/ep-engine/ (Results 276 - 300 of 4208)
Revision (<<< Hide revision tags) (Show revision tags >>>)Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
bdcdcabc16-Jun-2014 abhinavdangeti <abhinav@couchbase.com>

Fix indentation in tasks.h

Change-Id: I5cba82df5d3e04a13022d6fab3849e677dbe7a2c
Reviewed-on: http://review.couchbase.org/38340
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.c

Fix indentation in tasks.h

Change-Id: I5cba82df5d3e04a13022d6fab3849e677dbe7a2c
Reviewed-on: http://review.couchbase.org/38340
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...

c66eaf1b16-Jun-2014 Mike Wiederhold <mike@couchbase.com>

Check upr expiration when checking that seqno's increase

Change-Id: Idc5d1598e6c1221927b0a4eff8ef5651b95d7f1a
Reviewed-on: http://review.couchbase.org/38336
Reviewed-by: Sundararaman

Check upr expiration when checking that seqno's increase

Change-Id: Idc5d1598e6c1221927b0a4eff8ef5651b95d7f1a
Reviewed-on: http://review.couchbase.org/38336
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

62d3229216-Jun-2014 Sundar Sridharan <sundar.sridharan@gmail.com>

MB-11405 optimize by avoiding string constructions

getDescription() overhead in performance is seen in profile
reports when large number of active buckets come into picture
Avoid con

MB-11405 optimize by avoiding string constructions

getDescription() overhead in performance is seen in profile
reports when large number of active buckets come into picture
Avoid constructing strings in it to optimize CPU

Change-Id: Ic2d1e875eba51a9dff3a2530ca4d3b0ffe5d1e0d
Reviewed-on: http://review.couchbase.org/38337
Tested-by: Sundararaman Sridharan <sundar@couchbase.com>
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>

show more ...

080b7e6e16-Jun-2014 Mike Wiederhold <mike@couchbase.com>

Fix memory leak when queueing messages in a PassiveStream

Upr mutations, deletions, and expirations contain and Item and we
need to make sure they get freed if a stream is dead.

Fix memory leak when queueing messages in a PassiveStream

Upr mutations, deletions, and expirations contain and Item and we
need to make sure they get freed if a stream is dead.

Change-Id: I504b326e3af2ca5493df54c205feacaa9a97c9f5
Reviewed-on: http://review.couchbase.org/38333
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

c8302b8716-Jun-2014 Mike Wiederhold <mike@couchbase.com>

Revert "MB-11325: Use isBackfillPhase instead of checking chk id num"

This reverts commit 2469a551fabdcd68d6e589adde1181d7cf81ded3.

I meant to make things a little bit cleaner with

Revert "MB-11325: Use isBackfillPhase instead of checking chk id num"

This reverts commit 2469a551fabdcd68d6e589adde1181d7cf81ded3.

I meant to make things a little bit cleaner with this change. It
wasn't actually meant to fix a particular problem. Since it instead
just created issues we can revert it without having to find any
other fix.

Change-Id: Id67bffea9233b826a32b7907a9284ce80b7ab11a
Reviewed-on: http://review.couchbase.org/38314
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

fb5427df12-Jun-2014 abhinavdangeti <abhinav@couchbase.com>

Log expired items during warmup at INFO level

Change-Id: I564f61cb6affcf9d0f7d5ef9e36db1f9a4c7fed2
Reviewed-on: http://review.couchbase.org/38166
Reviewed-by: Sundararaman Sridharan

Log expired items during warmup at INFO level

Change-Id: I564f61cb6affcf9d0f7d5ef9e36db1f9a4c7fed2
Reviewed-on: http://review.couchbase.org/38166
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...

68c617d004-Jun-2014 Venu Uppalapati <venumahesh@gmail.com>

MB-11051: Add module tests for failover table

Change-Id: I21e9dc006ff0156b2c92c309ac61d0a7f3035f6b
Reviewed-on: http://review.couchbase.org/37873
Reviewed-by: Michael Wiederhold <mik

MB-11051: Add module tests for failover table

Change-Id: I21e9dc006ff0156b2c92c309ac61d0a7f3035f6b
Reviewed-on: http://review.couchbase.org/37873
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

1a5978cb12-Jun-2014 Mike Wiederhold <mike@couchbase.com>

MB-11325: Fix race condition in updating persisted seqno

We cannot rely on setting the last persisted seqno by checking
where the cursor/backfill queue is after doing persistence. The

MB-11325: Fix race condition in updating persisted seqno

We cannot rely on setting the last persisted seqno by checking
where the cursor/backfill queue is after doing persistence. The
reason is that we might switch from backfill phase to checkpoint
phase in the middle of a commit which will cause the last persisted
seqno to be set to higher than what it actually is. This can cause
backfills to be scheduled pre-maturely as a result and cause us not
to read enough items off of disk.

The only place we can really trust to get the persistence seqno is
from the actual file. So when we do persistence for a particular
vbucket we should cache the last persisted seqno. This will allow us
to get this value without having to do a disk read.

Change-Id: Ie975dae49d5271f31ba7ee48fdb9e06e30eeb8ae
Reviewed-on: http://review.couchbase.org/38243
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

8c8e30ae13-Jun-2014 Mike Wiederhold <mike@couchbase.com>

MB-11325: Fix off by one error when scheduling backfills

When we register a checkpoint cursor the seqno returned is the
first seqno that will be received for that cursor. As a result we

MB-11325: Fix off by one error when scheduling backfills

When we register a checkpoint cursor the seqno returned is the
first seqno that will be received for that cursor. As a result we
should backfill up to one less than where the cursor is scheduled.

Change-Id: I3de5c8244f68fbb764f856877a04c2f29fb1f4be
Reviewed-on: http://review.couchbase.org/38242
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

2469a55113-Jun-2014 Mike Wiederhold <mike@couchbase.com>

MB-11325: Use isBackfillPhase instead of checking chk id num

When a checkpoint is in backill phase the checkpoint id is set to
0. We should instead make sure that the vbucket is actually

MB-11325: Use isBackfillPhase instead of checking chk id num

When a checkpoint is in backill phase the checkpoint id is set to
0. We should instead make sure that the vbucket is actually in
backfill phase instead of just checking one of the symptoms of
being in backfill phase.

Change-Id: Ib5be4c18b9d551f7f8ce9abaa1071375ffff293e
Reviewed-on: http://review.couchbase.org/38241
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

c86c7db013-Jun-2014 abhinavdangeti <abhinav@couchbase.com>

MB-11417: Datatype validation for TAP_MUTATIONs

- If datatype is not supported by connection, check
for the JSONness of data before setting the datatype.

Change-Id: I0e6d4af98af

MB-11417: Datatype validation for TAP_MUTATIONs

- If datatype is not supported by connection, check
for the JSONness of data before setting the datatype.

Change-Id: I0e6d4af98af1c55b8e64df240036dd6ed13f870d
Reviewed-on: http://review.couchbase.org/38246
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...

00db5d7013-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

Don't free stack variables

couch-kvstore.cc:1644:27: warning: attempt to free a non-heap object 'ext_meta' [-Wfree-nonheap-object]

Change-Id: Iff414c633af0976d8036ad58b42ee24a638f63

Don't free stack variables

couch-kvstore.cc:1644:27: warning: attempt to free a non-heap object 'ext_meta' [-Wfree-nonheap-object]

Change-Id: Iff414c633af0976d8036ad58b42ee24a638f6387
Reviewed-on: http://review.couchbase.org/38235
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

1fc9281111-Jun-2014 Mike Wiederhold <mike@couchbase.com>

MB-10697: Add upragg stats to stats.org docs file

Change-Id: I5826faf0f6a39d3690727894da6a360613aed824
Reviewed-on: http://review.couchbase.org/38158
Reviewed-by: Sriram Ganesan <sri

MB-10697: Add upragg stats to stats.org docs file

Change-Id: I5826faf0f6a39d3690727894da6a360613aed824
Reviewed-on: http://review.couchbase.org/38158
Reviewed-by: Sriram Ganesan <sriram@couchbase.com>
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

196b6f0d28-May-2014 Mike Wiederhold <mike@couchbase.com>

MB-10697: Add upr stats to stats.org docs file

Change-Id: I03120b0cac52152b82120f67ac56bed3648e8378
Reviewed-on: http://review.couchbase.org/38157
Reviewed-by: Sriram Ganesan <sriram

MB-10697: Add upr stats to stats.org docs file

Change-Id: I03120b0cac52152b82120f67ac56bed3648e8378
Reviewed-on: http://review.couchbase.org/38157
Reviewed-by: Sriram Ganesan <sriram@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

e74d1e3312-Jun-2014 abhinavdangeti <abhinav@couchbase.com>

MB-11234: Notify when item expired by GET

When we try GET-ing an item and find that it has
expired already, we issue a softDelete on it,
upon which the item is added to the dirty que

MB-11234: Notify when item expired by GET

When we try GET-ing an item and find that it has
expired already, we issue a softDelete on it,
upon which the item is added to the dirty queue.
When enqueued, we should notifyVBConnections for
the producer to notify that the item is waiting
to be replicated and is currently in the producer
queue.

Change-Id: I0d83a2d0baabb7a9f992f8feb802cd34633079e9
Reviewed-on: http://review.couchbase.org/38212
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...

e68297e112-Jun-2014 Mike Wiederhold <mike@couchbase.com>

Add stat to PassiveStream class for last received seqno

Change-Id: I88f0756f6857a9762c6bdbc46884d9dee4af567a
Reviewed-on: http://review.couchbase.org/38201
Reviewed-by: abhinav dange

Add stat to PassiveStream class for last received seqno

Change-Id: I88f0756f6857a9762c6bdbc46884d9dee4af567a
Reviewed-on: http://review.couchbase.org/38201
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

c7e016d712-Jun-2014 abhinavdangeti <abhinav@couchbase.com>

MB-11414: Producer's state before active stream tasks

- Ensure producer's state is indeed BACKFILLING before
activestream's markDiskSnapshot task.

Change-Id: Ib68bb39100db06d843

MB-11414: Producer's state before active stream tasks

- Ensure producer's state is indeed BACKFILLING before
activestream's markDiskSnapshot task.

Change-Id: Ib68bb39100db06d8435997b327ed15439601b03a
Reviewed-on: http://review.couchbase.org/38185
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...

fe70bd4511-Jun-2014 Mike Wiederhold <mike@couchbase.com>

Use cb_assert instead of assert for windows compatibility

Change-Id: I1c2c326f60dd16c595aee22856f53f5b78553e55
Reviewed-on: http://review.couchbase.org/38155
Reviewed-by: abhinav dan

Use cb_assert instead of assert for windows compatibility

Change-Id: I1c2c326f60dd16c595aee22856f53f5b78553e55
Reviewed-on: http://review.couchbase.org/38155
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

7869ef9f11-Jun-2014 Mike Wiederhold <mike@couchbase.com>

MB-11377: Don't rollback to start_seq when snap_start_seq == start_seq

We should never attempt to rollback to the snap_start_seqno when it is
the same as the start_seqno otherwise we ris

MB-11377: Don't rollback to start_seq when snap_start_seq == start_seq

We should never attempt to rollback to the snap_start_seqno when it is
the same as the start_seqno otherwise we risk potentially having the
server response by constantly asking the consumer to rollback to the
same seqno.

Change-Id: Id6a16df2f0e08fdd1bf7abb89f1eeead474310eb
Reviewed-on: http://review.couchbase.org/38154
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

f78f13cb11-Jun-2014 Sundar Sridharan <sundar.sridharan@gmail.com>

replace assert with check in ExecutorPool

This fix is needed to prevent make simple-test from failing
due to MB-11287 where an assert fires even when dead tasks
that have no taskType

replace assert with check in ExecutorPool

This fix is needed to prevent make simple-test from failing
due to MB-11287 where an assert fires even when dead tasks
that have no taskType call doneTask()

Change-Id: I0b1ced312b40a2cce8e6b4b5d7ad5f6536292273
Reviewed-on: http://review.couchbase.org/38148
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: Sundararaman Sridharan <sundar@couchbase.com>

show more ...

3af1e55210-Jun-2014 Sundar Sridharan <sundar.sridharan@gmail.com>

MB-11287 Lock TaskQ selectively, avoid busy loops

Global Thread Pool offers 2 serialization features:
1. lockless shard serialization (Flusher, VBDelete, Snapshot etc)
2. task-queue

MB-11287 Lock TaskQ selectively, avoid busy loops

Global Thread Pool offers 2 serialization features:
1. lockless shard serialization (Flusher, VBDelete, Snapshot etc)
2. task-queue based thread control (NonIO and AuxIO)
If thread is working on tasks that need neither of the above two,
then avoid any additional locking overhead.

Also isLock variable ends up causing more overhead, removing same

Change-Id: I38b060573975786973aa608277d40851adb64e45
Reviewed-on: http://review.couchbase.org/38102
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: Sundararaman Sridharan <sundar@couchbase.com>

show more ...

5773d77c09-Jun-2014 Sundar Sridharan <sundar.sridharan@gmail.com>

MB-11349 report compaction error to memcached

return code from notifyCompaction was masking error in
actual compaction. Fix to return FAILED message to memcached

Change-Id: Iae5

MB-11349 report compaction error to memcached

return code from notifyCompaction was masking error in
actual compaction. Fix to return FAILED message to memcached

Change-Id: Iae5b88daec56c2adbf86709557d279a029599535
Reviewed-on: http://review.couchbase.org/38032
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: Sundararaman Sridharan <sundar@couchbase.com>

show more ...

99b8c1b810-Jun-2014 Sundar Sridharan <sundar.sridharan@gmail.com>

cbvdiff to find VBs where active != replica

Change-Id: Idd5a43170bac61cc15ee1ed80a68b515b88b778c
Reviewed-on: http://review.couchbase.org/38029
Reviewed-by: Sundararaman Sridharan <s

cbvdiff to find VBs where active != replica

Change-Id: Idd5a43170bac61cc15ee1ed80a68b515b88b778c
Reviewed-on: http://review.couchbase.org/38029
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: Sundararaman Sridharan <sundar@couchbase.com>

show more ...

09036c3210-Jun-2014 abhinavdangeti <abhinav@couchbase.com>

MB-11365:Datatype to be in response where required

- Return datatype in responses for GAT, GATQ,
GetLocked, GetRandomKey

Change-Id: Ia7e40c7d4a79efae3f9cfff41b51d099e89b0621

MB-11365:Datatype to be in response where required

- Return datatype in responses for GAT, GATQ,
GetLocked, GetRandomKey

Change-Id: Ia7e40c7d4a79efae3f9cfff41b51d099e89b0621
Reviewed-on: http://review.couchbase.org/38078
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...

1957db4607-Jun-2014 abhinavdangeti <abhinav@couchbase.com>

MB-11059: Support datatype during offline upgrade

- When a 3.0 server reads from a pre-3.0 couchstore
database, we need to identify the value to set the
correct datatype. Warmup will

MB-11059: Support datatype during offline upgrade

- When a 3.0 server reads from a pre-3.0 couchstore
database, we need to identify the value to set the
correct datatype. Warmup will handle this.

- In the loadKVPairs and loadData phase, if the
metadata buffer's length is found to be 16B, we will
check for the JSONness of the value to set the correct
datatype for the particular item in memory.

- In a BGFetch case, if the metadata buffer length of
the item is found to be 16B, we identify the data for
key, before setting its datatype.

- Provide a second callback function to couchstore's
compaction API to edit the docinfo of the document
only if its metadata buffer is of length 16B.

Change-Id: I1149b937d495d5dd1f0d344f701565ba96fe8225
Reviewed-on: http://review.couchbase.org/37352
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...

1...<<11121314151617181920>>...169