History log of /3.0.3-GA/ep-engine/src/couch-kvstore/couch-kvstore.cc (Results 1 - 25 of 275)
Revision (<<< Hide revision tags) (Show revision tags >>>) Date Author Comments
Revision tags: v4.6.5, v4.6.3, v4.6.4, v4.6.2, v4.6.1, v4.6.0, v4.6.0-DP, v4.5.1, v4.1.2, v3.1.6, v4.5.0, v4.1.1, v3.1.5, v3.1.4, v3.1.3, v4.1.0, v3.1.2, v3.1.1, v4.0.0, v3.1.0
# b4279b60 24-Feb-2015 abhinavdangeti <abhinav@couchbase.com>

MB-13386: Ensure that purging the highSeqno doesn't happen

+ The highest seqno is to not be purged for DCP.
+ This change ensures that items are still queued
for deletion if found to

MB-13386: Ensure that purging the highSeqno doesn't happen

+ The highest seqno is to not be purged for DCP.
+ This change ensures that items are still queued
for deletion if found to be expired.

Change-Id: I8102d5f61989523efc4f39b70b225c05cdd1b128
Reviewed-on: http://review.couchbase.org/47241
Reviewed-by: Manu Dhundi <manu@couchbase.com>
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...


# f2bc0697 18-Feb-2015 Manu Dhundi <manu@couchbase.com>

MB-13386: Do not purge the item with highest sequence number from db.

When the highest seq number that DCP is supposed to read from
the db is the last seq number in the db and is purged,

MB-13386: Do not purge the item with highest sequence number from db.

When the highest seq number that DCP is supposed to read from
the db is the last seq number in the db and is purged,
DCP backfill does not know about it and hence waits for it.
This results in DCP connection hang.
To solve this problem, during compaction we do not purge the
item with last(highest) sequence number in the db.

Change-Id: Ib83c335da3f7c0a952e4b760309276f73bff4ccf
Reviewed-on: http://review.couchbase.org/47035
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Manu Dhundi <manu@couchbase.com>

show more ...


Revision tags: v3.0.2
# e1873975 03-Nov-2014 Mike Wiederhold <mike@couchbase.com>

MB-12483: Make sure vbucket_state initializes all variables

We need to make sure that this data is always completely filled
out so that we don't accidentally write garbage data to disk.

MB-12483: Make sure vbucket_state initializes all variables

We need to make sure that this data is always completely filled
out so that we don't accidentally write garbage data to disk.

Change-Id: I196e7ca9f5bada8e0df90ddb01b6e952650bed56
Reviewed-on: http://review.couchbase.org/42729
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


# 8e87073b 03-Nov-2014 Mike Wiederhold <mike@couchbase.com>

MB-12483: Remove the default constructor in the vbucket_state struct

The default constructor can leave uninitialized fields and we persist
this structure to disk. In oreder to prevent ga

MB-12483: Remove the default constructor in the vbucket_state struct

The default constructor can leave uninitialized fields and we persist
this structure to disk. In oreder to prevent garbage from being written
we should remove the default constructor.

Change-Id: I028fac1dc112bb454779a30f695eb180278455df
Reviewed-on: http://review.couchbase.org/42728
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


# 7d037a78 31-Oct-2014 Mike Wiederhold <mike@couchbase.com>

MB-12483: Don't allow recreation during vbucket deletion

When we delete a vbucket we have an option to recreate the file
immediately. Doing this is incorrect because we will not know

MB-12483: Don't allow recreation during vbucket deletion

When we delete a vbucket we have an option to recreate the file
immediately. Doing this is incorrect because we will not know
what the failover log of the new vbucket looks like until we
actually create it in memory. This can lead to a situation where
there is no failover log and as a result the local doc json will
be invalid. If the server is shutdown right after this happens and
then is restarted the vbuckets might be created with garbage values
in some of their fields.

Change-Id: I70e6335af68746aeac49a336da5e33b70dfcfe0e
Reviewed-on: http://review.couchbase.org/42677
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


# a5bb2d58 15-Oct-2014 Sriram Ganesan <sriram@couchbase.com>

MB-12226: Handle ENOENT error during unlink

If the file is not found during an unlink, it shouldn't be added
to the pending file deletions queue.

Change-Id: Ief306277bbbc946ae18

MB-12226: Handle ENOENT error during unlink

If the file is not found during an unlink, it shouldn't be added
to the pending file deletions queue.

Change-Id: Ief306277bbbc946ae18e39dd4819f811f12ea76c
Reviewed-on: http://review.couchbase.org/42173
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Sriram Ganesan <sriram@couchbase.com>

show more ...


# 1915b03f 09-Sep-2014 Sriram Ganesan <sriram@couchbase.com>

Fix build breakage on Linux

Remove usage of constant strings for maintaining file deletion queue

Change-Id: I1992343ff65f923b6d3ffbf7a25932b936e3ff7c
Reviewed-on: http://review.

Fix build breakage on Linux

Remove usage of constant strings for maintaining file deletion queue

Change-Id: I1992343ff65f923b6d3ffbf7a25932b936e3ff7c
Reviewed-on: http://review.couchbase.org/41291
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: Sriram Ganesan <sriram@couchbase.com>

show more ...


Revision tags: v3.0.0
# 9665c150 05-Sep-2014 Sriram Ganesan <sriram@couchbase.com>

Handle unlink/remove failures

The unlink/remove function can fail if there is another process that
has an open file handle on that file. In such cases, we need to retry
the unlink pe

Handle unlink/remove failures

The unlink/remove function can fail if there is another process that
has an open file handle on that file. In such cases, we need to retry
the unlink periodically in the flusher task until we get rid of those
files.

Change-Id: I4bfcf29b3fa866ec4946db658a245c722f3725ce
Reviewed-on: http://review.couchbase.org/41268
Tested-by: Sriram Ganesan <sriram@couchbase.com>
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>

show more ...


# a20ff04d 28-Aug-2014 Mike Wiederhold <mike@couchbase.com>

Fix build breakage

Change-Id: Ibeac0d57fc1ea3bc94bf488ee5e82cf7e9143d3a
Reviewed-on: http://review.couchbase.org/41012
Reviewed-by: Chris Hillery <ceej@couchbase.com>
Tested-by:

Fix build breakage

Change-Id: Ibeac0d57fc1ea3bc94bf488ee5e82cf7e9143d3a
Reviewed-on: http://review.couchbase.org/41012
Reviewed-by: Chris Hillery <ceej@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


# 669dfe80 27-Aug-2014 Mike Wiederhold <mike@couchbase.com>

MB-12063: Properly save the max deleted seqno during vb snapshots

Change-Id: Ife9e3b26956638622de0427cd573cd4d37c7e443
Reviewed-on: http://review.couchbase.org/40997
Reviewed-by: abh

MB-12063: Properly save the max deleted seqno during vb snapshots

Change-Id: Ife9e3b26956638622de0427cd573cd4d37c7e443
Reviewed-on: http://review.couchbase.org/40997
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


# c2a66e65 28-Aug-2014 abhinavdangeti <abhinav@couchbase.com>

Avoid getting config lock on every unlinkCouchFile

Change-Id: I7a5c3cf81a227ee2ddc02750839cc3b94359fe88
Reviewed-on: http://review.couchbase.org/41004
Reviewed-by: Sundararaman Sridh

Avoid getting config lock on every unlinkCouchFile

Change-Id: I7a5c3cf81a227ee2ddc02750839cc3b94359fe88
Reviewed-on: http://review.couchbase.org/41004
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...


# baa3f6d8 27-Aug-2014 Trond Norbye <trond.norbye@gmail.com>

Fix build break on win32

Change-Id: Iab0f0cfa7fb61b84aa54f20513f80d4683775073
Reviewed-on: http://review.couchbase.org/40981
Reviewed-by: Michael Wiederhold <mike@couchbase.com>

Fix build break on win32

Change-Id: Iab0f0cfa7fb61b84aa54f20513f80d4683775073
Reviewed-on: http://review.couchbase.org/40981
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...


# 850e80fa 04-Aug-2014 Mike Wiederhold <mike@couchbase.com>

Remove shutdown check

We only needed this because we didn't want to notify mccouch.

Change-Id: I63ad9cddbe86930facfd68ceaa3ee87998ba025d
Reviewed-on: http://review.couchbase.org

Remove shutdown check

We only needed this because we didn't want to notify mccouch.

Change-Id: I63ad9cddbe86930facfd68ceaa3ee87998ba025d
Reviewed-on: http://review.couchbase.org/40958
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


# d8d0da1f 26-Aug-2014 abhinavdangeti <abhinav@couchbase.com>

MB-11722: Remove the mcCouch dependency

Now,
- unlinking stale files at the end of compaction
- unlinking files in couchkvstore reset
- unlink files in delVbucket

Change

MB-11722: Remove the mcCouch dependency

Now,
- unlinking stale files at the end of compaction
- unlinking files in couchkvstore reset
- unlink files in delVbucket

Change-Id: I000fbd076856b8de1a0dcb82aa673b3316dc745f
Reviewed-on: http://review.couchbase.org/40195
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


# 51d6b413 20-Aug-2014 Mike Wiederhold <mike@couchbase.com>

MB-11980: Fix bugs caused from persisting the current snapshot

There are two issues fixed here. One is around the current
snapshot not being updated properly during bucket flush. The

MB-11980: Fix bugs caused from persisting the current snapshot

There are two issues fixed here. One is around the current
snapshot not being updated properly during bucket flush. The
second is an issue caused by persisting the wrong information
for the high seqno, snap start seqno, and snap end seqno during
the snapshot vbuckets task. These values should remain the same
as they were after the last vbucket persistence task otherwise
we might persist incorrect values.

Change-Id: Ie4a357270b52bd35b5f29018f24fd3550913f1cc
Reviewed-on: http://review.couchbase.org/40707
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


# e3290a8b 15-Aug-2014 Sriram Ganesan <sriram@couchbase.com>

MB-11934: Fix warmup for windows

During warmup in windows, the platform library appends a backslash instead
of a forward slash causing a database file name parsing to break.

Cha

MB-11934: Fix warmup for windows

During warmup in windows, the platform library appends a backslash instead
of a forward slash causing a database file name parsing to break.

Change-Id: I4b3d2296c83dcdf4f94698532a2115dedc841fdb
Reviewed-on: http://review.couchbase.org/40673
Tested-by: Sriram Ganesan <sriram@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# f7459c6a 15-Aug-2014 Chiyoung Seo <chiyoung.seo@gmail.com>

Fix the regression from the change for MB-11943

The change for MB-11943 caused the sporadic failure
in "vbucket deletion doesn't affect new data" unit test case.

This change mak

Fix the regression from the change for MB-11943

The change for MB-11943 caused the sporadic failure
in "vbucket deletion doesn't affect new data" unit test case.

This change makes sure that we have the same logic in maintaining
cachedVBState instance for a deleted vbucket.

Change-Id: I7fda66a258c46cd04820001e945e0679eed0469b
Reviewed-on: http://review.couchbase.org/40645
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# ce5f4f7e 14-Aug-2014 Chiyoung Seo <chiyoung.seo@gmail.com>

MB-11945 Remove the assertion check on sequence number in the flusher.

We sporadically observe the sequence number mismatches between the
flusher and Couchstore. This is not a regression

MB-11945 Remove the assertion check on sequence number in the flusher.

We sporadically observe the sequence number mismatches between the
flusher and Couchstore. This is not a regression from any recent
changes, and mostly existed much earlier. We will investigate this
issue separately to see if there are any bugs in ep-engine or
Couchstore.

Change-Id: Ifac2eae0deae09cad09dd7b5664f63bcbf828b24
Reviewed-on: http://review.couchbase.org/40630
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# f97e7c37 14-Aug-2014 Sundar Sridharan <sundar.sridharan@gmail.com>

MB-11943: replace map with vector for cachedVBStates

std::map can incur thread-unsafe rb balance operations which
may invalidate concurrent iterators causing asserts or crashes
Pre-a

MB-11943: replace map with vector for cachedVBStates

std::map can incur thread-unsafe rb balance operations which
may invalidate concurrent iterators causing asserts or crashes
Pre-allocated vectors are thread-safe as long as the size is not
altered
Change-Id: I777b0cc7d9c421cc11425db75506fdf90044a93c
Reviewed-on: http://review.couchbase.org/40600
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# 171ef022 14-Aug-2014 Mike Wiederhold <mike@couchbase.com>

MB-11928: Fast path for rollback to 0

Right now we run through all of the headers even if we have to
rollback to 0. This change provides a fast path to rollback to
zero by immediatel

MB-11928: Fast path for rollback to 0

Right now we run through all of the headers even if we have to
rollback to 0. This change provides a fast path to rollback to
zero by immediately resetting the vbucket.

Change-Id: I8e7b62ec711838894c4eda92eaff78704bd94d50
Reviewed-on: http://review.couchbase.org/40595
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


# 60cb687f 06-Aug-2014 Mike Wiederhold <mike@couchbase.com>

MB-11299: Allow rollbacks to a partial snapshot

If we roll back to a partial snapshot we need to make sure to get
the snapshot start and end seqnos for the partial snapshot in order

MB-11299: Allow rollbacks to a partial snapshot

If we roll back to a partial snapshot we need to make sure to get
the snapshot start and end seqnos for the partial snapshot in order
to make sure that we don't accidentally miss any items when
reconnecting.

Change-Id: If95d0476d8d582d6b57786387212f03b2aafc7ba
Reviewed-on: http://review.couchbase.org/40340
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


# 007528bb 07-Aug-2014 Mike Wiederhold <mike@couchbase.com>

MB-11887: Properly send the snapshot start and end seqnos

Currently we always set the snapshot start and end seqno to be the
same as the start seqno. This is incorrect if we recently wer

MB-11887: Properly send the snapshot start and end seqnos

Currently we always set the snapshot start and end seqno to be the
same as the start seqno. This is incorrect if we recently were
disconnected and need to resume from a partial snapshot.

Change-Id: I7c9430e0b24ef01cc427cb03b518f4c41a55d875
Reviewed-on: http://review.couchbase.org/40276
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


# 5f113e6f 30-Jul-2014 D Liao <liaodw@gmail.com>

MB-9131 Warmup should check for couchstore dbfile before open

When creating dbFileRevMap during warmup, we now check for the
existence of couchstore db files so that we don't open non-ex

MB-9131 Warmup should check for couchstore dbfile before open

When creating dbFileRevMap during warmup, we now check for the
existence of couchstore db files so that we don't open non-existing
files so to avoid generating warning logs.

Change-Id: I8dd7b423f01240e8958b88fce2d58b429f0c9590
Reviewed-on: http://review.couchbase.org/40078
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# d25a5759 30-Jul-2014 Sundar Sridharan <sundar.sridharan@gmail.com>

MB-11830 unless recreating don't resetVBucket on delVBucket

This change avoids writing an empty json failover table which
can cause tools like cbtransfer to fail
Change-Id: I658a0822

MB-11830 unless recreating don't resetVBucket on delVBucket

This change avoids writing an empty json failover table which
can cause tools like cbtransfer to fail
Change-Id: I658a08222800a4dc35b2c0b469de6cfbbbb8e9a4
Reviewed-on: http://review.couchbase.org/40039
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# e9459939 25-Jul-2014 Chiyoung Seo <chiyoung.seo@gmail.com>

MB-11731 Replace the shard-level vbstate snapshot with individual tasks.

As we replace a shard-level lock with a vbucket-level lock to synchronize
the flusher, vbucket deletion, vbucket

MB-11731 Replace the shard-level vbstate snapshot with individual tasks.

As we replace a shard-level lock with a vbucket-level lock to synchronize
the flusher, vbucket deletion, vbucket compaction, vbucket state
persistence tasks, this changes also replaces the shard-level vbstate
snapshot task with individual vbstate persistence tasks.

Change-Id: Ief7138a4b63d388cd786b966f68fcd8ab6ce2722
Reviewed-on: http://review.couchbase.org/39906
Reviewed-by: David Liao <david.liao@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


1234567891011