MB-10476: Use cb_assert instead of assert

If compiled with -DNDEBUG assert is an empty macro

Change-Id: I266ddf8a8fe3f1a388a9d8ce3d21f28614c35315
Reviewed-on: http://review.couc

MB-10476: Use cb_assert instead of assert

If compiled with -DNDEBUG assert is an empty macro

Change-Id: I266ddf8a8fe3f1a388a9d8ce3d21f28614c35315
Reviewed-on: http://review.couchbase.org/34579
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

Use our own thread wrapper for tests

Change-Id: Id32ebcaa3ae2967cbc4c8fbdcb6ccff641ff2353
Reviewed-on: http://review.couchbase.org/31411
Reviewed-by: Michael Wiederhold <mike@couchba

Use our own thread wrapper for tests

Change-Id: Id32ebcaa3ae2967cbc4c8fbdcb6ccff641ff2353
Reviewed-on: http://review.couchbase.org/31411
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

MB-8066 Maintain the high priority vbucket counter per shard

As we have a separate flusher per shard, we need to maintain
the high priority vbucket counter per shard.

Change-Id:

MB-8066 Maintain the high priority vbucket counter per shard

As we have a separate flusher per shard, we need to maintain
the high priority vbucket counter per shard.

Change-Id: I03a626006fb3f9b285e84d1927e9bd44ead70f02
Reviewed-on: http://review.couchbase.org/26448
Reviewed-by: Jin Lim <jin@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>

show more ...

MB-7966 KVShard implementation for Multi-readers and writers

This change introduces the concept of the KVShard class which is
used to allow scheduling for the multi-reader/writer feature

MB-7966 KVShard implementation for Multi-readers and writers

This change introduces the concept of the KVShard class which is
used to allow scheduling for the multi-reader/writer feature. The
KVShard is a simply a logical partitioning of the VBucket map that
allows the engine to easily be able to schedule jobs from different
VBuckets to specific reader and writer threads.

Change-Id: I527b63a2f998020334d0d47dbb8fb3870d8312e6
Reviewed-on: http://review.couchbase.org/25624
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

MB-7728: Add copyright headers to all files

This is something that our cpplint tool turns on and it makes
our product look a little bit more profesional. I have also
enabled the tool

MB-7728: Add copyright headers to all files

This is something that our cpplint tool turns on and it makes
our product look a little bit more profesional. I have also
enabled the tool to begin checking for these headers so it will
start complaining if we add a new file without a copyright header.

Change-Id: Ie956fdf7027bf56d9665ee455acd3c109fcacc76
Reviewed-on: http://review.couchbase.org/24560
Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Reviewed-by: Jin Lim <jin@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

MB-7461: Alphabetize includes to conform with c++ standards

Change-Id: I71333dedada6530713b90184857bab9ac49d13df
Reviewed-on: http://review.couchbase.org/23515
Reviewed-by: Jin Lim <

MB-7461: Alphabetize includes to conform with c++ standards

Change-Id: I71333dedada6530713b90184857bab9ac49d13df
Reviewed-on: http://review.couchbase.org/23515
Reviewed-by: Jin Lim <jin@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

MB-7405: Make extension for all header files .h

Change-Id: I7badb1e71c038b6498296c2893ccdbd47c2f0f87
Reviewed-on: http://review.couchbase.org/23483
Reviewed-by: Michael Wiederhold <m

MB-7405: Make extension for all header files .h

Change-Id: I7badb1e71c038b6498296c2893ccdbd47c2f0f87
Reviewed-on: http://review.couchbase.org/23483
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

MB-6141: Reorganize test directory structure

The t/ directroy is now tests/
Module tests now live in tests/module_tests
ep_testsuite.* now lives in tests/

Change-Id: Ifb0725

MB-6141: Reorganize test directory structure

The t/ directroy is now tests/
Module tests now live in tests/module_tests
ep_testsuite.* now lives in tests/

Change-Id: Ifb0725d1a235af4b910df12d366d41d40f7cc646
Reviewed-on: http://review.couchbase.org/19623
Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>

show more ...

MB-3875: Prioritize active vbuckets for persistence

Change-Id: I23dfe15413fd8399e9e09224beaa82a84ec13bd0
Reviewed-on: http://review.couchbase.org/17659
Reviewed-by: Chiyoung Seo <chi

MB-3875: Prioritize active vbuckets for persistence

Change-Id: I23dfe15413fd8399e9e09224beaa82a84ec13bd0
Reviewed-on: http://review.couchbase.org/17659
Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>

show more ...

Include unistd.h for usleep(3)

Fixes compiler errors like this:

In file included from vbucket.hh:18:0,
from backfill.cc:3:
stored-value.hh: In destructor 'H

Include unistd.h for usleep(3)

Fixes compiler errors like this:

In file included from vbucket.hh:18:0,
from backfill.cc:3:
stored-value.hh: In destructor 'HashTable::~HashTable()':
stored-value.hh:973:23: error: 'usleep' was not declared in this scope

Change-Id: I7bc2c26a8e7e1fec928d51f36a78ba028a6486d7
Reviewed-on: http://review.couchbase.org/16024
Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>

show more ...

MB-5092 Use std::set to maintain the list of VB ids in VBFilter

Using std::vector introduced some bugs in maintaining the list
of sorted unique vbucket ids in VBFilter instance. This cha

MB-5092 Use std::set to maintain the list of VB ids in VBFilter

Using std::vector introduced some bugs in maintaining the list
of sorted unique vbucket ids in VBFilter instance. This change
fixes this issue by using std::set instead.

Change-Id: I531a080cddae356b897a4feab1d5a74dc2de1ced
Reviewed-on: http://review.couchbase.org/15179
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Reviewed-on: http://review.couchbase.org/15264
Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>

show more ...

[Backport] Refactor: Make checkpoint config variables non-static

Change-Id: Id56e3e25204c8f825911aa0860096fdf531f91f1
Reviewed-on: http://review.couchbase.org/12155
Reviewed-by: Chiy

[Backport] Refactor: Make checkpoint config variables non-static

Change-Id: Id56e3e25204c8f825911aa0860096fdf531f91f1
Reviewed-on: http://review.couchbase.org/12155
Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>

show more ...

VBucketMap shouldn't change in size @runtime

Change-Id: I3801595d5a5a727c4cd9ebf9f5f96b63fc2862cd
Reviewed-on: http://review.couchbase.org/11679
Reviewed-by: Chiyoung Seo <chiyoung.s

VBucketMap shouldn't change in size @runtime

Change-Id: I3801595d5a5a727c4cd9ebf9f5f96b63fc2862cd
Reviewed-on: http://review.couchbase.org/11679
Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>

show more ...

Refactor: Make checkpoint config variables non-static.

Making checkpoint config variables non-static is required to
have difference values for multiple buckets.

Change-Id: Idbab

Refactor: Make checkpoint config variables non-static.

Making checkpoint config variables non-static is required to
have difference values for multiple buckets.

Change-Id: Idbabf8c08cfef4ed051e0894b61c4806de490cc0
Reviewed-on: http://review.couchbase.org/8473
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>

show more ...

Use threadlocal storage to keep track of the current engine

Change-Id: Id0d5de0c6f7509467f0cc4caef5de692cd9787a4
Reviewed-on: http://review.membase.org/5306
Reviewed-by: Chiyoung Seo

Use threadlocal storage to keep track of the current engine

Change-Id: Id0d5de0c6f7509467f0cc4caef5de692cd9787a4
Reviewed-on: http://review.membase.org/5306
Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>

show more ...

Fix to the memory over-accounting issue caused by shared pointers.

There was a memory over-accounting issue because we account the
memory usage of a value pointed by both hashtable and c

Fix to the memory over-accounting issue caused by shared pointers.

There was a memory over-accounting issue because we account the
memory usage of a value pointed by both hashtable and checkpoint
twice. This fixes the above issue by accounting the memory usage
of values in Blob constructor and deconstructor.

Change-Id: I574f8a4444da2f3cb04689b0a8770adb79980052
Reviewed-on: http://review.membase.org/5072
Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Use ep_real_time() in checking the time bound on a checkpoint.

ep_current_time doesn't return the relative time correctly while
initializing the ep_engine instance and activating vbucket

Use ep_real_time() in checking the time bound on a checkpoint.

ep_current_time doesn't return the relative time correctly while
initializing the ep_engine instance and activating vbuckets and their
checkpoints. ep_real_time doesn't invoke any sys call and is actually
as efficient as ep_current_time. We will fix the ep_current_time
issue during the warmup time as a separate change.

Change-Id: I9b7c653e247ece9e3bb32f0144d54de2deae3862
Reviewed-on: http://review.membase.org/4945
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>

show more ...

Integration of checkpoint support into the persistence module.

The flusher gets persistence tasks by grabing all the items from
its current cursor position in the checkpoint datastructur

Integration of checkpoint support into the persistence module.

The flusher gets persistence tasks by grabing all the items from
its current cursor position in the checkpoint datastructure for each
vbucket, and then performs the further optimization, and finally
places them into the outgoing queue.

Change-Id: I23a29d6e2d972e5620ba5702e374928925f595c8
Reviewed-on: http://review.membase.org/4817
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Add the checkpoint support into VBucket.

This integrates the checkpoint and checkpoint manager into
VBucket class.

Change-Id: I83bf5378384c5e6080e57b745dd8abc7ba22c624
Revie

Add the checkpoint support into VBucket.

This integrates the checkpoint and checkpoint manager into
VBucket class.

Change-Id: I83bf5378384c5e6080e57b745dd8abc7ba22c624
Reviewed-on: http://review.membase.org/4816
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Reusable logger code for tests.

This code was cut-and-pasted in a few locations in test code and I
need something very similar for dbupgrade.

Change-Id: Ib7e740c6744d7c44f17fa7c

Reusable logger code for tests.

This code was cut-and-pasted in a few locations in test code and I
need something very similar for dbupgrade.

Change-Id: Ib7e740c6744d7c44f17fa7c4dd3c8f87830e5d40
Reviewed-on: http://review.membase.org/4278
Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>

show more ...

Write vbucket filter in a compact form

Instead of listing all of the individual buckets all ranges that span
more than two numbers will be written as [start,end].

Ex:

{

Write vbucket filter in a compact form

Instead of listing all of the individual buckets all ranges that span
more than two numbers will be written as [start,end].

Ex:

{ 1, 2, 3, 4, 5, 6, 7, 8, 9 } ==> { [1,9] }
{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 100, 101 } ==> { [1,9], 100, 102 }
{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 100, 101, 102 } ==> { [1,9], [100,102] }

Change-Id: I6597f78f0826c339f7e155fac008cff8b7a5a79f
Reviewed-on: http://review.membase.org/4250
Reviewed-by: Dustin Sallings <dustin@spy.net>
Tested-by: Dustin Sallings <dustin@spy.net>

show more ...

Update to the upstream engine changes

Change-Id: Id032f37f620649f2b2cafeec9f25c859676bc354
Reviewed-on: http://review.membase.org/3952
Reviewed-by: Dustin Sallings <dustin@spy.net>

Update to the upstream engine changes

Change-Id: Id032f37f620649f2b2cafeec9f25c859676bc354
Reviewed-on: http://review.membase.org/3952
Reviewed-by: Dustin Sallings <dustin@spy.net>
Tested-by: Dustin Sallings <dustin@spy.net>

show more ...

Compile fixes for Sun Studio compilers

Change-Id: I087fbe83c239ec7934d57400f714d8c3906dd04a
Reviewed-on: http://review.northscale.com/2942
Reviewed-by: Dustin Sallings <dustin@spy.ne

Compile fixes for Sun Studio compilers

Change-Id: I087fbe83c239ec7934d57400f714d8c3906dd04a
Reviewed-on: http://review.northscale.com/2942
Reviewed-by: Dustin Sallings <dustin@spy.net>
Tested-by: Dustin Sallings <dustin@spy.net>

show more ...

Isolate memory tracking removing global variables.

Change-Id: I443f7bf1c7f3c1ef8408bdb509604d39d5660343
Reviewed-on: http://review.northscale.com/1560
Reviewed-by: Steve Yen <steve.y

Isolate memory tracking removing global variables.

Change-Id: I443f7bf1c7f3c1ef8408bdb509604d39d5660343
Reviewed-on: http://review.northscale.com/1560
Reviewed-by: Steve Yen <steve.yen@gmail.com>
Tested-by: Steve Yen <steve.yen@gmail.com>

show more ...

Include config.h as the first file in the source files

This allows us to define symbols that might affect the content of system headers

Change-Id: Idbb24a38757192f62abd68a2aa930d577

Include config.h as the first file in the source files

This allows us to define symbols that might affect the content of system headers

Change-Id: Idbb24a38757192f62abd68a2aa930d577d486687
Reviewed-on: http://review.northscale.com/1614
Tested-by: Dustin Sallings <dustin@spy.net>
Reviewed-by: Dustin Sallings <dustin@spy.net>

show more ...