History log of /3.0.3-GA/memcached/ (Results 51 - 75 of 1687)
Revision (<<< Hide revision tags) (Show revision tags >>>)Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
87bfbfab13-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

Fixed incorrect break for unsupported TLS

Change-Id: Iabc48f756567adab0ba5f283207d51a7608c0f13
Reviewed-on: http://review.couchbase.org/38225
Tested-by: Trond Norbye <trond.norbye@gm

Fixed incorrect break for unsupported TLS

Change-Id: Iabc48f756567adab0ba5f283207d51a7608c0f13
Reviewed-on: http://review.couchbase.org/38225
Tested-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

1add166110-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

MB-11360: Don't ack successful mutations

Change-Id: I2b09fc07a2063a53d82e10477c500be1bed88847
Reviewed-on: http://review.couchbase.org/38068
Reviewed-by: Michael Wiederhold <mike@cou

MB-11360: Don't ack successful mutations

Change-Id: I2b09fc07a2063a53d82e10477c500be1bed88847
Reviewed-on: http://review.couchbase.org/38068
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

fd7677df10-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

MB-11244: Don't try to cleanly shut down the logger (WIN32)

Unfortunately it looks like the C runtime from MSVC "kills" the
threads before the "atexit" handler is run, causing the progra

MB-11244: Don't try to cleanly shut down the logger (WIN32)

Unfortunately it looks like the C runtime from MSVC "kills" the
threads before the "atexit" handler is run, causing the program
to halt in one of these steps depending on the state of the
variables. Just disable the code for now.

Change-Id: I314bb689b26e87a60b15ed996752ce33803c2912
Reviewed-on: http://review.couchbase.org/38077
Tested-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Michael Wiederhold <mike@couchbase.com>

show more ...

b9cba82710-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

Remove unused constants

Change-Id: I21eb9fb964c0db92d373c8c498b4e5af6d190059
Reviewed-on: http://review.couchbase.org/38067
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tes

Remove unused constants

Change-Id: I21eb9fb964c0db92d373c8c498b4e5af6d190059
Reviewed-on: http://review.couchbase.org/38067
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

83a24bff10-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

Cleanup conn_shrink

All that extra casting just makes the code hard to read.

Change-Id: I2ab8bd1599d26b7ce670c51d4ab06f7fbd0bf09f
Reviewed-on: http://review.couchbase.org/38066

Cleanup conn_shrink

All that extra casting just makes the code hard to read.

Change-Id: I2ab8bd1599d26b7ce670c51d4ab06f7fbd0bf09f
Reviewed-on: http://review.couchbase.org/38066
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

8667210c04-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

MB-11284: Support "admin" user in memcached core

Change-Id: I8e990e147ea870857483638bd1e9fa8e6fea551b
Reviewed-on: http://review.couchbase.org/37830
Reviewed-by: Trond Norbye <trond.

MB-11284: Support "admin" user in memcached core

Change-Id: I8e990e147ea870857483638bd1e9fa8e6fea551b
Reviewed-on: http://review.couchbase.org/37830
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

2f31ff5c06-Jun-2014 Dave Rigby <daver@couchbase.com>

MB-11305 Ensure that memcpy() source is not NULL

As noted by Clang static analyzer. The source of memcpy {key} cannot
be NULL here (as keylen is checked) so to squelch the warning, add a

MB-11305 Ensure that memcpy() source is not NULL

As noted by Clang static analyzer. The source of memcpy {key} cannot
be NULL here (as keylen is checked) so to squelch the warning, add an
assert().

Change-Id: I516607efcc8156fb310cdc635f1cf5615c3441c7
Reviewed-on: http://review.couchbase.org/37964
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

f4372ea106-Jun-2014 Dave Rigby <daver@couchbase.com>

MB-11305 Ensure that realloc isn't called with zero size

realloc() with a size of zero is undefined according to ISO C [9899:2011]. Assert that the size is non-zero.

Change-Id: I406

MB-11305 Ensure that realloc isn't called with zero size

realloc() with a size of zero is undefined according to ISO C [9899:2011]. Assert that the size is non-zero.

Change-Id: I4069675a73d13d06e324d8aa43ff213ec107bbd4
Reviewed-on: http://review.couchbase.org/37963
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

7e99993306-Jun-2014 Mike Wiederhold <mike@couchbase.com>

Set the signal handler mask to empty to avoid valgrind warning

Change-Id: I9c9fd12377b759aff38c7012edea74722dee9c1f
Reviewed-on: http://review.couchbase.org/37980
Reviewed-by: Chiyou

Set the signal handler mask to empty to avoid valgrind warning

Change-Id: I9c9fd12377b759aff38c7012edea74722dee9c1f
Reviewed-on: http://review.couchbase.org/37980
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

ca994d1e06-Jun-2014 Mike Wiederhold <mike@couchbase.com>

Fix memory leak in engine_testapp when destroying cookie

We need to decrement the reference counter when we are done with a
cookie otherwise it won't actually be freed.

Change-I

Fix memory leak in engine_testapp when destroying cookie

We need to decrement the reference counter when we are done with a
cookie otherwise it won't actually be freed.

Change-Id: I35cc19f36a50a61e4be8f9701972c75695313fb3
Reviewed-on: http://review.couchbase.org/37977
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

77dfcb2c06-Jun-2014 Dave Rigby <daver@couchbase.com>

MB-11305 Fix memory leak in testapp

As identified by Clang static analyzer; fix memory leak in the
memcached testapp.

Change-Id: I1738288aa648b6b680dd205446dea6badc80b863
Re

MB-11305 Fix memory leak in testapp

As identified by Clang static analyzer; fix memory leak in the
memcached testapp.

Change-Id: I1738288aa648b6b680dd205446dea6badc80b863
Reviewed-on: http://review.couchbase.org/37962
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

d5a4e06d06-Jun-2014 Dave Rigby <daver@couchbase.com>

MB-11305 Fix dead assignments

As identified by Clang static analyzer; fix instances of dead
assignments - either remove the assignment where it's not needed, or
actually check return

MB-11305 Fix dead assignments

As identified by Clang static analyzer; fix instances of dead
assignments - either remove the assignment where it's not needed, or
actually check return values we were previously ignoring.

Change-Id: I71848c43a126e0fab736ca2a804a9fb51ac5cf03
Reviewed-on: http://review.couchbase.org/37961
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

e228ad6b22-May-2014 Trond Norbye <trond.norbye@gmail.com>

Add support for jemalloc

See http://www.canonware.com/jemalloc/

Change-Id: I1b5617b1534863f88f223675ccc7dc7fdc02f917
Reviewed-on: http://review.couchbase.org/37444
Reviewed-

Add support for jemalloc

See http://www.canonware.com/jemalloc/

Change-Id: I1b5617b1534863f88f223675ccc7dc7fdc02f917
Reviewed-on: http://review.couchbase.org/37444
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

e1780a9b04-Jun-2014 Dave Rigby <daver@couchbase.com>

MB-11305 Fix type used for sizeof() during {re,c}alloc

As identified by clang static analyser, use the correct type in
sizeof() {re,c}alloc.

Change-Id: I66cd8be2b8c1b0a7661294b6

MB-11305 Fix type used for sizeof() during {re,c}alloc

As identified by clang static analyser, use the correct type in
sizeof() {re,c}alloc.

Change-Id: I66cd8be2b8c1b0a7661294b6d799dfcdb190d269
Reviewed-on: http://review.couchbase.org/37838
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

74a7abf704-Jun-2014 Dave Rigby <daver@couchbase.com>

MB-11307 Initialize inflated_length

Clang static analyser complains that inflaged_length can be used
before it's initialized. I've checked the code and I believe it is
safe, and this

MB-11307 Initialize inflated_length

Clang static analyser complains that inflaged_length can be used
before it's initialized. I've checked the code and I believe it is
safe, and this isn't possible. However there's no harm in initializing
inflated_length, which has the benefit of squelching the warning.

Change-Id: Ibfb533dc32f6bee4948c40afba8505e1edd108bf
Reviewed-on: http://review.couchbase.org/37837
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

bc329cc004-Jun-2014 Dave Rigby <daver@couchbase.com>

MB-11305 Use correct type for sizeof() when allocating hashtable.

Change-Id: I3cf0a46699bd30241bd9708b1e9bc82084e6a7cb
Reviewed-on: http://review.couchbase.org/37836
Reviewed-by: Tro

MB-11305 Use correct type for sizeof() when allocating hashtable.

Change-Id: I3cf0a46699bd30241bd9708b1e9bc82084e6a7cb
Reviewed-on: http://review.couchbase.org/37836
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

273bdbd004-Jun-2014 Dave Rigby <daver@couchbase.com>

MB-11305 Fix mock_stats type

The type used by mock stats (mock_new_independent_stats /
mock_release_independent_stats) was incorrect - it should be
'struct mock_stats'

Chang

MB-11305 Fix mock_stats type

The type used by mock stats (mock_new_independent_stats /
mock_release_independent_stats) was incorrect - it should be
'struct mock_stats'

Change-Id: Ice731564fdd9dfbc19e4c6095947251a6fa11259
Reviewed-on: http://review.couchbase.org/37835
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

480eeabd04-Jun-2014 Dave Rigby <daver@couchbase.com>

MB-11305 potential dereference of NULL pointer

As identified by clang static analyser; there is a code path where
{ptr} may be NULL - if no daemon extensions are loaded
(settings.ext

MB-11305 potential dereference of NULL pointer

As identified by clang static analyser; there is a code path where
{ptr} may be NULL - if no daemon extensions are loaded
(settings.extensions.daemon is NULL) and an attempt is made to
unregister something, then {ptr} would be dereferenced at line 8054.

Same bug is also present (and fixed) in mock_server.c

Change-Id: Iea12fa797d8559991bb73f18f48e7361730dca91
Reviewed-on: http://review.couchbase.org/37834
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

a242a76204-Jun-2014 Dave Rigby <daver@couchbase.com>

MB-11305 fix leak of cmdline from engine_testapp

As identified by clang static analyser; {cmdline} was not previously
freed if main() exited during any of the parameter checks. Fix by

MB-11305 fix leak of cmdline from engine_testapp

As identified by clang static analyser; {cmdline} was not previously
freed if main() exited during any of the parameter checks. Fix by
moving the check for cmdline to the end; and then freeing there.

Change-Id: I43784d726da8a602e07b528404e08de844f2a7d1
Reviewed-on: http://review.couchbase.org/37833
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

1fe7ad4b04-Jun-2014 Dave Rigby <daver@couchbase.com>

MB-11305 fix leak of config from handle_delete_bucket()

As identified by clang static analyser; ensure {config} is freed in
the case where (config[0] == 0) at line 2905.

Change-

MB-11305 fix leak of config from handle_delete_bucket()

As identified by clang static analyser; ensure {config} is freed in
the case where (config[0] == 0) at line 2905.

Change-Id: Ic7a90434f57690371c6137b06ba0ff9a04f7809d
Reviewed-on: http://review.couchbase.org/37832
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

c010914404-Jun-2014 Dave Rigby <daver@couchbase.com>

MB-11305 remove double-free of conn in allocate_connection()

As identified by clang static analyser; remove the double free of the
connection object. Note that conn_constructor already c

MB-11305 remove double-free of conn in allocate_connection()

As identified by clang static analyser; remove the double free of the
connection object. Note that conn_constructor already cleans up after
itself and free()s all allocated data; so it is incorrect to call
conn_destructor() on a failed construction.

Change-Id: Ie0163914ac7295332ff26cca94db3280ed36e27a
Reviewed-on: http://review.couchbase.org/37831
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

a92301a723-May-2014 Mark Nunberg <mnunberg@haskalah.org>

MB-11203: Refer to SSL_read()/SSL_peek before polling for read data

This fixes some issues with SSL receiving large amounts of data in its
input buffer.

Note this is a WIP and s

MB-11203: Refer to SSL_read()/SSL_peek before polling for read data

This fixes some issues with SSL receiving large amounts of data in its
input buffer.

Note this is a WIP and someone might have to fix this up. I don't know
how this may impact libevent - all I know is that it fixes my problem.

Change-Id: I2b235c301ce557e684c6d2224cebc8f45a36d560
Reviewed-on: http://review.couchbase.org/37537
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

ab18468623-May-2014 Trond Norbye <trond.norbye@gmail.com>

Fix problem related to SSL buffering

There was a problem if OpenSSL accepted the last piece of the
data to be sent, but the socket library failed to accept it
(ewouldblock). This pat

Fix problem related to SSL buffering

There was a problem if OpenSSL accepted the last piece of the
data to be sent, but the socket library failed to accept it
(ewouldblock). This patch set's the ewouldblock in these
cases and retires the flushing of the buffer until it is done.

Change-Id: Icc2bba8d0d8b6870a0b303454bdedb28bd5527bc
Reviewed-on: http://review.couchbase.org/37512
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

ad04bf7b22-May-2014 David Liao <liaodw@gmail.com>

MB-11016 Deal with byte order of UPR mutation flag

Make sure upr-producer send 'flags' in the mutation in network
byte-order by not converting the value which is already in network
b

MB-11016 Deal with byte order of UPR mutation flag

Make sure upr-producer send 'flags' in the mutation in network
byte-order by not converting the value which is already in network
byte-order when stored.

Change-Id: Idbadb5deb427af2e456e57c0001ab7cb1c33fcd2
Reviewed-on: http://review.couchbase.org/37413
Tested-by: David Liao <david.liao@couchbase.com>
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

c6c3202422-May-2014 Trond Norbye <trond.norbye@gmail.com>

Get allocation size should be const

Change-Id: I6e6091e1df56fc012b74a76c3c737f122636ff0d
Reviewed-on: http://review.couchbase.org/37431
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.

Get allocation size should be const

Change-Id: I6e6091e1df56fc012b74a76c3c737f122636ff0d
Reviewed-on: http://review.couchbase.org/37431
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

12345678910>>...68