History log of /3.0.3-GA/memcached/daemon/ (Results 1 - 25 of 254)
Revision (<<< Hide revision tags) (Show revision tags >>>)Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
Revision tags: v4.6.3, v4.6.2-MP3, v4.6.5, v4.6.2, v4.5.1-MP1, v4.6.0-DP, v4.1.2-MP2, v4.5.1, v4.6.0, v4.5.0, v4.1.1, v3.1.4, v3.1.5, v4.1.0, v3.1.2, v3.1.1, v4.0.0, v3.1.0, v3.1.6, v3.0.2-MP2
4424e90314-Feb-2015 Trond Norbye <trond.norbye@gmail.com>

MB-13286: Update conn_new_cmd

Change-Id: I8edaaa81f786cbc7bc6f32ed4076cc0c820b0f0f
Reviewed-on: http://review.couchbase.org/46845
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>

MB-13286: Update conn_new_cmd

Change-Id: I8edaaa81f786cbc7bc6f32ed4076cc0c820b0f0f
Reviewed-on: http://review.couchbase.org/46845
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

8792bc0a12-Feb-2015 abhinavdangeti <abhinav@couchbase.com>

MB-13286: State change to conn_ship_log for DCP regardless of nevents

Change-Id: I3ada2a963cb112b9d4901fef45e2c382950d0dfc
Reviewed-on: http://review.couchbase.org/46726
Reviewed-by:

MB-13286: State change to conn_ship_log for DCP regardless of nevents

Change-Id: I3ada2a963cb112b9d4901fef45e2c382950d0dfc
Reviewed-on: http://review.couchbase.org/46726
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...

Revision tags: v3.0.2
908acf7825-Nov-2014 Dave Rigby <daver@couchbase.com>

MB-12762: Close SSL connection on error during handshake

If a receive error occured during SSL handshake (e.g. received
incorrect handshake data) then instead of closing the connection (

MB-12762: Close SSL connection on error during handshake

If a receive error occured during SSL handshake (e.g. received
incorrect handshake data) then instead of closing the connection (as
expected) memcached would belive it needed to retry and return the
connection to the conn_read state. This resulted in the state machine
for the connection essentially looping forever attempting to read
data. This has two observabl side-effects:

1) A connection slot is essentially consumed (forever) by the failed
connection attempt.

2) The frontend thread that the failed connection was assigned to will
spin (at 100% CPU), if no other connections owned by the worker have
any events waiting.

(Note for (2), the CPU isn't "consumed" - other connections if present
*will* be serviced as normal, the issue is simply that the failed
connection immediately posts an event to retry the read, which
libevent will immediately schedule if there are no other events
(i.e. other connections) ready).

Fix is to ensure that the ssl.error status is checked after draining
the SSL recv pipe, and if set then reseting the connection.

Change-Id: I1775b7ad16c6e12fc619da2ba15c93f6e07cd096
Reviewed-on: http://review.couchbase.org/43608
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

28e825f710-Nov-2014 Trond Norbye <trond.norbye@gmail.com>

Backport of fix for MB-11642

This is a minimum implementation of the patch provided
for Sherlock (all configuration methods removed).

Change-Id: I5be0b7247e13d55570d662f2470ffd8

Backport of fix for MB-11642

This is a minimum implementation of the patch provided
for Sherlock (all configuration methods removed).

Change-Id: I5be0b7247e13d55570d662f2470ffd841a3a7c65
Reviewed-on: http://review.couchbase.org/43047
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

Revision tags: v3.0.1
9658c49713-Oct-2014 Mike Wiederhold <mike@couchbase.com>

[Backport] MB-12328: Convert the dcp mutation flags field to network order

Change-Id: I9feda82beff4e930e18d6127f538622225b86d8f
Reviewed-on: http://review.couchbase.org/42373
Reviewe

[Backport] MB-12328: Convert the dcp mutation flags field to network order

Change-Id: I9feda82beff4e930e18d6127f538622225b86d8f
Reviewed-on: http://review.couchbase.org/42373
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

Revision tags: v3.0.0-beta3, v3.0.0
6410c8f707-Aug-2014 jim <jim@couchbase.com>

[MB-11203] SSL-enabled memcached will hang...

A large pipeline input lead to memcached effectively
performing a under-read of the input buffer. This occured
when memcached moved to

[MB-11203] SSL-enabled memcached will hang...

A large pipeline input lead to memcached effectively
performing a under-read of the input buffer. This occured
when memcached moved to conn_waiting as part of yield, we
only check rbuf for data when a SSL_peek is needed for SSL
connections.

Also on the drain_recv code we could get into a situation
where we'd read everything off the network but didn't quite
handle the SSL_read -1 error correctly. Again we could end up
yielding and never wake up again because there's no more data
on the network, yet there's data in our intermediate ssl read
buffer.

testapp changes are required because this defect occured when
a large single sendto occurs. The old SSL code in testapp
used openssl methods to send/recv, which actually chunked up
large pipelines using smaller writes, hiding the bug because
we kept stimulating memcached.

New code allows testapp to take full control of sends using
whatever chunking scheme we wish.

Also removed some time tests which weren't needed and were
causing some occasional failures because they were a little
intolerant.

Change-Id: Ie2a3374fc32ad57a122040ad359e3148d6bdeffd
Reviewed-on: http://review.couchbase.org/40417
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

7fb8cafb08-Aug-2014 Chiyoung Seo <chiyoung.seo@gmail.com>

Check if the send buffer is full or not for an DCP mutation.

Change-Id: I4401cda9b16ced3278f505169ed1f4658e18dcfa
Reviewed-on: http://review.couchbase.org/40397
Reviewed-by: Chiyoung

Check if the send buffer is full or not for an DCP mutation.

Change-Id: I4401cda9b16ced3278f505169ed1f4658e18dcfa
Reviewed-on: http://review.couchbase.org/40397
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

01347b5901-Aug-2014 jim <jim@couchbase.com>

[MB-11548] Perform a less strict check on the current time

Perform a less strict check on the current time as we may see
59/61 seconds which isn't neccesarily a clock change.

Al

[MB-11548] Perform a less strict check on the current time

Perform a less strict check on the current time as we may see
59/61 seconds which isn't neccesarily a clock change.

Also update warning message to show the difference in time.

Change-Id: I524640de83de0159733d2813d55fec523b774e65
Reviewed-on: http://review.couchbase.org/40172
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Revision tags: v3.0.0-beta2
d6f3b95c29-Jul-2014 Dave Rigby <daver@couchbase.com>

jemalloc: Ensure stats are up-to-date

jemalloc can cache it's statistics. Add a call to mallctl("epoch")
when fetching allocator stats to ensure that we have up-to-date stats
values.

jemalloc: Ensure stats are up-to-date

jemalloc can cache it's statistics. Add a call to mallctl("epoch")
when fetching allocator stats to ensure that we have up-to-date stats
values.

Change-Id: Ie466e193e442a8b9dbb75367c3cc44e4cdbef90f
Reviewed-on: http://review.couchbase.org/39996
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

e73832dc22-Jul-2014 jim <jim@couchbase.com>

[MB-11548] Memcached does not handle going back in time.

1) Update testapp so that we can expose the bug.

The idea here is to move us to using a platform method that abstracts getti

[MB-11548] Memcached does not handle going back in time.

1) Update testapp so that we can expose the bug.

The idea here is to move us to using a platform method that abstracts gettimeofday.
With that in place we can apply time shifts in a programmatic fashion using the
memcached protocol extension framework.

Testapp uses testapp_extension.so to send time offset values into memcached and
cause a jump in time.

2) Add mc_time module and move memcached.c methods + add bug fix.
- This module provides the legacy API but
a) current_time is now monotonic and immune to system clock changes
b) allow correct absolute system time calculations without the I/O path needing
a system call. This works alongside real system clock changes.
c) validate that existing expiry tests and new expiry tests are now operational.

3) Remove any gettimeofday reference from memcached so that we use the new platform method.

4) As part of final testing, some system tests were performed where I manually
changed the real system clock using "sudo date" commands.

Change-Id: I2048c536f344050191feeed16635196f44b70b37
Reviewed-on: http://review.couchbase.org/39813
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

12c58e5215-Jul-2014 Dave Rigby <daver@couchbase.com>

MB-11735: mem allocator: Report both mapped and unmapped free bytes

From the tcmalloc documentation [1] we see that tcmalloc free memory
is sub-divided into two statistics:

* tc

MB-11735: mem allocator: Report both mapped and unmapped free bytes

From the tcmalloc documentation [1] we see that tcmalloc free memory
is sub-divided into two statistics:

* tcmalloc.pageheap_free_bytes: Number of bytes in free, mapped pages in page heap.
* tcmalloc.pageheap_unmapped_bytes: Number of bytes in free, unmapped pages in page heap.

However at present we only include `pageheap_free_bytes` in the free
calculation.

Rename "total_free_bytes" to "total_free_mapped_bytes", and
"tcmalloc_unmapped_bytes" to "total_free_unmapped_bytes".

Update the calculations of total_fragmentation_bytes to account for
unmapped_bytes.

Change-Id: I3364b732175da25fa9f45490cc4af81e3812836a
Reviewed-on: http://review.couchbase.org/39416
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

ca4ab0ea23-Jul-2014 Trond Norbye <trond.norbye@gmail.com>

Log more information with sasl errors

Change-Id: I9c278ea2005c9c9535e9485c23340ef75bdfb0df
Reviewed-on: http://review.couchbase.org/39738
Reviewed-by: Daniel Owen <owend@couchbase.co

Log more information with sasl errors

Change-Id: I9c278ea2005c9c9535e9485c23340ef75bdfb0df
Reviewed-on: http://review.couchbase.org/39738
Reviewed-by: Daniel Owen <owend@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Revision tags: v3.0.0-beta1
85ad3ec720-Jun-2014 Dave Rigby <daver@couchbase.com>

MB-11326: Not possible to enter dcp_stream_req_executor() with ENGINE_ROLLBACK

Change-Id: I68464071fd6d19d9f06ce0194b61346174dee032
Reviewed-on: http://review.couchbase.org/38560
Tes

MB-11326: Not possible to enter dcp_stream_req_executor() with ENGINE_ROLLBACK

Change-Id: I68464071fd6d19d9f06ce0194b61346174dee032
Reviewed-on: http://review.couchbase.org/38560
Tested-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

f181819823-Jul-2014 Trond Norbye <trond.norbye@gmail.com>

Refactor: rename UPR to DCP

Change-Id: Idc9f5c4561fbf5bf011ca1dbed5ad00a64c67fa0
Reviewed-on: http://review.couchbase.org/39747
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

Refactor: rename UPR to DCP

Change-Id: Idc9f5c4561fbf5bf011ca1dbed5ad00a64c67fa0
Reviewed-on: http://review.couchbase.org/39747
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

f51fc50103-Jul-2014 Dave Rigby <daver@couchbase.com>

Add jemalloc support for cbstats memory/allocator

Allow the 'memory/allocator' statistic groups to output useful
information when jemalloc is the selected allocator.

Example out

Add jemalloc support for cbstats memory/allocator

Allow the 'memory/allocator' statistic groups to output useful
information when jemalloc is the selected allocator.

Example output (for `cbstats allocator`):

___ Begin jemalloc statistics ___
Version: 3.6.0-0-g46c0af68bd248b04df75e4f92d5fb804c3d75340
Assertions disabled
Run-time option settings:
opt.abort: false
opt.lg_chunk: 22
opt.dss: "secondary"
opt.narenas: 32
opt.lg_dirty_mult: 3
opt.stats_print: false
opt.junk: false
opt.quarantine: 0
opt.redzone: false
opt.zero: false
opt.tcache: true
opt.lg_tcache_max: 15
CPUs: 8
Arenas: 32
Pointer size: 8
Quantum size: 16
Page size: 4096
Min active:dirty page ratio per arena: 8:1
Maximum thread-cached size class: 32768
Chunk size: 4194304 (2^22)
Allocated: 399542368, active: 405270528, mapped: 457179136
Current active ceiling: 742391808
chunks: nchunks highchunks curchunks
109 109 109
huge: nmalloc ndalloc allocated
0 0 0

Merged arenas stats:
assigned threads: 14
dss allocation precedence: N/A
dirty pages: 98943:333 active:dirty, 1555 sweeps, 1601 madvises, 51586 purged
allocated nmalloc ndalloc nrequests
small: 154081376 267133 35769 1616464
large: 245460992 37051 5227 80776
total: 399542368 304184 40996 1697240
active: 405270528
mapped: 452984832
bins: bin size regs pgs allocated nmalloc ndalloc nrequests nfills nflushes newruns reruns curruns
0 8 501 1 4848 1525 919 80208 84 43 16 0 12
1 16 252 1 23104 2021 577 135568 41 45 13 0 13
2 32 126 1 1170112 37342 776 295700 439 41 301 5 297
3 48 84 1 35040 1325 595 48957 183 47 17 1 15
4 64 63 1 210752 4026 733 114187 170 75 60 12 58
5 80 50 1 8051600 101751 1106 116700 2584 94 2031 9 2020
6 96 84 2 247776 19352 16771 273741 516 275 228 29 36
7 112 72 2 563360 6496 1466 213426 200 89 90 8 83
8 128 63 2 49152 1091 707 12010 79 97 19 5 11
9 160 51 2 477120 3837 855 28882 114 79 77 7 64
10 192 63 3 136704 1444 732 15552 76 89 29 10 15
11 224 72 4 767872 4305 877 21426 116 94 67 8 49
12 256 63 4 662528 4048 1460 19599 222 112 71 13 50
13 320 63 5 611520 2828 917 8689 104 81 49 10 33
14 384 63 6 519936 2328 974 9027 76 81 42 11 26
15 448 63 7 1088192 3294 865 6928 96 83 52 6 43
16 512 63 8 896000 2675 925 17913 77 79 40 5 31
17 640 51 8 1668480 3219 612 8215 92 53 62 6 53
18 768 47 9 2200320 3520 655 9114 110 58 75 6 63
19 896 45 10 2272256 3057 521 20491 98 49 65 5 58
20 1024 63 16 2651136 3902 1313 7490 98 62 63 13 43
21 1280 51 16 7720960 6380 348 16044 180 33 124 0 123
22 1536 42 16 7856640 5430 315 15269 219 30 132 1 124
23 1792 38 17 9375744 5263 31 15589 140 3 139 0 139
24 2048 65 33 11214848 5762 286 15100 112 28 90 4 86
25 2560 52 33 26073600 10244 59 30202 197 4 197 0 197
26 3072 43 33 31211520 10470 310 30206 331 24 246 0 238
27 3584 39 35 36320256 10198 64 30231 262 4 261 0 261
large: size pages nmalloc ndalloc nrequests curruns
4096 1 10127 15 20128 10112
8192 2 20630 14 41580 20616
12288 3 66 48 12832 18
16384 4 24 2 24 22
20480 5 6 0 6 6
24576 6 10 8 18 2
28672 7 1024 0 1024 1024
32768 8 21 2 21 19
[3]
49152 12 16 16 16 0
[2]
61440 15 2 0 2 2
65536 16 2 2 2 0
[8]
102400 25 1 0 1 1
[7]
135168 33 5120 5120 5120 0
[478]
2097152 512 2 0 2 2
[506]
--- End jemalloc statistics ---

Change-Id: Ia06dbcc8c511006e376edd56d8330c22f7af0636
Reviewed-on: http://review.couchbase.org/39661
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

b449bca021-Jul-2014 Dave Rigby <daver@couchbase.com>

MB-11772: Add `release_free_memory` ioctl and `mcctl` program to access them

Add two new binary protocol commands:

* PROTOCOL_BINARY_CMD_IOCTL_GET - Retrieve a property from the s

MB-11772: Add `release_free_memory` ioctl and `mcctl` program to access them

Add two new binary protocol commands:

* PROTOCOL_BINARY_CMD_IOCTL_GET - Retrieve a property from the server
* PROTOCOL_BINARY_CMD_IOCTL_SET - Modify a property on the server.

Using these, implement a `set release_free_memory` command which will
request the memory allocator to return to the OS any free memory
inside the process.

To access this new functionality, add a `mcctl` command to set/get CTL
properties. Example usage (and currently only supported
functionality):

./mcctl -h localhost:12000 set release_free_memory

Change-Id: I35c40ff9c41c0f00802ff9db9202865ec146f46c
Reviewed-on: http://review.couchbase.org/39608
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

481bf9cb21-Jul-2014 Mike Wiederhold <mike@couchbase.com>

Fix breakage in build to to invalid rebase

Change-Id: I9381d2c6da70242a0d18d01bfbca401fb2f52bf4
Reviewed-on: http://review.couchbase.org/39641
Reviewed-by: Aliaksey Kandratsenka <alk

Fix breakage in build to to invalid rebase

Change-Id: I9381d2c6da70242a0d18d01bfbca401fb2f52bf4
Reviewed-on: http://review.couchbase.org/39641
Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>

show more ...

deee6a9015-Jul-2014 Mike Wiederhold <mike@couchbase.com>

MB-11721: Add a snapshot marker respnose api to upr_message_producers

We will be sending acks for some snapshot markers and need an api to
put the bytes on the wire.

Change-Id:

MB-11721: Add a snapshot marker respnose api to upr_message_producers

We will be sending acks for some snapshot markers and need an api to
put the bytes on the wire.

Change-Id: Ib0a2d8443fd1fb800319fca9160f38df8661deae
Reviewed-on: http://review.couchbase.org/39378
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

b0ad602130-Jun-2014 Mike Wiederhold <mike@couchbase.com>

Don't respond to a buffer ack unless there is an error

Change-Id: I751d387c3ece85574610dc0b8f4542506b509f89
Reviewed-on: http://review.couchbase.org/38993
Reviewed-by: Trond Norbye <

Don't respond to a buffer ack unless there is an error

Change-Id: I751d387c3ece85574610dc0b8f4542506b509f89
Reviewed-on: http://review.couchbase.org/38993
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

b4a135a202-Jun-2014 Mike Wiederhold <mike@couchbase.com>

MB-11259: Buffer acknowledgment should have extlen of 4

Change-Id: Ic020e7260db1138f607fb5b3e068f9955f3e5c58
Reviewed-on: http://review.couchbase.org/38790
Reviewed-by: Trond Norbye

MB-11259: Buffer acknowledgment should have extlen of 4

Change-Id: Ic020e7260db1138f607fb5b3e068f9955f3e5c58
Reviewed-on: http://review.couchbase.org/38790
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

04ae04db25-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

Initialize control cas to 0xdeadbeef

If its default value is 0 there is no way to change it without
using 0 as the cas value (which means override) introducing
the possibility for ra

Initialize control cas to 0xdeadbeef

If its default value is 0 there is no way to change it without
using 0 as the cas value (which means override) introducing
the possibility for race conditions. With a non-null value it
may be changed by someone who requested its value and protects
against race conditions.

Allow for using cas value 0 to override cas for setting the cas
(to make it behave consistently with the rest of the cas usage)

Change-Id: I637104df4f65527d8ad10636c01a0e7f53930c53
Reviewed-on: http://review.couchbase.org/38784
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

c00c866524-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

MB-10287: Add backwards compatibility for some options

Change-Id: Ib93b5b16fcb491f1a95226e91a236f08b5ce627f
Reviewed-on: http://review.couchbase.org/38763
Reviewed-by: Dave Rigby <da

MB-10287: Add backwards compatibility for some options

Change-Id: Ib93b5b16fcb491f1a95226e91a236f08b5ce627f
Reviewed-on: http://review.couchbase.org/38763
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

7ffd406a23-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

Reset auth_data when called for an invalid connection

Change-Id: Icd9d8b14e51e12348f2702f1ea60bf543a6255d6
Reviewed-on: http://review.couchbase.org/38690
Reviewed-by: Michael Wiederh

Reset auth_data when called for an invalid connection

Change-Id: Icd9d8b14e51e12348f2702f1ea60bf543a6255d6
Reviewed-on: http://review.couchbase.org/38690
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

9eddce5617-Jun-2014 Dave Rigby <daver@couchbase.com>

Correctly NUL-terminate log buffer

Change-Id: If19ef570617f3a841da87f3f08d3fb51a71ece36
Reviewed-on: http://review.couchbase.org/38543
Reviewed-by: Trond Norbye <trond.norbye@gmail.c

Correctly NUL-terminate log buffer

Change-Id: If19ef570617f3a841da87f3f08d3fb51a71ece36
Reviewed-on: http://review.couchbase.org/38543
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

ebcbd79b13-Jun-2014 Trond Norbye <trond.norbye@gmail.com>

Don't mix decl and code (non-c89)

Change-Id: Ibe27e31f31a8fafb1075e9f22e9aefcb8794d318
Reviewed-on: http://review.couchbase.org/38236
Tested-by: Trond Norbye <trond.norbye@gmail.com>

Don't mix decl and code (non-c89)

Change-Id: Ibe27e31f31a8fafb1075e9f22e9aefcb8794d318
Reviewed-on: http://review.couchbase.org/38236
Tested-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

1234567891011