History log of /4.0.0/platform/ (Results 1 - 25 of 93)
Revision (<<< Hide revision tags) (Show revision tags >>>)Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
Revision tags: v6.0.3, v5.5.4, v5.5.0, v4.6.5, v5.0.0, v4.6.0, v4.6.0-DP, v4.5.1-MP1, v4.5.1, v4.5.0, v4.1.0, v3.1.2
a44eb64221-Jul-2015 Dave Rigby <daver@couchbase.com>

MB-15778: Fix JSON_checker leak upon invalid UTF-8

A memory leak has been identified in the checkUTF8JSON function which
is used to determine the datatype field for document
mutation

MB-15778: Fix JSON_checker leak upon invalid UTF-8

A memory leak has been identified in the checkUTF8JSON function which
is used to determine the datatype field for document
mutations. Specifically, the leak occurs when validating UTF8 contents
of a JSON document. If an invalid UTF8 escape sequence is encountered
then we correctly mark the document as "binary" (non-JSON), however we
leak 52 bytes.

This is due to an error in the JSON_checker cleanup code - it will
free that memory if the actual JSON structure was invalid, but not if
it only encountered a bad UTF-8 value.

In general any document which:
1. Contains a byte of '"' (i.e. ASCII 0x22)
2. Followed (not necessary immediately) by 0xf8...0xff
3. And hasn't already failed JSON validation

could trigger this issue.

Change-Id: I53b7ca1ddd0ccc6f5e160733655cab29723b15cd
Reviewed-on: http://review.couchbase.org/53485
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

d75118b803-Jun-2015 Trond Norbye <trond.norbye@gmail.com>

Fix buildbreak on suse due to missing pthread symbol

Change-Id: I5ef4daff1da3d9fb71e91c9d4e9802c8cd50c524
Reviewed-on: http://review.couchbase.org/51711
Tested-by: buildbot <build@co

Fix buildbreak on suse due to missing pthread symbol

Change-Id: I5ef4daff1da3d9fb71e91c9d4e9802c8cd50c524
Reviewed-on: http://review.couchbase.org/51711
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

0d1de5db02-Jun-2015 Dave Rigby <daver@couchbase.com>

Add ability to set thread names

Add a new function cb_set_thread_name() which as the name suggests
allows the name of a thread to be set. Additionally, create a
variation of the exis

Add ability to set thread names

Add a new function cb_set_thread_name() which as the name suggests
allows the name of a thread to be set. Additionally, create a
variation of the existing cb_create_thread() function named
cb_create_named_thread() which allows a thread name to be specified
for the newly created thread.

Such thread names are exposed back to the OS, for example via top:

PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
15976 couchbas 20 0 150m 14m 6148 T 0 0.4 0:00.01 mc:listener
15977 couchbas 20 0 150m 14m 6148 T 0 0.4 0:00.00 mc:auditd
15978 couchbas 20 0 150m 14m 6148 T 0 0.4 0:00.04 ewb:pending Q
15979 couchbas 20 0 150m 14m 6148 T 0 0.4 0:00.01 mc:worker 0
15980 couchbas 20 0 150m 14m 6148 T 0 0.4 0:00.01 mc:worker 1
15981 couchbas 20 0 150m 14m 6148 T 0 0.4 0:00.01 mc:worker 2
15982 couchbas 20 0 150m 14m 6148 T 0 0.4 0:00.01 mc:worker 3
15983 couchbas 20 0 150m 14m 6148 T 0 0.4 0:00.01 mc:worker 4
15984 couchbas 20 0 150m 14m 6148 T 0 0.4 0:00.01 mc:worker 5
15985 couchbas 20 0 150m 14m 6148 T 0 0.4 0:00.00 mc:worker 6
15986 couchbas 20 0 150m 14m 6148 T 0 0.4 0:00.00 mc:parent mon

Change-Id: I7590c499aa25a7c203325a518ce5d95794dbd929
Reviewed-on: http://review.couchbase.org/51691
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

94d5661902-Jun-2015 Trond Norbye <trond.norbye@gmail.com>

Extend the assert to print the stack

Change-Id: I7cb64b488b0a8dcc2aa002f718a5def1502a99f3
Reviewed-on: http://review.couchbase.org/51686
Reviewed-by: Dave Rigby <daver@couchbase.com>

Extend the assert to print the stack

Change-Id: I7cb64b488b0a8dcc2aa002f718a5def1502a99f3
Reviewed-on: http://review.couchbase.org/51686
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

290c4c8802-Jun-2015 Dave Rigby <daver@couchbase.com>

Fix 'redundant redeclaration' warning due to missing include guard

Change-Id: Ifa8273d9e95ec4d16e52fec64db2d3ebd50e4e4b
Reviewed-on: http://review.couchbase.org/51690
Tested-by: buil

Fix 'redundant redeclaration' warning due to missing include guard

Change-Id: Ifa8273d9e95ec4d16e52fec64db2d3ebd50e4e4b
Reviewed-on: http://review.couchbase.org/51690
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

081d4eec18-Mar-2015 Patrick Varley <patrick@couchbase.com>

MB-14008: spell assertion correctly

Change-Id: Id6ae9fa77f14c85c62787b6cabefdd1674316b60
Reviewed-on: http://review.couchbase.org/48481
Reviewed-by: Trond Norbye <trond.norbye@gmail.

MB-14008: spell assertion correctly

Change-Id: Id6ae9fa77f14c85c62787b6cabefdd1674316b60
Reviewed-on: http://review.couchbase.org/48481
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

f46a036a12-Mar-2015 Trond Norbye <trond.norbye@gmail.com>

MB-13869: Add mkdirp() to create directories

Change-Id: I0f1d4b8ec635bb34ccc93420da3ecd81430d7f30
Reviewed-on: http://review.couchbase.org/48148
Tested-by: buildbot <build@couchbase.

MB-13869: Add mkdirp() to create directories

Change-Id: I0f1d4b8ec635bb34ccc93420da3ecd81430d7f30
Reviewed-on: http://review.couchbase.org/48148
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Daniel Owen <owend@couchbase.com>

show more ...

Revision tags: v3.0.3
62775b0b17-Feb-2015 Dave Rigby <daver@couchbase.com>

MB-13418: Ship DbgHelp.dll with platform

As per Microsoft's documentation[1], ship Dbghelp.dll along with
platform.dll - quoting from the above link:

The size of the IMAGEHL

MB-13418: Ship DbgHelp.dll with platform

As per Microsoft's documentation[1], ship Dbghelp.dll along with
platform.dll - quoting from the above link:

The size of the IMAGEHLP_MODULE64 structure used by this function
has changed over the years. If a version of DbgHelp.dll is called
that is older than the DbgHelp.h used to compile the calling code,
then this function may fail with an error code of
ERROR_INVALID_PARAMETER.
...
The recommended model is to redistribute the required version of
DbgHelp.dll along with the calling software...

[1]: https://msdn.microsoft.com/en-us/library/windows/desktop/ms681336(v=vs.85).aspx

Change-Id: Iefae029e7da5960596bb4dea42d205bdc401cdf4
Reviewed-on: http://review.couchbase.org/46975
Reviewed-by: Chris Hillery <ceej@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

bcdf402624-Feb-2015 Dave Rigby <daver@couchbase.com>

MB-13604: Fix warnings when building on Win32

Change-Id: I6117f350eb5a639c280510d13fd27998dbc089ea
Reviewed-on: http://review.couchbase.org/47289
Reviewed-by: Trond Norbye <trond.nor

MB-13604: Fix warnings when building on Win32

Change-Id: I6117f350eb5a639c280510d13fd27998dbc089ea
Reviewed-on: http://review.couchbase.org/47289
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

42c8d8bb17-Feb-2015 Trond Norbye <trond.norbye@gmail.com>

MB-13417: Remove compiler warning in backtrace_test

Change-Id: Iaeb157d63ff9497a72435859c55dd7aa2e5917a1
Reviewed-on: http://review.couchbase.org/46966
Reviewed-by: Dave Rigby <daver

MB-13417: Remove compiler warning in backtrace_test

Change-Id: Iaeb157d63ff9497a72435859c55dd7aa2e5917a1
Reviewed-on: http://review.couchbase.org/46966
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

a70b1bd816-Feb-2015 Dave Rigby <daver@couchbase.com>

MB-13466: Fix getopt unit test failure on Windows

Windows doesn't have getopt(), and so we have our own implementation. Fix
a bug in this where we initialize `optind` incorrectly.

MB-13466: Fix getopt unit test failure on Windows

Windows doesn't have getopt(), and so we have our own implementation. Fix
a bug in this where we initialize `optind` incorrectly.

Change-Id: Ic143dab478d0d1d4e7bd2f2cd3c8c1670620d46a
Reviewed-on: http://review.couchbase.org/46877
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

4d17a68e12-Feb-2015 Dave Rigby <daver@couchbase.com>

MB-13417: Add print_backtrace() function

Adds a new utility function print_backtrace() to platform. This allows
a textual description of the calling threads' backtrace to be printed.

MB-13417: Add print_backtrace() function

Adds a new utility function print_backtrace() to platform. This allows
a textual description of the calling threads' backtrace to be printed.

Example output:

c:\compile\couchbase\build\platform\platform-backtrace-test.exe(leaf+24) [0x000000013F9D1048]
c:\compile\couchbase\build\platform\platform-backtrace-test.exe(middle+9) [0x000000013F9D10D9]
c:\compile\couchbase\build\platform\platform-backtrace-test.exe(outer+9) [0x000000013F9D1109]
c:\compile\couchbase\build\platform\platform-backtrace-test.exe(main+9) [0x000000013F9D1079]
c:\compile\couchbase\build\platform\platform-backtrace-test.exe(__tmainCRTStartup+271) [0x000000013F9D14B7]
C:\Windows\system32\kernel32.dll(BaseThreadInitThunk+13) [0x0000000076D359ED]
C:\Windows\SYSTEM32\ntdll.dll(RtlUserThreadStart+33) [0x0000000076F6C541]

Change-Id: I99f9b091db140d0ac04256aa0df398d187e10ab3
Reviewed-on: http://review.couchbase.org/46730
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Mark Woosey <mark.woosey@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

c0012dd102-Feb-2015 Trond Norbye <trond.norbye@gmail.com>

MB-13269: Add missing checks for return values

Reported by source analysis in Visual Studio 2013

Change-Id: I8e4451581eaa9bbc2ce2c96e48a934ca83e485c1
Reviewed-on: http://review.

MB-13269: Add missing checks for return values

Reported by source analysis in Visual Studio 2013

Change-Id: I8e4451581eaa9bbc2ce2c96e48a934ca83e485c1
Reviewed-on: http://review.couchbase.org/46234
Reviewed-by: Adam Taylor <adamt@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

cb9ab79302-Feb-2015 Trond Norbye <trond.norbye@gmail.com>

Revert "MB-13259: Globally set CMP0042 policy"

This reverts commit 8a5ffbe05a3e79a0a6bf781f66995b665f1bdbea.

Change-Id: I39c67eed65335e1910b14e3482ebfb26a462f6be
Reviewed-on: ht

Revert "MB-13259: Globally set CMP0042 policy"

This reverts commit 8a5ffbe05a3e79a0a6bf781f66995b665f1bdbea.

Change-Id: I39c67eed65335e1910b14e3482ebfb26a462f6be
Reviewed-on: http://review.couchbase.org/46241
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

8a5ffbe002-Feb-2015 Trond Norbye <trond.norbye@gmail.com>

MB-13259: Globally set CMP0042 policy

Change-Id: I8670c7b3861b8d109e213de0bcee6419aba56ad4
Reviewed-on: http://review.couchbase.org/46210
Reviewed-by: Trond Norbye <trond.norbye@gmai

MB-13259: Globally set CMP0042 policy

Change-Id: I8670c7b3861b8d109e213de0bcee6419aba56ad4
Reviewed-on: http://review.couchbase.org/46210
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

877ba0c514-Jan-2015 Trond Norbye <trond.norbye@gmail.com>

Added isDirectory

A function to verify if a given path is a directory

Change-Id: I6037e3e7f92160387ca6b9b6653a8a3a3d18af4b
Reviewed-on: http://review.couchbase.org/45307
Rev

Added isDirectory

A function to verify if a given path is a directory

Change-Id: I6037e3e7f92160387ca6b9b6653a8a3a3d18af4b
Reviewed-on: http://review.couchbase.org/45307
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

5f3357af09-Jan-2015 Trond Norbye <trond.norbye@gmail.com>

Don't define min() and max() as macros for win32

Change-Id: I86bd95f7f45f15ea7fc8fe6b7064d8c4b6c7e810
Reviewed-on: http://review.couchbase.org/45138
Reviewed-by: Trond Norbye <trond.

Don't define min() and max() as macros for win32

Change-Id: I86bd95f7f45f15ea7fc8fe6b7064d8c4b6c7e810
Reviewed-on: http://review.couchbase.org/45138
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

a8eb6c4e06-Jan-2015 Trond Norbye <trond.norbye@gmail.com>

Drop pre MSVC 2013 code

We require MSVC 2013 to build on windows.

Change-Id: I8f7e3c104ba1b65231cda58c65099b4a76c98f1a
Reviewed-on: http://review.couchbase.org/44990
Tested-

Drop pre MSVC 2013 code

We require MSVC 2013 to build on windows.

Change-Id: I8f7e3c104ba1b65231cda58c65099b4a76c98f1a
Reviewed-on: http://review.couchbase.org/44990
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

98b1ab4a06-Jan-2015 Trond Norbye <trond.norbye@gmail.com>

Add directory separator

Change-Id: Ibf620db27755c7bbd36fa4568667436040b6f531
Reviewed-on: http://review.couchbase.org/44956
Tested-by: buildbot <build@couchbase.com>
Reviewed-by:

Add directory separator

Change-Id: Ibf620db27755c7bbd36fa4568667436040b6f531
Reviewed-on: http://review.couchbase.org/44956
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

33df39e702-Jan-2015 Dave Rigby <daver@couchbase.com>

MB-13024: Add gethrtime_period()

To allow us to query the period of the clock used for gethrtime(), add
a new function gethrtime_period which returns the period in
nanoseconds of the

MB-13024: Add gethrtime_period()

To allow us to query the period of the clock used for gethrtime(), add
a new function gethrtime_period which returns the period in
nanoseconds of the clock used by gethrtime().

Change-Id: I8075b52326acd7d73fddaca8bfa80834c9ab7f67
Reviewed-on: http://review.couchbase.org/44839
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

9bcd6af306-Dec-2014 Trond Norbye <trond.norbye@gmail.com>

Drop platform specific versions of gethrtime()

Use the implementation from C++ unless the platform supports
a native one.

Change-Id: I480bbd8953ce6f3cfe27e9e0f4b8c9f6b30385ff

Drop platform specific versions of gethrtime()

Use the implementation from C++ unless the platform supports
a native one.

Change-Id: I480bbd8953ce6f3cfe27e9e0f4b8c9f6b30385ff
Reviewed-on: http://review.couchbase.org/44078
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

f5e5fef819-Nov-2014 Trond Norbye <trond.norbye@gmail.com>

Start using @rpath for MacOSX correctly

Introduced in CMake 3 there is a new policy for dealing with
rpath.

Change-Id: I2ddd1c79ce81a7f19d4b49d87fb855b52f1af545
Reviewed-on:

Start using @rpath for MacOSX correctly

Introduced in CMake 3 there is a new policy for dealing with
rpath.

Change-Id: I2ddd1c79ce81a7f19d4b49d87fb855b52f1af545
Reviewed-on: http://review.couchbase.org/43396
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

3a9ee9e919-Nov-2014 Trond Norbye <trond.norbye@gmail.com>

Set the properties on the correct target (JSON_checker)

Change-Id: I22944d303797a66ef7118773bb32b1be42743bee
Reviewed-on: http://review.couchbase.org/43394
Reviewed-by: Dave Rigby <d

Set the properties on the correct target (JSON_checker)

Change-Id: I22944d303797a66ef7118773bb32b1be42743bee
Reviewed-on: http://review.couchbase.org/43394
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

c41f016818-Nov-2014 Trond Norbye <trond.norbye@gmail.com>

Drop unused non-working target

Change-Id: I26ce981ed3538f35453172d0e4399f42bb965fb5
Reviewed-on: http://review.couchbase.org/43358
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

Drop unused non-working target

Change-Id: I26ce981ed3538f35453172d0e4399f42bb965fb5
Reviewed-on: http://review.couchbase.org/43358
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Revision tags: v3.1.6
71e44c4618-Nov-2014 Trond Norbye <trond.norbye@gmail.com>

Add cb_gmtime_r and cb_localtime_r

gmtime_r and localtime_r is POSIX functions and Windows
have their own "secure" versions with _s suffix, but the
arguments are flipped and and the

Add cb_gmtime_r and cb_localtime_r

gmtime_r and localtime_r is POSIX functions and Windows
have their own "secure" versions with _s suffix, but the
arguments are flipped and and the return value inversed.

Change-Id: Ia0b3c34f267f8ad4a603342a0a376af8a20ad9af
Reviewed-on: http://review.couchbase.org/43349
Reviewed-by: Daniel Owen <owend@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

1234