History log of /4.5.1-MP3/couchstore/ (Results 1 - 25 of 619)
Revision (<<< Hide revision tags) (Show revision tags >>>)Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
Revision tags: v6.0.3, v5.5.3, v5.1.2, v5.1.0, v5.0.0, v4.6.0, v4.6.0-DP, v4.5.1-MP1
13d4a25118-Aug-2016 Dave Rigby <daver@couchbase.com>

MB-20769: Convert to cb_malloc memory allocation API

Replace:

* malloc -> cb_malloc
* calloc -> cb_calloc
* realloc -> cb_realloc
* free -> cb_free
* strdup -> cb_st

MB-20769: Convert to cb_malloc memory allocation API

Replace:

* malloc -> cb_malloc
* calloc -> cb_calloc
* realloc -> cb_realloc
* free -> cb_free
* strdup -> cb_strdup

Change-Id: Ia9edb231ebad30655489bec1052e4d41eea33a32
Reviewed-on: http://review.couchbase.org/67306
Well-Formed: buildbot <build@couchbase.com>
Reviewed-by: Daniel Owen <owend@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>

show more ...

Revision tags: v4.5.0, v4.5.1
bce1f23415-Feb-2016 Will Gardner <will.gardner@couchbase.com>

[BP] MB-20224: gtest macro changes

backport of 1e523270 (no MB on previous commit).

Improve doctest parameterised test name

Adds a test name generator for the CouchstoreDoc

[BP] MB-20224: gtest macro changes

backport of 1e523270 (no MB on previous commit).

Improve doctest parameterised test name

Adds a test name generator for the CouchstoreDocTest parameterised
testing. Also silences warnings introduced by the warning being
added to Google Test.

Change-Id: Iae14415c549c165a550d79b39df1619e1cac9f9a
Reviewed-on: http://review.couchbase.org/66217
Well-Formed: buildbot <build@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Will Gardner <will.gardner@couchbase.com>

show more ...

452a77c316-May-2016 Trond Norbye <trond.norbye@gmail.com>

MB-19605: Fix memory leak upon failure

Change-Id: Ia19559c76cad77c0944e65a33ad7fd95b7071e10
Reviewed-on: http://review.couchbase.org/64071
Reviewed-by: Will Gardner <will.gardner@cou

MB-19605: Fix memory leak upon failure

Change-Id: Ia19559c76cad77c0944e65a33ad7fd95b7071e10
Reviewed-on: http://review.couchbase.org/64071
Reviewed-by: Will Gardner <will.gardner@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

139918f912-May-2016 Trond Norbye <trond.norbye@gmail.com>

MB-19605: Check return value from snprintf

snprintf does not return -1 if the buffer is too small which
could result in buffer overflows.

Change-Id: I2f9c93d2cf10b1583fff3c6c35b

MB-19605: Check return value from snprintf

snprintf does not return -1 if the buffer is too small which
could result in buffer overflows.

Change-Id: I2f9c93d2cf10b1583fff3c6c35b78cfc9c342485
Reviewed-on: http://review.couchbase.org/63969
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

90a44a2323-Mar-2016 Will Gardner <will.gardner@couchbase.com>

MB-18855 Stop transforming error codes when inappropriate

In a few instances couchstore will override the error received
from the underlying fileops and turn it into a fixed error type.

MB-18855 Stop transforming error codes when inappropriate

In a few instances couchstore will override the error received
from the underlying fileops and turn it into a fixed error type.

This can be misleading as sometimes an underlying file system
write can be performed by the iobuffering when reading.

Change-Id: I51cbcc1f4ed39e710d28e61c5b241114d2396b25
Reviewed-on: http://review.couchbase.org/63743
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

d527b48c18-Apr-2016 harsha <hhs.couchbase@gmail.com>

[BP] Use C++11 primitives for thread creation and synchronization

We are mixing older Windows API CreateThread with C++
primitives for synchronization. This resulted in
failures in c

[BP] Use C++11 primitives for thread creation and synchronization

We are mixing older Windows API CreateThread with C++
primitives for synchronization. This resulted in
failures in couchdb due to improper exit of index_builder
thread. Correct way is to use either Windows API for
creation and synchronization or C++11 primitives and not
intermix them.

Change-Id: I975e96a617e13dabe559a1b02354857bddeaf53e
Reviewed-on: http://review.couchbase.org/63745
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

185ec8ff04-Apr-2016 harsha <hhs.couchbase@gmail.com>

[BP] MB-19031 Handle race in updating terminator timeout

Change-Id: Id9908e758a443bfe4c0c6b5a379f3dfe3ec159f5
Reviewed-on: http://review.couchbase.org/63744
Reviewed-by: Harsha H S <

[BP] MB-19031 Handle race in updating terminator timeout

Change-Id: Id9908e758a443bfe4c0c6b5a379f3dfe3ec159f5
Reviewed-on: http://review.couchbase.org/63744
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

9e90a38824-Mar-2016 Will Gardner <will.gardner@couchbase.com>

Destroy lua state before exiting couchscript

couchscript currently exits without destroying the lua
state which means both the lua state and any objects
within it that have not been

Destroy lua state before exiting couchscript

couchscript currently exits without destroying the lua
state which means both the lua state and any objects
within it that have not been garbage collected are
technically leaked and caught by valgrind. This change
ensures that the lua state is destroyed before exiting.

Change-Id: I795d439dccb171899463d0d1122865be8ec1f1f0
Reviewed-on: http://review.couchbase.org/61928
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

236dd13024-Mar-2016 Will Gardner <will.gardner@couchbase.com>

Return a non-zero exit code if a Lua test fails

Currently the lua tests do nothing if they fail. This change ensures
that they will trigger a test failure in ctest if they actually fail.

Return a non-zero exit code if a Lua test fails

Currently the lua tests do nothing if they fail. This change ensures
that they will trigger a test failure in ctest if they actually fail.

Change-Id: If658e562ca0dc5364859dce277cf9e380545699d
Reviewed-on: http://review.couchbase.org/61923
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

27f8df1921-Mar-2016 Will Gardner <will.gardner@couchbase.com>

Free db handle in couchscript when object is GC'd

Lua was just enabled on the commit validation and
couchstore gets flagged up for memory leaks. This frees
up database handles when t

Free db handle in couchscript when object is GC'd

Lua was just enabled on the commit validation and
couchstore gets flagged up for memory leaks. This frees
up database handles when the userdata table gets garbage
collected.

Change-Id: I0207dc3b6f38a203cf868c480ff36f802d966120
Reviewed-on: http://review.couchbase.org/61770
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

85bf96b421-Mar-2016 Will Gardner <will.gardner@couchbase.com>

Speed up 'large' lua test

Lua tests have just been enabled on the commit validation slaves
and the 'large' lua test is reasonably slow (~100s without
valgrind). This change speeds it

Speed up 'large' lua test

Lua tests have just been enabled on the commit validation slaves
and the 'large' lua test is reasonably slow (~100s without
valgrind). This change speeds it up by reducing the amount of
random characters is has to generate by a factor of ~20000x.

Change-Id: I8e874b57a78e738302c5776b11d0627d54d9b8ab
Reviewed-on: http://review.couchbase.org/61763
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

b6a0fbbd24-Feb-2016 Will Gardner <will.gardner@couchbase.com>

[BP] MB-18086 MB-18087 Propogate goto_eof errors correctly

Previously goto_eof errors were not being recognised
or on linux, correctly reported. This change ensures
that errors are p

[BP] MB-18086 MB-18087 Propogate goto_eof errors correctly

Previously goto_eof errors were not being recognised
or on linux, correctly reported. This change ensures
that errors are propogated up when goto_eof fails rather
than when a subsequent read fails.

Change-Id: I6ee31454019b6f088b116cdb2961cd83ca42eb36
Reviewed-on: http://review.couchbase.org/60784
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

7032c71224-Feb-2016 Will Gardner <will.gardner@couchbase.com>

[BP] MB-18319 MB-18320 Propogate errors from db_write_buf properly

db_write_buf was not being used appropriately with respect to
error responses. This patch ensures that any write failur

[BP] MB-18319 MB-18320 Propogate errors from db_write_buf properly

db_write_buf was not being used appropriately with respect to
error responses. This patch ensures that any write failures
are correctly propogated immediately to the calling user.

Change-Id: Icd680adc889303908a6de51867239482c09eb1e2
Reviewed-on: http://review.couchbase.org/60783
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

9e10208601-Mar-2016 Will Gardner <will.gardner@couchbase.com>

[BP] Remove 100x loops in mapreduce tests

The couchstore testapp currently takes a very long time to run
and occasionally times out after 1500s on commit validation.

This change

[BP] Remove 100x loops in mapreduce tests

The couchstore testapp currently takes a very long time to run
and occasionally times out after 1500s on commit validation.

This change removes the code to run all the mapreduce tests 100
times and instead runs them just once.

The loop was previously there to reproduce a V8 crash in the
event that a regression occurred. This should be no longer
necessary as we now run the tests under Valgrind which should
detect race conditions and memory erors.

Change-Id: I8a7dc1285a390726dbee7be23938e5fe9125fc1b
Reviewed-on: http://review.couchbase.org/60717
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
(cherry picked from commit e47111a6949b4b812f939ecce724b183d286de27)
Reviewed-on: http://review.couchbase.org/60866
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>

show more ...

51e3c26716-Mar-2016 Will Gardner <will.gardner@couchbase.com>

MB-18665 Fix leak in couchstore_save_documents error path

If couchstore fails to write the new sequence root after writing
the new id root then couchstore will currently leak both the

MB-18665 Fix leak in couchstore_save_documents error path

If couchstore fails to write the new sequence root after writing
the new id root then couchstore will currently leak both the
in memory id header and the list of sorted ids. This patch
resolves this.

Change-Id: If8c738cdb37f55685726fd091211c08435e71fb1
Reviewed-on: http://review.couchbase.org/61565
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

efb512f416-Mar-2016 Will Gardner <will.gardner@couchbase.com>

Resolve memory leaks in compaction

couch_compact does not currently close the db which results in a
(short-lived) memory leak reported by valgrind.

Additionally if we compact in

Resolve memory leaks in compaction

couch_compact does not currently close the db which results in a
(short-lived) memory leak reported by valgrind.

Additionally if we compact into a target file which already
exists then we will load in the id header and seq header from the
target file and overwrite them without freeing them.

Change-Id: I2f8756e37c6f71b7fe59aa32501df6f76eb53ff3
Reviewed-on: http://review.couchbase.org/61564
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

0b948c5516-Mar-2016 Will Gardner <will.gardner@couchbase.com>

Enable code coverage for couchstore

Change-Id: I5d15d9486f3bc0a455b8f700e4c918edf412f395
Reviewed-on: http://review.couchbase.org/61586
Reviewed-by: Dave Rigby <daver@couchbase.com>

Enable code coverage for couchstore

Change-Id: I5d15d9486f3bc0a455b8f700e4c918edf412f395
Reviewed-on: http://review.couchbase.org/61586
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

128e895c14-Dec-2015 harsha <hhs.couchbase@gmail.com>

MB-17043 Upgrade V8 to version 4.8

V8 APIs have changed from earlier version of 3.23 to current
version of 4.8, current stable v8 version used in Chrome.
Corresponding API changes ar

MB-17043 Upgrade V8 to version 4.8

V8 APIs have changed from earlier version of 3.23 to current
version of 4.8, current stable v8 version used in Chrome.
Corresponding API changes are incorporated in this fix.

Change-Id: I9942225d70d8d5b8dac1bde2429d995b8a4d7dc2
Reviewed-on: http://review.couchbase.org/57777
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: Volker Mische <volker.mische@gmail.com>

show more ...

1daef43203-Feb-2016 Will Gardner <will.gardner@couchbase.com>

MB-10280 Align position when extending file for commit

Currently extending the file doesn't achieve very much and leaves
stray 1-byte chunks around the file. This change aligns the file

MB-10280 Align position when extending file for commit

Currently extending the file doesn't achieve very much and leaves
stray 1-byte chunks around the file. This change aligns the file
extension to the next block so when the header's written it doesn't
extend the file again.

Change-Id: Ib6e168abe1cad12a352d4f29f6d2fac4d4924e61
Reviewed-on: http://review.couchbase.org/59458
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

6a82e74802-Feb-2016 Will Gardner <will.gardner@couchbase.com>

Refactor couchstore_commit to make commit testable

This commit splits commit into two phases

- Precommit: Extends the file to be large enough for
the header and performs a sync.

Refactor couchstore_commit to make commit testable

This commit splits commit into two phases

- Precommit: Extends the file to be large enough for
the header and performs a sync. This is to write the
data before the header and to avoid doing a second
metdata flush
- Commit: Actually writes the header which points
to the written data.

This is done to make it possible to test that the
precommit has written the file to be large enough
to include the header.

Change-Id: I9d9f9540544bfc08d1f99240149aee3bc8f28262
Reviewed-on: http://review.couchbase.org/59388
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

6ae2e01120-Jan-2016 Volker Mische <vmx@couchbase.com>

MB-17420: Fix stderr on Windows

Set the stderr to binary mode and don't buffer it.

In text mode printed line feeds (`\n`) are automatically prefixed with
carriage returns (`\r')

MB-17420: Fix stderr on Windows

Set the stderr to binary mode and don't buffer it.

In text mode printed line feeds (`\n`) are automatically prefixed with
carriage returns (`\r'), this leads to error messages containing a
carriage return at the end.

The buffering may lead to error messages not being received on the
Erlang side.

Change-Id: I702051f5baa3b7e10b645477d53bc6abf914e1b5
Reviewed-on: http://review.couchbase.org/58846
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

2110dd8512-Jan-2016 Volker Mische <vmx@couchbase.com>

Fixing memory leaks found by the Clang AddressSanitizer

Couchstore was compiled via:

make EXTRA_CMAKE_OPTIONS='-D CMAKE_C_FLAGS=-fsanitize=address -D CMAKE_CXX_FLAGS=-fsanitize=

Fixing memory leaks found by the Clang AddressSanitizer

Couchstore was compiled via:

make EXTRA_CMAKE_OPTIONS='-D CMAKE_C_FLAGS=-fsanitize=address -D CMAKE_CXX_FLAGS=-fsanitize=address -D CC=clang -D CXX=clang++'

And the analysis was run via:

ASAN_SYMBOLIZER_PATH=llvm-symbolizer-3.8 ./couchstore_testapp

Change-Id: I19fee52229ee5f9993233ecc11f376b20eba2656
Reviewed-on: http://review.couchbase.org/58515
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

54061de107-Jan-2016 Volker Mische <vmx@couchbase.com>

MB-17154: Fixing memory leaks in file sorter

This patch fixes memory leaks that were found with static analysis
by the Clang Analyzer `scan-build`.

Change-Id: I9819790ae6a0afc9b

MB-17154: Fixing memory leaks in file sorter

This patch fixes memory leaks that were found with static analysis
by the Clang Analyzer `scan-build`.

Change-Id: I9819790ae6a0afc9b836e181e6da5484064c99a6
Reviewed-on: http://review.couchbase.org/58010
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>

show more ...

599c8c2322-Dec-2015 Volker Mische <vmx@couchbase.com>

MB-17154: Improve error message code in view group

The error message code had memory leaks (uncovered by the Clang Analyzer
`scan-build`) and could also be simplified.

Change-Id

MB-17154: Improve error message code in view group

The error message code had memory leaks (uncovered by the Clang Analyzer
`scan-build`) and could also be simplified.

Change-Id: I2b7abd18b35853ab776fab98418a7784a8953d7e
Reviewed-on: http://review.couchbase.org/58051
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>

show more ...

921f72aa22-Dec-2015 Volker Mische <vmx@couchbase.com>

MB-17154: Free records in file merger correctly

There were some memory leaks in the file merger. Those were found by
the Clang Analyzer `scan-build`.

Change-Id: Icd2c5c7ce2ed02b

MB-17154: Free records in file merger correctly

There were some memory leaks in the file merger. Those were found by
the Clang Analyzer `scan-build`.

Change-Id: Icd2c5c7ce2ed02b11313f62c60f5cfa990bd5ced
Reviewed-on: http://review.couchbase.org/58050
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

12345678910>>...25