History log of /4.5.1-MP3/subjson/ (Results 1 - 25 of 153)
Revision (<<< Hide revision tags) (Show revision tags >>>)Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
Revision tags: v5.1.2, v5.0.0, v4.5.0
65d3f05330-Mar-2016 Dave Rigby <daver@couchbase.com>

Remove unused Error::Code enumerations

Change-Id: I124d3fdbc66e06a49c7654a3ff2d59ce303b2fb6
Reviewed-on: http://review.couchbase.org/62155
Tested-by: buildbot <build@couchbase.com>

Remove unused Error::Code enumerations

Change-Id: I124d3fdbc66e06a49c7654a3ff2d59ce303b2fb6
Reviewed-on: http://review.couchbase.org/62155
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Will Gardner <will.gardner@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>
Reviewed-by: Mark Nunberg <mark.nunberg@couchbase.com>

show more ...

4b8ca4d116-Feb-2016 Mark Nunberg <mnunberg@haskalah.org>

MB-18176: Optimize root-only append

This doesn't require a full scan of a potentially lengthy document.

Change-Id: Ida1c3db10df134482e61ba083077f5ab9bc01d10
Reviewed-on: http://

MB-18176: Optimize root-only append

This doesn't require a full scan of a potentially lengthy document.

Change-Id: Ida1c3db10df134482e61ba083077f5ab9bc01d10
Reviewed-on: http://review.couchbase.org/60065
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

3d8f744416-Feb-2016 Mark Nunberg <mnunberg@haskalah.org>

MB-18169: Refactor COUNTER error codes

Change-Id: Iaf0d833507d6f07da35e39bec38febd8c16c7760
Reviewed-on: http://review.couchbase.org/60051
Tested-by: buildbot <build@couchbase.com>

MB-18169: Refactor COUNTER error codes

Change-Id: Iaf0d833507d6f07da35e39bec38febd8c16c7760
Reviewed-on: http://review.couchbase.org/60051
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

f99261c816-Feb-2016 Mark Nunberg <mnunberg@haskalah.org>

Remove error code numeric values

These were initially written to correspond to the actual memcached
protocol (so they wouldn't need to be converted twice), but reality has
since show

Remove error code numeric values

These were initially written to correspond to the actual memcached
protocol (so they wouldn't need to be converted twice), but reality has
since shown things to be different.

Change-Id: I464022e88c235bc502e506a1da0d07a8629b6c78
Reviewed-on: http://review.couchbase.org/60050
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

64dbb0e116-Feb-2016 Mark Nunberg <mnunberg@haskalah.org>

Remove compat C symbols

Memcached (our only consumer thus far) no longer uses them

Change-Id: I22ebf337fb46034b0891493d814f152b7e5512f8
Reviewed-on: http://review.couchbase.org/

Remove compat C symbols

Memcached (our only consumer thus far) no longer uses them

Change-Id: I22ebf337fb46034b0891493d814f152b7e5512f8
Reviewed-on: http://review.couchbase.org/60049
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

2c682b4716-Dec-2015 Mark Nunberg <mnunberg@haskalah.org>

Fix wrong num_siblings calculation

Note that for some reason I can't make a test which fails with the old
code and succeeds with the new one; however I do remember running into
an is

Fix wrong num_siblings calculation

Note that for some reason I can't make a test which fails with the old
code and succeeds with the new one; however I do remember running into
an issue when *copying* the older code for something else.

Change-Id: Idc128797840172aa57cca971b5a17572c8756a66
Reviewed-on: http://review.couchbase.org/58399
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

9f2dfe6a16-Dec-2015 Mark Nunberg <mnunberg@haskalah.org>

Remove 'Match::has_key' field

This value can be implicitly determined by inspecting whether the actual
key is empty

Change-Id: Ia5f05d6d4cc4ea91975e2983fc986a8ebbb96071
Revi

Remove 'Match::has_key' field

This value can be implicitly determined by inspecting whether the actual
key is empty

Change-Id: Ia5f05d6d4cc4ea91975e2983fc986a8ebbb96071
Reviewed-on: http://review.couchbase.org/58398
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

aef8453a14-Dec-2015 Mark Nunberg <mnunberg@haskalah.org>

Refactor hkey/uescape code into common class

This will help us with the 'multi' implementation of things.

Change-Id: I5ded83976f19ffae9c840e87fac1a909279d7071
Reviewed-on: http:

Refactor hkey/uescape code into common class

This will help us with the 'multi' implementation of things.

Change-Id: I5ded83976f19ffae9c840e87fac1a909279d7071
Reviewed-on: http://review.couchbase.org/58396
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

4e1bf09f16-Dec-2015 Mark Nunberg <mnunberg@haskalah.org>

loc: add clear() function

Change-Id: Ic4630999500d541a52d5aea9820e21bc46354ae1
Reviewed-on: http://review.couchbase.org/58397
Tested-by: buildbot <build@couchbase.com>
Reviewed-b

loc: add clear() function

Change-Id: Ic4630999500d541a52d5aea9820e21bc46354ae1
Reviewed-on: http://review.couchbase.org/58397
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

9157758714-Dec-2015 Mark Nunberg <mnunberg@haskalah.org>

MB-17060: Replace assert with std::runtime_error

This replaces assert() calls with SUBDOC_ASSERT ones which in turn
attempt to throw a std::runtime_error with the same context informatio

MB-17060: Replace assert with std::runtime_error

This replaces assert() calls with SUBDOC_ASSERT ones which in turn
attempt to throw a std::runtime_error with the same context information
(as a string) so it 'looks' like an assertion, but can be caught.

Change-Id: Icba3baf767f4465dd64971a6c794488fd8c0e9a9
Reviewed-on: http://review.couchbase.org/57789
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

247edaab11-Dec-2015 Mark Nunberg <mnunberg@haskalah.org>

ignore gtest from contrib

Change-Id: I3194a901c8971b66a7514576d477a5786a60949b
Reviewed-on: http://review.couchbase.org/57785
Reviewed-by: Dave Rigby <daver@couchbase.com>
Review

ignore gtest from contrib

Change-Id: I3194a901c8971b66a7514576d477a5786a60949b
Reviewed-on: http://review.couchbase.org/57785
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Mark Nunberg <mark.nunberg@couchbase.com>
Tested-by: Mark Nunberg <mark.nunberg@couchbase.com>

show more ...

5a685f4414-Dec-2015 Mark Nunberg <mnunberg@haskalah.org>

Use jsonsl_path_match instead of jpr_match

The new function allows for smaller, simpler code in match.cc

I've also started moving away from the `is_arridx` variable in
jpr_compo

Use jsonsl_path_match instead of jpr_match

The new function allows for smaller, simpler code in match.cc

I've also started moving away from the `is_arridx` variable in
jpr_component_st, as this is implied by a `ptype` of JSONSL_PATH_NUMERIC
using the newer path_match semantics.

Change-Id: Iaae694d52d7caec44676007dd79a3d343c64557e
Reviewed-on: http://review.couchbase.org/57788
Well-Formed: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

cfc6467511-Dec-2015 Mark Nunberg <mnunberg@haskalah.org>

match: remove unreachable line

Change-Id: I85920eb5186488a21e4c4e2e1d1d9e861aacd4f6
Reviewed-on: http://review.couchbase.org/57786
Well-Formed: buildbot <build@couchbase.com>
Rev

match: remove unreachable line

Change-Id: I85920eb5186488a21e4c4e2e1d1d9e861aacd4f6
Reviewed-on: http://review.couchbase.org/57786
Well-Formed: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

5cf05eaf14-Dec-2015 Mark Nunberg <mnunberg@haskalah.org>

Update jsonsl

This version contains some additional optimizations in parsing code as
well as a new path_match function (which will be used in the next
commit).

Change-Id: I0

Update jsonsl

This version contains some additional optimizations in parsing code as
well as a new path_match function (which will be used in the next
commit).

Change-Id: I0414e86b4f286ebb276478ef8cb57f8953b73823
Reviewed-on: http://review.couchbase.org/57787
Well-Formed: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Jens Alfke <jens@couchbase.com>
Reviewed-by: Mark Nunberg <mark.nunberg@couchbase.com>
Tested-by: Mark Nunberg <mark.nunberg@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

fbf39f0e08-Dec-2015 Mark Nunberg <mnunberg@haskalah.org>

Add error description for DOC_ETOODEEP

Change-Id: I4df05a5aada0de16c37600c4a7bdc1cdd96341ab
Reviewed-on: http://review.couchbase.org/57591
Tested-by: buildbot <build@couchbase.com>

Add error description for DOC_ETOODEEP

Change-Id: I4df05a5aada0de16c37600c4a7bdc1cdd96341ab
Reviewed-on: http://review.couchbase.org/57591
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

cb6de48412-Nov-2015 Mark Nunberg <mnunberg@haskalah.org>

MB-16790: Disallow upsert with final array index component

This is never allowed, and results in a corrupted document.

Change-Id: I82f49c18be4bf02367e31af98a164253a657cae5
Revie

MB-16790: Disallow upsert with final array index component

This is never allowed, and results in a corrupted document.

Change-Id: I82f49c18be4bf02367e31af98a164253a657cae5
Reviewed-on: http://review.couchbase.org/57005
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

5579467b11-Nov-2015 Mark Nunberg <mnunberg@haskalah.org>

insert should return EINVAL if not passed an index

MISMATCH is reserved for dynamic mismatches against the actual document
contents, while EINVAL is determined without looking at the doc

insert should return EINVAL if not passed an index

MISMATCH is reserved for dynamic mismatches against the actual document
contents, while EINVAL is determined without looking at the document

Change-Id: I6671e86a612c5c0f0cb76752299ba020e66f83ac
Reviewed-on: http://review.couchbase.org/56919
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

23a2b7e503-Nov-2015 Mark Nunberg <mnunberg@haskalah.org>

MB-16695: Use mandatory JSON path escaping

Without path escaping we risk having invalid JSON. Additionally, some
sequences like '"' and '\"' might seem ambiguous (do they mean a literal

MB-16695: Use mandatory JSON path escaping

Without path escaping we risk having invalid JSON. Additionally, some
sequences like '"' and '\"' might seem ambiguous (do they mean a literal
escape-quote or just intend to place the quote). By restricting every
path component to be valid JSON we solve for inadvertently inserting bad
paths up the stack.

This commit also disables support for using \u-XXXX sequences in paths.
Despite them being valid JSON, they need to be normalized before they
are used in the parser. Support for u-escapes in paths will be present
when these escapes are properly normalized into utf8 within the path
parser.

Change-Id: Ia3c3bccf3b6e3006268635656d1c66ab4225a24f
Reviewed-on: http://review.couchbase.org/56617
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

63a6760409-Oct-2015 Mark Nunberg <mnunberg@haskalah.org>

Add test for replacing array index

Change-Id: I57437ac98f3555d53dedd914d217ffdc0dca69a6
Reviewed-on: http://review.couchbase.org/55963
Reviewed-by: Dave Rigby <daver@couchbase.com>

Add test for replacing array index

Change-Id: I57437ac98f3555d53dedd914d217ffdc0dca69a6
Reviewed-on: http://review.couchbase.org/55963
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

6d65d6ae08-Oct-2015 Mark Nunberg <mnunberg@haskalah.org>

Add multi value tests

We currently accept adding a "list" of values (so long as they are all
valid JSON elements and are valid when evaluated within an array
context). As such, we sh

Add multi value tests

We currently accept adding a "list" of values (so long as they are all
valid JSON elements and are valid when evaluated within an array
context). As such, we should test for this "feature" (even if we don't
publicly advertise it yet).

Change-Id: Ia3a32a1b71541030ae1528540b23198ff771eeff
Reviewed-on: http://review.couchbase.org/55930
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Mark Nunberg <mark.nunberg@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

886c2a5708-Oct-2015 Mark Nunberg <mnunberg@haskalah.org>

ADD_UNIQUE: Return error on multivalue and complex values

ADD_UNIQUE inspects its value as a single value using string comparison
with existing array values. More than a single value, or

ADD_UNIQUE: Return error on multivalue and complex values

ADD_UNIQUE inspects its value as a single value using string comparison
with existing array values. More than a single value, or non-primitive
values cannot be properly compared to existing values within the array
and should not be allowed as values.

Change-Id: I0b622be6caac8a1de973fb940e725774a3d09000
Reviewed-on: http://review.couchbase.org/55929
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

cc089f2124-Sep-2015 Mark Nunberg <mnunberg@haskalah.org>

Remove unused subdoc-util.h

This file contained a stub for ntohll which we don't end up actually
using

Change-Id: I368dbec75055fce584bb889614d35b1216b81070
Reviewed-on: http

Remove unused subdoc-util.h

This file contained a stub for ntohll which we don't end up actually
using

Change-Id: I368dbec75055fce584bb889614d35b1216b81070
Reviewed-on: http://review.couchbase.org/55515
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

9f0cd35911-Aug-2015 Mark Nunberg <mnunberg@haskalah.org>

Add constructors for Loc

Change-Id: I4ea8a590e2d5423f3fbafd449a5f8592ea446299
Reviewed-on: http://review.couchbase.org/54352
Tested-by: buildbot <build@couchbase.com>
Reviewed-by

Add constructors for Loc

Change-Id: I4ea8a590e2d5423f3fbafd449a5f8592ea446299
Reviewed-on: http://review.couchbase.org/54352
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

431730af16-Jul-2015 Mark Nunberg <mnunberg@haskalah.org>

Update jsonsl

Using revision 0ba6edd8e6e142cbd88ff28a8eceec9b6505a488.

Parsing speed is improved for longer strings

Change-Id: I15a6bb8c6c73e962741fe1a6be12e26366c1d0ff

Update jsonsl

Using revision 0ba6edd8e6e142cbd88ff28a8eceec9b6505a488.

Parsing speed is improved for longer strings

Change-Id: I15a6bb8c6c73e962741fe1a6be12e26366c1d0ff
Reviewed-on: http://review.couchbase.org/53294
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

5702588308-Jul-2015 Mark Nunberg <mnunberg@haskalah.org>

Streaming optimizations and refactor

This refactors the match system to be more streamlined with respect to
stopping parsing as soon as a match is found. Changes include:

- Arra

Streaming optimizations and refactor

This refactors the match system to be more streamlined with respect to
stopping parsing as soon as a match is found. Changes include:

- Array operations are now more straightforward. No need to specify the
'first' or 'last' element to find an array.
- Match::loc_parent field removed. Consolidated into a single field,
loc_deepest.
- Match::loc_key is now only used for the actual key. No need to
specifically search for the last child. List append operations inspect
the number of children and prepend a comma to the new value.
- New match option, Match::GET_NUM_SIBLINGS, instructs the parser to
check if the match is the last child in the container. Used by REMOVE

Change-Id: I04619c8007782e0b0b713a593e709b136eaa8929
Reviewed-on: http://review.couchbase.org/52990
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

1234567