History log of /4.6.4/couchstore/ (Results 26 - 50 of 621)
Revision (<<< Hide revision tags) (Show revision tags >>>)Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
599c8c2322-Dec-2015 Volker Mische <vmx@couchbase.com>

MB-17154: Improve error message code in view group

The error message code had memory leaks (uncovered by the Clang Analyzer
`scan-build`) and could also be simplified.

Change-Id

MB-17154: Improve error message code in view group

The error message code had memory leaks (uncovered by the Clang Analyzer
`scan-build`) and could also be simplified.

Change-Id: I2b7abd18b35853ab776fab98418a7784a8953d7e
Reviewed-on: http://review.couchbase.org/58051
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>

show more ...

921f72aa22-Dec-2015 Volker Mische <vmx@couchbase.com>

MB-17154: Free records in file merger correctly

There were some memory leaks in the file merger. Those were found by
the Clang Analyzer `scan-build`.

Change-Id: Icd2c5c7ce2ed02b

MB-17154: Free records in file merger correctly

There were some memory leaks in the file merger. Those were found by
the Clang Analyzer `scan-build`.

Change-Id: Icd2c5c7ce2ed02b11313f62c60f5cfa990bd5ced
Reviewed-on: http://review.couchbase.org/58050
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

32773ceb22-Dec-2015 Volker Mische <vmx@couchbase.com>

MB-17154: Fix issues found with static analysis

Clang's Analyzer `scan-build` found a memory leak and certain implicit
conditions that are now manifested as asserts.

Change-Id:

MB-17154: Fix issues found with static analysis

Clang's Analyzer `scan-build` found a memory leak and certain implicit
conditions that are now manifested as asserts.

Change-Id: Ica102bbccc6aad9ceeee0a0467e41769bbaefe6f
Reviewed-on: http://review.couchbase.org/58049
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

4fc6e3d922-Dec-2015 Volker Mische <vmx@couchbase.com>

MB-17154: Fix not properly initialized variables

Some variables weren't initialized properly. Those where detected by
the Clang Analyzer `scan-build`.

Change-Id: I8db85cd1f7d9d6

MB-17154: Fix not properly initialized variables

Some variables weren't initialized properly. Those where detected by
the Clang Analyzer `scan-build`.

Change-Id: I8db85cd1f7d9d6a3f6718010bd509fc8c79854dc
Reviewed-on: http://review.couchbase.org/58048
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>

show more ...

faffc97822-Dec-2015 Volker Mische <vmx@couchbase.com>

MB-17154: Handle error in `couch_dbdump` case properly

Change-Id: I513adbf7d9e3c483a85c65082e0cd8c1de0e7d7d
Reviewed-on: http://review.couchbase.org/58047
Reviewed-by: Abhishek Singh

MB-17154: Handle error in `couch_dbdump` case properly

Change-Id: I513adbf7d9e3c483a85c65082e0cd8c1de0e7d7d
Reviewed-on: http://review.couchbase.org/58047
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

f1dc670c22-Dec-2015 Volker Mische <vmx@couchbase.com>

MB-17154: Fix potential memory issues in spatial compare function

Implicit assumptions are now changed into asserts. Those problems
where found by the Clang Analyzer `scan-build`.

MB-17154: Fix potential memory issues in spatial compare function

Implicit assumptions are now changed into asserts. Those problems
where found by the Clang Analyzer `scan-build`.

Change-Id: Iad3991cf12e61e96bf205b89d00780b9ca8602e7
Reviewed-on: http://review.couchbase.org/58046
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>

show more ...

bbabdf7b22-Dec-2015 Volker Mische <vmx@couchbase.com>

MB-17154: Fixing problems in tests

Those problems were identified by static analysis with the Clang Analyzer
`scan-build`.

Change-Id: I7b547ccffb1459475815b450b0ef0d0fd6c27ebc

MB-17154: Fixing problems in tests

Those problems were identified by static analysis with the Clang Analyzer
`scan-build`.

Change-Id: I7b547ccffb1459475815b450b0ef0d0fd6c27ebc
Reviewed-on: http://review.couchbase.org/58045
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>

show more ...

71e0dc3922-Dec-2015 Volker Mische <vmx@couchbase.com>

MB-17154: Return early if there's nothing to decode

Change-Id: If6628ad7ff1d9e695649af34f3f37fae1c4b8efd
Reviewed-on: http://review.couchbase.org/58044
Reviewed-by: Abhishek Singh <a

MB-17154: Return early if there's nothing to decode

Change-Id: If6628ad7ff1d9e695649af34f3f37fae1c4b8efd
Reviewed-on: http://review.couchbase.org/58044
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

5b82b23c22-Dec-2015 Volker Mische <vmx@couchbase.com>

MB-17154: Fixing a memory leak in couchscript

Change-Id: I8bdb00909a6dbc76a6dba4f02c7b3baf68500101
Reviewed-on: http://review.couchbase.org/58043
Reviewed-by: Harsha H S <hhs.couchba

MB-17154: Fixing a memory leak in couchscript

Change-Id: I8bdb00909a6dbc76a6dba4f02c7b3baf68500101
Reviewed-on: http://review.couchbase.org/58043
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

05983a8e22-Dec-2015 Volker Mische <vmx@couchbase.com>

MB-17154: Return results early

If one string is zero-sized, return early before doing any more
complicated things.

Change-Id: I35845144aafa39ce0a59bbe97f68ed02430a79ae
Revie

MB-17154: Return results early

If one string is zero-sized, return early before doing any more
complicated things.

Change-Id: I35845144aafa39ce0a59bbe97f68ed02430a79ae
Reviewed-on: http://review.couchbase.org/58042
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

e935ff6c21-Nov-2015 Sriram Ganesan <sriram@couchbase.com>

Validate arguments in couchstore_db_info

Validate the input arguments in couchstore_db_info and return
appropriate errors

Change-Id: I9e002090b7f8791183153a6e9c0c447d4da3d4de

Validate arguments in couchstore_db_info

Validate the input arguments in couchstore_db_info and return
appropriate errors

Change-Id: I9e002090b7f8791183153a6e9c0c447d4da3d4de
Reviewed-on: http://review.couchbase.org/57183
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: Sriram Ganesan <sriram@couchbase.com>

show more ...

ae5f3a1d20-Nov-2015 Sriram Ganesan <sriram@couchbase.com>

Return error if database handle is NULL in couchstore_db_info

If the caller passed a NULL pointer for the couchstore database
handle, the API needs to handle it appropriately and return

Return error if database handle is NULL in couchstore_db_info

If the caller passed a NULL pointer for the couchstore database
handle, the API needs to handle it appropriately and return
an error

Change-Id: Id02ec06b50cd3e79774f11780bcc7383df1b53f1
Reviewed-on: http://review.couchbase.org/57181
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

7c0b5f8310-Nov-2015 Trond Norbye <trond.norbye@gmail.com>

Merge remote-tracking branch 'couchbase/sherlock'

* couchbase/sherlock:
MB-16454: Fix issues with python bindings on osx 10.11

Change-Id: Idac0c99a726958336e464f7094741ea1e45f

Merge remote-tracking branch 'couchbase/sherlock'

* couchbase/sherlock:
MB-16454: Fix issues with python bindings on osx 10.11

Change-Id: Idac0c99a726958336e464f7094741ea1e45ff4bb

show more ...


Revision tags: v4.1.0
7d6bc22a12-Oct-2015 Mike Wiederhold <mike@couchbase.com>

MB-16454: Fix issues with python bindings on osx 10.11

Change-Id: If02848550b211fcf3151ca05c594eba4267f7dce
Reviewed-on: http://review.couchbase.org/56276
Tested-by: buildbot <build@

MB-16454: Fix issues with python bindings on osx 10.11

Change-Id: If02848550b211fcf3151ca05c594eba4267f7dce
Reviewed-on: http://review.couchbase.org/56276
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

d5981bd602-Nov-2015 harsha <hhs.couchbase@gmail.com>

Get rid of V8 version macros

Since v8 library file as part of cbdeps, no need to maintatin
v8 code base for different versions.

Change-Id: Ifa0a179d2cd7f52ff9589bd286554a2078ff5

Get rid of V8 version macros

Since v8 library file as part of cbdeps, no need to maintatin
v8 code base for different versions.

Change-Id: Ifa0a179d2cd7f52ff9589bd286554a2078ff5b00
Reviewed-on: http://review.couchbase.org/56596
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

88f1f22d26-Oct-2015 Volker Mische <vmx@couchbase.com>

MB-16527: Initialize `index_file`

If the decoding of the header fails, then the cleanup also cleans up
the `index_file`. For the cleanup that struct (`tree_file`) needs to be
initial

MB-16527: Initialize `index_file`

If the decoding of the header fails, then the cleanup also cleans up
the `index_file`. For the cleanup that struct (`tree_file`) needs to be
initialized (at least the `ops`).

Change-Id: I67e7d4e6f511a7b1ccbec344e7266b27bdb4d788
Reviewed-on: http://review.couchbase.org/56383
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

b0937e3026-Oct-2015 Volker Mische <vmx@couchbase.com>

MB-16526: Check header size before allocating

Make sure the header size of the view group is smaller than the
maximum allowed before allocating memory for it.

Change-Id: Id8cff5

MB-16526: Check header size before allocating

Make sure the header size of the view group is smaller than the
maximum allowed before allocating memory for it.

Change-Id: Id8cff574cad8d8630296803efd57250607991d3c
Reviewed-on: http://review.couchbase.org/56382
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

51360cef26-Oct-2015 Volker Mische <vmx@couchbase.com>

MB-16645: Maximum view header size is wrong

The header size of a view index file can be way bigger than 64KB.
Based on the code in `couch_set_view_util:group_to_header_bin/1`
functio

MB-16645: Maximum view header size is wrong

The header size of a view index file can be way bigger than 64KB.
Based on the code in `couch_set_view_util:group_to_header_bin/1`
function, the maximum size is below 20MB.

The currently exact maximum size is `20144805` (uncompressed) which comes
from the following calculation.

16 + 1 + 2 + 128 + 128 + 128 + (2 + 8*1024) + 2+65535 +
(2 + 256*(2+65535)) + 1 + (2 + 1024*2) + (3*2 + 1024*2) + (2 + 1024*8) +
(2 + (2 + 2 + 25*128)*1024)

It makes sense when you look at `couch_set_view_util:group_to_header_bin/1`
where the Erlang terms get encoded into the final binary format.

Change-Id: Icb2114b53ae7da5bf5fd45cd34fdea4a5a9d3cbd
Reviewed-on: http://review.couchbase.org/56386
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

2fa9324b20-Oct-2015 Abhishek Singh <abhishek@couchbase.com>

couch_dbdump: Adding support to read mapreduce index couchstore files

Change-Id: I58cb161729b0b2187045c7623c2d3cd728dfbab0
Reviewed-on: http://review.couchbase.org/56246
Tested-by: b

couch_dbdump: Adding support to read mapreduce index couchstore files

Change-Id: I58cb161729b0b2187045c7623c2d3cd728dfbab0
Reviewed-on: http://review.couchbase.org/56246
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

f00c64d315-Jun-2015 Volker Mische <vmx@couchbase.com>

MB-15267: Add line numbers to JavaScript errors

When there's an error in a view, it's hard to determine where exactly
it happened. The logging of the errors is improved to contain the li

MB-15267: Add line numbers to JavaScript errors

When there's an error in a view, it's hard to determine where exactly
it happened. The logging of the errors is improved to contain the line
and column number:

[mapreduce_errors:error,2015-06-11T17:23:47.302+02:00,couchdb_n_0@127.0.0.1:<0.461.0>:couch_set_view_updater:-do_maps/3-fun-0-:783]Bucket `beer-sample`, main group `_design/dev_beer`, error mapping document `copper_kettle_brewery` for view `brewery_beers`: TypeError: Cannot read property 'bar' of undefined (line 4:21)

Change-Id: Ife11faecd97082ac2e658a2a2d9ef59e5d513da6
Reviewed-on: http://review.couchbase.org/52061
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

8846eb4522-Sep-2015 abhinavdangeti <abhinav@couchbase.com>

Correct the key comparison logic in btree_lookup

Getting rid of unreachable code. Also ensure correctness
in the compare function, for the case where both the keys
are NULL.

Correct the key comparison logic in btree_lookup

Getting rid of unreachable code. Also ensure correctness
in the compare function, for the case where both the keys
are NULL.

Change-Id: I7c3ca339533cabe358361ba0b7a7cd50c5ac1703
Reviewed-on: http://review.couchbase.org/55415
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

4f39838605-Aug-2015 Jim Walker <jim@couchbase.com>

Make couch_compact and couch_dbinfo aware of version 11/12

* couch_dbinfo prints the CRC mode (as text)
* couch_compact accepts --upgrade to trigger the version
11 to 12 upgrade pa

Make couch_compact and couch_dbinfo aware of version 11/12

* couch_dbinfo prints the CRC mode (as text)
* couch_compact accepts --upgrade to trigger the version
11 to 12 upgrade path.

Change-Id: I0fac300a3cbc87002f9079ad6cc6fb664e366d3d
Reviewed-on: http://review.couchbase.org/54139
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

346633ad11-Aug-2015 Dave Rigby <daver@couchbase.com>

Enable CTest support on couchstore

Include the CTest module in couchstore's CMakeList.txt, so the
metadata needed for CTest (and specifically running MemoryChecker
tests) is configur

Enable CTest support on couchstore

Include the CTest module in couchstore's CMakeList.txt, so the
metadata needed for CTest (and specifically running MemoryChecker
tests) is configured.

Change-Id: I47fb570535bd138376b5f50744ccea91c5e65334
Reviewed-on: http://review.couchbase.org/54347
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

65f4fbb311-Aug-2015 Dave Rigby <daver@couchbase.com>

couchstore_tests: Fix Windows compile failure

Fix compile failures on Windows due to missing types / headers.

Change-Id: Ifef91c26c03957ababfa3c5212fd25f470c44d1c
Reviewed-on: h

couchstore_tests: Fix Windows compile failure

Fix compile failures on Windows due to missing types / headers.

Change-Id: Ifef91c26c03957ababfa3c5212fd25f470c44d1c
Reviewed-on: http://review.couchbase.org/54346
Reviewed-by: Jim Walker <jim@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

7a1ecb6131-Jul-2015 Jim Walker <jim@couchbase.com>

Enable crc32c in couchstore. Changes couchstore file version.

This increases the couchstore version number from 11 to 12.

The idea is that we wish to utilise crc32c for efficient ch

Enable crc32c in couchstore. Changes couchstore file version.

This increases the couchstore version number from 11 to 12.

The idea is that we wish to utilise crc32c for efficient checksumming.

The strategy is to bump the version number.
- version 11 files use the old crc.
- version 12 files use the new crc.

1) Brand new couchstore files will be version 12.

1a) However the API allows users to open files and force
legacy CRC, this is in-case any couchstore user doesn't
want to upgrade (e.g. erlang couchdb).

Opening a file with COUCHSTORE_OPEN_WITH_LEGACY_CRC will
force the version to 11 if the file is new. If the file is
not new the open is failed if the file version is not 11.

2) Compaction is the method to have upgrades performed.

A new compaction flag COUCHSTORE_COMPACT_FLAG_UPGRADE_DB
informs compaction that if the file to be compacted is
version 11, then the new file is version 12.

If the flag is not specified then compaction writes the new
file with same version/crc as the source file.

3) Views are not being upgraded to CRC-32C as part of this commit.
Code which opens tree-files specifies CRC32 explictly so that
they are compatible with couchdb/geocouch code. Upgrading views
to crc32c is a separate item.

Change-Id: I25573f5107408ba8040d06033abb1b6fcbde8414
Reviewed-on: http://review.couchbase.org/54136
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

12345678910>>...25