History log of /4.6.4/memcached/ (Results 1 - 25 of 2930)
Revision (<<< Hide revision tags) (Show revision tags >>>)Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
Revision tags: v4.6.3
8bd505eb13-Jul-2017 Dave Rigby <daver@couchbase.com>

MB-25241: Return ENGINE_NO_BUCKET when not associated with a bucket

If not associated with a bucket - e.g. if there's no 'default' bucket
and user hasn't performed SELECT_BUCKET yet, ret

MB-25241: Return ENGINE_NO_BUCKET when not associated with a bucket

If not associated with a bucket - e.g. if there's no 'default' bucket
and user hasn't performed SELECT_BUCKET yet, return ENGINE_NO_BUCKET
if bucket-level stats are requested.

Change-Id: I243fdaaf9d5c3c2b88bd04576b345b0e9992bcdd
Reviewed-on: http://review.couchbase.org/80645
Well-Formed: Build Bot <build@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>
Reviewed-by: Daniel Owen <owend@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

Revision tags: v4.6.2-MP3
89e5a92a22-Jun-2017 Trond Norbye <trond.norbye@gmail.com>

MB-24634: Keep buffers attached the connection

Pin the input and output buffer to the connection once it is
associated with the connection.

This avoids a buffer corruption which

MB-24634: Keep buffers attached the connection

Pin the input and output buffer to the connection once it is
associated with the connection.

This avoids a buffer corruption which is caused by issues in tracking
buffer usage - conn_return_single_buffer() if curr == buff and the
number of bytes in the buffer is 0, but when we add the packet header
to the buffer we don't update curr or bytes in the buffer (we add stuff
to the buffer a number of other places as well without updating rbytes).

In master the underlying bug has been addressed by moving to a more
explicit buffer management implementaiton; but for 4.6.x we are taking
a simpler/more conservative approach and disablging this optimization.

This does have the potential to increase the memory footprint if there
are a large number of connections.

Change-Id: I41781ab763518b2bd362513c546207febdfbb486
Reviewed-on: http://review.couchbase.org/79882
Reviewed-by: Dave Rigby <daver@couchbase.com>
Well-Formed: Build Bot <build@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

Revision tags: v4.6.5, v4.6.2
e30154cd10-Mar-2017 Matt Carabine <matt.carabine@hotmail.co.uk>

MB-23269: Avoid passing NULL to Audit::log_error()

- As detailed in the MB, when trying to write to a file that it
did not have permission to open, Memcached would crash.
- This wa

MB-23269: Avoid passing NULL to Audit::log_error()

- As detailed in the MB, when trying to write to a file that it
did not have permission to open, Memcached would crash.
- This was due to the fact that the method call to
Audit::log_error() passed a null pointer as an argument which
was then attempted to be converted to a string.
- The Audit::log_error() method already made use of an optional
second string argument, defaulting to an empty string ("") if
not specified.
- To prevent crashing due to calling this method incorrectly,
everywhere where Audit::log_error() was called with NULL has now
had the second argument removed.

Change-Id: I14280a9ef317ce7caca90ff07df2299f4559411a
Reviewed-on: http://review.couchbase.org/75053
Tested-by: Build Bot <build@couchbase.com>
Well-Formed: Build Bot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

a8389c0417-Jan-2017 Mark Nunberg <mnunberg@haskalah.org>

MB-22044: Subdoc should detect and handle locked items (3/3)

If an item is locked and the user has provided a CAS, then we should
assume the user's CAS is correct, and it there is a mism

MB-22044: Subdoc should detect and handle locked items (3/3)

If an item is locked and the user has provided a CAS, then we should
assume the user's CAS is correct, and it there is a mismatch, detect it
when actually applying the mutation, rather than before (in the
verification phase).

Change-Id: I5ad061eaf50d2131c9c3d2d295c1305420de96c5
Reviewed-on: http://review.couchbase.org/72906
Reviewed-by: Dave Rigby <daver@couchbase.com>
Well-Formed: Build Bot <build@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

072764b530-Jan-2017 Mark Nunberg <mnunberg@haskalah.org>

MB-22044: ewouldblock_engine_configure: Allow to pass key (2/3)

Change-Id: Idbe8e2c4fed91067ff525f3a7ad1d757e667a8d3
Reviewed-on: http://review.couchbase.org/72905
Reviewed-by: Dave

MB-22044: ewouldblock_engine_configure: Allow to pass key (2/3)

Change-Id: Idbe8e2c4fed91067ff525f3a7ad1d757e667a8d3
Reviewed-on: http://review.couchbase.org/72905
Reviewed-by: Dave Rigby <daver@couchbase.com>
Well-Formed: Build Bot <build@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

81c00ea930-Jan-2017 Mark Nunberg <mnunberg@haskalah.org>

MB-22044: EWBEngineMode::SetItemCas (1/3)

Provide an out-of-band way to set the CAS for an item.

This helps us "implement" get and lock (so that a subsequent internal
get by Mem

MB-22044: EWBEngineMode::SetItemCas (1/3)

Provide an out-of-band way to set the CAS for an item.

This helps us "implement" get and lock (so that a subsequent internal
get by Memcached returns a cas of -1)

Change-Id: I8984bdfee75cd0621d0563286b09a5158ce6de50
Reviewed-on: http://review.couchbase.org/72904
Tested-by: Build Bot <build@couchbase.com>
Well-Formed: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Revision tags: v4.5.1-MP1, v4.6.0-DP, v4.1.2-MP2, v4.5.1, v4.6.0
45a4642505-Aug-2016 Matt Carabine <matt.carabine@couchbase.com>

MB-20016: Add CBNT test list

- Couchbase Nightly Test (CBNT), the performance commit validation
infrastructure used by KV engine requires a list of tests to be
supplied in yml fo

MB-20016: Add CBNT test list

- Couchbase Nightly Test (CBNT), the performance commit validation
infrastructure used by KV engine requires a list of tests to be
supplied in yml format
- For maintainability and ease of adding/removing tests it makes
most sense to store this list of tests within the KV engine
source tree, specifically within the memcached tests directory

Change-Id: If614845a087981b815a8788ad81819c8f2c39aea
Reviewed-on: http://review.couchbase.org/68096
Reviewed-by: Matt Carabine <matt.carabine@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

39d843c322-Nov-2016 Trond Norbye <trond.norbye@gmail.com>

MB-21762: Return ENOMEM instead of dereference nullptr

Creation of the subdoc executor context may fail due to
std::bad_alloc being thrown which is caught and nullptr
is returned ins

MB-21762: Return ENOMEM instead of dereference nullptr

Creation of the subdoc executor context may fail due to
std::bad_alloc being thrown which is caught and nullptr
is returned instead.

Change-Id: Icc1a01792910651ba23dcfbea9888879313c3a16
Reviewed-on: http://review.couchbase.org/70239
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

50eba8e417-Nov-2016 Jim Walker <jim@couchbase.com>

MB-21599: Add new *_with_meta options

These options allow LWW aware clients to perform *with_meta
commands and enables the option of cas regeneration.

Change-Id: Ifb149927d3f633

MB-21599: Add new *_with_meta options

These options allow LWW aware clients to perform *with_meta
commands and enables the option of cas regeneration.

Change-Id: Ifb149927d3f63357d30392352c9c81533cbf2ff1
Reviewed-on: http://review.couchbase.org/70015
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

139bb81021-Nov-2016 Trond Norbye <trond.norbye@gmail.com>

MB-21731: Delete command context during disconnect

Change-Id: I5aa77a9d95355761954721d04c3cc844d136a5f5
Reviewed-on: http://review.couchbase.org/70141
Reviewed-by: Dave Rigby <daver@

MB-21731: Delete command context during disconnect

Change-Id: I5aa77a9d95355761954721d04c3cc844d136a5f5
Reviewed-on: http://review.couchbase.org/70141
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

fe458a8f21-Nov-2016 Trond Norbye <trond.norbye@gmail.com>

Add timeout to the blocking shutdown lock in EngineManager

Ideally we should use cond.wait() here, but I _HAVE_ seen this
wait stuck on our commit validator builders on.. tata WINDOWS

Add timeout to the blocking shutdown lock in EngineManager

Ideally we should use cond.wait() here, but I _HAVE_ seen this
wait stuck on our commit validator builders on.. tata WINDOWS

Whenever this happens that windows builder is blocked from
running any other commit validation builds for memcached until
someone manually logs into the builder and kill the process
(because it locks the files on the filesystem for modification
while the process is running).

Lets back off every now and then to recheck the map until
we figure out why there is a missing notification somewhere.

Change-Id: I08b9ebf8f9026d6b4fcca0e942f53db81b4af34c
Reviewed-on: http://review.couchbase.org/70142
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

da2a776217-Nov-2016 Dave Rigby <daver@couchbase.com>

MB-20096: Include opaque in 'Slow operation' messages

Change-Id: I9f266a7e8e6402e4fddd1c4b9c40c5d5963abe5a
Reviewed-on: http://review.couchbase.org/70021
Reviewed-by: David Haikney <

MB-20096: Include opaque in 'Slow operation' messages

Change-Id: I9f266a7e8e6402e4fddd1c4b9c40c5d5963abe5a
Reviewed-on: http://review.couchbase.org/70021
Reviewed-by: David Haikney <david.haikney@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

cc0ec27817-Nov-2016 Dave Rigby <daver@couchbase.com>

MB-21650: Fix build-break on macOS

Failure due to buffer.h not including <string> when using std::string

Change-Id: Ia2f29caa187f7dde0272f2205e263d449b8d61c8
Reviewed-on: http:/

MB-21650: Fix build-break on macOS

Failure due to buffer.h not including <string> when using std::string

Change-Id: Ia2f29caa187f7dde0272f2205e263d449b8d61c8
Reviewed-on: http://review.couchbase.org/70022
Reviewed-by: Daniel Owen <owend@couchbase.com>
Tested-by: Dave Rigby <daver@couchbase.com>

show more ...

5cf4074116-Nov-2016 Dave Rigby <daver@couchbase.com>

MB-21650: Improve const_sized_buffer compatibility with std::string

Add two methods (data() and size()) to const_sized_buffer, and a
construtor which takes a std::string to const_sized_b

MB-21650: Improve const_sized_buffer compatibility with std::string

Add two methods (data() and size()) to const_sized_buffer, and a
construtor which takes a std::string to const_sized_buffer, to make it
easier to use this class instead of std::string

Change-Id: I4177b4329e6903840cfa8754a8fcd5931250e3c0
Reviewed-on: http://review.couchbase.org/69943
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Daniel Owen <owend@couchbase.com>

show more ...

85dded7f15-Nov-2016 Trond Norbye <trond.norbye@gmail.com>

Add a unit test that tests incorrect auth

While looking at MB-21659 I discovered that we don't have any
"end to end" test which tests incorrect authentication.

Change-Id: I73975

Add a unit test that tests incorrect auth

While looking at MB-21659 I discovered that we don't have any
"end to end" test which tests incorrect authentication.

Change-Id: I73975d5a86e7f776fd4d3a724be1c0ee08c13a8b
Reviewed-on: http://review.couchbase.org/69911
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

098c351e04-Nov-2016 Mark Nunberg <mnunberg@haskalah.org>

MB-21597: Use OPERATION_CAS rather than OPERATION_REPLACE

REPLACE means unconditional replace in old-style Memcached parlance.
CAS is the actual operation required, as it actually verifi

MB-21597: Use OPERATION_CAS rather than OPERATION_REPLACE

REPLACE means unconditional replace in old-style Memcached parlance.
CAS is the actual operation required, as it actually verifies the CAS.
See e.g.
https://github.com/couchbase/memcached/blob/master/engines/default_engine/items.c#L564

Update the ewouldblock_engine error injection to only inject
CasMismatch for CAS operatons (and not for SET operations) - this
ensures the original unit test for CAS checking
(McdTestappTest.SubdocCASAutoRetry) now correctly tests for this
issue, and will fail without the fix to subdocument.cc.

Change-Id: I67393114110add05807dbb8dc6bdcc7467f4b887
Reviewed-on: http://review.couchbase.org/69736
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Mark Nunberg <mark.nunberg@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

d4b3338b01-Nov-2016 Trond Norbye <trond.norbye@gmail.com>

MB-21512: Don't shutdown EngineManager twice

Previously we called the shutdown manually, and later on
it was called from the destructor without checking if
it was already shut down.

MB-21512: Don't shutdown EngineManager twice

Previously we called the shutdown manually, and later on
it was called from the destructor without checking if
it was already shut down.

In addition to that we had some cases where we could race
during shutdown by just checking an atomic variable if
we should add stuff to the internal queues or not. We
have to hold the mutex so that another thread can't change
that state right after we checked it, but before we added
our items to the list.

Change-Id: I7686e549f2e80bbdc165d608513b882774fe658e
Reviewed-on: http://review.couchbase.org/69335
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

6232d98a01-Nov-2016 Trond Norbye <trond.norbye@gmail.com>

Refactor: Move scrubberTask out of engine_manager.cc

Change-Id: I3540aa3e85e2b1ab19e7763a4b8a350505d43ee3
Reviewed-on: http://review.couchbase.org/69378
Tested-by: buildbot <build@co

Refactor: Move scrubberTask out of engine_manager.cc

Change-Id: I3540aa3e85e2b1ab19e7763a4b8a350505d43ee3
Reviewed-on: http://review.couchbase.org/69378
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

e5541e1301-Nov-2016 Trond Norbye <trond.norbye@gmail.com>

MB-21537: Fix memory leak in auditevent_generator

Change-Id: If07115d2ef94f88b0212f436f40eda59e191be65
Reviewed-on: http://review.couchbase.org/69360
Reviewed-by: Dave Rigby <daver@c

MB-21537: Fix memory leak in auditevent_generator

Change-Id: If07115d2ef94f88b0212f436f40eda59e191be65
Reviewed-on: http://review.couchbase.org/69360
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

7daad7a431-Oct-2016 Trond Norbye <trond.norbye@gmail.com>

Change loglevel when peer closed the connection

There is nothing "wrong" that an operator should look into if
the client close the socket without reading the response message
from th

Change loglevel when peer closed the connection

There is nothing "wrong" that an operator should look into if
the client close the socket without reading the response message
from the server.

Change-Id: I04b61b4e7270bb8f61938b12d187a4dd013cef1e
Reviewed-on: http://review.couchbase.org/69332
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

a8527f6e31-Oct-2016 Trond Norbye <trond.norbye@gmail.com>

Use NOTICE instead of WARNING for invalid packet

WARNING should not be used for logging invalid input from the
client. NOTICE (or even INFO is more appropriate)

Change-Id: I07c0

Use NOTICE instead of WARNING for invalid packet

WARNING should not be used for logging invalid input from the
client. NOTICE (or even INFO is more appropriate)

Change-Id: I07c0f09f02e1b7c9b56e4ac82a343879e5c4d72f
Reviewed-on: http://review.couchbase.org/69331
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

ff0de8a128-Oct-2016 Trond Norbye <trond.norbye@gmail.com>

Refactor: Change loglevel for some create bucket messages

Don't log invalid bucket names or types as warnings. These
error scenarios is only created by a user providing invalid
input

Refactor: Change loglevel for some create bucket messages

Don't log invalid bucket names or types as warnings. These
error scenarios is only created by a user providing invalid
input and it should rather be logged / handled at the client
side.

We'll still put the entries into the server logs, but at
a more appropriate log leve.

Change-Id: I245a421b960c3639983972218f75a75a83f72964
Reviewed-on: http://review.couchbase.org/69294
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

c133abee31-Oct-2016 Trond Norbye <trond.norbye@gmail.com>

MB-21513: Race condition accessing listening port

The ListeningPort object is stored in a vector which is
(currently) being protected by the stats mutex (which we should
split up). T

MB-21513: Race condition accessing listening port

The ListeningPort object is stored in a vector which is
(currently) being protected by the stats mutex (which we should
split up). This patch refactored the "struct listening_port"
to "class ListeningPort" and const'd some of the members which
cannot change dynamically. It protects the access to the vector
where we previously tried to access it without the lock.

Change-Id: I3cae24e6ace3a344bde75b515a1571308cc06136
Reviewed-on: http://review.couchbase.org/69326
Reviewed-by: Jim Walker <jim@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

0cd4dee527-Oct-2016 Trond Norbye <trond.norbye@gmail.com>

Add more info if WIFEXITED failed in testapp

Change-Id: I046b028c6780e06a9219db14bca8b730d438b9f0
Reviewed-on: http://review.couchbase.org/69296
Tested-by: buildbot <build@couchbase.

Add more info if WIFEXITED failed in testapp

Change-Id: I046b028c6780e06a9219db14bca8b730d438b9f0
Reviewed-on: http://review.couchbase.org/69296
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>

show more ...

6c17560327-Oct-2016 Trond Norbye <trond.norbye@gmail.com>

Use the correct loglevel for debug output in ewb engine

Change-Id: I04028baf68c6553ed42100b68ce1e493aba9210a
Reviewed-on: http://review.couchbase.org/69279
Tested-by: buildbot <build

Use the correct loglevel for debug output in ewb engine

Change-Id: I04028baf68c6553ed42100b68ce1e493aba9210a
Reviewed-on: http://review.couchbase.org/69279
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

12345678910>>...118