History log of /5.5.2/couchdb/src/couch_index_merger/ (Results 1 - 25 of 59)
Revision (<<< Hide revision tags) (Show revision tags >>>)Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
ba0c3c1218-May-2018 Aman Achpal <aman.achpal@couchbase.com>

MB-27124 Log Query Volume

Log the volume of incoming queries at regular
intervals instead of every incoming query.

Log message when there are no queries:
[couchdb:info,2018-

MB-27124 Log Query Volume

Log the volume of incoming queries at regular
intervals instead of every incoming query.

Log message when there are no queries:
[couchdb:info,2018-05-23T10:25:26.439+05:30,couchdb_n_1@127.0.0.1:couch_query_logger<0.157.0>:couch_log:info:41]Query-Volume
---

Log message with queries:
[couchdb:info,2018-05-23T10:26:26.443+05:30,couchdb_n_0@127.0.0.1:couch_query_logger<0.157.0>:couch_log:info:41]Query-Volume
<ud>"/beer-sample/_design/beer/_view/brewery_beers"</ud> | internal.stale={ok: 0, update_after: 0, false: 0} | external.stale={ok: 0, update_after: 1, false: 1}
<ud>"/beer-sample/_design/beer/_view/by_location"</ud> | internal.stale={ok: 0, update_after: 0, false: 0} | external.stale={ok: 0, update_after: 1, false: 1}
---

Note: internal queries are scatter-gather queries
and external queries come from external clients

Change-Id: I8a0ee9af8d09d3c95dacd322d7d57d90a93ebb0d
Reviewed-on: http://review.couchbase.org/94420
Reviewed-by: Harsha H S
Tested-by: Harsha H S

show more ...

1fa7fd4a06-Mar-2018 Aman Achpal <aman.achpal@couchbase.com>

MB-28499 Fix Dialyzer failure ...

... by removing unnecessary case condition.

Change-Id: I33cd1bbdb617197e4c04d700c98375f2407aed70
Reviewed-on: http://review.couchbase.org/90486

MB-28499 Fix Dialyzer failure ...

... by removing unnecessary case condition.

Change-Id: I33cd1bbdb617197e4c04d700c98375f2407aed70
Reviewed-on: http://review.couchbase.org/90486
Reviewed-by: Jeelan Basha Poola <jeelan.poola@couchbase.com>
Reviewed-by: Aman Kishore Achpal <aman.achpal@couchbase.com>
Tested-by: Aman Kishore Achpal <aman.achpal@couchbase.com>

show more ...

2d7b7d5823-Feb-2018 Aman Achpal <aman.achpal@couchbase.com>

MB-16737: [couch_index_merger] Perform socket cleanup ...

... once the internal client times out and no longer
listens to streaming results from the remote node.

Change-Id: Ic17

MB-16737: [couch_index_merger] Perform socket cleanup ...

... once the internal client times out and no longer
listens to streaming results from the remote node.

Change-Id: Ic177b5389d46ead360cf73a2bb40bb6daa9ea0e1
Reviewed-on: http://review.couchbase.org/89944
Reviewed-by: Harsha H S
Tested-by: Aman Kishore Achpal <aman.achpal@couchbase.com>

show more ...

2c50cb2915-Feb-2018 Aman Achpal <aman.achpal@couchbase.com>

Revert "MB-100: Refactor Code"

query_index/2 is needed in some exceptional cases
(rebalance during failover) and cannot be removed

This reverts commit 4db36f62526258376183997efb

Revert "MB-100: Refactor Code"

query_index/2 is needed in some exceptional cases
(rebalance during failover) and cannot be removed

This reverts commit 4db36f62526258376183997efb48e075aaf50995.

Change-Id: I6e18950dff442e653abb8baa798a22420f44ad78
Reviewed-on: http://review.couchbase.org/89474
Reviewed-by: Aman Kishore Achpal <aman.achpal@couchbase.com>
Tested-by: Aman Kishore Achpal <aman.achpal@couchbase.com>

show more ...

4db36f6212-Feb-2018 Aman Achpal <aman.achpal@couchbase.com>

MB-100: Refactor Code

Refactor code in view-engine query path to enhance readability

Change-Id: I9ac366f9f97acba7d5655b9a4eb29259a26648e8
Reviewed-on: http://review.couchbase.or

MB-100: Refactor Code

Refactor code in view-engine query path to enhance readability

Change-Id: I9ac366f9f97acba7d5655b9a4eb29259a26648e8
Reviewed-on: http://review.couchbase.org/89236
Reviewed-by: Aman Kishore Achpal <aman.achpal@couchbase.com>
Tested-by: Aman Kishore Achpal <aman.achpal@couchbase.com>

show more ...

73648b9013-Jan-2018 harsha <harsha.hs.81@gmail.com>

MB-26674 Log redaction support in views.

This patch identifies user data and redacts customer user data
that are logged in the views under <ud> </ud> tags.

Change-Id: Ic61c92179

MB-26674 Log redaction support in views.

This patch identifies user data and redacts customer user data
that are logged in the views under <ud> </ud> tags.

Change-Id: Ic61c9217908c455ef4e4dce987a2295add9c5515
Reviewed-on: http://review.couchbase.org/87818
Reviewed-by: Aman Kishore Achpal <aman.achpal@couchbase.com>
Reviewed-by: Jeelan Basha Poola <jeelan.poola@couchbase.com>
Tested-by: Jeelan Basha Poola <jeelan.poola@couchbase.com>

show more ...

Revision tags: v4.6.0
ed40de6f01-Jun-2016 Volker Mische <vmx@couchbase.com>

MB-16737 Set default timeout late

The default timeout for internal scatter requests is 60s. It can be changed
with the `connection_timeout` query parameter. For future changes it's neede

MB-16737 Set default timeout late

The default timeout for internal scatter requests is 60s. It can be changed
with the `connection_timeout` query parameter. For future changes it's needed
to be able to distinguish the `connection_timeout` parameter being set at
query time or not.

Hence set the default value to `nil` and set it to the default value of
60 seconds as late as possible.

Change-Id: I45e7a2b07d27abb656150492e3a11985b77f901e
Reviewed-on: http://review.couchbase.org/64651
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>

show more ...

af17ac0c01-Jun-2016 Volker Mische <vmx@couchbase.com>

Remove the `Timeout` variable which isn't used

Change-Id: I50d1e8755de7986ae6a724540cc9e57856b0df11
Reviewed-on: http://review.couchbase.org/64650
Tested-by: buildbot <build@couchbas

Remove the `Timeout` variable which isn't used

Change-Id: I50d1e8755de7986ae6a724540cc9e57856b0df11
Reviewed-on: http://review.couchbase.org/64650
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>

show more ...

a80ef04e11-May-2016 Abhishek Singh <abhishek@couchbase.com>

Reference expected and received ddoc revision appropriately

Change-Id: I12c4a22da7b98f3e8e6574579465532c849948ee
Reviewed-on: http://review.couchbase.org/63923
Reviewed-by: Volker Mi

Reference expected and received ddoc revision appropriately

Change-Id: I12c4a22da7b98f3e8e6574579465532c849948ee
Reviewed-on: http://review.couchbase.org/63923
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>

show more ...

Revision tags: v4.5.0
58b8edf925-Feb-2016 Abhishek <abhishek@couchbase.com>

MB-18268 - Adding timing stats for view queries

Exposing view query timing stats over _get_query_stats endpoint

Sample example:

curl http://10.142.200.101:9500/_set_view/de

MB-18268 - Adding timing stats for view queries

Exposing view query timing stats over _get_query_stats endpoint

Sample example:

curl http://10.142.200.101:9500/_set_view/default/_design/ddoc1/_get_query_stats -s | python -m json.tool
{
"query_timing_in_ms": {
"_design/ddoc1": {
"view1": {
"1": 0,
"10": 16,
"100": 0,
"1000": 0,
"10000": 0,
"100000": 0
},
"view2": {
"1": 0,
"10": 14,
"100": 0,
"1000": 0,
"10000": 0,
"100000": 0
}
}
}
}

Change-Id: I6d1260c9b4d7146f0365862a9be797001e9d7db0
Reviewed-on: http://review.couchbase.org/60499
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: Abhishek Singh <abhishek@couchbase.com>

show more ...

1fc9a81f09-Mar-2016 Volker Mische <vmx@couchbase.com>

CBD-1453: Rebuild when header files change

Whenever an Erlang header file changes, rebuild the corresponding
Erlang files. This isn't an automated process, but you need to pass
in th

CBD-1453: Rebuild when header files change

Whenever an Erlang header file changes, rebuild the corresponding
Erlang files. This isn't an automated process, but you need to pass
in the header files a project should depend on manually. For simplicity
sometimes more headers are use than strictly needed. We rather rebuild
more than having a broken incremental build.

Change-Id: Iae6d0a9043ed1b74f2c104d9b251f45715ac04fd
Reviewed-on: http://review.couchbase.org/61152
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>

show more ...

4bd0f4c503-Mar-2016 Volker Mische <vmx@couchbase.com>

MB-17420 Don't use GLOB to find source/test files

Instead of using globbing, it's better to name the files
explicitely. That way incremental builds work.

Change-Id: I1b47c61b0f5

MB-17420 Don't use GLOB to find source/test files

Instead of using globbing, it's better to name the files
explicitely. That way incremental builds work.

Change-Id: I1b47c61b0f524e5576d4111075516d923f039a6f
Reviewed-on: http://review.couchbase.org/60856
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

6f94d5aa17-Feb-2016 Volker Mische <vmx@couchbase.com>

MB-16618 Sort keys the expected way

When a mapreduce query is using the `keys` parameter, you would expect
the result sorted the same way as the supplied keys. This wasn't the
case,

MB-16618 Sort keys the expected way

When a mapreduce query is using the `keys` parameter, you would expect
the result sorted the same way as the supplied keys. This wasn't the
case, but it is now.

Change-Id: I75cab77a44eb4cdc26a98118c6abca5a1635bd62
Reviewed-on: http://review.couchbase.org/60121
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

a84b68ec15-Apr-2015 Volker Mische <vmx@couchbase.com>

MB-14470: Make spatial views work with active replica partitions

If some replica partitions are active, the spatial view merger failed.

The reason is, that the rows the merger is pr

MB-14470: Make spatial views work with active replica partitions

If some replica partitions are active, the spatial view merger failed.

The reason is, that the rows the merger is processing in that case are
already transformed into JSON, so the results are just passed on without
modification by the `make_row_fun`.

A special version of that function (compared to the mapreduce version)
is needed as the actual fold function that runs over the index is
different between spatial and mapreduce views. The spatial one has an
arity of 2, the one for mapreduce views an arity of 3 (due to the reduce).

Change-Id: I3adaa16d6b4c53f189fd582fe43dd682a5dd0082
Reviewed-on: http://review.couchbase.org/49740
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: Volker Mische <volker.mische@gmail.com>

show more ...

2f4031c013-Apr-2015 Nimish Gupta <nimish@couchbase.com>

MB-14466 Mixing of data in views

We were applying a wrong rereduce function in views when we collect and merge the
query result and apply the rereduce. In that rereduce function, we crea

MB-14466 Mixing of data in views

We were applying a wrong rereduce function in views when we collect and merge the
query result and apply the rereduce. In that rereduce function, we create a reduce
context and store it in the erlang process table, but we were not deleting that context
processing the query. So if the next query comes and mochiweb uses the same
erlang process, the next query will find the context and use it. If both are
queries are from different views, the reduce context applied to second query
is wrong and the result will be wrong. To reproduce this issue, create following
2 view functions in different design doc on a 3 node cluster with 1000 documents:
view1:
map:
function (doc, meta) {
emit(["A", "B"], ["couch", "base"]);
}
reduce:
function(keys, values, rereduce) {
return ["couch", "base"];
}

view2:
map:
function (doc, meta) {
emit(["A1", "B1"], ["couch1", "base1"]);
}
reduce:
function(keys, values, rereduce) {
return ["couch1", "base1"];
}
Now when we query view1 and view2, we can see that view2 result
has value from view1.
Result:
{"rows":[
{"key":["A1","B1"],"value":["couch","base"]}
]
}
In this fix, now we delete the context after query is finished.

Change-Id: I37f7488136c5023e97b35fec7ca554411ebf9eb5
Reviewed-on: http://review.couchbase.org/49589
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: Volker Mische <volker.mische@gmail.com>

show more ...

4fb3db5d19-Feb-2015 Volker Mische <vmx@couchbase.com>

MB-13084 View engine doesn't support `include_docs` anymore

Removing a left-over when `include_docs` was a supported option.

Change-Id: I1bd4d818329c3ed874caa9571cfe640598e13b1a

MB-13084 View engine doesn't support `include_docs` anymore

Removing a left-over when `include_docs` was a supported option.

Change-Id: I1bd4d818329c3ed874caa9571cfe640598e13b1a
Reviewed-on: http://review.couchbase.org/47183
Reviewed-by: Nimish Gupta <nimish@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

18349dde23-Feb-2015 Nimish Gupta <nimish@couchbase.com>

MB-12607 Remove the extra call to updater

We were calling the updater twice in get_set_view function to update
the stat.This was causing multiple stats call to ep-engine which was
im

MB-12607 Remove the extra call to updater

We were calling the updater twice in get_set_view function to update
the stat.This was causing multiple stats call to ep-engine which was
impacting query performance in stale=false case.This change removes the
extra updater call while keeping the stat intact. After this change,
the rate almost doubled (from 29.6 to 57 with 1M items) when there were
no mutations on a single server node.

Change-Id: I7bcbc767e17ee38a8488df79e85a87d506a90d8d
Reviewed-on: http://review.couchbase.org/47190
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

28f6e37419-Feb-2015 Volker Mische <volker.mische@gmail.com>

Revert "Remove the extra call for updater"

This reverts commit e799b6e7678d0c70f67e22f5cb5b030b6f2e5ee2.

The reason to revert this change is that the original commit changes
the

Revert "Remove the extra call for updater"

This reverts commit e799b6e7678d0c70f67e22f5cb5b030b6f2e5ee2.

The reason to revert this change is that the original commit changes
the behaviour. When there are missing partitions (e.g. during rebalance)
the stats will be updated on every retry. Though the stats should be
updated only once, as from the user perspective it was a single request
and not multiple ones.

Change-Id: Iee17a14d7f36acf4f5fe824ed5f0aaa93dabfe80
Reviewed-on: http://review.couchbase.org/47077
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Reviewed-by: Nimish Gupta <nimish@couchbase.com>
Tested-by: Volker Mische <volker.mische@gmail.com>

show more ...

e799b6e718-Feb-2015 Nimish Gupta <nimish@couchbase.com>

Remove the extra call for updater

Change-Id: I137da3ec4b5cfdcfb5566cf513e1c22b2ad89b7b
Reviewed-on: http://review.couchbase.org/47016
Reviewed-by: Volker Mische <volker.mische@gmail.

Remove the extra call for updater

Change-Id: I137da3ec4b5cfdcfb5566cf513e1c22b2ad89b7b
Reviewed-on: http://review.couchbase.org/47016
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: Volker Mische <volker.mische@gmail.com>

show more ...

e1006d5119-Jan-2015 Volker Mische <vmx@couchbase.com>

MB-13084 Remove _all_docs and old couchdb views support

The view/index merger still had code to support all_docs and the
old couchdb views. It lead to many special cases and a lot of cod

MB-13084 Remove _all_docs and old couchdb views support

The view/index merger still had code to support all_docs and the
old couchdb views. It lead to many special cases and a lot of code.
This code is now removed.

Change-Id: Ib90c876904326b596efd7a44706a23d4ebdfb6b7
Reviewed-on: http://review.couchbase.org/45975
Reviewed-by: Nimish Gupta <nimish@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

6f2f1af218-Nov-2014 Artem Stemkovski <artem@couchbase.com>

do not return url in the "from" field of view_merger error record

because it can contain user:pasword@ and overall contains too much
internal info for user to know

return host:p

do not return url in the "from" field of view_merger error record

because it can contain user:pasword@ and overall contains too much
internal info for user to know

return host:port instead so the user knows which node had a problem

Change-Id: Ia7d401ba70161cf79afabe899b0e24e6331c30a2
Reviewed-on: http://review.couchbase.org/43382
Tested-by: Artem Stemkovski <artem@couchbase.com>
Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

3824c9a002-Sep-2014 Volker Mische <vmx@couchbase.com>

MB-12112: Streamline CMake files

With an improved ERL_BUILD_OTP macro less code is needed within
the individual CMakeLists.txt files.

Change-Id: I9b03b82194dc787715730d3adb2bc59

MB-12112: Streamline CMake files

With an improved ERL_BUILD_OTP macro less code is needed within
the individual CMakeLists.txt files.

Change-Id: I9b03b82194dc787715730d3adb2bc599af162d0a
Reviewed-on: http://review.couchbase.org/41147
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Chris Hillery <ceej@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

0f0f36fc31-Jul-2014 Volker Mische <vmx@couchbase.com>

Export additional function for the spatial views

In anticipation for the spatial views, export some additional functions.

Change-Id: Ide2df7ada829e5ad1212da2b8ba50fcbaf03814a
Re

Export additional function for the spatial views

In anticipation for the spatial views, export some additional functions.

Change-Id: Ide2df7ada829e5ad1212da2b8ba50fcbaf03814a
Reviewed-on: http://review.couchbase.org/40115
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Nimish Gupta <nimish@couchbase.com>

show more ...

eca35e7b14-Jun-2014 Volker Mische <vmx@couchbase.com>

Move code into the more generic module

This is a refactoring without a functional change. Code from the specific
mapreduce views merger is moved into the more general index merger.

Move code into the more generic module

This is a refactoring without a functional change. Code from the specific
mapreduce views merger is moved into the more general index merger.

Change-Id: I119109624e1a0c4bd5b5f55f37f3f74b7e8cc9f6
Reviewed-on: http://review.couchbase.org/39638
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>

show more ...

330283c907-Apr-2014 Trond Norbye <trond.norbye@gmail.com>

otp build macro to get correct layout

Change-Id: I5aa44455ae8bc857342d57dca0848f6fa4ba8957
Reviewed-on: http://review.couchbase.org/35367
Reviewed-by: Trond Norbye <trond.norbye@gmai

otp build macro to get correct layout

Change-Id: I5aa44455ae8bc857342d57dca0848f6fa4ba8957
Reviewed-on: http://review.couchbase.org/35367
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

123