Cleanup: Reduce include from memcached.h and connection.h

These two files used to be included from almost every .cc file
and included a lot of other files, which results in recomplie

Cleanup: Reduce include from memcached.h and connection.h

These two files used to be included from almost every .cc file
and included a lot of other files, which results in recomplie
of almost everything whenever changing stuff in one of the
headers.

Forward decl the classes whenever possible to reduce the
number of nested includes and just include the .h from the
.cc where it is needed.

Change-Id: I5dfc884b58473898f15cf407cc069a0bac32dc82
Reviewed-on: http://review.couchbase.org/91660
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Tim Bradgate <tim.bradgate@couchbase.com>

show more ...

Use logger directly in the core

Changed the LOG_ macros used in the core and call
them directly instead of going through the old
logger interface using the printf-style of formatting

Use logger directly in the core

Changed the LOG_ macros used in the core and call
them directly instead of going through the old
logger interface using the printf-style of formatting

Change-Id: I7927bfdd98a843a605fd418ab343f166c25c7b74
Reviewed-on: http://review.couchbase.org/88814
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

MB-22217 - change config_strerror to use std::string

Moving away from char* so the caller does not have to remember to free()
the returned value.

Change-Id: Ida27e6e26b3510e4935

MB-22217 - change config_strerror to use std::string

Moving away from char* so the caller does not have to remember to free()
the returned value.

Change-Id: Ida27e6e26b3510e4935d2c0e4ea09b25daeb6c50
Reviewed-on: http://review.couchbase.org/71992
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

MB-21513: Race condition accessing listening port

The ListeningPort object is stored in a vector which is
(currently) being protected by the stats mutex (which we should
split up). T

MB-21513: Race condition accessing listening port

The ListeningPort object is stored in a vector which is
(currently) being protected by the stats mutex (which we should
split up). This patch refactored the "struct listening_port"
to "class ListeningPort" and const'd some of the members which
cannot change dynamically. It protects the access to the vector
where we previously tried to access it without the lock.

Change-Id: I3cae24e6ace3a344bde75b515a1571308cc06136
Reviewed-on: http://review.couchbase.org/69326
Reviewed-by: Jim Walker <jim@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

MB-20586: Update memcached to use cb_malloc memory API

For all instances where we control C-style memory allocation, replace
with calls to cb_malloc/cb_realloc etc.

There are a

MB-20586: Update memcached to use cb_malloc memory API

For all instances where we control C-style memory allocation, replace
with calls to cb_malloc/cb_realloc etc.

There are a small number of instances where memory is allocated on our
behalf inside a library function, for example asprintf(). In such
cases we must still use free() to match the (internal) malloc().

Change-Id: I3e93d3a4bc2c8103e7da96ef448df1c226564528
Reviewed-on: http://review.couchbase.org/67087
Well-Formed: buildbot <build@couchbase.com>
Reviewed-by: Daniel Owen <owend@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

MB-20586: Use cJSON_Free to free cJSON_Print strings

Any strings created by cJSON_Print() need to use cJSON_Free() to free
it, not free().

Change-Id: Ie62efab4327f8e16dfe1615109

MB-20586: Use cJSON_Free to free cJSON_Print strings

Any strings created by cJSON_Print() need to use cJSON_Free() to free
it, not free().

Change-Id: Ie62efab4327f8e16dfe1615109f789e3c577950a
Reviewed-on: http://review.couchbase.org/67504
Well-Formed: buildbot <build@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>

show more ...

Refactor: C++ifying Settings

Refactor the parsing from C code to C++ and use exceptions
to signal errors.

Moved the reconfiguration logic out of the settings class,
so that

Refactor: C++ifying Settings

Refactor the parsing from C code to C++ and use exceptions
to signal errors.

Moved the reconfiguration logic out of the settings class,
so that you may subscribe to notifications when a value
change and handle the reconfigure of the value elsewhere.

Rewrote the unit tests to use gtest

Change-Id: I76417819d57e4cca924cc16752a322e860fe544f
Reviewed-on: http://review.couchbase.org/64898
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Remove unused possibility to disable admin

In that mode everyone would have admin privileges

Change-Id: I34997696959050f8189cd14588589c31ab0a37f3
Reviewed-on: http://review.couc

Remove unused possibility to disable admin

In that mode everyone would have admin privileges

Change-Id: I34997696959050f8189cd14588589c31ab0a37f3
Reviewed-on: http://review.couchbase.org/64649
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

Allow for dynamically change the SSL protocol support

The minimum protocol should be specified in memcached.json as
"ssl_minimum_protocol". The value is case insensitive and may
be o

Allow for dynamically change the SSL protocol support

The minimum protocol should be specified in memcached.json as
"ssl_minimum_protocol". The value is case insensitive and may
be one of the following:

TLSv1 Allow TLSv1, TLSv1.1 and TLSv1.2
TLSv1.1/TLSv1_1 Allow TLSv1.1 and TLSv1.2
TLSv1.2/TLSv1_2 Allow TLSv1.2

You may set the variable in ns_server by running:

./couchbase-cli server-eshell -c <clusterurl> -u Administrator -p password

and send the commands like:

ns_config:set(ssl_minimum_protocol, 'tlsv1.2').

Then you can verify that you can't connect by using the
openssl s_client utility:

$ openssl s_client -connect localhost:11996 -debug -tls1
$ openssl s_client -connect localhost:11996 -debug -tls1_1
$ openssl s_client -connect localhost:11996 -debug -tls1_2

Depending on what you set the minimum value to (and what's
supported by the underlying openssl) you may or may not be
able to open a connection.

Change-Id: I62313e7f11dd6e5f3f6d2a5147cbac6cad11e4d9
Reviewed-on: http://review.couchbase.org/61003
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Add config support for: dedupe_nmvb_maps

Change-Id: I010bafa90acb004878eab159ab6210245360290c
Reviewed-on: http://review.couchbase.org/60705
Tested-by: buildbot <build@couchbase.com>

Add config support for: dedupe_nmvb_maps

Change-Id: I010bafa90acb004878eab159ab6210245360290c
Reviewed-on: http://review.couchbase.org/60705
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

MB-18198: Allow for specifying management on interfaces

The interfaces marked as a management interface will be enabled
during startup (only allowing _admin to authenticate). The
int

MB-18198: Allow for specifying management on interfaces

The interfaces marked as a management interface will be enabled
during startup (only allowing _admin to authenticate). The
intended use case is that ns_server connects to this interface
and defines all of the buckets before it sends "init complete"
to memcached which cause memcached to open up the other
interfaces for traffic. (Please note that the logic described
here is not implemented yet)

Change-Id: I5dd9eb389bd7ab6d97c391b946ddf39797410636
Reviewed-on: http://review.couchbase.org/60178
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

Allow the user to specify the list of available mechs

This is done through setting "sasl_mechanisms" in the
configuration file.

Change-Id: I6f290cd199bc566479df358767f1fd9732a9c

Allow the user to specify the list of available mechs

This is done through setting "sasl_mechanisms" in the
configuration file.

Change-Id: I6f290cd199bc566479df358767f1fd9732a9c294
Reviewed-on: http://review.couchbase.org/58576
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

daemon/config_parse.cc: Potential leak of memory pointed to by 'content_str'

Fix issue reported by Clang Static Analyzer:

File: memcached/daemon/config_parse.cc
L

daemon/config_parse.cc: Potential leak of memory pointed to by 'content_str'

Fix issue reported by Clang Static Analyzer:

File: memcached/daemon/config_parse.cc
Location: line 848, column 9
Description: Potential leak of memory pointed to by 'content_str'

Change-Id: I37a418746396049be64b7e24a7bb1112e7ea402a
Reviewed-on: http://review.couchbase.org/57851
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Refactor: fix bad style on boolean expr

Don't compare a boolean variable to the values for
true or false.

Change-Id: I6252c5c209df55a8ca25646a2243b97a5bb7057c
Reviewed-on: h

Refactor: fix bad style on boolean expr

Don't compare a boolean variable to the values for
true or false.

Change-Id: I6252c5c209df55a8ca25646a2243b97a5bb7057c
Reviewed-on: http://review.couchbase.org/56855
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

MB-16063: Add support for connection timeout

Set the idle time to 5 minutes

Change-Id: I3faaa306d54b1825f84fdcd306cc5bd6873b3ca4
Reviewed-on: http://review.couchbase.org/56803

MB-16063: Add support for connection timeout

Set the idle time to 5 minutes

Change-Id: I3faaa306d54b1825f84fdcd306cc5bd6873b3ca4
Reviewed-on: http://review.couchbase.org/56803
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

afl-fuzz support.

1) Enable listening on stdin (writing back to stdout).

"stdin_listen" : true

This makes memcached listen to stdin (as well as the defined ports).
Deve

afl-fuzz support.

1) Enable listening on stdin (writing back to stdout).

"stdin_listen" : true

This makes memcached listen to stdin (as well as the defined ports).
Development only feature as it forces libevent to avoid epoll.

2) Enable exit on connection close.

"exit_on_connection_close" : true

This config switch means that when any connection close memcached
will exit(0). This is required for afl-fuzz as it expects the
process to exit cleanly when a test is complete.

So when memcached reads 0 bytes (EOF) from stdin it will close
the connection and in turn exit(0).

afl-fuzz knows then to start a new test.

Change-Id: Ifd8ba62e0938fcfd8c3799ffda61e7ed1cada4e5
Reviewed-on: http://review.couchbase.org/55862
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

Ignore obsolete "engine" parameter in the config

Change-Id: I943881aebfd1ede4664ec84b39364e626e24b976
Reviewed-on: http://review.couchbase.org/56046
Tested-by: buildbot <build@couchb

Ignore obsolete "engine" parameter in the config

Change-Id: I943881aebfd1ede4664ec84b39364e626e24b976
Reviewed-on: http://review.couchbase.org/56046
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Use LOG_ macros to make the code easier to read

Change-Id: Ic2f392825e4dc9befc8316d8aa040b9feed60311
Reviewed-on: http://review.couchbase.org/55960
Reviewed-by: Dave Rigby <daver@cou

Use LOG_ macros to make the code easier to read

Change-Id: Ic2f392825e4dc9befc8316d8aa040b9feed60311
Reviewed-on: http://review.couchbase.org/55960
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

MB-16257: Plug leak in audit by changing to cJSON_AddItemToObject

Change the way the real_userid sub-JSON block is added to the
payload so that it's correctly deleted.

Change-Id

MB-16257: Plug leak in audit by changing to cJSON_AddItemToObject

Change the way the real_userid sub-JSON block is added to the
payload so that it's correctly deleted.

Change-Id: Ia3cb83b45a12e0104d8cc805217a133008e4913a
Reviewed-on: http://review.couchbase.org/55177
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

Allow for specifying 0 for multiple ports

This allows for the test suite to let the operating system to
pick an available port for ssl. When we're going to start
testing Greenstack w

Allow for specifying 0 for multiple ports

This allows for the test suite to let the operating system to
pick an available port for ssl. When we're going to start
testing Greenstack we need even more sockets.

Change-Id: I8a5d8fafc300aeeeca66a18491297192b3f5ba01
Reviewed-on: http://review.couchbase.org/55138
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

MB-16056: Replace cb_assert in connection-related code with exceptions

Where applicable, replace cb_assert() on function preconditions /
arguments checks with std::invalid_argument / std

MB-16056: Replace cb_assert in connection-related code with exceptions

Where applicable, replace cb_assert() on function preconditions /
arguments checks with std::invalid_argument / std::logic_error

Change-Id: I139ccc428362787bea4c91def32a010d55e85a19
Reviewed-on: http://review.couchbase.org/54977
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

Refactor: use getter/setter for next member

Change-Id: I947222cf35e37e8447572dedf596ec2b4e72859e
Reviewed-on: http://review.couchbase.org/53703
Tested-by: buildbot <build@couchbase.c

Refactor: use getter/setter for next member

Change-Id: I947222cf35e37e8447572dedf596ec2b4e72859e
Reviewed-on: http://review.couchbase.org/53703
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Use std::limits instead of stdint/ UINT16_MAX

Patch only exists as I've a broken debian7 build where this wasn't
defined, yet same source on ubuntu1404 was fine.

Seems cleaner g

Use std::limits instead of stdint/ UINT16_MAX

Patch only exists as I've a broken debian7 build where this wasn't
defined, yet same source on ubuntu1404 was fine.

Seems cleaner given recent C++ conversions and gets me building again
and hopefully prevents anyone else wasting time if they hit the same
environmental issue I did.

Change-Id: I33b1334ce4717abf0ed3cb6a19688b94305dec7f
Reviewed-on: http://review.couchbase.org/53678
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Refactor: protect parent_port behind getter/setter

Change-Id: I4a271a54554d2fdf7a77dfe7ef5e6eac73abe4c1
Reviewed-on: http://review.couchbase.org/53593
Tested-by: buildbot <build@couc

Refactor: protect parent_port behind getter/setter

Change-Id: I4a271a54554d2fdf7a77dfe7ef5e6eac73abe4c1
Reviewed-on: http://review.couchbase.org/53593
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Refactor: Hide sfd behind getter/setter

In addition to that use "getId()" to get an identifier for
the object that is a uin32_t cast of the socket descriptor
to make it easier for th

Refactor: Hide sfd behind getter/setter

In addition to that use "getId()" to get an identifier for
the object that is a uin32_t cast of the socket descriptor
to make it easier for the log formatting

Change-Id: I4e05b03c0fcfcac64f55b2beecc48d0e79d27539
Reviewed-on: http://review.couchbase.org/53584
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...