History log of /5.5.2/kv_engine/engines/ep/src/collections/vbucket_manifest_entry.cc (Results 1 - 25 of 33)
Revision (<<< Hide revision tags) (Show revision tags >>>) Date Author Comments
Revision tags: v7.0.2, v6.6.3, v7.0.1, v7.0.0, v6.6.2, v6.5.2, v6.6.1, v6.0.5, v6.6.0, v6.5.1, v6.0.4, v6.5.0, v6.0.3, v5.5.4, v5.5.5, v5.5.6, v6.0.1, v5.5.3, v6.0.0, v5.1.3, v5.5.2, v5.5.1, v5.1.2, v5.1.1, v5.0.1, v5.1.0, v5.0.0
# be1b54aa 06-Sep-2017 Jim Walker <jim@couchbase.com>

MB-25342: Refactor VB::Manifest::completeDelete

Move the completeDeletion logic into ManifestEntry and
clean up the exception logic so we have more consistent
exceptions.

Ch

MB-25342: Refactor VB::Manifest::completeDelete

Move the completeDeletion logic into ManifestEntry and
clean up the exception logic so we have more consistent
exceptions.

Change-Id: I74f32aeecd5f6eeb9bb6fb46acbb10a0e9d4c5a9
Reviewed-on: http://review.couchbase.org/83228
Reviewed-by: Daniel Owen <owend@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


# 9160b844 04-Aug-2017 Jim Walker <jim@couchbase.com>

MB-25342: Introduce Collection::uid to the VB::Manifest

Many functions on VB::Manifest required the caller to specify the name
and a uint32_t as separate parameters when trying to identi

MB-25342: Introduce Collection::uid to the VB::Manifest

Many functions on VB::Manifest required the caller to specify the name
and a uint32_t as separate parameters when trying to identify a
collection. This is now cleaned up so that a new class is used when
identifying a specific 'generation' of a collection.

As part of this new class we are removing the use of 'revision' and
replacing it with 'uid', however we use the Manifest::revision as
the uid and later changes will change the Manifest format so that each
collection is assigned a uid.

As part of the clean-up of revision usage this commit fixes some short
comings in the VB::Manifest management where a delete of a collection
was updating it's revision, forcing later callers of completeDeletion
to use the newer revision, instead of referring to the collection by
the correct name:rev from when it was created.

This commit additionally cleans up the separator changed path which
was needlessly passing the revision through the various code paths and
even over DCP. There is no need it was set and never read.

Change-Id: I0d81ccb9a7c7b7505d0f021b284b368f7a60f88e
Reviewed-on: http://review.couchbase.org/81984
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


# ef22f9b0 25-May-2017 Dave Rigby <daver@couchbase.com>

Move ep-engine to engines/ep


Revision tags: v4.6.2_ep, v4.6.2_mc, v4.6.1_ep
# 3a9c4c4e 12-Jan-2017 Jim Walker <jim@couchbase.com>

MB-16181: Add Collections::VB::ManifestEntry

A class that stores a single collection for a VBucket.

We store

- the name
- the seqno it was added
- the seqno it was

MB-16181: Add Collections::VB::ManifestEntry

A class that stores a single collection for a VBucket.

We store

- the name
- the seqno it was added
- the seqno it was deleted
- the Collections::Manifest revision which added it

Change-Id: Iaa3a1ae3c6405572680361e885ca7a52879ffd0f
Reviewed-on: http://review.couchbase.org/72459
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


# cab1f89e 12-Jan-2017 Jim Walker <jim@couchbase.com>

MB-16181: Add Collections::Manifest

A class which can convert a JSON manifest into something usable
by other parts of the code.

Change-Id: I2201457539ad9172002d5ff07d767ccf8d88b

MB-16181: Add Collections::Manifest

A class which can convert a JSON manifest into something usable
by other parts of the code.

Change-Id: I2201457539ad9172002d5ff07d767ccf8d88b7ec
Reviewed-on: http://review.couchbase.org/72457
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


Revision tags: v4.6.0_ep, v4.5.1-MP1_mc, v4.6.0-DP_mc, v4.6.0-DP_ep, v4.5.1-MP1_ep, v4.1.2-MP2_mc, v4.5.1_mc
# d02d8c21 12-Aug-2016 Dave Rigby <daver@couchbase.com>

Remove hooksApi global; reduce coupling with MemoryTracker

MemoryTracker is somewhat tightly coupled with ep_engine.cc as it uses
the getHooksApi() function to obtain the memory allocato

Remove hooksApi global; reduce coupling with MemoryTracker

MemoryTracker is somewhat tightly coupled with ep_engine.cc as it uses
the getHooksApi() function to obtain the memory allocator hooks.

Firstly this makes it hard to test - compile one file and you have to
include the other, and it's also difficult to provide a different
hooks api - either for injecting a mock one for testing, or simply to
use the 'normal' hooks API but without pulling in ep-engine.

Secondly, there is unnecessary indirection in NewHook / DeleteHook -
which are called on every new/delete so performance is relevant
there. By giving the MemoryTracker it's own copy of the alloc_hooks
(instead of calling getHooksApi() on every call) we can reduce the
amount of work in NewHook / DeleteHook by approx. 50% (measured in
terms of x64 instructions).

Change-Id: Ia0f8ebb0a5263567dc08b32fe6ff9b7ea9eefa92
Reviewed-on: http://review.couchbase.org/68210
Reviewed-by: Daniel Owen <owend@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...


Revision tags: v4.6.0_mc, v4.1.2-MP1_ep, v3.1.6_ep, v4.5.0_mc, v4.5.0_ep, v4.1.1_ep, v3.1.5_ep, v4.1.1_mc
# 66bb41ad 04-Mar-2016 Dave Rigby <daver@couchbase.com>

Remove AtomicValue and Mutex defines

We already removed our own custom AtomicValue and Mutex classes when
we moved to C++11; replacing them with #defines to std::atomic and
std::mute

Remove AtomicValue and Mutex defines

We already removed our own custom AtomicValue and Mutex classes when
we moved to C++11; replacing them with #defines to std::atomic and
std::mutex respectively. This patch completes that changover, using
the underlying types directly so it's easier to see what is actually
being used.

Change-Id: If3f717f766727042cd81ae7b8c65f9a19934f2fa
Reviewed-on: http://review.couchbase.org/60925
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Will Gardner <will.gardner@couchbase.com>

show more ...


Revision tags: v3.1.4_ep, v3.1.4_mc, v3.1.5_mc, v3.1.3_ep
# b9334207 30-Nov-2015 Dave Rigby <daver@couchbase.com>

Mutex modernization [2/2]: Use std::condition_variable for SyncObject

Change Mutex to a typedef to std::mutex, and use
std::condition_variable for the implementation of SyncObject.

Mutex modernization [2/2]: Use std::condition_variable for SyncObject

Change Mutex to a typedef to std::mutex, and use
std::condition_variable for the implementation of SyncObject.

Note these two changes are mutually dependent hence being done in the
same patch.

Change-Id: Ife74822e9c4e04efefff446e964a952b672a1f91
Reviewed-on: http://review.couchbase.org/57328
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# df3730be 30-Nov-2015 Dave Rigby <daver@couchbase.com>

Mutex modernization [1/2]: Replace with std::mutex

Update the API of Mutex to match that of std::mutex, and SyncObject to
match that of std::condition_variable in preparation for replaci

Mutex modernization [1/2]: Replace with std::mutex

Update the API of Mutex to match that of std::mutex, and SyncObject to
match that of std::condition_variable in preparation for replacing
Mutex and SyncObject with the C++11 standard library equivilents.

Change-Id: I5625d980b11144f681f7e717df87c8b5f323dc7c
Reviewed-on: http://review.couchbase.org/57327
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...


Revision tags: v4.1.0_ep
# 44137813 05-Nov-2015 Dave Rigby <daver@couchbase.com>

Simplify common.h: add utility.h [2/3]

Create a new utility.h header file and move some of the functions /
macros which virtually everyone uses to there. utility.h has
significantly

Simplify common.h: add utility.h [2/3]

Create a new utility.h header file and move some of the functions /
macros which virtually everyone uses to there. utility.h has
significantly fewer dependancies, and such is much cheaper to include
than common.h

Update users of these functions / macros (DISALLOW_COPY_ON_ASSIGN, LOG
etc) to use utility.h instead of common.h

Change-Id: I3f93435c82950bd2a20b416af2b2e5011a931e04
Reviewed-on: http://review.couchbase.org/56704
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


Revision tags: v3.1.2_ep, v4.1.0_mc, v3.1.2_mc, v3.1.1_mc, v3.1.1_ep, v4.0.0_ep, v4.0.0_mc, v3.1.0_ep, v3.1.0_mc, v3.1.6_mc, v3.0.2-MP2_mc, v3.0.2_ep, v3.0.2_mc, v3.0.1_mc, v3.0.0_ep, v3.0.0-beta3_mc, v3.0.0_mc, v3.0.0-beta2_mc
# 08276dd4 26-Jul-2014 Chiyoung Seo <chiyoung.seo@gmail.com>

MB-11731 Reduce the lock overhead among flusher, VB deletion, and compaction

This change reduces the lock blocking overhead among flusher, vbucket
deletion, compaction, and snapshot task

MB-11731 Reduce the lock overhead among flusher, VB deletion, and compaction

This change reduces the lock blocking overhead among flusher, vbucket
deletion, compaction, and snapshot tasks, by skipping the rest of
tasks if a lock is already grabbed by one task.

Change-Id: I643d7fe74150b5ead5c1368d660deb3c64dd1d01
Reviewed-on: http://review.couchbase.org/39910
Reviewed-by: David Liao <david.liao@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


Revision tags: v3.0.0-beta1_mc, v2.5.1_ep, v2.5.1-MP1-A_mc, v2.5.0_mc, v2.5.0-dp1_mc
# 1b2a19ba 06-Nov-2013 Trond Norbye <trond.norbye@gmail.com>

call cb_thread_self instead of pthread_self

Change-Id: I2509b9710b0caa0324ec39a18cf82cd8cb1751b8
Reviewed-on: http://review.couchbase.org/30092
Reviewed-by: Trond Norbye <trond.norby

call cb_thread_self instead of pthread_self

Change-Id: I2509b9710b0caa0324ec39a18cf82cd8cb1751b8
Reviewed-on: http://review.couchbase.org/30092
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


# ad9cc7e3 04-Nov-2013 Trond Norbye <trond.norbye@gmail.com>

Use our own mutex abstraction

Change-Id: I12faa0016977e1d5b08cdd05f509aebf71a5bbb8
Reviewed-on: http://review.couchbase.org/30014
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

Use our own mutex abstraction

Change-Id: I12faa0016977e1d5b08cdd05f509aebf71a5bbb8
Reviewed-on: http://review.couchbase.org/30014
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# 4db168a3 03-Nov-2013 Trond Norbye <trond.norbye@gmail.com>

Use our thread abstraction layer

Change-Id: I5d52d55ea603d8e53c9b39a94fa3029cdad50748
Reviewed-on: http://review.couchbase.org/30013
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com

Use our thread abstraction layer

Change-Id: I5d52d55ea603d8e53c9b39a94fa3029cdad50748
Reviewed-on: http://review.couchbase.org/30013
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


Revision tags: v2.2.0_mc, 2.1.1r_ep, 2.1.0r_ep, 2.0.2r_ep, 2.0.2r_mc, 2.0.1-macosx_ep, 2.0.1-linux_ep
# 66eb94d0 17-Jan-2013 Mike Wiederhold <mike@couchbase.com>

MB-7728: Add copyright headers to all files

This is something that our cpplint tool turns on and it makes
our product look a little bit more profesional. I have also
enabled the tool

MB-7728: Add copyright headers to all files

This is something that our cpplint tool turns on and it makes
our product look a little bit more profesional. I have also
enabled the tool to begin checking for these headers so it will
start complaining if we add a new file without a copyright header.

Change-Id: Ie956fdf7027bf56d9665ee455acd3c109fcacc76
Reviewed-on: http://review.couchbase.org/24560
Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Reviewed-by: Jin Lim <jin@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


Revision tags: 2.0.1-linux_mc, 2.0.0-couchbase_ep
# 244c0146 26-Nov-2012 Mike Wiederhold <mike@couchbase.com>

MB-7461: Alphabetize includes to conform with c++ standards

Change-Id: I71333dedada6530713b90184857bab9ac49d13df
Reviewed-on: http://review.couchbase.org/23515
Reviewed-by: Jin Lim <

MB-7461: Alphabetize includes to conform with c++ standards

Change-Id: I71333dedada6530713b90184857bab9ac49d13df
Reviewed-on: http://review.couchbase.org/23515
Reviewed-by: Jin Lim <jin@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


# 8f48f64b 23-Nov-2012 Mike Wiederhold <mike@couchbase.com>

MB-7426: Fix all header defines to conform with cpplint

Change-Id: I8253b640bc49ee8a0fabbb39ece73c2efdb906d5
Reviewed-on: http://review.couchbase.org/23510
Reviewed-by: Michael Wiede

MB-7426: Fix all header defines to conform with cpplint

Change-Id: I8253b640bc49ee8a0fabbb39ece73c2efdb906d5
Reviewed-on: http://review.couchbase.org/23510
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


# fc9615cd 23-Nov-2012 Mike Wiederhold <mike@couchbase.com>

MB-7405: Make extension for all header files .h

Change-Id: I7badb1e71c038b6498296c2893ccdbd47c2f0f87
Reviewed-on: http://review.couchbase.org/23483
Reviewed-by: Michael Wiederhold <m

MB-7405: Make extension for all header files .h

Change-Id: I7badb1e71c038b6498296c2893ccdbd47c2f0f87
Reviewed-on: http://review.couchbase.org/23483
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


Revision tags: 2.0.1-macosx_mc, v2.0.0_mc
# e63b0310 27-Sep-2012 Mike Wiederhold <mike@couchbase.com>

MB-7392: DISALLOW_COPY_AND_ASSIGN() should be private

Change-Id: I7a3ef1403518643aac9b7ecdab1d14cfe18deff8
Reviewed-on: http://review.couchbase.org/23416
Reviewed-by: Michael Wiederh

MB-7392: DISALLOW_COPY_AND_ASSIGN() should be private

Change-Id: I7a3ef1403518643aac9b7ecdab1d14cfe18deff8
Reviewed-on: http://review.couchbase.org/23416
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


Revision tags: v2.0.0-beta_mc, 1.8.1-MB-5845_ep
# bf3b555b 15-Aug-2012 Mike Wiederhold <mike@couchbase.com>

MB-6141: Move ep-engine source files into src directory

Change-Id: I6068c3aa7bc92d45bce4dd3097079665d807ac75
Reviewed-on: http://review.couchbase.org/19664
Reviewed-by: Michael Wiede

MB-6141: Move ep-engine source files into src directory

Change-Id: I6068c3aa7bc92d45bce4dd3097079665d807ac75
Reviewed-on: http://review.couchbase.org/19664
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...


Revision tags: 2.0.0r_ep, 1.8.1_ep, v1.8.1_mc, 1.8-MB-4901_ep, v2.0.0-dp4_mc, 1.8-MB-4738_ep, 1.8.1r_ep, 1.8.0_ep
# efa6a28b 13-Dec-2011 Trond Norbye <trond.norbye@gmail.com>

Add probes for our mutexes

Change-Id: Ide2be00c4b0af05796f66ec87b1c8b9286017efa
Reviewed-on: http://review.couchbase.org/11628
Tested-by: Dustin Sallings <dustin@spy.net>
Reviewe

Add probes for our mutexes

Change-Id: Ide2be00c4b0af05796f66ec87b1c8b9286017efa
Reviewed-on: http://review.couchbase.org/11628
Tested-by: Dustin Sallings <dustin@spy.net>
Reviewed-by: Dustin Sallings <dustin@spy.net>

show more ...


Revision tags: 1.8.0r_ep, 1.6.5.6_ep, 1.7.3r_ep, 1.7.2_ep, 1.7.1.1_ep, 1.6.5.5r_ep, 1.7.1_ep, 1.7.0_ep, 1.6.5.4_ep, v1.7.0_mc, 1.6.5.3.1_ep, 1.6.5.3_ep, v1.6.5.3_mc, 1.6.5.2.1_ep, 1.6.5.2_ep, v1.6.5.2_mc, 1.6.5.3r_ep, 1.6.5.2r_ep, 1.6.5.1_ep, v1.6.5.1_mc, 1.6.5.1r_ep, 1.7.0r_ep, 1.6.5_ep, 1.6.5r_ep, 1.6.4.1.1_ep, 1.6.4.1_ep, 1.6.4_ep, 1.6.3_ep, 1.6.4r_ep, 1.6.3r_ep, 1.6.2_ep, 1.6.1_ep, 1.6.1rc2_ep
# 24260eef 25-Oct-2010 Dustin Sallings <dustin@spy.net>

Mutex owner tracking API for lock assertions.

Gerrit got kind of confused and wouldn't let me submit updates to this
in its previous life. This was http://review.membase.org/3705

Mutex owner tracking API for lock assertions.

Gerrit got kind of confused and wouldn't let me submit updates to this
in its previous life. This was http://review.membase.org/3705

Change-Id: I25c091c59d28689365a3292036b5351ead588bee
Reviewed-on: http://review.membase.org/6467
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Dustin Sallings <dustin@spy.net>

show more ...


# 2c5720e3 17-Nov-2010 Trond Norbye <trond.norbye@gmail.com>

Use PTHREAD_MUTEX_ERRORCHECK if the system supports it

Change-Id: I115288572df71c509857b54d121b926c6f03cef5
Reviewed-on: http://review.membase.org/3708
Tested-by: Dustin Sallings <du

Use PTHREAD_MUTEX_ERRORCHECK if the system supports it

Change-Id: I115288572df71c509857b54d121b926c6f03cef5
Reviewed-on: http://review.membase.org/3708
Tested-by: Dustin Sallings <dustin@spy.net>
Reviewed-by: Dustin Sallings <dustin@spy.net>

show more ...


Revision tags: 1.6.0.4_ep, 1.6.0.3_ep, 1.6.1rc1_ep, 1.6.0.2_ep, 1.6.1pre_ep, 1.6.0.1_ep, 1.6.0_ep, 1.6.0beta4_ep, 1.6.0beta4rc1_ep, 1.6.0beta3.2b_ep, 1.6.0beta3.1_ep, 1.6.0beta3_ep, 1.6.0beta3c_ep, 1.6.0beta3b_ep, 1.6.0beta3a_ep
# db2e2b13 20-Jul-2010 Trond Norbye <trond.norbye@gmail.com>

Disable extra mutex check for win32

The pthread implementation we use on win32 doesn't support the
construct: pthread_t id = pthread_self();

The code is just an extra error chec

Disable extra mutex check for win32

The pthread implementation we use on win32 doesn't support the
construct: pthread_t id = pthread_self();

The code is just an extra error check added at a time we had weird
mutex problems, and not really necessary for the code to work. If we
have mutex problems on win32 we should figure out how to implement the
same functionality on win32.

Change-Id: I6035b9e5ddf1441dc25f4ffd61d10e47b6bbf4c0
Reviewed-on: http://review.northscale.com/1279
Reviewed-by: Dustin Sallings <dustin@spy.net>
Tested-by: Dustin Sallings <dustin@spy.net>

show more ...


Revision tags: 1.6.0beta2_ep, 1.6.0beta2rc2_ep, 1.6.0beta2rc1_ep, 1.6.0beta1.1_ep, 1.6.0beta1_ep, 1.6.0beta1rc2_ep, 1.6.0a1_ep, 1.6.0a2_ep, 1.6.0a_ep
# 13fa5cd0 23-May-2010 Dustin Sallings <dustin@spy.net>

Use a LockHolder whenever a lock should be held.

This prevents issues where a lock is mistakenly released twice because
LockHolder doesn't know the lock isn't held by the current thread.

Use a LockHolder whenever a lock should be held.

This prevents issues where a lock is mistakenly released twice because
LockHolder doesn't know the lock isn't held by the current thread.

Change-Id: I8e701038145e2a64c73a53d24051cb578bc93d0d
Reviewed-on: http://review.northscale.com:8080/144
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


12