MB-25929[2/3]: Replace ep-eng hrtime2text() with platform time2text()

Replace uses of hrtime2text(ep/src/common.h) with cb::time2text()
from platform (platform/src/timeutils.h), which is

MB-25929[2/3]: Replace ep-eng hrtime2text() with platform time2text()

Replace uses of hrtime2text(ep/src/common.h) with cb::time2text()
from platform (platform/src/timeutils.h), which is the improved
version of Couchbase::hrtime2text(). Remove the ep-engine method
and its tests.

Change-Id: I75967ae2982b6b07c381790710e274ad354f653b
Reviewed-on: http://review.couchbase.org/83310
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Daniel Owen <owend@couchbase.com>

show more ...

Move ep-engine to engines/ep

Remove unused functions from common.h

Also removes a now defunct test.

Change-Id: I322684836e7a4be3ffde129eb63188b889272036
Reviewed-on: http://review.couchbase.org/71032
Te

Remove unused functions from common.h

Also removes a now defunct test.

Change-Id: I322684836e7a4be3ffde129eb63188b889272036
Reviewed-on: http://review.couchbase.org/71032
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

MB-21540: ep-engine: Remove abort()

Final set of changes to remove abort() from ep_engine production code;
replacing with exceptions where a dynamic error is still required.

All

MB-21540: ep-engine: Remove abort()

Final set of changes to remove abort() from ep_engine production code;
replacing with exceptions where a dynamic error is still required.

All non-test ep-engine code is now abort-free :)

Change-Id: I9702b6bbaf28267b696498067318e78af0988002
Reviewed-on: http://review.couchbase.org/69376
Reviewed-by: Daniel Owen <owend@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

MB-18476: Handle write failures more gracefully in the mutation log

Log and error message in case of a write failure and remove any unnecessary
asserts in that code path

Change-

MB-18476: Handle write failures more gracefully in the mutation log

Log and error message in case of a write failure and remove any unnecessary
asserts in that code path

Change-Id: I50b7e4de4d414e21bf00404a22863baff06c0f4f
Reviewed-on: http://review.couchbase.org/61116
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

Simplify common.h: Remove unnecessary headers [3/3]

Remove all #includes which arn't actually needed by the file including
them (aka "include what you use").

Reduces build time

Simplify common.h: Remove unnecessary headers [3/3]

Remove all #includes which arn't actually needed by the file including
them (aka "include what you use").

Reduces build time down from before this patch series from:

31.82 real 222.13 user 16.09 sys

down to:

26.95 real 188.54 user 13.29 sys

giving a 15% speedup in (user+sys).

(Built using `make clean && CCACHE_DISABLE=1 time make -j8`)

Change-Id: Ia47f08487d20c94167d93de8dd6590f7703dd898
Reviewed-on: http://review.couchbase.org/56705
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Manu Dhundi <manu@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

Simplify common.h: add utility.h [2/3]

Create a new utility.h header file and move some of the functions /
macros which virtually everyone uses to there. utility.h has
significantly

Simplify common.h: add utility.h [2/3]

Create a new utility.h header file and move some of the functions /
macros which virtually everyone uses to there. utility.h has
significantly fewer dependancies, and such is much cheaper to include
than common.h

Update users of these functions / macros (DISALLOW_COPY_ON_ASSIGN, LOG
etc) to use utility.h instead of common.h

Change-Id: I3f93435c82950bd2a20b416af2b2e5011a931e04
Reviewed-on: http://review.couchbase.org/56704
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

Simplify common.h: Remove unused headers [1/3]

common.h is included by a large number of files in ep-engine,
furthermore it's a pretty large and complex file. This unnecessarily
slow

Simplify common.h: Remove unused headers [1/3]

common.h is included by a large number of files in ep-engine,
furthermore it's a pretty large and complex file. This unnecessarily
slows down compilation.

First patch removes <unordered_set>, <unordered_map> and <memory> from
common.h, adding them only to the files which actually use them.

Change-Id: I270e7cd921982a1db3053af19afe3a31a09e12e1
Reviewed-on: http://review.couchbase.org/56703
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Manu Dhundi <manu@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

Remove tr1 (pre-C++11) code

There are a few remnents of pre-C++11 code in ep-engine - support for
technical report 1 (tr1) versions of unordered_map,
unordered_set. Given we now requ

Remove tr1 (pre-C++11) code

There are a few remnents of pre-C++11 code in ep-engine - support for
technical report 1 (tr1) versions of unordered_map,
unordered_set. Given we now require C++11 (and have for a while),
remove this.

Change-Id: I93553c0474accf9585f4a32ac677c39262b00765
Reviewed-on: http://review.couchbase.org/56701
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Manu Dhundi <manu@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

MB-16056: Use exceptions instead of cb_assert() [1]

First set of changes to migrate away from cb_assert() and use
exceptions where applicable for invalid input / logic errors.

C

MB-16056: Use exceptions instead of cb_assert() [1]

First set of changes to migrate away from cb_assert() and use
exceptions where applicable for invalid input / logic errors.

Covers: access_scanner, backfill, bloomfilter, checkpoint, common.h,
configuration, connmap

Change-Id: I8c6fb8f8db4fc5a1a604107afe28ed73ce491082
Reviewed-on: http://review.couchbase.org/54991
Reviewed-by: Jim Walker <jim@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

Add util function getJSONObjString to common.h

The function getJSONObjString is being used in multiple places.
Add this utility function to common.h.

Change-Id: I4019f9525f9c62f

Add util function getJSONObjString to common.h

The function getJSONObjString is being used in multiple places.
Add this utility function to common.h.

Change-Id: I4019f9525f9c62f398e61203650bd8315168adee
Reviewed-on: http://review.couchbase.org/54367
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Reviewed-by: Manu Dhundi <manu@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

Enable CB_FORMAT_PRINTF on LOG(), fix warnings

As LOG() takes a printf-style format string, annotate it with the
CB_FORMAT_PRINTF macro which enables compiler warnings on mismatches

Enable CB_FORMAT_PRINTF on LOG(), fix warnings

As LOG() takes a printf-style format string, annotate it with the
CB_FORMAT_PRINTF macro which enables compiler warnings on mismatches
between the format string and arguments. Fix all the usage errors in
ep-engine flagged by this.

Change-Id: Ie9a46caf5fd7ba182b61e6078e49f30a8cab1aa7
Reviewed-on: http://review.couchbase.org/53874
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

MB-15628: Stop all warmup tasks upon interruption

Warmup spins off a shard number of tasks in every phase.
Therefore upon interruption (for e.g bucket deletion),
all those tasks need

MB-15628: Stop all warmup tasks upon interruption

Warmup spins off a shard number of tasks in every phase.
Therefore upon interruption (for e.g bucket deletion),
all those tasks need to be cancelled.

Change-Id: Ic9b5c90df2c914a33714820df45959ce96137f30
Reviewed-on: http://review.couchbase.org/53051
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>

show more ...

MB-12926: Generate CAS using Hybrid Logical Clock (HLC)

Add configuration option for time_synchronization. Disabled
by default. Generate CAS using HLC if time_sync is enabled. Add
ma

MB-12926: Generate CAS using Hybrid Logical Clock (HLC)

Add configuration option for time_synchronization. Disabled
by default. Generate CAS using HLC if time_sync is enabled. Add
max_cas and drift counter for vbucket and persist the same

Change-Id: Ibb905dc1ad847fda6313afcef34994e58e00caa8
Reviewed-on: http://review.couchbase.org/44988
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Sriram Ganesan <sriram@couchbase.com>

show more ...

Add explicit Item copy-constructor, reduce uses of value_t constructor

Further refactor and simplify Item construction:

- Add an explicit Item copy-constructor for use when copying

Add explicit Item copy-constructor, reduce uses of value_t constructor

Further refactor and simplify Item construction:

- Add an explicit Item copy-constructor for use when copying items
(e.g. MutationResponse).

- Change uses of Blob-passing constructor to just use the {char* data,
size_t len} variant instead - in three use-cases the client just
creates a Blob immediately before calling the constructor; might as
well let the consturctor do the work.

This reduces the users of the Blob-passing constructor to one -
StoredValue::toItem(). This already has a value_t and so we do want to
make the new Item point to it, hence can't change this to use the
{data, len} variant.

Change-Id: I7c0ff575da70b24290c49d371e1aff14ef160d55
Reviewed-on: http://review.couchbase.org/42626
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...

MB-10539: use less than eq comparison in wake()

ExecutorPool::wake() was wrongly using less_tv()
in its wake routine, resulting in un-woken tasks
This was causing large delays in sch

MB-10539: use less than eq comparison in wake()

ExecutorPool::wake() was wrongly using less_tv()
in its wake routine, resulting in un-woken tasks
This was causing large delays in scheduling
Fix by using less_eq_tv

Change-Id: I52e97c6308c70cfc415dd731a50dc8e00a7d834a
Reviewed-on: http://review.couchbase.org/35586
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: Sundararaman Sridharan <sundar@couchbase.com>

show more ...

MB-10476: Use cb_assert instead of assert

If compiled with -DNDEBUG assert is an empty macro

Change-Id: I266ddf8a8fe3f1a388a9d8ce3d21f28614c35315
Reviewed-on: http://review.couc

MB-10476: Use cb_assert instead of assert

If compiled with -DNDEBUG assert is an empty macro

Change-Id: I266ddf8a8fe3f1a388a9d8ce3d21f28614c35315
Reviewed-on: http://review.couchbase.org/34579
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

MB-9645: Workaround for broken c++ compilers

<unordered_map> should be part of C++11, but the clang 4.1.0
defines __cplusplus claiming it support it, but doesn't contain
the header..

MB-9645: Workaround for broken c++ compilers

<unordered_map> should be part of C++11, but the clang 4.1.0
defines __cplusplus claiming it support it, but doesn't contain
the header..

Change-Id: I8503d1fdb996b393d9f40d1ef8821afbf6930ba0
Reviewed-on: http://review.couchbase.org/30665
Reviewed-by: Sundararaman Sridharan <sundar.sridharan@gmail.com>
Tested-by: Sundararaman Sridharan <sundar.sridharan@gmail.com>

show more ...

Fix compile errors from cmake move

Change-Id: I626835f4bbe4ba58cdd00ac9d2603bb445583479
Reviewed-on: http://review.couchbase.org/30476
Reviewed-by: David Liao <david.liao@couchbase.c

Fix compile errors from cmake move

Change-Id: I626835f4bbe4ba58cdd00ac9d2603bb445583479
Reviewed-on: http://review.couchbase.org/30476
Reviewed-by: David Liao <david.liao@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

Transition to CMake

Change-Id: I949c21c2420ad4bdd917dc14b1f1ea9c69d876a4
Reviewed-on: http://review.couchbase.org/29983
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-

Transition to CMake

Change-Id: I949c21c2420ad4bdd917dc14b1f1ea9c69d876a4
Reviewed-on: http://review.couchbase.org/29983
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Use our own condition variable impl

Change-Id: Iad2ce85335fa9d5737fc39282e7429e6bb94c441
Reviewed-on: http://review.couchbase.org/30015
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.

Use our own condition variable impl

Change-Id: Iad2ce85335fa9d5737fc39282e7429e6bb94c441
Reviewed-on: http://review.couchbase.org/30015
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

Simplify logic for shared_ptr and unordered_map

Just check if the headers exists during configure.

Compilers with support for c++11 will use the one
part of the standard, the ot

Simplify logic for shared_ptr and unordered_map

Just check if the headers exists during configure.

Compilers with support for c++11 will use the one
part of the standard, the others will use the
ones in tr1 (that would be for g++/clang++)

Change-Id: I18d88eff0927fc255e4cc1ce66eb4da42d45930d
Reviewed-on: http://review.couchbase.org/29967
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

Add missing include for c++11

Change-Id: Ibaf61792254122d0e18337c0ebb03d957b79d367
Reviewed-on: http://review.couchbase.org/29891
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

Add missing include for c++11

Change-Id: Ibaf61792254122d0e18337c0ebb03d957b79d367
Reviewed-on: http://review.couchbase.org/29891
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Allow compilation with clang++

Change-Id: Ie622380456cfcb51615bdb5eea1be04b12383d3a
Reviewed-on: http://review.couchbase.org/29723
Reviewed-by: Michael Wiederhold <mike@couchbase.com

Allow compilation with clang++

Change-Id: Ie622380456cfcb51615bdb5eea1be04b12383d3a
Reviewed-on: http://review.couchbase.org/29723
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

Use implementations from platform lib

Change-Id: Ic92b3960d73c4f6c89e43491031d386f41754b46
Reviewed-on: http://review.couchbase.org/29578
Tested-by: buildbot <build@couchbase.com>

Use implementations from platform lib

Change-Id: Ic92b3960d73c4f6c89e43491031d386f41754b46
Reviewed-on: http://review.couchbase.org/29578
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Michael Wiederhold <mike@couchbase.com>

show more ...