Move ep-engine to engines/ep

Debug: Add dump() methods to VBucket/SeqList

Add a number of dump() and operator<< methods to dump textual
representation of the class, to aid in debugging.

Change-Id: I4cb3f63f

Debug: Add dump() methods to VBucket/SeqList

Add a number of dump() and operator<< methods to dump textual
representation of the class, to aid in debugging.

Change-Id: I4cb3f63f69d85cab11e1682d82a5ebc562843047
Reviewed-on: http://review.couchbase.org/75148
Reviewed-by: David Haikney <david.haikney@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

MB-21916: StoredDocKey - A DocKey container and test code

This commit introduces StoredDocKey - a container to replace
our use of std::string for document keys. The container can be used

MB-21916: StoredDocKey - A DocKey container and test code

This commit introduces StoredDocKey - a container to replace
our use of std::string for document keys. The container can be used
in std::map/set etc... and allows for us to store all items that are
needed to reference a document.

- the key (and the key size)
- the document namespace (a critical piece for Collections)

StoredDocKey will store a key of n-bytes in an n+1 std::string.
The extra byte is where we store the DocNamespace.

Change-Id: I1221e55d0081427c5f477773234ebbab482a6226
Reviewed-on: http://review.couchbase.org/70680
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

Remove hooksApi global; reduce coupling with MemoryTracker

MemoryTracker is somewhat tightly coupled with ep_engine.cc as it uses
the getHooksApi() function to obtain the memory allocato

Remove hooksApi global; reduce coupling with MemoryTracker

MemoryTracker is somewhat tightly coupled with ep_engine.cc as it uses
the getHooksApi() function to obtain the memory allocator hooks.

Firstly this makes it hard to test - compile one file and you have to
include the other, and it's also difficult to provide a different
hooks api - either for injecting a mock one for testing, or simply to
use the 'normal' hooks API but without pulling in ep-engine.

Secondly, there is unnecessary indirection in NewHook / DeleteHook -
which are called on every new/delete so performance is relevant
there. By giving the MemoryTracker it's own copy of the alloc_hooks
(instead of calling getHooksApi() on every call) we can reduce the
amount of work in NewHook / DeleteHook by approx. 50% (measured in
terms of x64 instructions).

Change-Id: Ia0f8ebb0a5263567dc08b32fe6ff9b7ea9eefa92
Reviewed-on: http://review.couchbase.org/68210
Reviewed-by: Daniel Owen <owend@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

Remove AtomicValue and Mutex defines

We already removed our own custom AtomicValue and Mutex classes when
we moved to C++11; replacing them with #defines to std::atomic and
std::mute

Remove AtomicValue and Mutex defines

We already removed our own custom AtomicValue and Mutex classes when
we moved to C++11; replacing them with #defines to std::atomic and
std::mutex respectively. This patch completes that changover, using
the underlying types directly so it's easier to see what is actually
being used.

Change-Id: If3f717f766727042cd81ae7b8c65f9a19934f2fa
Reviewed-on: http://review.couchbase.org/60925
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Will Gardner <will.gardner@couchbase.com>

show more ...

Mutex modernization [2/2]: Use std::condition_variable for SyncObject

Change Mutex to a typedef to std::mutex, and use
std::condition_variable for the implementation of SyncObject.

Mutex modernization [2/2]: Use std::condition_variable for SyncObject

Change Mutex to a typedef to std::mutex, and use
std::condition_variable for the implementation of SyncObject.

Note these two changes are mutually dependent hence being done in the
same patch.

Change-Id: Ife74822e9c4e04efefff446e964a952b672a1f91
Reviewed-on: http://review.couchbase.org/57328
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

Mutex modernization [1/2]: Replace with std::mutex

Update the API of Mutex to match that of std::mutex, and SyncObject to
match that of std::condition_variable in preparation for replaci

Mutex modernization [1/2]: Replace with std::mutex

Update the API of Mutex to match that of std::mutex, and SyncObject to
match that of std::condition_variable in preparation for replacing
Mutex and SyncObject with the C++11 standard library equivilents.

Change-Id: I5625d980b11144f681f7e717df87c8b5f323dc7c
Reviewed-on: http://review.couchbase.org/57327
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

Simplify common.h: add utility.h [2/3]

Create a new utility.h header file and move some of the functions /
macros which virtually everyone uses to there. utility.h has
significantly

Simplify common.h: add utility.h [2/3]

Create a new utility.h header file and move some of the functions /
macros which virtually everyone uses to there. utility.h has
significantly fewer dependancies, and such is much cheaper to include
than common.h

Update users of these functions / macros (DISALLOW_COPY_ON_ASSIGN, LOG
etc) to use utility.h instead of common.h

Change-Id: I3f93435c82950bd2a20b416af2b2e5011a931e04
Reviewed-on: http://review.couchbase.org/56704
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

MB-11731 Reduce the lock overhead among flusher, VB deletion, and compaction

This change reduces the lock blocking overhead among flusher, vbucket
deletion, compaction, and snapshot task

MB-11731 Reduce the lock overhead among flusher, VB deletion, and compaction

This change reduces the lock blocking overhead among flusher, vbucket
deletion, compaction, and snapshot tasks, by skipping the rest of
tasks if a lock is already grabbed by one task.

Change-Id: I643d7fe74150b5ead5c1368d660deb3c64dd1d01
Reviewed-on: http://review.couchbase.org/39910
Reviewed-by: David Liao <david.liao@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

call cb_thread_self instead of pthread_self

Change-Id: I2509b9710b0caa0324ec39a18cf82cd8cb1751b8
Reviewed-on: http://review.couchbase.org/30092
Reviewed-by: Trond Norbye <trond.norby

call cb_thread_self instead of pthread_self

Change-Id: I2509b9710b0caa0324ec39a18cf82cd8cb1751b8
Reviewed-on: http://review.couchbase.org/30092
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Use our own mutex abstraction

Change-Id: I12faa0016977e1d5b08cdd05f509aebf71a5bbb8
Reviewed-on: http://review.couchbase.org/30014
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

Use our own mutex abstraction

Change-Id: I12faa0016977e1d5b08cdd05f509aebf71a5bbb8
Reviewed-on: http://review.couchbase.org/30014
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

Use our thread abstraction layer

Change-Id: I5d52d55ea603d8e53c9b39a94fa3029cdad50748
Reviewed-on: http://review.couchbase.org/30013
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com

Use our thread abstraction layer

Change-Id: I5d52d55ea603d8e53c9b39a94fa3029cdad50748
Reviewed-on: http://review.couchbase.org/30013
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

MB-7728: Add copyright headers to all files

This is something that our cpplint tool turns on and it makes
our product look a little bit more profesional. I have also
enabled the tool

MB-7728: Add copyright headers to all files

This is something that our cpplint tool turns on and it makes
our product look a little bit more profesional. I have also
enabled the tool to begin checking for these headers so it will
start complaining if we add a new file without a copyright header.

Change-Id: Ie956fdf7027bf56d9665ee455acd3c109fcacc76
Reviewed-on: http://review.couchbase.org/24560
Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Reviewed-by: Jin Lim <jin@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

MB-7461: Alphabetize includes to conform with c++ standards

Change-Id: I71333dedada6530713b90184857bab9ac49d13df
Reviewed-on: http://review.couchbase.org/23515
Reviewed-by: Jin Lim <

MB-7461: Alphabetize includes to conform with c++ standards

Change-Id: I71333dedada6530713b90184857bab9ac49d13df
Reviewed-on: http://review.couchbase.org/23515
Reviewed-by: Jin Lim <jin@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

MB-7426: Fix all header defines to conform with cpplint

Change-Id: I8253b640bc49ee8a0fabbb39ece73c2efdb906d5
Reviewed-on: http://review.couchbase.org/23510
Reviewed-by: Michael Wiede

MB-7426: Fix all header defines to conform with cpplint

Change-Id: I8253b640bc49ee8a0fabbb39ece73c2efdb906d5
Reviewed-on: http://review.couchbase.org/23510
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

MB-7405: Make extension for all header files .h

Change-Id: I7badb1e71c038b6498296c2893ccdbd47c2f0f87
Reviewed-on: http://review.couchbase.org/23483
Reviewed-by: Michael Wiederhold <m

MB-7405: Make extension for all header files .h

Change-Id: I7badb1e71c038b6498296c2893ccdbd47c2f0f87
Reviewed-on: http://review.couchbase.org/23483
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

MB-7392: DISALLOW_COPY_AND_ASSIGN() should be private

Change-Id: I7a3ef1403518643aac9b7ecdab1d14cfe18deff8
Reviewed-on: http://review.couchbase.org/23416
Reviewed-by: Michael Wiederh

MB-7392: DISALLOW_COPY_AND_ASSIGN() should be private

Change-Id: I7a3ef1403518643aac9b7ecdab1d14cfe18deff8
Reviewed-on: http://review.couchbase.org/23416
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

MB-6141: Move ep-engine source files into src directory

Change-Id: I6068c3aa7bc92d45bce4dd3097079665d807ac75
Reviewed-on: http://review.couchbase.org/19664
Reviewed-by: Michael Wiede

MB-6141: Move ep-engine source files into src directory

Change-Id: I6068c3aa7bc92d45bce4dd3097079665d807ac75
Reviewed-on: http://review.couchbase.org/19664
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Michael Wiederhold <mike@couchbase.com>

show more ...

Add probes for our mutexes

Change-Id: Ide2be00c4b0af05796f66ec87b1c8b9286017efa
Reviewed-on: http://review.couchbase.org/11628
Tested-by: Dustin Sallings <dustin@spy.net>
Reviewe

Add probes for our mutexes

Change-Id: Ide2be00c4b0af05796f66ec87b1c8b9286017efa
Reviewed-on: http://review.couchbase.org/11628
Tested-by: Dustin Sallings <dustin@spy.net>
Reviewed-by: Dustin Sallings <dustin@spy.net>

show more ...

Mutex owner tracking API for lock assertions.

Gerrit got kind of confused and wouldn't let me submit updates to this
in its previous life. This was http://review.membase.org/3705

Mutex owner tracking API for lock assertions.

Gerrit got kind of confused and wouldn't let me submit updates to this
in its previous life. This was http://review.membase.org/3705

Change-Id: I25c091c59d28689365a3292036b5351ead588bee
Reviewed-on: http://review.membase.org/6467
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Dustin Sallings <dustin@spy.net>

show more ...

Use PTHREAD_MUTEX_ERRORCHECK if the system supports it

Change-Id: I115288572df71c509857b54d121b926c6f03cef5
Reviewed-on: http://review.membase.org/3708
Tested-by: Dustin Sallings <du

Use PTHREAD_MUTEX_ERRORCHECK if the system supports it

Change-Id: I115288572df71c509857b54d121b926c6f03cef5
Reviewed-on: http://review.membase.org/3708
Tested-by: Dustin Sallings <dustin@spy.net>
Reviewed-by: Dustin Sallings <dustin@spy.net>

show more ...

Disable extra mutex check for win32

The pthread implementation we use on win32 doesn't support the
construct: pthread_t id = pthread_self();

The code is just an extra error chec

Disable extra mutex check for win32

The pthread implementation we use on win32 doesn't support the
construct: pthread_t id = pthread_self();

The code is just an extra error check added at a time we had weird
mutex problems, and not really necessary for the code to work. If we
have mutex problems on win32 we should figure out how to implement the
same functionality on win32.

Change-Id: I6035b9e5ddf1441dc25f4ffd61d10e47b6bbf4c0
Reviewed-on: http://review.northscale.com/1279
Reviewed-by: Dustin Sallings <dustin@spy.net>
Tested-by: Dustin Sallings <dustin@spy.net>

show more ...

Use a LockHolder whenever a lock should be held.

This prevents issues where a lock is mistakenly released twice because
LockHolder doesn't know the lock isn't held by the current thread.

Use a LockHolder whenever a lock should be held.

This prevents issues where a lock is mistakenly released twice because
LockHolder doesn't know the lock isn't held by the current thread.

Change-Id: I8e701038145e2a64c73a53d24051cb578bc93d0d
Reviewed-on: http://review.northscale.com:8080/144
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Assert lock ownership.

Change-Id: I8c57a1d81e7e63e2cd835ffd9ca08b31638bc397
Reviewed-on: http://review.northscale.com:8080/142
Tested-by: Trond Norbye <trond.norbye@gmail.com>
Re

Assert lock ownership.

Change-Id: I8c57a1d81e7e63e2cd835ffd9ca08b31638bc397
Reviewed-on: http://review.northscale.com:8080/142
Tested-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Get proper errors out of mutex operations.

errno is not set by these, instead, the error condition is returned.
Must display the error we got.

Change-Id: I2bcce177a614ab6e9587f7

Get proper errors out of mutex operations.

errno is not set by these, instead, the error condition is returned.
Must display the error we got.

Change-Id: I2bcce177a614ab6e9587f73e1dd5c0eb56a4f631
Reviewed-on: http://review.northscale.com:8080/128
Tested-by: Dustin Sallings <dustin@spy.net>
Reviewed-by: Sean Lynch <seanl@literati.org>

show more ...