Use cb_assert instead of assert

Change-Id: If6b3170af815c324b26ff44bea3b950deed774fd
Reviewed-on: http://review.couchbase.org/49431
Tested-by: buildbot <build@couchbase.com>
Revi

Use cb_assert instead of assert

Change-Id: If6b3170af815c324b26ff44bea3b950deed774fd
Reviewed-on: http://review.couchbase.org/49431
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Steve Yen <steve.yen@gmail.com>

show more ...

MB-9990: Initialize addrinfo struct before connecting

Ensure that the struct addrinfo is initialized properly
before making a connection

Change-Id: I6f57b30c01a2df50617bd0398847

MB-9990: Initialize addrinfo struct before connecting

Ensure that the struct addrinfo is initialized properly
before making a connection

Change-Id: I6f57b30c01a2df50617bd03988471b65e81371f0
Reviewed-on: http://review.couchbase.org/35417
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

Make config.h more explicit by including as src/config.h

Change-Id: I8f0b2d13a0683b43df21653f6b91d547322e3d93
Reviewed-on: http://review.couchbase.org/35161
Reviewed-by: Trond Norbye

Make config.h more explicit by including as src/config.h

Change-Id: I8f0b2d13a0683b43df21653f6b91d547322e3d93
Reviewed-on: http://review.couchbase.org/35161
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Refactor: Prepare source to be squashed

Change-Id: I275dc53298b8cd14df84cb528decfe08be32f68e
Reviewed-on: http://review.couchbase.org/34635
Reviewed-by: Trond Norbye <trond.norbye@gm

Refactor: Prepare source to be squashed

Change-Id: I275dc53298b8cd14df84cb528decfe08be32f68e
Reviewed-on: http://review.couchbase.org/34635
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Cleanup from int to SOCKET

Change-Id: I43e3cc18c2a0c15845296ebfa82c9707482f9f96
Reviewed-on: http://review.couchbase.org/32423
Reviewed-by: Steve Yen <steve.yen@gmail.com>
Tested

Cleanup from int to SOCKET

Change-Id: I43e3cc18c2a0c15845296ebfa82c9707482f9f96
Reviewed-on: http://review.couchbase.org/32423
Reviewed-by: Steve Yen <steve.yen@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Use libplatform instead of pthread

Change-Id: Id366ec26ddd2e68022e70cb6fd84a00a21a04313
Reviewed-on: http://review.couchbase.org/32422
Reviewed-by: Steve Yen <steve.yen@gmail.com>

Use libplatform instead of pthread

Change-Id: Id366ec26ddd2e68022e70cb6fd84a00a21a04313
Reviewed-on: http://review.couchbase.org/32422
Reviewed-by: Steve Yen <steve.yen@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Move towards C89

Change-Id: I9953891a2fa858b0a957faaa5974fbe2b7ba3ac5
Reviewed-on: http://review.couchbase.org/31537
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by:

Move towards C89

Change-Id: I9953891a2fa858b0a957faaa5974fbe2b7ba3ac5
Reviewed-on: http://review.couchbase.org/31537
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Move towards C89 (step 1)

Change-Id: I8a0f9d0b027ee068a4404f634a208eb5bfdf79cf
Reviewed-on: http://review.couchbase.org/30952
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
T

Move towards C89 (step 1)

Change-Id: I8a0f9d0b027ee068a4404f634a208eb5bfdf79cf
Reviewed-on: http://review.couchbase.org/30952
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

MB-8102: Switched from using select(..) to poll(..) within mcs_io_read

This prevent segfaults when more than 1024 fd's are used.

Change-Id: I5513af3fdeca6d807d14d5977e9ca2cb5b2c8719

MB-8102: Switched from using select(..) to poll(..) within mcs_io_read

This prevent segfaults when more than 1024 fd's are used.

Change-Id: I5513af3fdeca6d807d14d5977e9ca2cb5b2c8719
Reviewed-on: http://review.couchbase.org/30345
Reviewed-by: Steve Yen <steve.yen@gmail.com>
Tested-by: Bin Cui <bin.cui@gmail.com>

show more ...

Use C-stype comments

Change-Id: Ib374e49763843988b26f726220b66372c84828f5
Reviewed-on: http://review.couchbase.org/30327
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested

Use C-stype comments

Change-Id: Ib374e49763843988b26f726220b66372c84828f5
Reviewed-on: http://review.couchbase.org/30327
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Require libmemcached

We are currently building moxi with libmemcached in our
product, and this commit is part of the process to simplify
our build process. By removing everything we

Require libmemcached

We are currently building moxi with libmemcached in our
product, and this commit is part of the process to simplify
our build process. By removing everything we don't use it'll
be easier to know which parts needs moving over to CMake.

Change-Id: I9f2073636099ba59bb645b6b867973a78289e958
Reviewed-on: http://review.couchbase.org/26952
Reviewed-by: Steve Yen <steve.yen@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Require libvbucket

We are currently building moxi with libvbucket in our
product, and this commit is part of the process to simplify
our build process. By removing everything we don'

Require libvbucket

We are currently building moxi with libvbucket in our
product, and this commit is part of the process to simplify
our build process. By removing everything we don't use it'll
be easier to know which parts needs moving over to CMake.

Change-Id: I7258260405f95a281f4fd37b3c98fa4488b0daac
Reviewed-on: http://review.couchbase.org/26951
Reviewed-by: Steve Yen <steve.yen@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

MB-3799 - moxi default libmemcached hashing is now ketama_weighted

Change-Id: I84c498913f9f816ecd4a084375cccbe67b556967
Reviewed-on: http://review.membase.org/6537
Reviewed-by: Matt

MB-3799 - moxi default libmemcached hashing is now ketama_weighted

Change-Id: I84c498913f9f816ecd4a084375cccbe67b556967
Reviewed-on: http://review.membase.org/6537
Reviewed-by: Matt Ingenthron <matt@couchbase.com>
Tested-by: Steve Yen <steve.yen@gmail.com>

show more ...

MB-3798 - moxi option for ketama/weighted/modula item distributions

When using libmemcached, start moxi with an extra -Z key=value
configuration option...

moxi -Z mcs_opts=dis

MB-3798 - moxi option for ketama/weighted/modula item distributions

When using libmemcached, start moxi with an extra -Z key=value
configuration option...

moxi -Z mcs_opts=distribution:ketama
moxi -Z mcs_opts=distribution:ketama-weighted
moxi -Z mcs_opts=distribution:modula

In this commit, moxi stays with distribution:ketama as its default and
a later debate can change that.

Change-Id: I36d3df3a2ba79c9d793a5e1e1a31d0d24ba48450
Reviewed-on: http://review.membase.org/6138
Tested-by: Steve Yen <steve.yen@gmail.com>
Reviewed-by: Matt Ingenthron <matt@northscale.com>

show more ...

added stats for local & total latencies

NOTE: that we assume that first server in downstream server list is
'local'. Corresponding change will be made to ns_server.

Change-Id: I

added stats for local & total latencies

NOTE: that we assume that first server in downstream server list is
'local'. Corresponding change will be made to ns_server.

Change-Id: I8dd5c61828f6cdcc3c75a0e4f8d2559731701341
Reviewed-on: http://review.membase.org/4499
Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Reviewed-by: Steve Yen <steve.yen@gmail.com>

show more ...

MB-3202 - windows async connect() returns different errcode

Enabled async connect() usage on windows, so moxi will have the same
"pull network plug" behavior as on linux. However, windo

MB-3202 - windows async connect() returns different errcode

Enabled async connect() usage on windows, so moxi will have the same
"pull network plug" behavior as on linux. However, windows returns
EWOULDBLOCK instead of EINPROGRESS, and WSAGetLastError() must be used
instead of errno.

Change-Id: I6f4918387737cbb6ee458825aec96b57877062ae
Reviewed-on: http://review.membase.org/4103
Reviewed-by: Bin Cui <bin.cui@gmail.com>
Tested-by: Steve Yen <steve.yen@gmail.com>

show more ...

MB-3023 - moxi hangs in select() on linux

The theory with this fix is to handle a linux API difference in the
select() API, where the inconclusive proof of this is that I haven't
bee

MB-3023 - moxi hangs in select() on linux

The theory with this fix is to handle a linux API difference in the
select() API, where the inconclusive proof of this is that I haven't
been able to reproduce it on OSX.

From the linux select man page...

On Linux, select() modifies timeout to reflect the amount of time not
slept; most other implementations do not do this. (POSIX.1-2001 per-
mits either behaviour.) This causes problems both when Linux code
which reads timeout is ported to other operating systems, and when code
is ported to Linux that reuses a struct timeval for multiple select()s
in a loop without reinitializing it. Consider timeout to be undefined
after select() returns.

So, the thinking is that the timeout struct was reused in moxi and
eventually decreased to 0 by repeated calls to select(), which caused
select() on linux to block.

Change-Id: Ie349305be47b404cbba96aedd7f7a2dc2b614ff6
Reviewed-on: http://review.membase.org/3888
Tested-by: Sean Lynch <seanl@literati.org>
Reviewed-by: Sean Lynch <seanl@literati.org>

show more ...

MB-2962 - use errfds with select()

Change-Id: I42840bdc59a5b36a29b267feb69fc4c72def834a
Reviewed-on: http://review.membase.org/3825
Tested-by: Sean Lynch <seanl@literati.org>
Rev

MB-2962 - use errfds with select()

Change-Id: I42840bdc59a5b36a29b267feb69fc4c72def834a
Reviewed-on: http://review.membase.org/3825
Tested-by: Sean Lynch <seanl@literati.org>
Reviewed-by: Sean Lynch <seanl@literati.org>

show more ...

auth/read() should block less with 1 byte reads

Change-Id: I8e3f74bf6532a4ef0bed07c0cdf402f087311a60
Reviewed-on: http://review.membase.org/3795
Reviewed-by: Sean Lynch <seanl@litera

auth/read() should block less with 1 byte reads

Change-Id: I8e3f74bf6532a4ef0bed07c0cdf402f087311a60
Reviewed-on: http://review.membase.org/3795
Reviewed-by: Sean Lynch <seanl@literati.org>
Tested-by: Steve Yen <steve.yen@gmail.com>

show more ...

MB-2810 - check select() return code more

Change-Id: Ibfd431e0692a23ad7380eb31ef401d75d59f825b
Reviewed-on: http://review.membase.org/3639
Tested-by: Sean Lynch <seanl@literati.org>

MB-2810 - check select() return code more

Change-Id: Ibfd431e0692a23ad7380eb31ef401d75d59f825b
Reviewed-on: http://review.membase.org/3639
Tested-by: Sean Lynch <seanl@literati.org>
Reviewed-by: Sean Lynch <seanl@literati.org>

show more ...

MB-2724 - configurable auth_timeout with auth timeout blacklisting

auth_timeout is now command-line configurable, and can now be used
with the zstored downstream conn blacklisting flags.

MB-2724 - configurable auth_timeout with auth timeout blacklisting

auth_timeout is now command-line configurable, and can now be used
with the zstored downstream conn blacklisting flags. For example...

cycle=200,
connect_max_errors=10,
connect_retry_interval=30000,
auth_timeout=100,
...

A new tot_auth_timeout stat also tracks how often we see
an auth timeout error.

Change-Id: Idfb64d627ff0b5b470332efb640b498382d9e5bf
Reviewed-on: http://review.membase.org/3628
Tested-by: Sean Lynch <seanl@literati.org>
Reviewed-by: Sean Lynch <seanl@literati.org>

show more ...

MB-2689 - call select() right

Change-Id: I02bdcff66390bafb76cab93b55d1d7585d1df418
Reviewed-on: http://review.membase.org/3618
Reviewed-by: Steve Yen <steve.yen@gmail.com>
Tested

MB-2689 - call select() right

Change-Id: I02bdcff66390bafb76cab93b55d1d7585d1df418
Reviewed-on: http://review.membase.org/3618
Reviewed-by: Steve Yen <steve.yen@gmail.com>
Tested-by: Steve Yen <steve.yen@gmail.com>

show more ...

MB-2689 - add timeout to moxi SASL auth & bucket select requests

In this change, moxi SASl auth and bucket select are still
synchronous, but have additional configurable timeouts (via th

MB-2689 - add timeout to moxi SASL auth & bucket select requests

In this change, moxi SASl auth and bucket select are still
synchronous, but have additional configurable timeouts (via the
downstream_timeout configuration parameter).

This is done by adding a select() with timeout mcs_io_read(),
which shouldn't be too horrible as SASL auth should be very
infrequent due to long-lived, reused connections.

The alternative solution of rewriting SASL auth and bucket-select, in
comparison, to be asynchronous is a lot of effort.

Change-Id: I61f31fb3a4c4a994ff79d6a9f909ca578ae02236
Reviewed-on: http://review.membase.org/3604
Reviewed-by: Sean Lynch <seanl@literati.org>
Tested-by: Sean Lynch <seanl@literati.org>

show more ...

bug 2600 - fcntl() F_GETFL was lying on windows

The bad effect was that all sockets on windows ended up being
incorrectly in blocking mode instead of non-blocking mode,
after doing a

bug 2600 - fcntl() F_GETFL was lying on windows

The bad effect was that all sockets on windows ended up being
incorrectly in blocking mode instead of non-blocking mode,
after doing a sasl-auth.

Change-Id: I06d8a1447b33bbeef4aa35bf119a9c448e635a55
Reviewed-on: http://review.northscale.com/3047
Reviewed-by: Steve Yen <steve.yen@gmail.com>
Tested-by: Steve Yen <steve.yen@gmail.com>

show more ...

bug 2605 - propagate usr/pwd correctly to mcs layer

A helpful fix for empty-password buckets like the default bucket.
The host_ident hash string caching in mcs, in particular, was
se

bug 2605 - propagate usr/pwd correctly to mcs layer

A helpful fix for empty-password buckets like the default bucket.
The host_ident hash string caching in mcs, in particular, was
sensitive to formatting NULL vs empty ("") passwords.

Change-Id: I17650074e2a962881f9904c7c6ede218f58ae9d5
Reviewed-on: http://review.northscale.com/2998
Reviewed-by: Steve Yen <steve.yen@gmail.com>
Tested-by: Steve Yen <steve.yen@gmail.com>

show more ...