History log of /6.0.3/couchdb/ (Results 126 - 150 of 3947)
Revision (<<< Hide revision tags) (Show revision tags >>>)Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
bf387bcd15-Feb-2016 Volker Mische <vmx@couchbase.com>

MB-17044 Test for write guard issue

There could be a dangling file in the couch_file_write_guard if there
is a crash during the initialisation of a view group. This test reproduces
t

MB-17044 Test for write guard issue

There could be a dangling file in the couch_file_write_guard if there
is a crash during the initialisation of a view group. This test reproduces
the issue with forcing a crash when the header is read.

Change-Id: Ifc7d1009c3913f907d7670f83b63d2b80b1422ec
Reviewed-on: http://review.couchbase.org/59962
Tested-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>

show more ...

884cf29c16-Feb-2016 Volker Mische <vmx@couchbase.com>

Merge remote-tracking branch 'remotes/couchbase/sherlock' into master

* remotes/couchbase/sherlock:
MB-18125 Don't reverse the ordering of partition ids

Change-Id: If1dca9e83a

Merge remote-tracking branch 'remotes/couchbase/sherlock' into master

* remotes/couchbase/sherlock:
MB-18125 Don't reverse the ordering of partition ids

Change-Id: If1dca9e83a70733eb91068c6f0caea4d3afd856c

show more ...


d5111e5915-Feb-2016 Volker Mische <vmx@couchbase.com>

MB-18125 Don't reverse the ordering of partition ids

The partition ids must always be sorted ascending. Previously
`list:foldl/3` was used to filter out certain partition ids.
Hence

MB-18125 Don't reverse the ordering of partition ids

The partition ids must always be sorted ascending. Previously
`list:foldl/3` was used to filter out certain partition ids.
Hence the result reversed, which lead to errors like:
`Cleanup list is not an ordset`.

Instead use lists:filter/2, which preserves the ordering.

Change-Id: Iada18de69ce0a200c716b008667ba367a974e044
Reviewed-on: http://review.couchbase.org/60040
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>

show more ...

29c7ee6801-Feb-2016 Abhishek Singh <abhishek@couchbase.com>

MB-17044: Clear dead PID from couch_file_write_guard

couch_file_write_guard is responsible for serializing access to
writers on a given mapreduce index file on disk.

This fix is

MB-17044: Clear dead PID from couch_file_write_guard

couch_file_write_guard is responsible for serializing access to
writers on a given mapreduce index file on disk.

This fix is supposed to clean up dead pid holding up write access to
mapreduce index files.

Change-Id: I754bde746b19fa82bd448b960f8ba5fe091dab5f
Reviewed-on: http://review.couchbase.org/59326
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: Abhishek Singh <abhishek@couchbase.com>

show more ...

e824e5ae25-Jan-2016 Volker Mische <vmx@couchbase.com>

MB-17420: Deletion and recreation of file failed on Windows

The deletion an immediate recreation of a file causes problems on
Windows. Instead just rename the file to the destination, wi

MB-17420: Deletion and recreation of file failed on Windows

The deletion an immediate recreation of a file causes problems on
Windows. Instead just rename the file to the destination, without
prior deletion.

Change-Id: I942aacc4681ae5d163559b7cf764ce1649dd5829
Reviewed-on: http://review.couchbase.org/59013
Tested-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>

show more ...

9f12dd5b25-Jan-2016 Volker Mische <vmx@couchbase.com>

MB-17420: Use lowercase filenames for comparison

On Windows the different case in file paths is a problem. For example
`file:get_cwd/0` may return a path that includes an uppercase drive

MB-17420: Use lowercase filenames for comparison

On Windows the different case in file paths is a problem. For example
`file:get_cwd/0` may return a path that includes an uppercase drive
letter. Though the file operation `filename:join/1` normalises the
drive letter into lowercase.

The fix is to make the full path to lowercase before comparing it.

Change-Id: I2acdd40d62d59dc3ce35ebaae7a2a245dbc5686a
Reviewed-on: http://review.couchbase.org/59012
Tested-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>

show more ...

6b32ccaa25-Jan-2016 Volker Mische <vmx@couchbase.com>

MB-17420: Remove boot option from etap test

The `-boot` parameter caused an erro on Windows:

Conflicting -start_erl and -boot options

It is not needed, all tests pass w

MB-17420: Remove boot option from etap test

The `-boot` parameter caused an erro on Windows:

Conflicting -start_erl and -boot options

It is not needed, all tests pass without it.

Change-Id: Ib40677876b7fb8d19519d5bf7474b19ad15f0f8c
Reviewed-on: http://review.couchbase.org/59011
Tested-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>

show more ...

3aec007912-Jan-2016 Volker Mische <vmx@couchbase.com>

MB-17044: Fix race conditions when initialising a view group

When a view group is initialised a new file handler is created. That handler
also adds an entry to write guard, which makes s

MB-17044: Fix race conditions when initialising a view group

When a view group is initialised a new file handler is created. That handler
also adds an entry to write guard, which makes sure that no files are opened
twice for writing. The file handler is then associated with the view group.
In case of a crash/failure the file handler is closed during the cleanup of
the view group.

There is a race condition if a crash happens *after* the file handler was
created successfully, but *before* it got associated with the group. During
the cleanup of the group, there won't be any reference to the file handler.

The solution is to clean up early and if that's not possible to have at least
a reference to the file handler in case an error occurs.

Change-Id: I0bb0ec95ffe5107243847e86ccbf941894041edc
Reviewed-on: http://review.couchbase.org/58519
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>

show more ...

10fbeb7b15-Jan-2016 Volker Mische <vmx@couchbase.com>

MB-17382: Pass on modified information about temp files

The spatial views store additional information in the temporary file
information during the Mod:write_kvs/3 calls. This informatio

MB-17382: Pass on modified information about temp files

The spatial views store additional information in the temporary file
information during the Mod:write_kvs/3 calls. This information should
be passed on between subsequent calls.

Change-Id: Iba2993f397922953324330aa0dd4e98d7debb312
Reviewed-on: http://review.couchbase.org/58691
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Tested-by: Volker Mische <volker.mische@gmail.com>

show more ...

4de925a112-Jan-2016 Volker Mische <vmx@couchbase.com>

Fix compiler warning about unitialised variable

Change-Id: If0a148be2ebb8efdee4bac1dfe29c8d9bd54f753
Reviewed-on: http://review.couchbase.org/58524
Reviewed-by: Trond Norbye <trond.n

Fix compiler warning about unitialised variable

Change-Id: If0a148be2ebb8efdee4bac1dfe29c8d9bd54f753
Reviewed-on: http://review.couchbase.org/58524
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: Volker Mische <volker.mische@gmail.com>

show more ...

93c1535c12-Jan-2016 Volker Mische <vmx@couchbase.com>

Fix compiler warnings

The warnings

/tmp/clean_master/couchdb/src/couch_view_parser/yajl/yajl_gen.c:305:37: warning: implicit conversion from enumeration type 'yajl_gen_state' to

Fix compiler warnings

The warnings

/tmp/clean_master/couchdb/src/couch_view_parser/yajl/yajl_gen.c:305:37: warning: implicit conversion from enumeration type 'yajl_gen_state' to different enumeration type 'yajl_gen_status' [-Wenum-conversion]
if (--(g->depth) >= 128) return yajl_gen_error;;
~~~~~~ ^~~~~~~~~~~~~~
/tmp/clean_master/couchdb/src/couch_view_parser/yajl/yajl_gen.c:331:37: warning: implicit conversion from enumeration type 'yajl_gen_state' to different enumeration type 'yajl_gen_status' [-Wenum-conversion]
if (--(g->depth) >= 128) return yajl_gen_error;;
~~~~~~ ^~~~~~~~~~~~~~
2 warnings generated.

are fixed the same way as upstream [1].

[1]: https://github.com/lloyd/yajl/commit/71ce86b48b60040835531493465be02923b21acb#diff-1

Change-Id: Ia41af1498cea74b71ed92d3f7c10cc8909d9b47e
Reviewed-on: http://review.couchbase.org/58523
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

c3943b0b06-Aug-2015 harsha <hhs.couchbase@gmail.com>

MB-17026: Report restarting of dcp receive worker back to parent

Restaring dcp receive worker due to closed dcp connection was not
reported back to group in the case of all_seqs call.

MB-17026: Report restarting of dcp receive worker back to parent

Restaring dcp receive worker due to closed dcp connection was not
reported back to group in the case of all_seqs call.

This is a backport of MB-15922.

Change-Id: I00e52ea312ca9d06eecc5f4501b6d6b15fab07e4
Original-Reviewed-on: http://review.couchbase.org/54167
Original-Reviewed-by: Volker Mische <volker.mische@gmail.com>
Original-Tested-by: buildbot <build@couchbase.com>
Reviewed-on: http://review.couchbase.org/57770
Well-Formed: buildbot <build@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: Volker Mische <volker.mische@gmail.com>

show more ...

f5f1d56d15-Dec-2015 Volker Mische <vmx@couchbase.com>

MB-17026: Unit tests to prevent another future regression

Change-Id: I921f49841cc121ba558f8ed1777785cceae56ca5
Reviewed-on: http://review.couchbase.org/57812
Well-Formed: buildbot <b

MB-17026: Unit tests to prevent another future regression

Change-Id: I921f49841cc121ba558f8ed1777785cceae56ca5
Reviewed-on: http://review.couchbase.org/57812
Well-Formed: buildbot <build@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

7d0e0e6c10-Dec-2015 Volker Mische <vmx@couchbase.com>

Merge branch 'sherlock' into master

This merge contains only a backport from 3.x, hence no additional changes
are expected to me merged. This merge is just done to make future merges

Merge branch 'sherlock' into master

This merge contains only a backport from 3.x, hence no additional changes
are expected to me merged. This merge is just done to make future merges
easier.

Change-Id: Iec2ccd5e67a24e20846a5663a19dd70588568e4f

show more ...


ace6e47610-Dec-2015 Volker Mische <vmx@couchbase.com>

Merge remote-tracking branch 'remotes/couchbase/3.x' into sherlock

* remotes/couchbase/3.x:
[bp] MB-16826 Get rid of flawed applications starts in mochiweb.

Change-Id: I91a516

Merge remote-tracking branch 'remotes/couchbase/3.x' into sherlock

* remotes/couchbase/3.x:
[bp] MB-16826 Get rid of flawed applications starts in mochiweb.

Change-Id: I91a516d1f1f08014b98527360fcaa17f35f88ab9

show more ...


f571f5a516-Nov-2015 Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>

[bp] MB-16826 Get rid of flawed applications starts in mochiweb.

It is flawed because it might lead to deadlocks during server
shutdown. When application:stop(App) is called, it blocks e

[bp] MB-16826 Get rid of flawed applications starts in mochiweb.

It is flawed because it might lead to deadlocks during server
shutdown. When application:stop(App) is called, it blocks entire
application_controller process. So anything that tries to access it
from inside application being stopped will be blocked. It leads to
deadlock if such blocked call also blocks application shutdown. And
this is exactly the case with mochiweb, because corresponding
application:start calls are executed in supervisor process context
whenever mochiweb process is started.

These applications are now explicitly started by ns_server during
bootstrap.

Change-Id: I858e79812c81adf955e282ac2829069132678931
Original-Change-Id: I419c80f7bea1eb1d08094fb216891b423d502fc0
Original-Reviewed-on: http://review.couchbase.org/57096
Original-Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
Original-Reviewed-by: Volker Mische <volker.mische@gmail.com>
Original-Tested-by: buildbot <build@couchbase.com>
Reviewed-on: http://review.couchbase.org/57594
Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>

show more ...

d3be4a3d16-Nov-2015 Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>

MB-16826 Get rid of flawed applications starts in mochiweb.

It is flawed because it might lead to deadlocks during server
shutdown. When application:stop(App) is called, it blocks entire

MB-16826 Get rid of flawed applications starts in mochiweb.

It is flawed because it might lead to deadlocks during server
shutdown. When application:stop(App) is called, it blocks entire
application_controller process. So anything that tries to access it
from inside application being stopped will be blocked. It leads to
deadlock if such blocked call also blocks application shutdown. And
this is exactly the case with mochiweb, because corresponding
application:start calls are executed in supervisor process context
whenever mochiweb process is started.

These applications are now explicitly started by ns_server during
bootstrap.

Change-Id: I419c80f7bea1eb1d08094fb216891b423d502fc0
Reviewed-on: http://review.couchbase.org/57096
Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

a0f0440313-Nov-2015 Volker Mische <vmx@couchbase.com>

Merge remote-tracking branch 'couchbase/sherlock' into master

* couchbase/sherlock:
MB-16435: OS X: Add correct rpath for NIFs

Change-Id: Id6accdf6b55c008426b475ee0e6e

Merge remote-tracking branch 'couchbase/sherlock' into master

* couchbase/sherlock:
MB-16435: OS X: Add correct rpath for NIFs

Change-Id: Id6accdf6b55c008426b475ee0e6e5458077f2711

show more ...


90c5f62e06-Nov-2015 Volker Mische <vmx@couchbase.com>

MB-16738: Create directory where files are move to for deletion

When a file is deleted, it's first moved into a temporary directory and
then deleted from there. The file can't be deleted

MB-16738: Create directory where files are move to for deletion

When a file is deleted, it's first moved into a temporary directory and
then deleted from there. The file can't be deleted if the temporary directory
doesn't exist. We now try to create that directory in case it doesn't exist
yet.

Change-Id: I8073aefaa692b764c68218bb914d62de478aa7b6
Reviewed-on: http://review.couchbase.org/56746
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: Volker Mische <volker.mische@gmail.com>

show more ...

62efc60102-Nov-2015 harsha <hhs.couchbase@gmail.com>

Get rid of V8 version macros

Since v8 library file as part of cbdeps, no need to maintatin
v8 code base for different versions.

Change-Id: I6ed27e7af350cbe9316e397d1949b7c825d36

Get rid of V8 version macros

Since v8 library file as part of cbdeps, no need to maintatin
v8 code base for different versions.

Change-Id: I6ed27e7af350cbe9316e397d1949b7c825d361b4
Reviewed-on: http://review.couchbase.org/56598
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

e8dbef3629-Oct-2015 Volker Mische <vmx@couchbase.com>

MB-16085: Stop view group when design document is deleted

Stop a view group immediately when the corresponding design document was
deleted. This will also stop all current requests that

MB-16085: Stop view group when design document is deleted

Stop a view group immediately when the corresponding design document was
deleted. This will also stop all current requests that are still waiting
for a response. Those requests were started with `stale=false` before the
design document was deleted. They will error with the error
"Design document was deleted".

Change-Id: Id185e1633dad4d4e84d9080a95c2c10c37f783dc
Reviewed-on: http://review.couchbase.org/56512
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>

show more ...

9e9e563709-Jul-2015 Volker Mische <vmx@couchbase.com>

Fix warnings on Erlang 18.0

Change-Id: I29f8a6b275b2ca53d82e21b85799d308ef76bbfa
Reviewed-on: http://review.couchbase.org/56440
Tested-by: buildbot <build@couchbase.com>
Reviewed

Fix warnings on Erlang 18.0

Change-Id: I29f8a6b275b2ca53d82e21b85799d308ef76bbfa
Reviewed-on: http://review.couchbase.org/56440
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>

show more ...

57c0c78911-Jun-2015 Volker Mische <vmx@couchbase.com>

MB-15267: Add line numbers to JavaScript errors

When there's an error in a view, it's hard to determine where exactly
it happened. The logging of the errors is improved to contain the li

MB-15267: Add line numbers to JavaScript errors

When there's an error in a view, it's hard to determine where exactly
it happened. The logging of the errors is improved to contain the line
and column number:

[mapreduce_errors:error,2015-06-11T17:23:47.302+02:00,couchdb_n_0@127.0.0.1:<0.461.0>:couch_set_view_updater:-do_maps/3-fun-0-:783]Bucket `beer-sample`, main group `_design/dev_beer`, error mapping document `copper_kettle_brewery` for view `brewery_beers`: TypeError: Cannot read property 'bar' of undefined (line 4:21)

Change-Id: Ife11faecd97082ac2e658a2a2d9ef59e5d513da6
Reviewed-on: http://review.couchbase.org/51953
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

f62ce88d29-Jun-2015 Volker Mische <vmx@couchbase.com>

MB-15274 Delete old file *after* new one was renamed

The view file compaction goes through the following steps:

1. The original file is called `*.view.1`
2. For compaction a n

MB-15274 Delete old file *after* new one was renamed

The view file compaction goes through the following steps:

1. The original file is called `*.view.1`
2. For compaction a new file with the same name, but a `compact` extension
is appended (`*.view.1.compact`)
3. Once the compaction was successful, rename the new file with the number
at the increased (`*.view.2`)

In the current code, after a successful compaction the old view file is
deleted, then the `*.compact` file is renamed. In case there would be a
crash between those two operations, there would only be a `*.compact` file
in the views directory. The view-engine won't pick it up and start re-indexing.

With this code change the old file is deleted *after* the `*.compact` file
got renamed. In case there's a crash in between those operations you will
only end up with two `*.view.<some-number>` files, but the view engine will
automatically pick up the one with the highest number.

Change-Id: I533ca5bcfd711fb967d58702e086b470421dfd48
Reviewed-on: http://review.couchbase.org/52661
Reviewed-by: Nimish Gupta <nimish@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

884834f506-Jul-2015 Volker Mische <vmx@couchbase.com>

Supply all existing stats

When querying the group information for debug purpose from the
`_set_view/<bucket>/<design_doc>/_info` endpoint, it should contain
all the stats we have.

Supply all existing stats

When querying the group information for debug purpose from the
`_set_view/<bucket>/<design_doc>/_info` endpoint, it should contain
all the stats we have.

Change-Id: Ifaabba0c63e9981fc7c9d4a898c72c268f16aabe
Reviewed-on: http://review.couchbase.org/52857
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

12345678910>>...158