History log of /6.0.3/couchdb/src/couch_view_parser/ (Results 1 - 25 of 25)
Revision (<<< Hide revision tags) (Show revision tags >>>)Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
Revision tags: v4.6.0
c0add99f17-May-2016 harsha <hhs.couchbase@gmail.com>

Enable asserts in release builds

Change-Id: I70a6a4afb1eaada643e9a70d33b43d5912f81d6b
Reviewed-on: http://review.couchbase.org/64101
Reviewed-by: Abhishek Singh <abhishek@couchbase.c

Enable asserts in release builds

Change-Id: I70a6a4afb1eaada643e9a70d33b43d5912f81d6b
Reviewed-on: http://review.couchbase.org/64101
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

Revision tags: v4.5.0
1fc9a81f09-Mar-2016 Volker Mische <vmx@couchbase.com>

CBD-1453: Rebuild when header files change

Whenever an Erlang header file changes, rebuild the corresponding
Erlang files. This isn't an automated process, but you need to pass
in th

CBD-1453: Rebuild when header files change

Whenever an Erlang header file changes, rebuild the corresponding
Erlang files. This isn't an automated process, but you need to pass
in the header files a project should depend on manually. For simplicity
sometimes more headers are use than strictly needed. We rather rebuild
more than having a broken incremental build.

Change-Id: Iae6d0a9043ed1b74f2c104d9b251f45715ac04fd
Reviewed-on: http://review.couchbase.org/61152
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>

show more ...

4bd0f4c503-Mar-2016 Volker Mische <vmx@couchbase.com>

MB-17420 Don't use GLOB to find source/test files

Instead of using globbing, it's better to name the files
explicitely. That way incremental builds work.

Change-Id: I1b47c61b0f5

MB-17420 Don't use GLOB to find source/test files

Instead of using globbing, it's better to name the files
explicitely. That way incremental builds work.

Change-Id: I1b47c61b0f524e5576d4111075516d923f039a6f
Reviewed-on: http://review.couchbase.org/60856
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

93c1535c12-Jan-2016 Volker Mische <vmx@couchbase.com>

Fix compiler warnings

The warnings

/tmp/clean_master/couchdb/src/couch_view_parser/yajl/yajl_gen.c:305:37: warning: implicit conversion from enumeration type 'yajl_gen_state' to

Fix compiler warnings

The warnings

/tmp/clean_master/couchdb/src/couch_view_parser/yajl/yajl_gen.c:305:37: warning: implicit conversion from enumeration type 'yajl_gen_state' to different enumeration type 'yajl_gen_status' [-Wenum-conversion]
if (--(g->depth) >= 128) return yajl_gen_error;;
~~~~~~ ^~~~~~~~~~~~~~
/tmp/clean_master/couchdb/src/couch_view_parser/yajl/yajl_gen.c:331:37: warning: implicit conversion from enumeration type 'yajl_gen_state' to different enumeration type 'yajl_gen_status' [-Wenum-conversion]
if (--(g->depth) >= 128) return yajl_gen_error;;
~~~~~~ ^~~~~~~~~~~~~~
2 warnings generated.

are fixed the same way as upstream [1].

[1]: https://github.com/lloyd/yajl/commit/71ce86b48b60040835531493465be02923b21acb#diff-1

Change-Id: Ia41af1498cea74b71ed92d3f7c10cc8909d9b47e
Reviewed-on: http://review.couchbase.org/58523
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

6edbd3a323-Jan-2015 Volker Mische <vmx@couchbase.com>

MB-13192 Use the escript found by CMake

Instead of relying `escript` to be set via `PATH` correctly, use
the `escript` that was found by CMake (`${ESCRIPT_EXECUTABLE}`).

Change-

MB-13192 Use the escript found by CMake

Instead of relying `escript` to be set via `PATH` correctly, use
the `escript` that was found by CMake (`${ESCRIPT_EXECUTABLE}`).

Change-Id: I406276998dab802613d5859ce8ee0c8b4c734834
Reviewed-on: http://review.couchbase.org/45782
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

96f3e86108-Jan-2015 Trond Norbye <trond.norbye@gmail.com>

Remove unused files.

Change-Id: Ifdc9a884736f58bd1c243e7e587ab5f426b42924
Reviewed-on: http://review.couchbase.org/45057
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Vo

Remove unused files.

Change-Id: Ifdc9a884736f58bd1c243e7e587ab5f426b42924
Reviewed-on: http://review.couchbase.org/45057
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

19551d2b26-Nov-2014 harsha <hhs.couchbase@gmail.com>

Revert "MB-11917 Async couch_view_parser implementation"

This reverts commit 3bf0b23892a11299ff5cc25e3d1ebf83e3beec9f.
Reverting async couch_view_parser implementation as it is
resul

Revert "MB-11917 Async couch_view_parser implementation"

This reverts commit 3bf0b23892a11299ff5cc25e3d1ebf83e3beec9f.
Reverting async couch_view_parser implementation as it is
resulting in lexical error and also not helping in resolving
erlang scheduler collapse issue.

Change-Id: I94f1cc5c0eb78bcbd95e321b0ed4d43870cc439b
Reviewed-on: http://review.couchbase.org/43633
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Nimish Gupta <nimish@couchbase.com>

show more ...

44d4d9b226-Nov-2014 harsha <hhs.couchbase@gmail.com>

Revert "MB-12697 Serialize parse_json requests chunks per query context"

This reverts commit cede9fe0761aa36eec2488103485c7b985e08f77.

Change-Id: Ieee9ccf680b1e627c4d6e0d30377ca8600

Revert "MB-12697 Serialize parse_json requests chunks per query context"

This reverts commit cede9fe0761aa36eec2488103485c7b985e08f77.

Change-Id: Ieee9ccf680b1e627c4d6e0d30377ca860040f7de
Reviewed-on: http://review.couchbase.org/43632
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Nimish Gupta <nimish@couchbase.com>

show more ...

cede9fe021-Nov-2014 harsha <hhs.couchbase@gmail.com>

MB-12697 Serialize parse_json requests chunks per query context

The order of processing json parsing request chunks
was assigned randomly to an execution thread which
resulted in lex

MB-12697 Serialize parse_json requests chunks per query context

The order of processing json parsing request chunks
was assigned randomly to an execution thread which
resulted in lexical error while processing json
parsing request during view querying. It is now
serialized, such that the request chunks per query
is processed in the same order of their arrival by
queueing every chunk to same execution thread.
However different query requests are assigned
randomly to a thread in the thread pool.

Change-Id: I16c89f7d4d422e9521ffc2a98d1d035b40e9b0fa
Reviewed-on: http://review.couchbase.org/43494
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Reviewed-by: Sriram Melkote <siri@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>

show more ...

3bf0b23805-Nov-2014 harsha <hhs.couchbase@gmail.com>

MB-11917 Async couch_view_parser implementation

Scheduler collapse in Erlang R16 is observed due to changes made
in R16 version with regard to erlang thread scheduler in general
and

MB-11917 Async couch_view_parser implementation

Scheduler collapse in Erlang R16 is observed due to changes made
in R16 version with regard to erlang thread scheduler in general
and to scheduling NIF threads in particular. couch_view_parser is
a json stream parser NIF and takes variable amount of time to parse
incoming data depending on the incoming stream length. This resulted
in reporting improper reduction count to erlang scheduler, which in
turn caused scheduler collapse. This NIF is now implemented in
asynchronous fashion, where NIF queues the incoming tasks and returns
to erlang world immediately.

Change-Id: I9e87fe63b78b10a31aba70aba31913d60331b5d7
Reviewed-on: http://review.couchbase.org/42821
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Harsha H S <hhs.couchbase@gmail.com>
Tested-by: Harsha H S <hhs.couchbase@gmail.com>

show more ...

232747b406-Nov-2014 Volker Mische <vmx@couchbase.com>

Make test logging more verbose

With the `--verbose` set the test logging output is more verbose.
The output on the screen is still the same it only changes what
gets written to the l

Make test logging more verbose

With the `--verbose` set the test logging output is more verbose.
The output on the screen is still the same it only changes what
gets written to the log file.

Change-Id: Iedaf4612d406450a2fc25e6066e325aa137915cf
Reviewed-on: http://review.couchbase.org/42893
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>

show more ...

efc2e92823-Sep-2014 Volker Mische <vmx@couchbase.com>

MB-12112 Simplify unit test runner

The unit test runner `runtest.py` needed the source as well as the
build directory of couchdb. This didn't work well as ERL_LIBS picks
the first ap

MB-12112 Simplify unit test runner

The unit test runner `runtest.py` needed the source as well as the
build directory of couchdb. This didn't work well as ERL_LIBS picks
the first application it encounters without checking if there might
be one which contains missing files later in the path.

The build system was changes so that the build directory also includes
the header files, hence only the information about the build path is
needed.

The `source` parameter got renamed to `libsdirs` and now takes a
directory as input that will be added to the ERL_LIBS environment
variable. This enables geocouch to use the same test runner.

All the subdirectories from the supplied couchdb build directory are
now added to erl_flags. This way you don't need to supply as many
modules as previously.

Change-Id: I07d5c40071ea85342ef72d2e64acf9feda0fb25c
Reviewed-on: http://review.couchbase.org/41581
Reviewed-by: Sarath Lakshman <sarath@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

a7a3a14307-Apr-2014 Volker Mische <vmx@couchbase.com>

Fix out of source build

Change-Id: I8dfa068b018f26974da6bce814f7759f8c2ae01d
Reviewed-on: http://review.couchbase.org/35371
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tes

Fix out of source build

Change-Id: I8dfa068b018f26974da6bce814f7759f8c2ae01d
Reviewed-on: http://review.couchbase.org/35371
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

c6a2900617-Mar-2014 Trond Norbye <trond.norbye@gmail.com>

Build using CMake

Change-Id: If0f29acdd08ff8b148a5362f3a6fb4d6a5be901c
Reviewed-on: http://review.couchbase.org/32799
Reviewed-by: Chris Hillery <ceej@couchbase.com>
Tested-by: T

Build using CMake

Change-Id: If0f29acdd08ff8b148a5362f3a6fb4d6a5be901c
Reviewed-on: http://review.couchbase.org/32799
Reviewed-by: Chris Hillery <ceej@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

be01dccc14-Oct-2013 Filipe David Borba Manana <fdmanana@apache.org>

MB-9330 Don't send unescaped JSON object keys

Ensure yajl preserves object keys' escaping, otherwise we
are using invalid JSON and sending it to the clients.

Change-Id: I5759943

MB-9330 Don't send unescaped JSON object keys

Ensure yajl preserves object keys' escaping, otherwise we
are using invalid JSON and sending it to the clients.

Change-Id: I5759943f33a299a572f9057fe13f45e26705fd0e
Reviewed-on: http://review.couchbase.org/29540
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: Filipe David Borba Manana <fdmanana@gmail.com>

show more ...

282a9d8a17-Sep-2013 Filipe David Borba Manana <fdmanana@apache.org>

Add emacs style line comment to several source files

Change-Id: Idc3e80655f6e122b1633a88b922336e5d3b42867
Reviewed-on: http://review.couchbase.org/29036
Reviewed-by: Filipe David Bor

Add emacs style line comment to several source files

Change-Id: Idc3e80655f6e122b1633a88b922336e5d3b42867
Reviewed-on: http://review.couchbase.org/29036
Reviewed-by: Filipe David Borba Manana <fdmanana@gmail.com>
Tested-by: Filipe David Borba Manana <fdmanana@gmail.com>

show more ...

Revision tags: 2.1.1r
989e9e2412-Jun-2013 Trond Norbye <trond.norbye@gmail.com>

-std=c99 is not accepted by clang c++

Change-Id: Iac3fa29b709892bdffa2295450d1b026a7a4b7ea
Reviewed-on: http://review.couchbase.org/26902
Tested-by: Trond Norbye <trond.norbye@gmail.

-std=c99 is not accepted by clang c++

Change-Id: Iac3fa29b709892bdffa2295450d1b026a7a4b7ea
Reviewed-on: http://review.couchbase.org/26902
Tested-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Filipe David Borba Manana <fdmanana@gmail.com>
Tested-by: Filipe David Borba Manana <fdmanana@gmail.com>

show more ...

Revision tags: 2.1.0r, 2.0.2r, 2.0.1-linux, 2.0.0-couchbase
69032c6d12-Oct-2012 Filipe David Borba Manana <fdmanana@apache.org>

Update allocator's allocate method

So that it conforms more to the way the default/standard
allocator based on the operators new and delete:

http://gcc.gnu.org/onlinedocs/gcc-4.

Update allocator's allocate method

So that it conforms more to the way the default/standard
allocator based on the operators new and delete:

http://gcc.gnu.org/onlinedocs/gcc-4.6.3/libstdc++/api/a00958_source.html

Also use static_cast instead of plain old C casts, and
avoid using the NULL constant, as these are best practices
in C++.

Change-Id: I7d5b24c1cae8bd0f3bcfcae4ed276a2d0a4fb0cc
Reviewed-on: http://review.couchbase.org/21586
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Damien Katz <damien@couchbase.com>
Tested-by: Filipe David Borba Manana <fdmanana@gmail.com>

show more ...

03cee9ab12-Oct-2012 Filipe David Borba Manana <fdmanana@apache.org>

Return correct max_size value for allocators

As it's done in the standard/default allocator that
uses the operators new and delete:

http://gcc.gnu.org/onlinedocs/gcc-4.6.3/libst

Return correct max_size value for allocators

As it's done in the standard/default allocator that
uses the operators new and delete:

http://gcc.gnu.org/onlinedocs/gcc-4.6.3/libstdc++/api/a00958_source.html

Change-Id: Ib6e2580a1e9f6a55a3cf220af808a374449f5a24
Reviewed-on: http://review.couchbase.org/21585
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Damien Katz <damien@couchbase.com>
Tested-by: Filipe David Borba Manana <fdmanana@gmail.com>

show more ...

919f9e5610-Aug-2012 Filipe David Borba Manana <fdmanana@apache.org>

CBD-504 More extensive couch_view_parser tests

The tests now do multiple iterations of the same test cases.
The goal here is to make it much more likely to detect errors
such as segm

CBD-504 More extensive couch_view_parser tests

The tests now do multiple iterations of the same test cases.
The goal here is to make it much more likely to detect errors
such as segmentation fauls in the C++ NIF.

Change-Id: Ic01618f59cd6f4e7f1cfaa6064d46c047798ef0a
Reviewed-on: http://review.couchbase.org/19464
Reviewed-by: Damien Katz <damien@couchbase.com>
Tested-by: Filipe David Borba Manana <fdmanana@gmail.com>

show more ...

75072cd810-Aug-2012 Filipe David Borba Manana <fdmanana@apache.org>

CBD-504 Use enif_alloc()/enif_free() in couch_view_parser

These are more efficient, since are Erlang VM specific, in
opposition to C++'s new and delete operators and C's malloc()
and

CBD-504 Use enif_alloc()/enif_free() in couch_view_parser

These are more efficient, since are Erlang VM specific, in
opposition to C++'s new and delete operators and C's malloc()
and free() allocators.

Change-Id: I4470fa75ac5f1d37587c13c3e7b51739f066fe33
Reviewed-on: http://review.couchbase.org/19457
Reviewed-by: Damien Katz <damien@couchbase.com>
Tested-by: Filipe David Borba Manana <fdmanana@gmail.com>

show more ...

3430b76625-Jul-2012 Filipe David Borba Manana <fdmanana@apache.org>

MB-6013 Fix parser error if doc has a boolean field

Change-Id: I2d31dc4a3bfa067071996a7f7fc0289e86b5c5ae
Reviewed-on: http://review.couchbase.org/18811
Reviewed-by: Volker Mische <vo

MB-6013 Fix parser error if doc has a boolean field

Change-Id: I2d31dc4a3bfa067071996a7f7fc0289e86b5c5ae
Reviewed-on: http://review.couchbase.org/18811
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: Filipe David Borba Manana <fdmanana@gmail.com>

show more ...

588f33dc06-Jul-2012 Filipe David Borba Manana <fdmanana@apache.org>

MB-5794 View parser didn't preserve escaping in strings

This includes a patch submitted upstream that tells YAJL
to not unescape strings before passing them to the user's
string call

MB-5794 View parser didn't preserve escaping in strings

This includes a patch submitted upstream that tells YAJL
to not unescape strings before passing them to the user's
string callback function.

Upstream pull request:

https://github.com/lloyd/yajl/pull/81

Change-Id: I9855e104dec2ce5bddaed526284afcca06d62c12
Reviewed-on: http://review.couchbase.org/17979
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Tested-by: Filipe David Borba Manana <fdmanana@gmail.com>

show more ...

014191f702-Jul-2012 Trond Norbye <trond.norbye@gmail.com>

MB-5757 Don't use gcc specific options to non-gcc compilers

Change-Id: I9b85c28782b8ab38fc0b59c8f00b9dbd2edb9a5c
Reviewed-on: http://review.couchbase.org/17809
Reviewed-by: Volker Mi

MB-5757 Don't use gcc specific options to non-gcc compilers

Change-Id: I9b85c28782b8ab38fc0b59c8f00b9dbd2edb9a5c
Reviewed-on: http://review.couchbase.org/17809
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Filipe David Borba Manana <fdmanana@gmail.com>
Tested-by: Filipe David Borba Manana <fdmanana@gmail.com>

show more ...

767de84e12-Jun-2012 Filipe David Borba Manana <fdmanana@apache.org>

CBD-32 Faster view merging and parsing

Change-Id: Ic80456651dc25baead3b24c74bd731a15f245548
Reviewed-on: http://review.couchbase.org/17464
Reviewed-by: Volker Mische <volker.mische@g

CBD-32 Faster view merging and parsing

Change-Id: Ic80456651dc25baead3b24c74bd731a15f245548
Reviewed-on: http://review.couchbase.org/17464
Reviewed-by: Volker Mische <volker.mische@gmail.com>
Reviewed-by: Bin Cui <bin.cui@gmail.com>
Reviewed-by: Damien Katz <damien@couchbase.com>
Tested-by: Filipe David Borba Manana <fdmanana@gmail.com>
Tested-by: Damien Katz <damien@couchbase.com>

show more ...