History log of /6.0.3/forestdb/ (Results 101 - 125 of 1302)
Revision (<<< Hide revision tags) (Show revision tags >>>)Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
245fdb8113-Apr-2016 Jung-Sang Ahn <jungsang.ahn@gmail.com>

Use dummy log callback for invalid_get_byoffset_test()

- Since the test triggers a lot of intentional errors, we disable
error messages by assigning dummy callback.

Change-Id: I

Use dummy log callback for invalid_get_byoffset_test()

- Since the test triggers a lot of intentional errors, we disable
error messages by assigning dummy callback.

Change-Id: I51b2442555cf0847a4bd9fc5073d137c7d8e6bfa
Reviewed-on: http://review.couchbase.org/62765
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

da4d76d713-Apr-2016 Jung-Sang Ahn <jungsang.ahn@gmail.com>

MB-19048 Do not grab fhandle_idx_lock in filemgr_free_func()

- The file already became unreachable so that grabbing lock is
unnecessary.

Change-Id: If6a6dff8511c6c76ac64bbb0cf94

MB-19048 Do not grab fhandle_idx_lock in filemgr_free_func()

- The file already became unreachable so that grabbing lock is
unnecessary.

Change-Id: If6a6dff8511c6c76ac64bbb0cf94feba9bf78831
Reviewed-on: http://review.couchbase.org/62764
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

1f644b8d07-Apr-2016 Jung-Sang Ahn <jungsang.ahn@gmail.com>

MB-19047 Protect superblock's bitmap from multiple readers and writers

- Added reference counters for readers and writers, to implement
a similar approach to readers-writer-lock.

MB-19047 Protect superblock's bitmap from multiple readers and writers

- Added reference counters for readers and writers, to implement
a similar approach to readers-writer-lock.

- The critical section size is very small, and writer is infrequently
invoked compared to readers so that almost no lock contention is
observed.

Change-Id: I71977fd2f4e4849df48508486d5b780147721ad9
Reviewed-on: http://review.couchbase.org/62555
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

b84960c205-Apr-2016 Jung-Sang Ahn <jungsang.ahn@gmail.com>

Log error messages through stderr if log callback is not given

- If error log callback function is not given, print error messages
through stderr.

- _fdb_restore_wal() may repor

Log error messages through stderr if log callback is not given

- If error log callback function is not given, print error messages
through stderr.

- _fdb_restore_wal() may report some false alarms due to circular
block reuse, we temporarily disable it.

Change-Id: I501c05e4926b4c94d47ef5ebc63de5692565652f
Reviewed-on: http://review.couchbase.org/62399
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

734d29cb12-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

Destroy mutex while closing FileHandlePool in usecase_tests

Change-Id: I2c2fbc144d3a1f0431912dfd3ba59e12699bd95b
Reviewed-on: http://review.couchbase.org/62743
Reviewed-by: Chiyoung

Destroy mutex while closing FileHandlePool in usecase_tests

Change-Id: I2c2fbc144d3a1f0431912dfd3ba59e12699bd95b
Reviewed-on: http://review.couchbase.org/62743
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

5a6f3f2711-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

MB-19155: Replacing the rw_spin_lock implementation

Replacing the rw_spin_lock implementation with the
more optimal and prevelant pthread_rw_lock in linux-based
systems and the srw_l

MB-19155: Replacing the rw_spin_lock implementation

Replacing the rw_spin_lock implementation with the
more optimal and prevelant pthread_rw_lock in linux-based
systems and the srw_lock in the windows-based systems.

Change-Id: I69d8bba4fb38f8e62c3b39408cf2adc471479a8d
Reviewed-on: http://review.couchbase.org/62690
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

b050253012-Apr-2016 Sundar Sridharan <sundar.sridharan@gmail.com>

fix build breakage for 32-bit linux (use %eip vs %rip)

Change-Id: I4f3e8de2a1468b07b07e06c5a24a8f691ec69d93
Reviewed-on: http://review.couchbase.org/62696
Tested-by: buildbot <build@

fix build breakage for 32-bit linux (use %eip vs %rip)

Change-Id: I4f3e8de2a1468b07b07e06c5a24a8f691ec69d93
Reviewed-on: http://review.couchbase.org/62696
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

5f72686d12-Apr-2016 Sundar Sridharan <sundar.sridharan@gmail.com>

Fix build breakage for non-couchbase server builds

DL_LIBRARY required for segfault handling was removed by mistake.

Change-Id: I8d477dc2b18e441a9a41e7cba0b399bb91ff877f
Reviewe

Fix build breakage for non-couchbase server builds

DL_LIBRARY required for segfault handling was removed by mistake.

Change-Id: I8d477dc2b18e441a9a41e7cba0b399bb91ff877f
Reviewed-on: http://review.couchbase.org/62694
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

5d870fa411-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

[Windows] Address compilation error seen in standalone forestdb

C:\Program Files (x86)\Microsoft Visual Studio 12.0\
forestdb\tests\e2e\e2etest.cc(23) :
fatal error C1083

[Windows] Address compilation error seen in standalone forestdb

C:\Program Files (x86)\Microsoft Visual Studio 12.0\
forestdb\tests\e2e\e2etest.cc(23) :
fatal error C1083: Cannot open include file:
'unistd.h': No such file or directory

Change-Id: Ic932965b27b63abd6033a65212e994c15e4b8038
Reviewed-on: http://review.couchbase.org/62672
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

6d85230b11-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

MB-19152: Generate backtrace when linked with platform directory

Backtrace has a lot of dependencies that platform and
tlm cater to. Removing backtrace support from standalone
forest

MB-19152: Generate backtrace when linked with platform directory

Backtrace has a lot of dependencies that platform and
tlm cater to. Removing backtrace support from standalone
forestdb, to avoid compilation errors seen on windows:

Linking CXX executable forestdb_dump.exe
backtrace.cc.obj : error LNK2019: unresolved external symbol
__imp__SymGetModuleInfo64@16 reference in function
"void __cdecl describe_address(char *, unsigned int, void *)"
(?describe_address@@YAXPADIPAX@Z)
...

Change-Id: I7f860f8130f131754603fc5a6113b1c653fc979e
Reviewed-on: http://review.couchbase.org/62671
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

90aea09511-Apr-2016 Sundar Sridharan <sundar.sridharan@gmail.com>

Backtrace forestdb segfaults with co-operative signal handling

When forestdb is invoked from golang segmentation faults in
forestdb have no line numbers or backtraces printed out.
Th

Backtrace forestdb segfaults with co-operative signal handling

When forestdb is invoked from golang segmentation faults in
forestdb have no line numbers or backtraces printed out.
This change installs signal handler for SIGSEGV on linux.
If segfault is in forestdb code, invoke breakpad,
else call golang's signal handler to ensure proper functioning.
Follows rules by Ian at https://golang.org/src/os/signal/doc.go

Change-Id: Ie50d4c40d7e3afecbd3c182362ab42d556573964
Reviewed-on: http://review.couchbase.org/62589
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

1de419c809-Apr-2016 Sundar Sridharan <sundar.sridharan@gmail.com>

Fix compiler warnings for signed vs unsigned comparisons

Change-Id: I475b838cc6dd1d7d33c6fa7e9d8589c16e871edc
Reviewed-on: http://review.couchbase.org/62627
Reviewed-by: Chiyoung Seo

Fix compiler warnings for signed vs unsigned comparisons

Change-Id: I475b838cc6dd1d7d33c6fa7e9d8589c16e871edc
Reviewed-on: http://review.couchbase.org/62627
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

2283ca4808-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

MB-19087: Update new_file and prev_file pointers on filemgr_close

Update new_file and prev_file pointers in the case where
fdb_close comes from regular shutdown. This is so that
a re

MB-19087: Update new_file and prev_file pointers on filemgr_close

Update new_file and prev_file pointers in the case where
fdb_close comes from regular shutdown. This is so that
a regular close doesn't race with the close issued by
compaction in certain testcases.

Change-Id: I1e7bcdc8c5e1d5cef03607b2710634aead0fd748
Reviewed-on: http://review.couchbase.org/62622
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...

44d0bd2d09-Apr-2016 Chiyoung Seo <chiyoung.seo@gmail.com>

MB-19025 Reset the header len to zero before fetching a header

As the caller checks the header len after fetching a header, the length
should be reset to zero before fetching the header.

MB-19025 Reset the header len to zero before fetching a header

As the caller checks the header len after fetching a header, the length
should be reset to zero before fetching the header.

Change-Id: Ic24b1eab07b41dfe36f3c66c2b8583a8880c6999
Reviewed-on: http://review.couchbase.org/62625
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

715fe42908-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

MB-19061: Allocate buffer on heap to avoid stack exhaustion

Context: tests/functional/staleblock_test.cc
Windows has a much lower default stack size when compared
to linux.

MB-19061: Allocate buffer on heap to avoid stack exhaustion

Context: tests/functional/staleblock_test.cc
Windows has a much lower default stack size when compared
to linux.

Change-Id: I2d9692487288688a561b4a776a24a8b781783b50
Reviewed-on: http://review.couchbase.org/62620
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

10de594c08-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

MB-19087: Updating new_file and prev_file pointers for a file

Update the new_file and prev_file pointers within the openLock
in filemgr_close as opposed to filemgr_free_func, so that the

MB-19087: Updating new_file and prev_file pointers for a file

Update the new_file and prev_file pointers within the openLock
in filemgr_close as opposed to filemgr_free_func, so that there
is no race in updating the links.

Change-Id: Ibddf6e261786e9c0ecf574383e7f0e94cbd05b54
Reviewed-on: http://review.couchbase.org/62596
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...

7e16081a07-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

MB-19050: Address lock inversion with file handle lock and kv_header's lock

11:02:18 WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid=109140)
11:02:18 Cycle in

MB-19050: Address lock inversion with file handle lock and kv_header's lock

11:02:18 WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid=109140)
11:02:18 Cycle in lock order graph: M199 (0x7d0c0000eff0) => M517 (0x7d100000d570) => M199
11:02:18
11:02:18 Mutex M517 acquired here while holding mutex M199 in main thread:
11:02:18 #0 pthread_spin_lock <null> (multi_kv_functional_test+0x000000466ac0)
11:02:18 #1 fdb_kvs_open /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/kv_instance.cc:1650 (multi_kv_functional_test+0x000000530523)
11:02:18 #2 multi_kv_test(unsigned char, unsigned long) crtstuff.c (multi_kv_functional_test+0x0000004c973a)
11:02:18 #3 main crtstuff.c (multi_kv_functional_test+0x0000004ddc47)
11:02:18
11:02:18 Mutex M199 previously acquired by the same thread here:
11:02:18 #0 pthread_spin_lock <null> (multi_kv_functional_test+0x000000466ac0)
11:02:18 #1 fdb_kvs_open /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/kv_instance.cc:1638 (multi_kv_functional_test+0x000000530387)
11:02:18 #2 multi_kv_test(unsigned char, unsigned long) crtstuff.c (multi_kv_functional_test+0x0000004c973a)
11:02:18 #3 main crtstuff.c (multi_kv_functional_test+0x0000004ddc47)
11:02:18
11:02:18 Mutex M199 acquired here while holding mutex M517 in main thread:
11:02:18 #0 pthread_spin_lock <null> (multi_kv_functional_test+0x000000466ac0)
11:02:18 #1 _fdb_kvs_any_handle_opened(_fdb_file_handle*, unsigned long) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/kv_instance.cc:94 (multi_kv_functional_test+0x000000532f4a)
11:02:18 #2 _fdb_kvs_remove(_fdb_file_handle*, char const*, bool) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/kv_instance.cc:1980 (multi_kv_functional_test+0x000000531d63)
11:02:18 #3 fdb_kvs_remove /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/kv_instance.cc:2267 (multi_kv_functional_test+0x000000532220)
11:02:18 #4 multi_kv_test(unsigned char, unsigned long) crtstuff.c (multi_kv_functional_test+0x0000004c9836)
11:02:18 #5 main crtstuff.c (multi_kv_functional_test+0x0000004ddc47)
11:02:18
11:02:18 Mutex M517 previously acquired by the same thread here:
11:02:18 #0 pthread_spin_lock <null> (multi_kv_functional_test+0x000000466ac0)
11:02:18 #1 _fdb_kvs_remove(_fdb_file_handle*, char const*, bool) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/kv_instance.cc:1968 (multi_kv_functional_test+0x000000531b7b)
11:02:18 #2 fdb_kvs_remove /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/kv_instance.cc:2267 (multi_kv_functional_test+0x000000532220)
11:02:18 #3 multi_kv_test(unsigned char, unsigned long) crtstuff.c (multi_kv_functional_test+0x0000004c9836)
11:02:18 #4 main crtstuff.c (multi_kv_functional_test+0x0000004ddc47)

Change-Id: I7a4a9a0eb89eeb13c47ade3f8e3e80de7b2ad2d1
Reviewed-on: http://review.couchbase.org/62582
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

ebd50c5906-Apr-2016 Jung-Sang Ahn <jungsang.ahn@gmail.com>

Get rid of an unused function: sb_bmp_is_active_block()

Change-Id: I7a1df436f97fd09b8d8db776c4fde7b42626b023
Reviewed-on: http://review.couchbase.org/62480
Reviewed-by: Chiyoung Seo

Get rid of an unused function: sb_bmp_is_active_block()

Change-Id: I7a1df436f97fd09b8d8db776c4fde7b42626b023
Reviewed-on: http://review.couchbase.org/62480
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

4416967306-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

MB-19087: Address heap use after free issue with file pointers

In compaction scenario, before a file is freed, the
pointer to it held by a previous file and the pointer
to it held by

MB-19087: Address heap use after free issue with file pointers

In compaction scenario, before a file is freed, the
pointer to it held by a previous file and the pointer
to it held by a new file will need to be updated.

In the case of multiple files being present, and more than one
file has been redirected to the current file, the new_file pointers
of all those files will need to be updated in case the current file
is deleted.

10:59:36 WARNING: ThreadSanitizer: heap-use-after-free (pid=108627)
10:59:36 Read of size 1 at 0x7d640001f558 by main thread (mutexes: write M14, write M7597):
10:59:36 #0 filemgr_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/filemgr.cc:1451 (iterator_functional_test+0x000000504b5f)
10:59:36 #1 _fdb_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7203 (iterator_functional_test+0x0000005123bb)
10:59:36 #2 _fdb_close_root /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7174 (iterator_functional_test+0x000000511854)
10:59:36 #3 fdb_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7135 (iterator_functional_test+0x00000051ee5a)
10:59:36 #4 iterator_concurrent_compaction() crtstuff.c (iterator_functional_test+0x0000004e2078)
10:59:36 #5 main crtstuff.c (iterator_functional_test+0x0000004e4e1d)
10:59:36
10:59:36 Previous write of size 8 at 0x7d640001f558 by main thread:
10:59:36 #0 free <null> (iterator_functional_test+0x00000046136b)
10:59:36 #1 filemgr_free_func /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/filemgr.cc:1657 (iterator_functional_test+0x000000502a9f)
10:59:36 #2 filemgr_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/filemgr.cc:1479 (iterator_functional_test+0x000000504ea4)
10:59:36 #3 _fdb_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7203 (iterator_functional_test+0x0000005123bb)
10:59:36 #4 fdb_kvs_close_all /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/kv_instance.cc:1789 (iterator_functional_test+0x000000537922)
10:59:36 #5 _fdb_close_root /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7157 (iterator_functional_test+0x0000005117d3)
10:59:36 #6 fdb_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7135 (iterator_functional_test+0x00000051ee5a)
10:59:36 #7 iterator_concurrent_compaction() crtstuff.c (iterator_functional_test+0x0000004e2078)
10:59:36 #8 main crtstuff.c (iterator_functional_test+0x0000004e4e1d)

Change-Id: Iacf78604494026b33085663146d2adfda319fff9
Reviewed-on: http://review.couchbase.org/62449
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

410b475b06-Apr-2016 Sundar Sridharan <sundar.sridharan@gmail.com>

MB-19041:ThreadSanitizer data race - disable prefetch thread

Multiple races such as ...
WARNING: ThreadSanitizer: thread leak (pid=108225)
Thread T5 (tid=108255, finished) created by

MB-19041:ThreadSanitizer data race - disable prefetch thread

Multiple races such as ...
WARNING: ThreadSanitizer: thread leak (pid=108225)
Thread T5 (tid=108255, finished) created by main
thread at:
pthread_create <null> (fdb_functional_test+0x000000464d21)
filemgr_open forestdb/src/filemgr.cc:677 (fdb_functional_test+)
_fdb_open forestdb/src/forestdb.cc:1604 (fdb_functional_test+)
fdb_open forestdb/src/forestdb.cc:782 (fdb_functional_test+)
basic_test() crtstuff.c (fdb_functional_test+)
main crtstuff.c (fdb_functional_test+)

Change-Id: I281877320e2cd592ef427f1022fa02823ed1fa80
Reviewed-on: http://review.couchbase.org/62450
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

b5540fc305-Apr-2016 Jung-Sang Ahn <jungsang.ahn@gmail.com>

MB-19047 Convert some fields in superblock to atomic variable

- 'revnum', 'last_hdr_bid', and 'last_hdr_revnum' are converted to
atomic variable.

- Superblock doesn't need to be

MB-19047 Convert some fields in superblock to atomic variable

- 'revnum', 'last_hdr_bid', and 'last_hdr_revnum' are converted to
atomic variable.

- Superblock doesn't need to be synched for every close; now update
happens only when 1) the handle is not read-only, and 2) handle info
is newer than that in superblock.

Change-Id: Id5130e54cabdf35b13b46284571859c9d2089a18
Reviewed-on: http://review.couchbase.org/62438
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

78e00e6305-Apr-2016 Jung-Sang Ahn <jungsang.ahn@gmail.com>

MB-19047 Grab lock for superblock initialization

- If concurrent threads try to load BMP at the same time, memory leak
can happen.

- This happens only when multiple threads open

MB-19047 Grab lock for superblock initialization

- If concurrent threads try to load BMP at the same time, memory leak
can happen.

- This happens only when multiple threads open a file (which is not
opened yet) at the first time; otherwise lock contention will not
exist.

Change-Id: I4c4069c31e54547cd4c2ddde5c254e63fa2c6c45
Reviewed-on: http://review.couchbase.org/62425
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

93b9365b05-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

Filemgr_openlock to be acquired for a hash table scan

Context: filemgr_shutdown() in src/filemgr.cc

Change-Id: I413eb81c134c59a4589d9d7c08f590c15a0506de
Reviewed-on: http://revi

Filemgr_openlock to be acquired for a hash table scan

Context: filemgr_shutdown() in src/filemgr.cc

Change-Id: I413eb81c134c59a4589d9d7c08f590c15a0506de
Reviewed-on: http://review.couchbase.org/62461
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

89e47c0804-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

MB-19042: Address data race with fetching file's kv_header

11:38:55 WARNING: ThreadSanitizer: data race (pid=121717)
11:38:55 Write of size 8 at 0x7d6400a12d60 by thread T4 (mutexes: w

MB-19042: Address data race with fetching file's kv_header

11:38:55 WARNING: ThreadSanitizer: data race (pid=121717)
11:38:55 Write of size 8 at 0x7d6400a12d60 by thread T4 (mutexes: write M13601):
11:38:55 #0 filemgr_set_kv_header /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/filemgr.cc:2473 (e2etest+0x0000004f4bd3)
11:38:55 #1 _fdb_open /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:1697 (e2etest+0x0000004f9b97)
11:38:55 #2 fdb_check_file_reopen /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:2774 (e2etest+0x0000004fc5b7)
11:38:55 #3 fdb_set /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:3581 (e2etest+0x00000050313f)
11:38:55 #4 fdb_set_kv <null> (e2etest+0x0000004d2a29)
11:38:55 #5 e2e_fdb_set_person crtstuff.c (e2etest+0x0000004d0392)
11:38:55 #6 writer_thread(void*) crtstuff.c (e2etest+0x0000004c9bd2)
11:38:55
11:38:55 Previous read of size 8 at 0x7d6400a12d60 by thread T41:
11:38:55 #0 _fdb_open /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:1691 (e2etest+0x0000004f9afa)
11:38:55 #1 fdb_check_file_reopen /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:2774 (e2etest+0x0000004fc5b7)
11:38:55 #2 fdb_set /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:3581 (e2etest+0x00000050313f)
11:38:55 #3 fdb_set_kv <null> (e2etest+0x0000004d2a29)
11:38:55 #4 e2e_fdb_set_person crtstuff.c (e2etest+0x0000004d0392)
11:38:55 #5 writer_thread(void*) crtstuff.c (e2etest+0x0000004c9bd2)

Change-Id: I7d08e187edc3fa930d90065ed6b2524f266959ab
Reviewed-on: http://review.couchbase.org/62383
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...

7a19cd3804-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

Address data race in compaction_cancellation test case

11:04:36 Write of size 1 at 0x00000156a5f8 by thread T20:
11:04:36 #0 cb_cancel_test(_fdb_file_handle*, unsigned int, char co

Address data race in compaction_cancellation test case

11:04:36 Write of size 1 at 0x00000156a5f8 by thread T20:
11:04:36 #0 cb_cancel_test(_fdb_file_handle*, unsigned int, char const*, fdb_doc_struct*, unsigned long, unsigned long, void*) /home/couchbase/.ccache/tmp/compact_fu.tmp.2ec072386919.90336.ii (compact_functional_test+0x0000004dab23)
11:04:36 #1 _fdb_compact_move_docs(_fdb_kvs_handle*, filemgr*, hbtrie*, btree*, btree*, btree*, docio_handle*, btreeblk_handle*, unsigned long*, bool) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:5101 (compact_functional_test+0x0000005123cf)
11:04:36 #2 _fdb_compact_file(_fdb_kvs_handle*, filemgr*, btreeblk_handle*, docio_handle*, hbtrie*, hbtrie*, btree*, btree*, unsigned long, bool) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:6740 (compact_functional_test+0x00000050e277)
11:04:36 #3 fdb_compact_file /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:6618 (compact_functional_test+0x00000050da9f)
11:04:36 #4 _fdb_compact(_fdb_file_handle*, char const*, unsigned long, bool, fdb_encryption_key const*) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:6945 (compact_functional_test+0x00000051504c)
11:04:36 #5 fdb_compact /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:6970 (compact_functional_test+0x000000514f2a)
11:04:36 #6 db_compact_during_compaction_cancellation(void*) crtstuff.c (compact_functional_test+0x0000004daa28)
11:04:36
11:04:36 Previous read of size 1 at 0x00000156a5f8 by main thread:
11:04:36 #0 compaction_cancellation_test(compaction_test_mode) crtstuff.c (compact_functional_test+0x0000004dad11)
11:04:36 #1 __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 (libc.so.6+0x00000002176c)

Change-Id: Id2cc1bd557cd751bf9dd31c8ad5a62f799bce7e7
Reviewed-on: http://review.couchbase.org/62380
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...

12345678910>>...53