History log of /6.0.3/forestdb/ (Results 76 - 100 of 1302)
Revision (<<< Hide revision tags) (Show revision tags >>>)Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
5403f41922-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

MB-19321: Handle API calls with NULL arguments gracefully

+ Return FDB_RESULT_INVALID_ARGS in case of NULL handles.
+ Affected APIs:
- fdb_snapshot_open
- fdb_rollback

MB-19321: Handle API calls with NULL arguments gracefully

+ Return FDB_RESULT_INVALID_ARGS in case of NULL handles.
+ Affected APIs:
- fdb_snapshot_open
- fdb_rollback
- fdb_set_log_callback
- fdb_get_byoffset
- fdb_set
- fdb_del
- fdb_commit
- fdb_compact
- fdb_compact_with_cow
- fdb_rekey
- fdb_iterator_seek
- fdb_iterator_seek_to_min
- fdb_iterator_seek_to_max
- fdb_iterator_prev
- fdb_iterator_next
- fdb_iteartor_get
- fdb_iterator_get_metaonly
- fdb_kvs_open
- fdb_kvs_close
- fdb_begin_transaction
- fdb_abort_transaction
- fdb_end_transaction
+ Unit test

Change-Id: I2887e64d5cb4d2c50dde746b971caf9adbb63051
Reviewed-on: http://review.couchbase.org/63215
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

67566f2a20-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

MB-19306: Do not let fdb_get_byoffset() access out of bounds memory

10:18:34 WARNING: ThreadSanitizer: heap-use-after-free (pid=226090)
10:18:34 Read of size 1 at 0x7d8000618000 by mai

MB-19306: Do not let fdb_get_byoffset() access out of bounds memory

10:18:34 WARNING: ThreadSanitizer: heap-use-after-free (pid=226090)
10:18:34 Read of size 1 at 0x7d8000618000 by main thread:
10:18:34 #0 memcpy <null> (fdb_functional_test+0x000000462790)
10:18:34 #1 _docio_read_length(docio_handle*, unsigned long, docio_length*, err_log_callback*, bool) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/docio.cc:794 (fdb_functional_test+0x0000004faad5)
10:18:34 #2 docio_read_doc /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/docio.cc:1214 (fdb_functional_test+0x0000004fba3f)
10:18:34 #3 fdb_get_byoffset /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:3483 (fdb_functional_test+0x00000051313c)
10:18:34 #4 invalid_get_byoffset_test() crtstuff.c (fdb_functional_test+0x0000004e16cd)
10:18:34 #5 main crtstuff.c (fdb_functional_test+0x0000004e264b)
10:18:34
10:18:34 Previous write of size 8 at 0x7d8000618000 by main thread:
10:18:34 [failed to restore the stack]

Change-Id: I59af475900ad30f24190e2710a8e67c9689c0d3a
Reviewed-on: http://review.couchbase.org/63111
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

733d0c4320-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

MB-19236: Suppress data race seen with block cache's item->addr

This data race will never happen in reality. The bcache partition
lock is released iff a given dirty block has already mar

MB-19236: Suppress data race seen with block cache's item->addr

This data race will never happen in reality. The bcache partition
lock is released iff a given dirty block has already marked as
immutable. The bcache unit tests attempt to write to the same
immutable block again causing this race, while in reality this
wouldn't happen as these operations go through filemgr_read()
and filemgr_write().

WARNING: ThreadSanitizer: data race (pid=24573)
Read of size 8 at 0x7d080000efc0 by thread T2:
#0 pwrite <null>:0 (bcache_test+0x000000065100)
#1 _filemgr_linux_pwrite(int, void*, unsigned long, long) /root/work/watson/forestdb/src/filemgr_ops_linux.cc:50 (bcache_test+0x0000000ce1df)
#2 filemgr_write_blocks /root/work/watson/forestdb/src/filemgr.cc:352 (bcache_test+0x0000000c35a3)
#3 _flush_dirty_blocks(fnamedic_item*, bool, bool, bool) /root/work/watson/forestdb/src/blockcache.cc:585 (bcache_test+0x0000000c05d5)
#4 _bcache_evict(fnamedic_item*) /root/work/watson/forestdb/src/blockcache.cc:712 (bcache_test+0x0000000bf0a8)
#5 worker(void*) /root/work/watson/forestdb/tests/unit/bcache_test.cc:144 (bcache_test+0x0000000bbf31)

Previous write of size 8 at 0x7d080000efc0 by thread T1 (mutexes: write M247):
#0 memcpy <null>:0 (bcache_test+0x000000055950)
#1 bcache_write /root/work/watson/forestdb/src/blockcache.cc:1159 (bcache_test+0x0000000bf4c3)
#2 worker(void*) /root/work/watson/forestdb/tests/unit/bcache_test.cc:163 (bcache_test+0x0000000bc025)

Change-Id: I7ee09ac70a573fecbdcc47dddfed48b67818f48d
Reviewed-on: http://review.couchbase.org/63102
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

04c3d9a619-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

Suppress coverity warning seen with superblock.cc

||| CID 93208: Null pointer dereferences (FORWARD_NULL)
||| Assigning: "new_bmp" = "NULL".

Change-Id: I464c12d9140046c0b95e52

Suppress coverity warning seen with superblock.cc

||| CID 93208: Null pointer dereferences (FORWARD_NULL)
||| Assigning: "new_bmp" = "NULL".

Change-Id: I464c12d9140046c0b95e52e99659066a79512df1
Reviewed-on: http://review.couchbase.org/63041
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>

show more ...

bb32a27919-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

Address Control_flow_issues_(DEADCODE) in hbtrie.cc

This change doesn't alter anything semantically, but
will address the following warning seen with coverity
scan:

||| Exec

Address Control_flow_issues_(DEADCODE) in hbtrie.cc

This change doesn't alter anything semantically, but
will address the following warning seen with coverity
scan:

||| Execution cannot reach this statement: "return HBTRIE_RESULT_FAIL;".

Change-Id: I0089b1e838404d90da0dbbf9964a0f7cbfe30326
Reviewed-on: http://review.couchbase.org/63040
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

c1a4cfaa19-Apr-2016 Sundar Sridharan <sundar.sridharan@gmail.com>

fix comment errors in default configuration

Change-Id: I0e634d67625b3401c9f13721bad5cfc0b5836f45
Reviewed-on: http://review.couchbase.org/63038
Reviewed-by: Sundararaman Sridharan <s

fix comment errors in default configuration

Change-Id: I0e634d67625b3401c9f13721bad5cfc0b5836f45
Reviewed-on: http://review.couchbase.org/63038
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: Sundararaman Sridharan <sundar@couchbase.com>

show more ...

c835d42318-Apr-2016 Sundar Sridharan <sundar.sridharan@gmail.com>

MB-19237: Avoid touching the shared snapshot during clone

[ThreadSanitizer] data race in snap_clone_test in mvcc_functional_test
When cloning a handle, it is not necessary to update the

MB-19237: Avoid touching the shared snapshot during clone

[ThreadSanitizer] data race in snap_clone_test in mvcc_functional_test
When cloning a handle, it is not necessary to update the stats
in the shared snapshot handle since the snapshot handle itself is
ref counted and shared. This avoids data races when many readers
are cloning simultaneously. This allows for safe lock-free opens
among readers.

Change-Id: I805cde57bb28b30e9f6aa44a98b48b2b1c9e1b96
Reviewed-on: http://review.couchbase.org/62984
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

d4bc5f9d15-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

TSan throws out a false positive because of memory-reuse

db reused the same memory that was used by compact file
and thread sanitizer isn't able to detect that this is
not a legit he

TSan throws out a false positive because of memory-reuse

db reused the same memory that was used by compact file
and thread sanitizer isn't able to detect that this is
not a legit heap-use-after-free issue.

11:30:49 WARNING: ThreadSanitizer: heap-use-after-free (pid=115833)
11:30:49 Read of size 1 at 0x7d6400325b60 by main thread (mutexes: write M32786, write M19379964):
11:30:49 #0 filemgr_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/filemgr.cc:1481 (compact_functional_test+0x0000004fb4b4)
11:30:49 #1 _fdb_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7232 (compact_functional_test+0x0000005090bb)
11:30:49 #2 _fdb_close_root /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7203 (compact_functional_test+0x000000508560)
11:30:49 #3 fdb_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7161 (compact_functional_test+0x000000515dda)
11:30:49 #4 compact_reopen_with_iterator() crtstuff.c (compact_functional_test+0x0000004cb6fe)
11:30:49 #5 main crtstuff.c (compact_functional_test+0x0000004db4ee)
11:30:49
11:30:49 Previous write of size 8 at 0x7d6400325b60 by main thread:
11:30:49 #0 free <null> (compact_functional_test+0x0000004613bb)
11:30:49 #1 filemgr_free_func /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/filemgr.cc:1691 (compact_functional_test+0x0000004f8fef)
11:30:49 #2 filemgr_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/filemgr.cc:1567 (compact_functional_test+0x0000004fb8db)
11:30:49 #3 _fdb_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7232 (compact_functional_test+0x0000005090bb)
11:30:49 #4 fdb_kvs_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/kv_instance.cc:1773 (compact_functional_test+0x00000052eb13)
11:30:49 #5 compact_reopen_with_iterator() crtstuff.c (compact_functional_test+0x0000004cb6e1)
11:30:49 #6 main crtstuff.c (compact_functional_test+0x0000004db4ee)

Change-Id: I06c3f52669d8b6d33c5e3a99b28b7e931f13bc9e
Reviewed-on: http://review.couchbase.org/62934
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

ad0a1e2f15-Apr-2016 Jung-Sang Ahn <jungsang.ahn@gmail.com>

Check bmp_size before accessing bitmap

- Out-of-bound access to bitmap may occur.

Change-Id: Icc465e8456435d58f058e234c15e8e82c68e8416
Reviewed-on: http://review.couchbase.org/6

Check bmp_size before accessing bitmap

- Out-of-bound access to bitmap may occur.

Change-Id: Icc465e8456435d58f058e234c15e8e82c68e8416
Reviewed-on: http://review.couchbase.org/62893
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

92a56e7514-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

Address test heap-use-after-free issue

11:25:22 WARNING: ThreadSanitizer: heap-use-after-free (pid=115558)
11:25:22 Read of size 8 at 0x7d040000f308 by main thread:
11:25:22 #0

Address test heap-use-after-free issue

11:25:22 WARNING: ThreadSanitizer: heap-use-after-free (pid=115558)
11:25:22 Read of size 8 at 0x7d040000f308 by main thread:
11:25:22 #0 _cmp_double(void*, unsigned long, void*, unsigned long) /home/couchbase/.ccache/tmp/fdb_functi.tmp.140592e37b0d.95346.ii (fdb_functional_test+0x0000004d4dcc)
11:25:22 #1 __wal_cmp_bykey(wal_item_header*, wal_item_header*, void*) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/wal.cc:80 (fdb_functional_test+0x000000548483)
11:25:22 #2 _snap_cmp_bykey(avl_node*, avl_node*, void*) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/wal.cc:116 (fdb_functional_test+0x000000547ffc)
11:25:22 #3 avl_search_greater /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/avltree.cc:351 (fdb_functional_test+0x0000004e2f96)
11:25:22 #4 wal_itr_search_greater /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/wal.cc:2179 (fdb_functional_test+0x000000542d42)
11:25:22 #5 fdb_iterator_init <null> (fdb_functional_test+0x00000052b345)
11:25:22 #6 custom_compare_primitive_test() crtstuff.c (fdb_functional_test+0x0000004d4692)
11:25:22 #7 main crtstuff.c (fdb_functional_test+0x0000004e258a)
11:25:22
11:25:22 Previous write of size 8 at 0x7d040000f308 by main thread (mutexes: write M672581587812037744):
11:25:22 #0 free <null> (fdb_functional_test+0x00000046144b)
11:25:22 #1 free_docio_object /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/docio.cc:1067 (fdb_functional_test+0x0000004fb29a)
11:25:22 #2 fdb_kvs_header_read /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/kv_instance.cc:1134 (fdb_functional_test+0x000000532fba)
11:25:22 #3 _fdb_open /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:1980 (fdb_functional_test+0x00000050b393)
11:25:22 #4 fdb_open /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:807 (fdb_functional_test+0x0000005096ea)
11:25:22 #5 seq_tree_exception_test() crtstuff.c (fdb_functional_test+0x0000004cde92)
11:25:22 #6 main crtstuff.c (fdb_functional_test+0x0000004e257b)

Change-Id: I9191bc57e00fefadb0f31fee7cc48c3ad04cf43b
Reviewed-on: http://review.couchbase.org/62875
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

3f8ea20514-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

Addressing various detected static analyzer issues

Change-Id: I6a9af023e9ba811da7d8069a0491c41378bbc259
Reviewed-on: http://review.couchbase.org/62864
Tested-by: buildbot <build@couc

Addressing various detected static analyzer issues

Change-Id: I6a9af023e9ba811da7d8069a0491c41378bbc259
Reviewed-on: http://review.couchbase.org/62864
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Reviewed-by: Jung-Sang Ahn <jungsang.ahn@gmail.com>

show more ...

1c75bd9314-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

Address compiler warning seen in filemgr.cc

/home/abhinav/couchbase/forestdb/src/filemgr.cc:3560:27:
warning: ‘addr’ may be used uninitialized in this function

Address compiler warning seen in filemgr.cc

/home/abhinav/couchbase/forestdb/src/filemgr.cc:3560:27:
warning: ‘addr’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
block->addr = addr;
^

Change-Id: If78928413476e3bde7d5838b0779e564a3535b5c
Reviewed-on: http://review.couchbase.org/62852
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

73449b7714-Apr-2016 Chiyoung Seo <chiyoung.seo@gmail.com>

MB-19023 Don't release a filemgr's lock twice upon compaction failure

When the compaction fails due to the commit failure on the old file,
then the new file_mgr's lock is released before

MB-19023 Don't release a filemgr's lock twice upon compaction failure

When the compaction fails due to the commit failure on the old file,
then the new file_mgr's lock is released before calling
_fdb_cleanup_compact_err(). Therefore, we shouldn't release it again
in _fdb_cleanup_compact_err().

Change-Id: If31226aaa8d2919700e3e12ba3d644d818d0513c
Reviewed-on: http://review.couchbase.org/62828
Reviewed-by: Jung-Sang Ahn <jungsang.ahn@gmail.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

5b0b2b2e14-Apr-2016 Sundar Sridharan <sundar.sridharan@gmail.com>

MB-19179: Disable WAL seqtree if FDB_SEQTREE_NOT_USE

This fixes crashes in cbft and also improves point query perf

Change-Id: If15c72d39119b215b7c5566e51ac5faee455978f
Reviewed-

MB-19179: Disable WAL seqtree if FDB_SEQTREE_NOT_USE

This fixes crashes in cbft and also improves point query perf

Change-Id: If15c72d39119b215b7c5566e51ac5faee455978f
Reviewed-on: http://review.couchbase.org/62809
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

63a9431414-Apr-2016 Jung-Sang Ahn <jungsang.ahn@gmail.com>

MB-19023 Commit old file at the last stage of compaction

- If dirty WAL flush happens at the last loop of move delta, then
old file's last header doesn't include the up-to-date root node

MB-19023 Commit old file at the last stage of compaction

- If dirty WAL flush happens at the last loop of move delta, then
old file's last header doesn't include the up-to-date root node info.

- It may cause various kinds of failures including hb-trie assertion.

Change-Id: I0f5b574d49231f79af88168d6d0c43fe8646a4c0
Reviewed-on: http://review.couchbase.org/62824
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

a8f01baa14-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

Address data race with filemgr's bcache

Change-Id: I98a94cd9cc7acfce02bdf15b67e0cf9ace95e0e0
14:15:16 WARNING: ThreadSanitizer: data race (pid=68020)
14:15:16 Write of size 8 at 0x

Address data race with filemgr's bcache

Change-Id: I98a94cd9cc7acfce02bdf15b67e0cf9ace95e0e0
14:15:16 WARNING: ThreadSanitizer: data race (pid=68020)
14:15:16 Write of size 8 at 0x7d6400163b28 by thread T15 (mutexes: write M13):
14:15:16 #0 _fname_create(filemgr*) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/blockcache.cc:812 (e2etest+0x0000004d5c60)
14:15:16 #1 bcache_write /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/blockcache.cc:1062 (e2etest+0x0000004d526d)
14:15:16 #2 filemgr_read /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/filemgr.cc:2043 (e2etest+0x0000004f1a9b)
14:15:16 #3 _docio_read_through_buffer(docio_handle*, unsigned long, err_log_callback*, bool) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/docio.cc:691 (e2etest+0x0000004ea770)
14:15:16 #4 docio_read_doc /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/docio.cc:1212 (e2etest+0x0000004eb86f)
14:15:16 #5 fdb_kvs_header_read /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/kv_instance.cc:1123 (e2etest+0x000000522e4c)
14:15:16 #6 _fdb_open /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:1720 (e2etest+0x0000004fa137)
14:15:16 #7 fdb_check_file_reopen /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:2800 (e2etest+0x0000004fcb77)
14:15:16 #8 fdb_set /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:3607 (e2etest+0x00000050372f)
14:15:16 #9 fdb_set_kv <null> (e2etest+0x0000004d2a29)
14:15:16 #10 update_thread(void*) crtstuff.c (e2etest+0x0000004c9d26)
14:15:16
14:15:16 Previous read of size 8 at 0x7d6400163b28 by thread T14:
14:15:16 #0 bcache_read /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/blockcache.cc:924 (e2etest+0x0000004d4ddf)
14:15:16 #1 filemgr_read /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/filemgr.cc:1976 (e2etest+0x0000004f14f1)
14:15:16 #2 _docio_read_through_buffer(docio_handle*, unsigned long, err_log_callback*, bool) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/docio.cc:691 (e2etest+0x0000004ea770)
14:15:16 #3 docio_read_doc /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/docio.cc:1212 (e2etest+0x0000004eb86f)
14:15:16 #4 fdb_kvs_header_read /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/kv_instance.cc:1123 (e2etest+0x000000522e4c)
14:15:16 #5 _fdb_open /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:1720 (e2etest+0x0000004fa137)
14:15:16 #6 fdb_check_file_reopen /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:2800 (e2etest+0x0000004fcb77)
14:15:16 #7 fdb_set /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:3607 (e2etest+0x00000050372f)
14:15:16 #8 fdb_set_kv <null> (e2etest+0x0000004d2a29)
14:15:16 #9 e2e_fdb_set_person crtstuff.c (e2etest+0x0000004d0392)
14:15:16 #10 seq_writer_thread(void*) crtstuff.c (e2etest+0x0000004c9c62)
Reviewed-on: http://review.couchbase.org/62820
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

4a852f5a14-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

Replace asserts with fdb_asserts in usecase_test

fdb_assert() carries more information on why the check
failed. This is intended to help debug failures seen
in CV.

Change-Id

Replace asserts with fdb_asserts in usecase_test

fdb_assert() carries more information on why the check
failed. This is intended to help debug failures seen
in CV.

Change-Id: I215aaa3ea16e85038042ddf76d29b18993ddd967
Reviewed-on: http://review.couchbase.org/62821
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...

c35ce17114-Apr-2016 Chiyoung Seo <chiyoung.seo@gmail.com>

Fix to the sporadic failure in auto_compaction_snapshots_test

Snapshot handle should be used in fdb_get_byseq to get the consistent
immutable result while auto compaction is running.

Fix to the sporadic failure in auto_compaction_snapshots_test

Snapshot handle should be used in fdb_get_byseq to get the consistent
immutable result while auto compaction is running.

Change-Id: I0d4ff3496d27c6d7f9b8bca3412c4e8b48d70643
Reviewed-on: http://review.couchbase.org/62818
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

b4f5e4e413-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

[staleblock_test] Free markers after use

Free markers through fdb_free_snap_markers
after use to avoid heap-use-after-free issue
as detected by thread sanitizer.

Change-Id:

[staleblock_test] Free markers after use

Free markers through fdb_free_snap_markers
after use to avoid heap-use-after-free issue
as detected by thread sanitizer.

Change-Id: Id34281cb2d9c91d4d8934beefb2f186aea1bc035
11:43:20 WARNING: ThreadSanitizer: heap-use-after-free (pid=116815)
11:43:20 Read of size 8 at 0x7d300000bfb0 by main thread:
11:43:20 #0 superblock_recovery_test() crtstuff.c (staleblock_test+0x0000004d1be2)
11:43:20 #1 main crtstuff.c (staleblock_test+0x0000004d2662)
11:43:20
11:43:20 Previous write of size 8 at 0x7d300000bfb0 by main thread:
11:43:20 #0 free <null> (staleblock_test+0x00000046136b)
11:43:20 #1 fdb_free_snap_markers /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7700 (staleblock_test+0x00000050e49f)
11:43:20 #2 superblock_recovery_test() crtstuff.c (staleblock_test+0x0000004d1bbc)
11:43:20 #3 main crtstuff.c (staleblock_test+0x0000004d2662)
Reviewed-on: http://review.couchbase.org/62812
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

36a4344313-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

Address data race with wal_item's flag

11:38:53 WARNING: ThreadSanitizer: data race (pid=116143)
11:38:53 Write of size 1 at 0x7d2000217641 by thread T27 (mutexes: write M702774, write

Address data race with wal_item's flag

11:38:53 WARNING: ThreadSanitizer: data race (pid=116143)
11:38:53 Write of size 1 at 0x7d2000217641 by thread T27 (mutexes: write M702774, write M703325, write M702832):
11:38:53 #0 _wal_flush(filemgr*, void*, fdb_status (*)(void*, wal_item*, avl_tree*, avl_tree*), unsigned long (*)(void*, wal_item*), void (*)(void*, avl_tree*, avl_tree*), void (*)(filemgr*, avl_tree*), wal_flush_items*, bool) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/wal.cc:1628 (mvcc_functional_test+0x000000546a9d)
11:38:53 #1 wal_flush /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/wal.cc:1724 (mvcc_functional_test+0x0000005466a1)
11:38:53 #2 _fdb_compact_file(_fdb_kvs_handle*, filemgr*, btreeblk_handle*, docio_handle*, hbtrie*, hbtrie*, btree*, btree*, unsigned long, bool) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:6691 (mvcc_functional_test+0x00000051a281)
11:38:53 #3 fdb_compact_file /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:6644 (mvcc_functional_test+0x00000051a05f)
11:38:53 #4 compactor_thread(void*) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/compactor.cc:396 (mvcc_functional_test+0x0000004fb8a2)
11:38:53
11:38:53 Previous read of size 1 at 0x7d2000217641 by main thread (mutexes: write M702835):
11:38:53 #0 __wal_cmp_byseq(wal_item*, wal_item*) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/wal.cc:120 (mvcc_functional_test+0x00000054d046)
11:38:53 #1 _wal_cmp_byseq(avl_node*, avl_node*, void*) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/wal.cc:143 (mvcc_functional_test+0x00000054cf26)
11:38:53 #2 avl_search /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/avltree.cc:325 (mvcc_functional_test+0x0000004e7df4)
11:38:53 #3 _wal_find(_fdb_transaction*, filemgr*, unsigned long, _fdb_key_cmp_info*, snap_handle*, fdb_doc_struct*, unsigned long*) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/wal.cc:978 (mvcc_functional_test+0x0000005451ed)
11:38:53 #4 wal_find_kv_id /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/wal.cc:1041 (mvcc_functional_test+0x0000005455ec)
11:38:53 #5 fdb_get_byseq /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:3179 (mvcc_functional_test+0x000000516c64)
11:38:53 #6 auto_compaction_snapshots_test() crtstuff.c (mvcc_functional_test+0x0000004e235b)
11:38:53 #7 main crtstuff.c (mvcc_functional_test+0x0000004e7542)

Change-Id: Ib935696426aedb88465e61941ba2bf44faee2ad3
Reviewed-on: http://review.couchbase.org/62797
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

b495fd3613-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

Address data race with compactor's compactor_terminate_signal

11:38:53 WARNING: ThreadSanitizer: data race (pid=116143)
11:38:53 Write of size 1 at 0x0000015787d0 by main thread (mutex

Address data race with compactor's compactor_terminate_signal

11:38:53 WARNING: ThreadSanitizer: data race (pid=116143)
11:38:53 Write of size 1 at 0x0000015787d0 by main thread (mutexes: write M10, write M32788):
11:38:53 #0 compactor_shutdown /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/compactor.cc:534 (mvcc_functional_test+0x0000004fbd8a)
11:38:53 #1 fdb_shutdown /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7782 (mvcc_functional_test+0x000000523605)
11:38:53 #2 rollback_drop_multi_files_kvs_test() crtstuff.c (mvcc_functional_test+0x0000004e4bd1)
11:38:53 #3 main crtstuff.c (mvcc_functional_test+0x0000004e7527)
11:38:53
11:38:53 Previous read of size 1 at 0x0000015787d0 by thread T6 (mutexes: write M32787):
11:38:53 #0 compactor_thread(void*) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/compactor.cc:463 (mvcc_functional_test+0x0000004fb938)

Change-Id: I80274934d56310b17e04bfb25e0f44d42807e4aa
Reviewed-on: http://review.couchbase.org/62800
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

30dcf32713-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

MB-19047: Address data race while accessing the superblock's bitmap

WARNING: ThreadSanitizer: data race (pid=14362)
Write of size 8 at 0x7d340000cf50 by thread T5 (mutexes: write M3288

MB-19047: Address data race while accessing the superblock's bitmap

WARNING: ThreadSanitizer: data race (pid=14362)
Write of size 8 at 0x7d340000cf50 by thread T5 (mutexes: write M32880, write M32885):
#0 sb_reclaim_reusable_blocks /home/abhinav/couchbaseTS/forestdb/src/superblock.cc:661 (usecase_test+0x000000517fc9)
#1 _fdb_commit /home/abhinav/couchbaseTS/forestdb/src/forestdb.cc:4204 (usecase_test+0x0000004eb8ff)
#2 fdb_end_transaction /home/abhinav/couchbaseTS/forestdb/src/transaction.cc:181 (usecase_test+0x00000051b6c0)
#3 invoke_writer_ops(void*) /home/abhinav/couchbaseTS/forestdb/tests/usecase/usecase_test.cc:268 (usecase_test+0x0000004bd49c)

Previous read of size 8 at 0x7d340000cf50 by thread T9:
#0 sb_bmp_fetch_doc /home/abhinav/couchbaseTS/forestdb/src/superblock.cc:399 (usecase_test+0x0000005169d1)
#1 _fdb_open /home/abhinav/couchbaseTS/forestdb/src/forestdb.cc:1689 (usecase_test+0x0000004e64a5)
#2 _fdb_kvs_open /home/abhinav/couchbaseTS/forestdb/src/kv_instance.cc:1575 (usecase_test+0x000000511689)
#3 fdb_snapshot_open /home/abhinav/couchbaseTS/forestdb/src/forestdb.cc:1059 (usecase_test+0x0000004e8a0e)
#4 invoke_reader_ops(void*) /home/abhinav/couchbaseTS/forestdb/tests/usecase/usecase_test.cc:308 (usecase_test+0x0000004bd7d6)

Change-Id: Ia238f4eeec7f87a3b52bb4b130364d7438f8cbe7
Reviewed-on: http://review.couchbase.org/62778
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

e984c92f13-Apr-2016 Sundar Sridharan <sundar.sridharan@gmail.com>

Enable HANG_ON_CRASH for segfault+assertion debugging

Change-Id: Icd0eca89fe341c9d6bfd1e943b493e31ade15712
Reviewed-on: http://review.couchbase.org/62761
Reviewed-by: abhinav dangeti

Enable HANG_ON_CRASH for segfault+assertion debugging

Change-Id: Icd0eca89fe341c9d6bfd1e943b493e31ade15712
Reviewed-on: http://review.couchbase.org/62761
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: Sundararaman Sridharan <sundar@couchbase.com>

show more ...

5202bab413-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

Address data race with fdb_kvs_handle's cur_header_revnum

WARNING: ThreadSanitizer: data race (pid=10625)
Read of size 8 at 0x7d4c0001bf80 by thread T5 (mutexes: write M32880, write M3

Address data race with fdb_kvs_handle's cur_header_revnum

WARNING: ThreadSanitizer: data race (pid=10625)
Read of size 8 at 0x7d4c0001bf80 by thread T5 (mutexes: write M32880, write M32878, write M32939):
#0 fdb_get_smallest_active_header /home/abhinav/couchbaseTS/forestdb/src/kv_instance.cc:2536 (usecase_test+0x000000513fdd)
#1 sb_reclaim_reusable_blocks /home/abhinav/couchbaseTS/forestdb/src/superblock.cc:627 (usecase_test+0x0000005179cf)
#2 _fdb_commit /home/abhinav/couchbaseTS/forestdb/src/forestdb.cc:4204 (usecase_test+0x0000004eb9d8)
#3 fdb_end_transaction /home/abhinav/couchbaseTS/forestdb/src/transaction.cc:181 (usecase_test+0x00000051b520)
#4 invoke_writer_ops(void*) /home/abhinav/couchbaseTS/forestdb/tests/usecase/usecase_test.cc:268 (usecase_test+0x0000004bd49c)

Previous write of size 8 at 0x7d4c0001bf80 by thread T6:
#0 _fdb_open /home/abhinav/couchbaseTS/forestdb/src/forestdb.cc:1953 (usecase_test+0x0000004e74f0)
#1 _fdb_kvs_open /home/abhinav/couchbaseTS/forestdb/src/kv_instance.cc:1575 (usecase_test+0x000000511505)
#2 fdb_snapshot_open /home/abhinav/couchbaseTS/forestdb/src/forestdb.cc:1059 (usecase_test+0x0000004e8b0e)
#3 invoke_reader_ops(void*) /home/abhinav/couchbaseTS/forestdb/tests/usecase/usecase_test.cc:308 (usecase_test+0x0000004bd7d6)

Change-Id: Ie713f249cecfe8553ee27f520b0d69c550fe5ac4
Reviewed-on: http://review.couchbase.org/62776
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

d18182a113-Apr-2016 Chiyoung Seo <chiyoung.seo@gmail.com>

Remove verbose log messages from utils/debug

Change-Id: Ic576039ce01bcd78d163a049ef6fbe8a8ece1199
Reviewed-on: http://review.couchbase.org/62766
Reviewed-by: Jung-Sang Ahn <jungsang.

Remove verbose log messages from utils/debug

Change-Id: Ic576039ce01bcd78d163a049ef6fbe8a8ece1199
Reviewed-on: http://review.couchbase.org/62766
Reviewed-by: Jung-Sang Ahn <jungsang.ahn@gmail.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...

12345678910>>...53