History log of /6.0.3/forestdb/src/filemgr.cc (Results 1 - 25 of 237)
Revision (<<< Hide revision tags) (Show revision tags >>>) Date Author Comments
# e94d4c0a 22-Aug-2019 sduvuru <sduvuru@gmail.com>

MB-35323: Forestdb: Renaming a compacted file can lead to the file
getting deleted

Backport of MB-35666

When a file is compacted the older file is deleted when there are
no

MB-35323: Forestdb: Renaming a compacted file can lead to the file
getting deleted

Backport of MB-35666

When a file is compacted the older file is deleted when there are
no references to it. This causes an issue when the compacted file is
renamed to the original file and then backed up. When the backed up
file is opened, the original file gets deleted as the name of the
previous file for the compacted file matches the renamed file.

The fix is to not remove the old file if it is in a different directory.

Change-Id: Icdbe7e9506cb932190e7adec30f9ad9881dd9d80
Reviewed-on: http://review.couchbase.org/113959
Well-Formed: Build Bot <build@couchbase.com>
Reviewed-by: Srinath Duvuru <srinath.duvuru@couchbase.com>
Tested-by: Srinath Duvuru <srinath.duvuru@couchbase.com>

show more ...


# 56236603 09-Mar-2018 sduvuru <sduvuru@gmail.com>

MB-28014: Index node crashing with FDB error

When ForestDB encounters a corrupted buffer, currently it just asserts and crashes.
When indexer restarts, it again encounters the same corru

MB-28014: Index node crashing with FDB error

When ForestDB encounters a corrupted buffer, currently it just asserts and crashes.
When indexer restarts, it again encounters the same corrupted buffer and crashes again.
The indexer then has no way of determining the specific index file (forestDB file)
which is corrupt and disable the specific index.

This fix will handle corruption that is detected in the following way.
If buffer (on disk or on the buffer pool) is found to be corrupt,
the current dbheader will be marked as invalid and an error, FDB_RECOVERABLE_ERR,
will be returned. When the file is reopened, forestdb will move to the first valid
dbheader skipping the DBheaders that were marked as invalid. If the forestdb file open
encounters "num_keeping_headers", a config parameter, invalid dbheaders it will return
FDB_NONRECOVERABLE_ERR, a nonrecoverable error. The indexer will now be able to
determine the index is not recoverable and invalidate it so that it can be rebuilt.

The fix also has two functional tests which corrupt index and data pages and recovers
up to num_keeping_headers configuration value.

Change-Id: I181abface1ffe2e926597dccb883bb818b31d63a
Reviewed-on: http://review.couchbase.org/91777
Reviewed-by: Sundar Sridharan <sundar@couchbase.com>
Tested-by: Sundar Sridharan <sundar@couchbase.com>

show more ...


# 99e2edb2 28-Oct-2016 abhinavdangeti <abhinav@couchbase.com>

MB-26364: Warnings in forestdb on Mac during build
MB-21503: Replace OSSpinLock with os_unfair_lock for OSX>=10.12

OSSpinLock has been deprecated in OSX 10.12 onwards (Sierra),
repla

MB-26364: Warnings in forestdb on Mac during build
MB-21503: Replace OSSpinLock with os_unfair_lock for OSX>=10.12

OSSpinLock has been deprecated in OSX 10.12 onwards (Sierra),
replacing it with the suggestion from the compiler.

Removed the SPIN_INITIALIZER check in filemgr_shutdown as it is not needed and casues failures.

Reviewed-on: http://review.couchbase.org/69301
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: Sundararaman Sridharan <sundar@couchbase.com>
Change-Id: I4642be7b1302fb209326ee85796b9cf5a23d8cdf
Reviewed-on: http://review.couchbase.org/87701
Reviewed-by: Sundar Sridharan <sundar@couchbase.com>
Tested-by: Sundar Sridharan <sundar@couchbase.com>

show more ...


# a54fc06a 27-Jan-2018 sduvuru <sduvuru@gmail.com>

MB-28038: [FM] Attempting to write to a buffer still in use

Original fix was in MB-27005
sb_bmp_is_writable() was reporting a block is not writable. This is because the
test bid >= l

MB-28038: [FM] Attempting to write to a buffer still in use

Original fix was in MB-27005
sb_bmp_is_writable() was reporting a block is not writable. This is because the
test bid >= last_commit fails. This is due to the last_writable_bmp_revnum
getting set in all cases, even when last_commit was set to the end of file.
This causes the a bitmap version mismatch in the check for a writable block.
This fix is a work around to avoid the failure. By setting the last_writable_bmp_revnum
to current bitmap version only when last_commit is not set to end of file.

Change-Id: I4ac68b381599f9ebf87badb3fbb6e350203b8a8e
Reviewed-on: http://review.couchbase.org/88454
Well-Formed: Build Bot <build@couchbase.com>
Reviewed-by: Sundar Sridharan <sundar@couchbase.com>
Tested-by: Sundar Sridharan <sundar@couchbase.com>
Reviewed-on: http://review.couchbase.org/88549

show more ...


# 9c4bf803 23-Jun-2017 Jung-Sang Ahn <jungsang.ahn@gmail.com>

MB-24963: Add ISO 8601 timestamp for ForestDB

* Now every ForestDB log is prefixed with ISO 8601 timestamp.

Change-Id: I5138238d380e60e6cd3fea96ad56078e1f10fa0b
Reviewed-on: htt

MB-24963: Add ISO 8601 timestamp for ForestDB

* Now every ForestDB log is prefixed with ISO 8601 timestamp.

Change-Id: I5138238d380e60e6cd3fea96ad56078e1f10fa0b
Reviewed-on: http://review.couchbase.org/79924
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: Jung-Sang Ahn <jungsang.ahn@gmail.com>

show more ...


# b6e47bcd 22-Jun-2017 Jung-Sang Ahn <jungsang.ahn@gmail.com>

[BP] MB-22718: Add an API to find last valid file

* Added a new flag to DB header, indicates whether or not compaction
has been done successfully.

* Added a new API to check val

[BP] MB-22718: Add an API to find last valid file

* Added a new flag to DB header, indicates whether or not compaction
has been done successfully.

* Added a new API to check validity of the given series of files, using
above flag.

* It returns the last valid index number of the given file name array.

* All given files should belong to the same series of logical DB
instance.

Change-Id: Id6fd51cb3186e614f6c76837512374292a8877dd
Reviewed-on: http://review.couchbase.org/79901
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: Jung-Sang Ahn <jungsang.ahn@gmail.com>

show more ...


# e4615599 07-Feb-2017 Jung-Sang Ahn <jungsang.ahn@gmail.com>

[BP] MB-22538 Use file name instead of pointers for old/new file link

* Based on the same logic in
http://review.couchbase.org/#/c/66318

* Removed prev_file, new_file pointers

[BP] MB-22538 Use file name instead of pointers for old/new file link

* Based on the same logic in
http://review.couchbase.org/#/c/66318

* Removed prev_file, new_file pointers, and added new member variable
for new file name.

* Both old file name and new file name are used for tracking the
compaction order.

Change-Id: I211e3f6ac237305badae882dcd46cb81af30b01a
Reviewed-on: http://review.couchbase.org/73263
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: Jung-Sang Ahn <jungsang.ahn@gmail.com>

show more ...


# 10265520 26-May-2016 abhinavdangeti <abhinav@couchbase.com>

MB-19745: Handle windows scenario for reading a block at EOF

- When Linux's pread is run at an offset for a block
starting at the end of file, pread succeeds and returns 0.
- With

MB-19745: Handle windows scenario for reading a block at EOF

- When Linux's pread is run at an offset for a block
starting at the end of file, pread succeeds and returns 0.
- With Windows however, on the exact same scenario, ReadFile
fails, and sets errno to ENOENT. ENOENT is mapped to
FDB_RESULT_NO_SUCH_FILE, which is a case that isn't
handled when attempting to read a header block.
- Fixing this issue by handling the case when reading of a
block at EOF is attempted.
- Also do not use _F64 to print a uint32_t value, as on
windows, faulty numbers are seen in logs.

Change-Id: Ifb0718feb9afab489d1d7f1299c9d03a2620eabf
Reviewed-on: http://review.couchbase.org/64506
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Well-Formed: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Reviewed-by: Jung-Sang Ahn <jungsang.ahn@gmail.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


Revision tags: v1.2
# 9b16c7ee 13-May-2016 Sundar Sridharan <sundar.sridharan@gmail.com>

MB-19619: Add latencies for fdb_open, kvs_open, snapshot clone

Change-Id: I45ea98ff730555eefc1af4b04ad3104051e9fd75
Reviewed-on: http://review.couchbase.org/63996
Reviewed-by: Chiyou

MB-19619: Add latencies for fdb_open, kvs_open, snapshot clone

Change-Id: I45ea98ff730555eefc1af4b04ad3104051e9fd75
Reviewed-on: http://review.couchbase.org/63996
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# 1ccfc6d3 13-May-2016 Sundar Sridharan <sundar.sridharan@gmail.com>

MB-19619: Log first time fdb_open,close,bcache init

Change-Id: Ie8f4aa684518b52166453a6a7af978c039c540b4
Reviewed-on: http://review.couchbase.org/63994
Reviewed-by: Chiyoung Seo <chi

MB-19619: Log first time fdb_open,close,bcache init

Change-Id: Ie8f4aa684518b52166453a6a7af978c039c540b4
Reviewed-on: http://review.couchbase.org/63994
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# 34d1f130 28-Apr-2016 Jung-Sang Ahn <jungsang.ahn@gmail.com>

MB-19173 Maintain in-memory stale block info

- Keep system docs that contain the list of stale regions in-memory
to skip scanning stale-block tree.

- After block reclaim, do not

MB-19173 Maintain in-memory stale block info

- Keep system docs that contain the list of stale regions in-memory
to skip scanning stale-block tree.

- After block reclaim, do not remove & free the remaining items from
'merge-tree', and reuse the items in the next block reclaim without
re-loading them from the corresponding system doc.

Change-Id: I34ff747d55954d284105d3ee1e8be68fa4facb97
Reviewed-on: http://review.couchbase.org/63226
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...


# 97bd3815 28-Apr-2016 Jung-Sang Ahn <jungsang.ahn@gmail.com>

MB-19286 Adjust 'bmp_revnum' for 'cur_alloc_bid'

- When a commit is invoked just before block reclaim, then the commit
header is located at the end of file and the current allocatable

MB-19286 Adjust 'bmp_revnum' for 'cur_alloc_bid'

- When a commit is invoked just before block reclaim, then the commit
header is located at the end of file and the current allocatable
block (cur_alloc_bid) is the first block in the bitmap. In this case,
BMP revision number (bmp_revnum) of commit header block is different
to that of 'cur_alloc_bid' block. However, 'last_commit_bmp_revnum'
is incorrectly set using the 'bmp_revnum' header block, thus
sb_bmp_is_writable() may return incorrect answer.

- To avoid this issue, just update 'bmp_revnum' once again in
filemgr_commit_bid(). This is the most simple way for this problem.

Change-Id: Ib2d56bb0bbe27e93493fffa1e6fc99f78b224d9f
Reviewed-on: http://review.couchbase.org/63350
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# 1c75bd93 14-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

Address compiler warning seen in filemgr.cc

/home/abhinav/couchbase/forestdb/src/filemgr.cc:3560:27:
warning: ‘addr’ may be used uninitialized in this function

Address compiler warning seen in filemgr.cc

/home/abhinav/couchbase/forestdb/src/filemgr.cc:3560:27:
warning: ‘addr’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
block->addr = addr;
^

Change-Id: If78928413476e3bde7d5838b0779e564a3535b5c
Reviewed-on: http://review.couchbase.org/62852
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# 5b0b2b2e 14-Apr-2016 Sundar Sridharan <sundar.sridharan@gmail.com>

MB-19179: Disable WAL seqtree if FDB_SEQTREE_NOT_USE

This fixes crashes in cbft and also improves point query perf

Change-Id: If15c72d39119b215b7c5566e51ac5faee455978f
Reviewed-

MB-19179: Disable WAL seqtree if FDB_SEQTREE_NOT_USE

This fixes crashes in cbft and also improves point query perf

Change-Id: If15c72d39119b215b7c5566e51ac5faee455978f
Reviewed-on: http://review.couchbase.org/62809
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# a8f01baa 14-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

Address data race with filemgr's bcache

Change-Id: I98a94cd9cc7acfce02bdf15b67e0cf9ace95e0e0
14:15:16 WARNING: ThreadSanitizer: data race (pid=68020)
14:15:16 Write of size 8 at 0x

Address data race with filemgr's bcache

Change-Id: I98a94cd9cc7acfce02bdf15b67e0cf9ace95e0e0
14:15:16 WARNING: ThreadSanitizer: data race (pid=68020)
14:15:16 Write of size 8 at 0x7d6400163b28 by thread T15 (mutexes: write M13):
14:15:16 #0 _fname_create(filemgr*) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/blockcache.cc:812 (e2etest+0x0000004d5c60)
14:15:16 #1 bcache_write /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/blockcache.cc:1062 (e2etest+0x0000004d526d)
14:15:16 #2 filemgr_read /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/filemgr.cc:2043 (e2etest+0x0000004f1a9b)
14:15:16 #3 _docio_read_through_buffer(docio_handle*, unsigned long, err_log_callback*, bool) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/docio.cc:691 (e2etest+0x0000004ea770)
14:15:16 #4 docio_read_doc /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/docio.cc:1212 (e2etest+0x0000004eb86f)
14:15:16 #5 fdb_kvs_header_read /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/kv_instance.cc:1123 (e2etest+0x000000522e4c)
14:15:16 #6 _fdb_open /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:1720 (e2etest+0x0000004fa137)
14:15:16 #7 fdb_check_file_reopen /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:2800 (e2etest+0x0000004fcb77)
14:15:16 #8 fdb_set /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:3607 (e2etest+0x00000050372f)
14:15:16 #9 fdb_set_kv <null> (e2etest+0x0000004d2a29)
14:15:16 #10 update_thread(void*) crtstuff.c (e2etest+0x0000004c9d26)
14:15:16
14:15:16 Previous read of size 8 at 0x7d6400163b28 by thread T14:
14:15:16 #0 bcache_read /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/blockcache.cc:924 (e2etest+0x0000004d4ddf)
14:15:16 #1 filemgr_read /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/filemgr.cc:1976 (e2etest+0x0000004f14f1)
14:15:16 #2 _docio_read_through_buffer(docio_handle*, unsigned long, err_log_callback*, bool) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/docio.cc:691 (e2etest+0x0000004ea770)
14:15:16 #3 docio_read_doc /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/docio.cc:1212 (e2etest+0x0000004eb86f)
14:15:16 #4 fdb_kvs_header_read /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/kv_instance.cc:1123 (e2etest+0x000000522e4c)
14:15:16 #5 _fdb_open /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:1720 (e2etest+0x0000004fa137)
14:15:16 #6 fdb_check_file_reopen /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:2800 (e2etest+0x0000004fcb77)
14:15:16 #7 fdb_set /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:3607 (e2etest+0x00000050372f)
14:15:16 #8 fdb_set_kv <null> (e2etest+0x0000004d2a29)
14:15:16 #9 e2e_fdb_set_person crtstuff.c (e2etest+0x0000004d0392)
14:15:16 #10 seq_writer_thread(void*) crtstuff.c (e2etest+0x0000004c9c62)
Reviewed-on: http://review.couchbase.org/62820
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# da4d76d7 13-Apr-2016 Jung-Sang Ahn <jungsang.ahn@gmail.com>

MB-19048 Do not grab fhandle_idx_lock in filemgr_free_func()

- The file already became unreachable so that grabbing lock is
unnecessary.

Change-Id: If6a6dff8511c6c76ac64bbb0cf94

MB-19048 Do not grab fhandle_idx_lock in filemgr_free_func()

- The file already became unreachable so that grabbing lock is
unnecessary.

Change-Id: If6a6dff8511c6c76ac64bbb0cf94feba9bf78831
Reviewed-on: http://review.couchbase.org/62764
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# 1f644b8d 07-Apr-2016 Jung-Sang Ahn <jungsang.ahn@gmail.com>

MB-19047 Protect superblock's bitmap from multiple readers and writers

- Added reference counters for readers and writers, to implement
a similar approach to readers-writer-lock.

MB-19047 Protect superblock's bitmap from multiple readers and writers

- Added reference counters for readers and writers, to implement
a similar approach to readers-writer-lock.

- The critical section size is very small, and writer is infrequently
invoked compared to readers so that almost no lock contention is
observed.

Change-Id: I71977fd2f4e4849df48508486d5b780147721ad9
Reviewed-on: http://review.couchbase.org/62555
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# b84960c2 05-Apr-2016 Jung-Sang Ahn <jungsang.ahn@gmail.com>

Log error messages through stderr if log callback is not given

- If error log callback function is not given, print error messages
through stderr.

- _fdb_restore_wal() may repor

Log error messages through stderr if log callback is not given

- If error log callback function is not given, print error messages
through stderr.

- _fdb_restore_wal() may report some false alarms due to circular
block reuse, we temporarily disable it.

Change-Id: I501c05e4926b4c94d47ef5ebc63de5692565652f
Reviewed-on: http://review.couchbase.org/62399
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# 1de419c8 09-Apr-2016 Sundar Sridharan <sundar.sridharan@gmail.com>

Fix compiler warnings for signed vs unsigned comparisons

Change-Id: I475b838cc6dd1d7d33c6fa7e9d8589c16e871edc
Reviewed-on: http://review.couchbase.org/62627
Reviewed-by: Chiyoung Seo

Fix compiler warnings for signed vs unsigned comparisons

Change-Id: I475b838cc6dd1d7d33c6fa7e9d8589c16e871edc
Reviewed-on: http://review.couchbase.org/62627
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# 2283ca48 08-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

MB-19087: Update new_file and prev_file pointers on filemgr_close

Update new_file and prev_file pointers in the case where
fdb_close comes from regular shutdown. This is so that
a re

MB-19087: Update new_file and prev_file pointers on filemgr_close

Update new_file and prev_file pointers in the case where
fdb_close comes from regular shutdown. This is so that
a regular close doesn't race with the close issued by
compaction in certain testcases.

Change-Id: I1e7bcdc8c5e1d5cef03607b2710634aead0fd748
Reviewed-on: http://review.couchbase.org/62622
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...


# 44d0bd2d 09-Apr-2016 Chiyoung Seo <chiyoung.seo@gmail.com>

MB-19025 Reset the header len to zero before fetching a header

As the caller checks the header len after fetching a header, the length
should be reset to zero before fetching the header.

MB-19025 Reset the header len to zero before fetching a header

As the caller checks the header len after fetching a header, the length
should be reset to zero before fetching the header.

Change-Id: Ic24b1eab07b41dfe36f3c66c2b8583a8880c6999
Reviewed-on: http://review.couchbase.org/62625
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...


# 10de594c 08-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

MB-19087: Updating new_file and prev_file pointers for a file

Update the new_file and prev_file pointers within the openLock
in filemgr_close as opposed to filemgr_free_func, so that the

MB-19087: Updating new_file and prev_file pointers for a file

Update the new_file and prev_file pointers within the openLock
in filemgr_close as opposed to filemgr_free_func, so that there
is no race in updating the links.

Change-Id: Ibddf6e261786e9c0ecf574383e7f0e94cbd05b54
Reviewed-on: http://review.couchbase.org/62596
Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: abhinav dangeti <abhinav@couchbase.com>

show more ...


# 44169673 06-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

MB-19087: Address heap use after free issue with file pointers

In compaction scenario, before a file is freed, the
pointer to it held by a previous file and the pointer
to it held by

MB-19087: Address heap use after free issue with file pointers

In compaction scenario, before a file is freed, the
pointer to it held by a previous file and the pointer
to it held by a new file will need to be updated.

In the case of multiple files being present, and more than one
file has been redirected to the current file, the new_file pointers
of all those files will need to be updated in case the current file
is deleted.

10:59:36 WARNING: ThreadSanitizer: heap-use-after-free (pid=108627)
10:59:36 Read of size 1 at 0x7d640001f558 by main thread (mutexes: write M14, write M7597):
10:59:36 #0 filemgr_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/filemgr.cc:1451 (iterator_functional_test+0x000000504b5f)
10:59:36 #1 _fdb_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7203 (iterator_functional_test+0x0000005123bb)
10:59:36 #2 _fdb_close_root /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7174 (iterator_functional_test+0x000000511854)
10:59:36 #3 fdb_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7135 (iterator_functional_test+0x00000051ee5a)
10:59:36 #4 iterator_concurrent_compaction() crtstuff.c (iterator_functional_test+0x0000004e2078)
10:59:36 #5 main crtstuff.c (iterator_functional_test+0x0000004e4e1d)
10:59:36
10:59:36 Previous write of size 8 at 0x7d640001f558 by main thread:
10:59:36 #0 free <null> (iterator_functional_test+0x00000046136b)
10:59:36 #1 filemgr_free_func /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/filemgr.cc:1657 (iterator_functional_test+0x000000502a9f)
10:59:36 #2 filemgr_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/filemgr.cc:1479 (iterator_functional_test+0x000000504ea4)
10:59:36 #3 _fdb_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7203 (iterator_functional_test+0x0000005123bb)
10:59:36 #4 fdb_kvs_close_all /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/kv_instance.cc:1789 (iterator_functional_test+0x000000537922)
10:59:36 #5 _fdb_close_root /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7157 (iterator_functional_test+0x0000005117d3)
10:59:36 #6 fdb_close /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:7135 (iterator_functional_test+0x00000051ee5a)
10:59:36 #7 iterator_concurrent_compaction() crtstuff.c (iterator_functional_test+0x0000004e2078)
10:59:36 #8 main crtstuff.c (iterator_functional_test+0x0000004e4e1d)

Change-Id: Iacf78604494026b33085663146d2adfda319fff9
Reviewed-on: http://review.couchbase.org/62449
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


# b5540fc3 05-Apr-2016 Jung-Sang Ahn <jungsang.ahn@gmail.com>

MB-19047 Convert some fields in superblock to atomic variable

- 'revnum', 'last_hdr_bid', and 'last_hdr_revnum' are converted to
atomic variable.

- Superblock doesn't need to be

MB-19047 Convert some fields in superblock to atomic variable

- 'revnum', 'last_hdr_bid', and 'last_hdr_revnum' are converted to
atomic variable.

- Superblock doesn't need to be synched for every close; now update
happens only when 1) the handle is not read-only, and 2) handle info
is newer than that in superblock.

Change-Id: Id5130e54cabdf35b13b46284571859c9d2089a18
Reviewed-on: http://review.couchbase.org/62438
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...


# 93b9365b 05-Apr-2016 abhinavdangeti <abhinav@couchbase.com>

Filemgr_openlock to be acquired for a hash table scan

Context: filemgr_shutdown() in src/filemgr.cc

Change-Id: I413eb81c134c59a4589d9d7c08f590c15a0506de
Reviewed-on: http://revi

Filemgr_openlock to be acquired for a hash table scan

Context: filemgr_shutdown() in src/filemgr.cc

Change-Id: I413eb81c134c59a4589d9d7c08f590c15a0506de
Reviewed-on: http://review.couchbase.org/62461
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>

show more ...


12345678910