History log of /6.0.3/kv_engine/daemon/mcbpdestroybuckettask.h (Results 1 - 8 of 8)
Revision (<<< Hide revision tags) (Show revision tags >>>) Date Author Comments
Revision tags: v7.0.2, v6.6.3, v7.0.1, v7.0.0, v6.6.2, v6.5.2, v6.6.1, v6.0.5, v6.6.0, v6.5.1, v6.0.4, v6.5.0, v6.0.3, v5.5.4, v5.5.5, v5.5.6, v6.0.1, v5.5.3, v6.0.0, v5.1.3, v5.5.2, v5.5.1, v5.1.2, v5.1.1
# 1f38bead 27-Dec-2017 Trond Norbye <trond.norbye@gmail.com>

Refactor: use cookie and not connection in bucket remove task

The connection may have multiple commands associated

Change-Id: If83e94a038c9191340224d892f74a440bf4be769
Reviewed-

Refactor: use cookie and not connection in bucket remove task

The connection may have multiple commands associated

Change-Id: If83e94a038c9191340224d892f74a440bf4be769
Reviewed-on: http://review.couchbase.org/87240
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Manu Dhundi <manu@couchbase.com>

show more ...


Revision tags: v5.0.1, v5.1.0
# fbd739ae 03-Oct-2017 Trond Norbye <trond.norbye@gmail.com>

Refactor: Don't use both virtual and override

Change-Id: I6e06f1329c997249b5b48f7aa24e7d803dfe7f3a
Reviewed-on: http://review.couchbase.org/83978
Tested-by: Build Bot <build@couchbas

Refactor: Don't use both virtual and override

Change-Id: I6e06f1329c997249b5b48f7aa24e7d803dfe7f3a
Reviewed-on: http://review.couchbase.org/83978
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


Revision tags: v5.0.0
# a9477ebf 07-Aug-2017 Trond Norbye <trond.norbye@gmail.com>

MB-24309: refactor move Cookie.connection to McbpConnection reference

It used to be a pointer as the cookie would represent an
individual greenstack command when being utilized from

MB-24309: refactor move Cookie.connection to McbpConnection reference

It used to be a pointer as the cookie would represent an
individual greenstack command when being utilized from
greenstack. Now that greenstack is dead the connection
in a command cookie will _always_ be an MCBP connection.

Change-Id: I4fa12fc21cb2e2374f5839485f2e3a2012b58046
Reviewed-on: http://review.couchbase.org/81972
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>

show more ...


# c7abf941 20-Jun-2017 Trond Norbye <trond.norbye@gmail.com>

Refactor: drop conn_create/remove_bucket

Use the steppable command context pattern instead

Change-Id: I1c3f6d76044aa4a9c2d1556bc09b1f956d51eeba
Reviewed-on: http://review.couchb

Refactor: drop conn_create/remove_bucket

Use the steppable command context pattern instead

Change-Id: I1c3f6d76044aa4a9c2d1556bc09b1f956d51eeba
Reviewed-on: http://review.couchbase.org/79744
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Will Gardner <willg@rdner.io>

show more ...


# e4971bec 03-Jun-2017 Will Gardner <willg@rdner.io>

Add `PeriodicTask` abstract class

Introduces the `PeriodicTask` class which eases the creation of
tasks which must execute with a regular period.

This also adjusts the return va

Add `PeriodicTask` abstract class

Introduces the `PeriodicTask` class which eases the creation of
tasks which must execute with a regular period.

This also adjusts the return value of Task::execute from a bool
to an enum in order to reduce ambiguity.

Change-Id: Ie9d4b5858d0fe17944d5d3edf81abab43d051eee
Reviewed-on: http://review.couchbase.org/79024
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


Revision tags: v4.6.2_ep, v4.6.2_mc, v4.6.1_ep, v4.6.0_ep, v4.5.1-MP1_mc, v4.6.0-DP_mc, v4.6.0-DP_ep, v4.5.1-MP1_ep, v4.1.2-MP2_mc, v4.5.1_mc, v4.6.0_mc, v4.1.2-MP1_ep, v3.1.6_ep, v4.5.0_mc, v4.5.0_ep
# ccaf4605 25-Apr-2016 Trond Norbye <trond.norbye@gmail.com>

Don't hold the task lock during the completion message

The reason for this change is that we end up with
hacks in the callback that unlocks/relocks the mutex
before trying to access

Don't hold the task lock during the completion message

The reason for this change is that we end up with
hacks in the callback that unlocks/relocks the mutex
before trying to access the connection (since that
would aqcuire the connections thread lock, and the
locking order would be the oposite when the thread is
created). This lock/unlock/lock/unlock bracketing just
made it harder (and more difficult) to understand.

Change-Id: I607ef2a133f854bdb8e8d1c3f42da58aeafae2fd
Reviewed-on: http://review.couchbase.org/63312
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Will Gardner <will.gardner@couchbase.com>

show more ...


Revision tags: v4.1.1_ep, v3.1.5_ep
# c3e2b4f4 11-Mar-2016 Trond Norbye <trond.norbye@gmail.com>

MB-18657: Pass a cookie object to through the engine API

This is a dependency for Greenstack where the cookie will be
the command context and not the connection object to allow
for m

MB-18657: Pass a cookie object to through the engine API

This is a dependency for Greenstack where the cookie will be
the command context and not the connection object to allow
for multiple concurrent commands being executed for a single
connection

Change-Id: I36705402bff931b53eb371f1f9db0da55c6d1c7d
Reviewed-on: http://review.couchbase.org/61318
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


Revision tags: v4.1.1_mc, v3.1.4_ep, v3.1.4_mc
# 4ff1a49e 04-Feb-2016 Daniel Owen <owend@couchbase.com>

MB-17862 - Fix deadlock issue associated with shutdown

During shutdown for each bucket we perform the callback
ON_DELETE_BUCKET. When using the ep-engine this results
in calling Evp

MB-17862 - Fix deadlock issue associated with shutdown

During shutdown for each bucket we perform the callback
ON_DELETE_BUCKET. When using the ep-engine this results
in calling EvpHandleDeleteBucket().

This results in shutting down all connections, which
involves releasing connection references. Invoking
releaseReference() causes a callback into memcached to
execute release_cookie().

release_cookie() attempts to acquire the lock for the
thread associated with the connection being released.
However, because this work is being performed by a
worker thread the behaviour is such that memcached is
attempting to take the lock of potentially another
worker thread. This is not allowed as it can cause
deadlock.

The solution provided in this patch is to delete
buckets outside of worker threads. This is achieved
by scheduling a McbpDestroyBucketTask for each bucket
to be deleted. Note, this is the same approach taken
when deleting a bucket due to a standard DELETE_BUCKET
command.

Change-Id: I406afebd7a25933d0aae22c43e37f1cbfc4e9db8
Reviewed-on: http://review.couchbase.org/59505
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...