MB-29258: Add an engine API to get maximum item size

Add an engine API to get the maximum size of an item supported
by the underlying engine. Use the engine API to get the
maximum do

MB-29258: Add an engine API to get maximum item size

Add an engine API to get the maximum size of an item supported
by the underlying engine. Use the engine API to get the
maximum document size supported for that specific engine and
use it to compare with the decompressed document size

Change-Id: Ic2512c5a67156879e172eab4b36174f49ed21fbf
Reviewed-on: http://review.couchbase.org/92941
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

MB-28777: Provide a min_compression_ratio configuration parameter

If there isn't much difference between sizes of compressed and
uncompressed data, then decompressing the data every time

MB-28777: Provide a min_compression_ratio configuration parameter

If there isn't much difference between sizes of compressed and
uncompressed data, then decompressing the data every time for
a client would outweigh the cost of storing the data as
compressed as there is no perceivable benefit in space savings

Change-Id: Ic6d735213faa00dfc2331d577f4cee80b46e715e
Reviewed-on: http://review.couchbase.org/91769
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Log transition from one compression mode to another

The KV-engine compression mode has a bearing on the nature of data
that gets stored and it would be useful to log the transition
f

Log transition from one compression mode to another

The KV-engine compression mode has a bearing on the nature of data
that gets stored and it would be useful to log the transition
from one mode to the other

Change-Id: I77ec2e9affa81ce286250c65348484eb1d164a3a
Reviewed-on: http://review.couchbase.org/92102
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Tim Bradgate <tim.bradgate@couchbase.com>

show more ...

default_engine: Use zero-length / RAW_BYTES for deleted docs

When allocating an item to represent a deleted document, use
datatype:RAW_BYTES and a length of zero for the empty body. This

default_engine: Use zero-length / RAW_BYTES for deleted docs

When allocating an item to represent a deleted document, use
datatype:RAW_BYTES and a length of zero for the empty body. This is
necessary as if the previous body was Snappy-compressed and we
preserve the datatype; we end up with a deleted document marked as
snappy, but which we cannot decompress. As a result operations like
XATTR on deleted documents fail.

Change-Id: I336d774442b06b58c7fae2b2742f6f1e6fc7bbe3
Reviewed-on: http://review.couchbase.org/90523
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Tim Bradgate <tim.bradgate@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

MB-27275: [1/2] Add an engine API function to set an item's datatype

Change-Id: If151525bdb7f002ceb60c7daa456318237c9c268
Reviewed-on: http://review.couchbase.org/89900
Reviewed-by:

MB-27275: [1/2] Add an engine API function to set an item's datatype

Change-Id: If151525bdb7f002ceb60c7daa456318237c9c268
Reviewed-on: http://review.couchbase.org/89900
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

Remove engine feature information

The feature information was never used and is currently
generating warnings from gcc 7. Given that we don't use
it we should nuke it.

Chang

Remove engine feature information

The feature information was never used and is currently
generating warnings from gcc 7. Given that we don't use
it we should nuke it.

Change-Id: Ica99af5e9dda549b090b0a4033b0f577e08a5438
Reviewed-on: http://review.couchbase.org/88494
Reviewed-by: Tim Bradgate <tim.bradgate@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

MB-27543: [Restore] Decompress the value before storing in 'off' mode

This reverts commit abff81203272095e247926346c5c720b1210385e.
Restoring the commit as it wasn't the root cause of th

MB-27543: [Restore] Decompress the value before storing in 'off' mode

This reverts commit abff81203272095e247926346c5c720b1210385e.
Restoring the commit as it wasn't the root cause of the post commit
failures.

Change-Id: I7f8ad00cc4ddc2760140bcece8168caaef0e86b0
Reviewed-on: http://review.couchbase.org/88193
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Sriram Ganesan <sriram@couchbase.com>

show more ...

Revert "MB-27543: Decompress the value before storing in 'off' mode"

This reverts commit 268ecbd4b8715333475c833e12efee16a6d0e759. Commit
has resulted in post commit failures. Hence, rev

Revert "MB-27543: Decompress the value before storing in 'off' mode"

This reverts commit 268ecbd4b8715333475c833e12efee16a6d0e759. Commit
has resulted in post commit failures. Hence, reverting.

Change-Id: Ib5355170dd5e0e5aec0a39943f837bb0d90a09ea
Reviewed-on: http://review.couchbase.org/88185
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>

show more ...

MB-27543: Decompress the value before storing in 'off' mode

If the bucket compression mode is 'off' and the value is
snappy compressed, then the value needs to be decompressed before

MB-27543: Decompress the value before storing in 'off' mode

If the bucket compression mode is 'off' and the value is
snappy compressed, then the value needs to be decompressed before
storing it in the hash table

Change-Id: I6c32215ea49aebbd0f71993bb4579ac275acdf6d
Reviewed-on: http://review.couchbase.org/87808
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

MB-26729: [2/n] Allow memcached to limit expiry

Update the mc_time_convert_to_real_time function to accept a
cb::ExpiryLimit, which is a type that can carry an upper bound on
the exp

MB-26729: [2/n] Allow memcached to limit expiry

Update the mc_time_convert_to_real_time function to accept a
cb::ExpiryLimit, which is a type that can carry an upper bound on
the expiry we calculate.

mc_time_convert_to_real_time is exposed to the engines through the
server API so we will be able to update any relevant engine so that
it can begin limiting expiry to a value of its choice.

Change-Id: I019513630a09791732651d538030f1d4da7445e5
Reviewed-on: http://review.couchbase.org/86969
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

Tighten up engine API; Require cookie and cas for store

The cookie contains the command context and needs to be present
to allow the engine to perform any callbacks into the core.

Tighten up engine API; Require cookie and cas for store

The cookie contains the command context and needs to be present
to allow the engine to perform any callbacks into the core.

The CAS is an out parameter so that the core won't have to call
into the engine again in order to figure out the resulting CAS
value.

Change-Id: I5df57cfb3689b504eb754610e19fed01d4bd43ad
Reviewed-on: http://review.couchbase.org/86067
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Tighten up engine API; Require cookie for get

The cookie contains the command context and needs to be present

Change-Id: I419840db707e207fab73e174c84517489b837187
Reviewed-on: h

Tighten up engine API; Require cookie for get

The cookie contains the command context and needs to be present

Change-Id: I419840db707e207fab73e174c84517489b837187
Reviewed-on: http://review.couchbase.org/86066
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Tighten up engine API; Require cookie, cas and mutinfo for remove

Change-Id: I56e24566efe5e01cacd39209b229dc98995d9197
Reviewed-on: http://review.couchbase.org/86065
Reviewed-by: Dan

Tighten up engine API; Require cookie, cas and mutinfo for remove

Change-Id: I56e24566efe5e01cacd39209b229dc98995d9197
Reviewed-on: http://review.couchbase.org/86065
Reviewed-by: Daniel Owen <owend@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

Tighten up engine API; Require cookie for allocate

Change-Id: I43d86b6ab69cd16625f977d07d9b2f12c6a8f7db
Reviewed-on: http://review.couchbase.org/85989
Reviewed-by: Dave Rigby <daver@

Tighten up engine API; Require cookie for allocate

Change-Id: I43d86b6ab69cd16625f977d07d9b2f12c6a8f7db
Reviewed-on: http://review.couchbase.org/85989
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

Tighten up engine API; Require cookie for get_stats

Use gsl::not_null for the cookie parameter passed into
the engine and the add_stats callback (as the core expects
it to be a valid

Tighten up engine API; Require cookie for get_stats

Use gsl::not_null for the cookie parameter passed into
the engine and the add_stats callback (as the core expects
it to be a valid cookie).

Change the two parameter key + keylen into a cb::const_char_buffer

A followup to this patch (and the other not_null patches) change
the void pointer to a Cookie object passed by reference.

Change-Id: I31c72e4665ee548a3bb525b28b3a56b663c8f2c0
Reviewed-on: http://review.couchbase.org/85965
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

Tighten up engine API; Require cookie for allocate_ex

Change-Id: Ife6f45f0161f75417537516dab569c0b7fdfdbb0
Reviewed-on: http://review.couchbase.org/85985
Tested-by: Build Bot <build@

Tighten up engine API; Require cookie for allocate_ex

Change-Id: Ife6f45f0161f75417537516dab569c0b7fdfdbb0
Reviewed-on: http://review.couchbase.org/85985
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Tighten up engine API; Require cookie for get_and_touch

Change-Id: I9059dbc0501c3956a353bd8924b84c89cf4a232d
Reviewed-on: http://review.couchbase.org/85984
Tested-by: Build Bot <buil

Tighten up engine API; Require cookie for get_and_touch

Change-Id: I9059dbc0501c3956a353bd8924b84c89cf4a232d
Reviewed-on: http://review.couchbase.org/85984
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Tighten up engine API; Require cookie for get_meta

Change-Id: Ib31d776afe9036b09f19ef2bf44745ce659c903a
Reviewed-on: http://review.couchbase.org/85983
Tested-by: Build Bot <build@cou

Tighten up engine API; Require cookie for get_meta

Change-Id: Ib31d776afe9036b09f19ef2bf44745ce659c903a
Reviewed-on: http://review.couchbase.org/85983
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Tighten up engine API; Require cookie for locking

Change-Id: Iadfbf2cbe4d3fde684ad85c60591d5e764756f02
Reviewed-on: http://review.couchbase.org/85982
Tested-by: Build Bot <build@couc

Tighten up engine API; Require cookie for locking

Change-Id: Iadfbf2cbe4d3fde684ad85c60591d5e764756f02
Reviewed-on: http://review.couchbase.org/85982
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Tighten up engine API: Require cookie for get_if

Change-Id: I8a05eb427362a658a0d27459f94b16931539aeca
Reviewed-on: http://review.couchbase.org/85977
Tested-by: Build Bot <build@couch

Tighten up engine API: Require cookie for get_if

Change-Id: I8a05eb427362a658a0d27459f94b16931539aeca
Reviewed-on: http://review.couchbase.org/85977
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Tighten up engine API; Require cookie for store_if

Change-Id: Iee50d846a4fd1693d2b20299b725d97f5f8e3edd
Reviewed-on: http://review.couchbase.org/85976
Tested-by: Build Bot <build@cou

Tighten up engine API; Require cookie for store_if

Change-Id: Iee50d846a4fd1693d2b20299b725d97f5f8e3edd
Reviewed-on: http://review.couchbase.org/85976
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Tighten up engine API; Require cookie for flush

Change-Id: Iecc9fd34294be35aaa6eb410fad614366c0b3264
Reviewed-on: http://review.couchbase.org/85969
Reviewed-by: Dave Rigby <daver@cou

Tighten up engine API; Require cookie for flush

Change-Id: Iecc9fd34294be35aaa6eb410fad614366c0b3264
Reviewed-on: http://review.couchbase.org/85969
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

Tighten up engine API; Require cookie to be present for reset_stats

Change-Id: I1ab229a560f3cfd924bea077b218989fa123897a
Reviewed-on: http://review.couchbase.org/85964
Tested-by: Bui

Tighten up engine API; Require cookie to be present for reset_stats

Change-Id: I1ab229a560f3cfd924bea077b218989fa123897a
Reviewed-on: http://review.couchbase.org/85964
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Refactor: Use gsl::not_null in engine API

This is an initial refactor. At some point we want to refactor
the cookie argument from a const void pointer to Cookie&

Change-Id: Ie7d

Refactor: Use gsl::not_null in engine API

This is an initial refactor. At some point we want to refactor
the cookie argument from a const void pointer to Cookie&

Change-Id: Ie7d5b15f5d19725c4da2e3cbf760ced319026c0b
Reviewed-on: http://review.couchbase.org/85960
Reviewed-by: Paolo Cocchi <paolo.cocchi@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

Remove unused "cookie" parameter in engine API

release(), get_item_info(), set_item_info() and set_item_cas()
all ignored the cookie being passed in.

Remove the parameter as we

Remove unused "cookie" parameter in engine API

release(), get_item_info(), set_item_info() and set_item_cas()
all ignored the cookie being passed in.

Remove the parameter as we don't use it!

Change-Id: I6c78d734172925d50b69471d95c9aaefc42f99ed
Reviewed-on: http://review.couchbase.org/85956
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...