MB-21512: Don't shutdown EngineManager twice

Previously we called the shutdown manually, and later on
it was called from the destructor without checking if
it was already shut down.

MB-21512: Don't shutdown EngineManager twice

Previously we called the shutdown manually, and later on
it was called from the destructor without checking if
it was already shut down.

In addition to that we had some cases where we could race
during shutdown by just checking an atomic variable if
we should add stuff to the internal queues or not. We
have to hold the mutex so that another thread can't change
that state right after we checked it, but before we added
our items to the list.

Change-Id: I7686e549f2e80bbdc165d608513b882774fe658e
Reviewed-on: http://review.couchbase.org/69335
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Refactor: Move scrubberTask out of engine_manager.cc

Change-Id: I3540aa3e85e2b1ab19e7763a4b8a350505d43ee3
Reviewed-on: http://review.couchbase.org/69378
Tested-by: buildbot <build@co

Refactor: Move scrubberTask out of engine_manager.cc

Change-Id: I3540aa3e85e2b1ab19e7763a4b8a350505d43ee3
Reviewed-on: http://review.couchbase.org/69378
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Tynset - A multi-bucket default_engine

1. All buckets store their items in a single hash_table (assoc).
1.1 Each item key now has a bucket_id prepended to the key string.
1.2 The eng

Tynset - A multi-bucket default_engine

1. All buckets store their items in a single hash_table (assoc).
1.1 Each item key now has a bucket_id prepended to the key string.
1.2 The engine->assoc points to the single table and all code still
manipulates the table via the engine handle.

2. The bucket_id is managed by memcached 'core'
2.1 The bucket_id is a 32-bit unsigned integer which increments for
every bucket creation the process receives.
2.2 The bucket_id is not persisted, the same bucket after a restart is not
guaranteed the same bucket_id (this is subject to future change).
2.3 The bucket_id must not wrap (i.e. a bucket_id can't be reused)

3. Bucket deletion is performed by the item scrubber.
3.1 A single scrubber thread has a queue of engine's to scrub and delete.
3.2 Global cleanup/shutdown collects this single thread so that the DLL
can be safely unloaded.

Change-Id: Idc2bb6748dc75a227c97ad9c44445758b88015b0
Reviewed-on: http://review.couchbase.org/50122
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...