History log of /6.0.3/kv_engine/engines/default_engine/items.cc (Results 1 - 25 of 187)
Revision (<<< Hide revision tags) (Show revision tags >>>) Date Author Comments
Revision tags: v7.0.2, v6.6.3, v7.0.1, v7.0.0, v6.6.2, v6.5.2, v6.6.1, v6.0.5, v6.6.0, v6.5.1, v6.0.4, v6.5.0, v6.0.3, v5.5.4, v5.5.5, v5.5.6, v6.0.1, v5.5.3, v6.0.0, v5.1.3, v5.5.2, v5.5.1, v5.1.2, v5.1.1
# ab711953 07-Mar-2018 Tim Bradgate <tim.bradgate@couchbase.com>

MB-27661 [11/n]: Fix MSVC warnings - C4267

This patch addresses the following generated warnings:

C4267 - var : conversion from 'size_t' to 'type', possible loss of data

MB-27661 [11/n]: Fix MSVC warnings - C4267

This patch addresses the following generated warnings:

C4267 - var : conversion from 'size_t' to 'type', possible loss of data
The compiler detected a conversion from size_t to a smaller type.

This is the second and final commit addressing this error.

Change-Id: If23806c43a2024df2d4103f1b40cbd790957f1f0
Reviewed-on: http://review.couchbase.org/90604
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


# 4dd9b0f4 07-Feb-2018 Trond Norbye <trond.norbye@gmail.com>

Use logger directly in the core

Changed the LOG_ macros used in the core and call
them directly instead of going through the old
logger interface using the printf-style of formatting

Use logger directly in the core

Changed the LOG_ macros used in the core and call
them directly instead of going through the old
logger interface using the printf-style of formatting

Change-Id: I7927bfdd98a843a605fd418ab343f166c25c7b74
Reviewed-on: http://review.couchbase.org/88814
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


# 7d79b83c 02-Feb-2018 Trond Norbye <trond.norbye@gmail.com>

Use spdlogger for everything

Remove the old stderr and stdout loggers and use the spdlogger
everywhere (and remove the ability to install custom loggers).

Change-Id: Ibd5a5d6775

Use spdlogger for everything

Remove the old stderr and stdout loggers and use the spdlogger
everywhere (and remove the ability to install custom loggers).

Change-Id: Ibd5a5d6775970e33664341f2476dd2dee709abff
Reviewed-on: http://review.couchbase.org/88781
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


Revision tags: v5.0.1
# aacf24fd 23-Nov-2017 Trond Norbye <trond.norbye@gmail.com>

Refactor: Use gsl::not_null in engine API

This is an initial refactor. At some point we want to refactor
the cookie argument from a const void pointer to Cookie&

Change-Id: Ie7d

Refactor: Use gsl::not_null in engine API

This is an initial refactor. At some point we want to refactor
the cookie argument from a const void pointer to Cookie&

Change-Id: Ie7d5b15f5d19725c4da2e3cbf760ced319026c0b
Reviewed-on: http://review.couchbase.org/85960
Reviewed-by: Paolo Cocchi <paolo.cocchi@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


# a14f9224 23-Nov-2017 Trond Norbye <trond.norbye@gmail.com>

Remove unused "cookie" parameter in engine API

release(), get_item_info(), set_item_info() and set_item_cas()
all ignored the cookie being passed in.

Remove the parameter as we

Remove unused "cookie" parameter in engine API

release(), get_item_info(), set_item_info() and set_item_cas()
all ignored the cookie being passed in.

Remove the parameter as we don't use it!

Change-Id: I6c78d734172925d50b69471d95c9aaefc42f99ed
Reviewed-on: http://review.couchbase.org/85956
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


Revision tags: v5.1.0
# 41cf6767 26-Sep-2017 Trond Norbye <trond.norbye@gmail.com>

MB-26170: Let unlock return LOCKED for default_engine

ep-engine returns LOCKED if one tries to unlock a locked item.
Given that the lock support in default_engine was added to
allow

MB-26170: Let unlock return LOCKED for default_engine

ep-engine returns LOCKED if one tries to unlock a locked item.
Given that the lock support in default_engine was added to
allow unit testing we should return the same value for
default_engine.

Change-Id: Id6c9fa9aac02efd4286ebe5c4df27c715f26ac00
Reviewed-on: http://review.couchbase.org/83738
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


Revision tags: v5.0.0
# 0834b20f 11-Jul-2017 Trond Norbye <trond.norbye@gmail.com>

Refactor: We don't need the engine handle in the assoc

Drop the member to ease the implementation of unit tests

Change-Id: I578bac03d0b6e79717e681a600754e099c3fbb3d
Reviewed-on:

Refactor: We don't need the engine handle in the assoc

Drop the member to ease the implementation of unit tests

Change-Id: I578bac03d0b6e79717e681a600754e099c3fbb3d
Reviewed-on: http://review.couchbase.org/80564
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>

show more ...


# 8f9005d0 14-Jun-2017 Jim Walker <jim@couchbase.com>

MB-22163: Recover value-eviction performance loss with store_if

Introduce a new engine method called store_if, this method
is exactly like store but takes a predicate (std::function).

MB-22163: Recover value-eviction performance loss with store_if

Introduce a new engine method called store_if, this method
is exactly like store but takes a predicate (std::function).

For set and replace, they will call the predicate on the existing
item (if any) and if the predicate returns true, the store will
continue.

Memcached is changed to make use of store_if so that it can avoid
a get for determining if an existing item has xattrs.

store_if is tried first and if it fails because the existing item
has xattrs, then the slower read/modify/write path is chosen.

This recovers approx 10% in op/s primarily because we reduce the
hash-table locking (your mileage may vary).

Change-Id: I90af507695e4ae5afa195259cf4b7612f87de365
Reviewed-on: http://review.couchbase.org/79490
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


# 753d8721 13-Apr-2017 Trond Norbye <trond.norbye@gmail.com>

MB-23875: Implement GAT and TOUCH in the core [2/2]

The motivation for this is to decouple the protocol encoding
of the commands from the engine implementation, and to fix
problems w

MB-23875: Implement GAT and TOUCH in the core [2/2]

The motivation for this is to decouple the protocol encoding
of the commands from the engine implementation, and to fix
problems with these commands not being included in the
global counters for the command count.

As an extra benefit we can add end to end test through
commit validation as it is supported in all engines.

Change-Id: I2a26987c16b186c91de6f2bc7ab2b87d9c53ec67
Reviewed-on: http://review.couchbase.org/76936
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


Revision tags: v4.6.2_ep
# f068119e 31-Mar-2017 Trond Norbye <trond.norbye@gmail.com>

Refactor: use DocStateFilter for engine->get()

Change-Id: Ied4fa5cdd9520a449eac4ccd33be51cdbacc6f37
Reviewed-on: http://review.couchbase.org/76116
Reviewed-by: Dave Rigby <daver@couc

Refactor: use DocStateFilter for engine->get()

Change-Id: Ied4fa5cdd9520a449eac4ccd33be51cdbacc6f37
Reviewed-on: http://review.couchbase.org/76116
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


# 1607e540 28-Mar-2017 Trond Norbye <trond.norbye@gmail.com>

Fix replace of deleted items

There was a bug in the code for the memcached buckets
which allowed us to use replace to replace a deleted
document. It should not be possible (note: del

Fix replace of deleted items

There was a bug in the code for the memcached buckets
which allowed us to use replace to replace a deleted
document. It should not be possible (note: deleted
items is not enabled in production for memcached
buckets)

Change-Id: Ie673854c5083bd7154fd0f2491cc8707e44f493e
Reviewed-on: http://review.couchbase.org/75876
Reviewed-by: Jim Walker <jim@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


Revision tags: v4.6.2_mc, v4.6.1_ep
# 042e6327 07-Feb-2017 Trond Norbye <trond.norbye@gmail.com>

MB-22553: Fix delete path for default_bucket

The introduction of "keep deleted" used in the unit test
introduced a bug where it tried to remove the new copy
instead of the version st

MB-22553: Fix delete path for default_bucket

The introduction of "keep deleted" used in the unit test
introduced a bug where it tried to remove the new copy
instead of the version stored in the cache when keep deleted
was disabled.

Change-Id: Ie771a8d5eb84dc688d3b2bab7b423bd78496a7d7
Reviewed-on: http://review.couchbase.org/73262
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: David Haikney <david.haikney@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


# 3876ad82 12-Jan-2017 Trond Norbye <trond.norbye@gmail.com>

Remove item_info_holder and nvalue in item_info

We're always using a single entry in the io vector. We've got
an idea of using multiple entries to keep xattr's in one and
the body in

Remove item_info_holder and nvalue in item_info

We're always using a single entry in the io vector. We've got
an idea of using multiple entries to keep xattr's in one and
the body in another. Once we decide to do that, we should
change the item_info struct to reflect that.

The old item_info was designed this way when we wanted to
support a wide range of engines we didn't have control over,
but now that we only support our own engines we don't need
that kind of flexibility (and complexity)

Change-Id: Ifeb9a2f5cd4b1beb2afa072314000bd0a663fddf
Reviewed-on: http://review.couchbase.org/71896
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...


# 98c14ddb 09-Jan-2017 Trond Norbye <trond.norbye@gmail.com>

Refactor: Remove function to get struct member hash_item->cas

Change-Id: I0e6abb870ce864115a0172f775d8a20c18443ae6
Reviewed-on: http://review.couchbase.org/71757
Tested-by: buildbot

Refactor: Remove function to get struct member hash_item->cas

Change-Id: I0e6abb870ce864115a0172f775d8a20c18443ae6
Reviewed-on: http://review.couchbase.org/71757
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


# fb3b37a2 09-Jan-2017 Trond Norbye <trond.norbye@gmail.com>

Add support for document locking in default_bucket

Change-Id: Ic72624166b7a4cbd565ca57a03bdfe0436bd7760
Reviewed-on: http://review.couchbase.org/71761
Reviewed-by: Dave Rigby <daver@

Add support for document locking in default_bucket

Change-Id: Ic72624166b7a4cbd565ca57a03bdfe0436bd7760
Reviewed-on: http://review.couchbase.org/71761
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...


# 5cc551b0 10-Jan-2017 Trond Norbye <trond.norbye@gmail.com>

Fix compile warnings reported by gerrit

The gerrit configuration was incorrectly configured with
respect to warning detection causing the warning score to
be reported incorrectly. Th

Fix compile warnings reported by gerrit

The gerrit configuration was incorrectly configured with
respect to warning detection causing the warning score to
be reported incorrectly. This patch address those issues.

Change-Id: Iff731a25f1671a9a235ffd1d6678c6c4a046bb8d
Reviewed-on: http://review.couchbase.org/71807
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


# 2234cd91 10-Jan-2017 Trond Norbye <trond.norbye@gmail.com>

Delete unused TAP and DCP code from memcached bucket

Change-Id: Iaaa07c6d0fb57a62fb6f885bb5cd5b5a48a7d15f
Reviewed-on: http://review.couchbase.org/71791
Tested-by: buildbot <build@co

Delete unused TAP and DCP code from memcached bucket

Change-Id: Iaaa07c6d0fb57a62fb6f885bb5cd5b5a48a7d15f
Reviewed-on: http://review.couchbase.org/71791
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


# 22eb2257 06-Jan-2017 Trond Norbye <trond.norbye@gmail.com>

Remove support for running without cas

(As part of the refactor we've done in the core by implementing
various commands by using CAS we cannot run without CAS anymore.
It has never b

Remove support for running without cas

(As part of the refactor we've done in the core by implementing
various commands by using CAS we cannot run without CAS anymore.
It has never been a public API to disable CAS so nuking it should
be safe)

Change-Id: I26a33805877e932c2274b3c5d019420c3fa82934
Reviewed-on: http://review.couchbase.org/71646
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Daniel Owen <owend@couchbase.com>

show more ...


# 374efa4b 10-Dec-2016 Trond Norbye <trond.norbye@gmail.com>

Add support for keeping deleted items in memcached buckets

We need this for unit testing of subdoc access to operate
on deleted items.

It is enabled by setting the configuration

Add support for keeping deleted items in memcached buckets

We need this for unit testing of subdoc access to operate
on deleted items.

It is enabled by setting the configuration parameter

keep_deleted=true

With that option enabled they're treated just as a normal
entry in the cache with respect to the LRU, but not
returned unless explicitly asked for.

Change-Id: I3dff83c200f96b48fa40a1aa0337419b0adc52a5
Reviewed-on: http://review.couchbase.org/70857
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>

show more ...


Revision tags: v4.6.0_ep
# 5944bb89 06-Dec-2016 Trond Norbye <trond.norbye@gmail.com>

Create a server document API for notifications

Let the engines call a method right before they link the
document into its datastructures and make it available
for other threads.

Create a server document API for notifications

Let the engines call a method right before they link the
document into its datastructures and make it available
for other threads.

This API will be utilized by subdocument as part of
macro expansion

Change-Id: Ia29115af263ac764aeadf822455a6f30ff6081c4
Reviewed-on: http://review.couchbase.org/70434
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


# 42031746 28-Nov-2016 Trond Norbye <trond.norbye@gmail.com>

Fix warnings reported by Coverty

Change-Id: I20fd35bc6d2376aea5000df40524935dd9721d37
Reviewed-on: http://review.couchbase.org/70379
Tested-by: buildbot <build@couchbase.com>
Rev

Fix warnings reported by Coverty

Change-Id: I20fd35bc6d2376aea5000df40524935dd9721d37
Reviewed-on: http://review.couchbase.org/70379
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


# fbfe6e1d 22-Nov-2016 Jim Walker <jim@couchbase.com>

MB-21763: Move final C modules to C++

Remove all of the C modules from memcached. Fairly simple and requires
some changes mostly for const and void* usage.

Change-Id: Ib2a741944

MB-21763: Move final C modules to C++

Remove all of the C modules from memcached. Fairly simple and requires
some changes mostly for const and void* usage.

Change-Id: Ib2a7419448448102fe1c6bd61d4b03596166ad1b
Reviewed-on: http://review.couchbase.org/70261
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...


Revision tags: v4.5.1-MP1_mc, v4.6.0-DP_mc, v4.6.0-DP_ep
# bf7ee064 10-Oct-2016 Trond Norbye <trond.norbye@gmail.com>

Let the core implement arithmetic

The motivation behind this is to avoid having to implement
support for XATTRs in all underlying engines

Change-Id: Ibd87139595e09537a7bf13ce34d

Let the core implement arithmetic

The motivation behind this is to avoid having to implement
support for XATTRs in all underlying engines

Change-Id: Ibd87139595e09537a7bf13ce34d1baac471f9b56
Reviewed-on: http://review.couchbase.org/68558
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


Revision tags: v4.5.1-MP1_ep, v4.1.2-MP2_mc, v4.5.1_mc, v4.6.0_mc, v4.1.2-MP1_ep
# 0e15cfcb 14-Jul-2016 Trond Norbye <trond.norbye@gmail.com>

Refactor: Let the core implement append/prepend

This was initially added to the underlying engines so that they
could implement append/prepend more efficiently by using different
chu

Refactor: Let the core implement append/prepend

This was initially added to the underlying engines so that they
could implement append/prepend more efficiently by using different
chunks of memory, but we never ended up doing that. Now that
we are going to add the XATTRs we would like to avoid having
all underlying engines to have code to handle that so we're
just moving the already existing append/prepend logic up from
the clients.

Change-Id: If75d6b52cb09e392a2ffa09fc10991e40b6f5bdf
Reviewed-on: http://review.couchbase.org/65776
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


# aa327187 18-Aug-2016 Dave Rigby <daver@couchbase.com>

MB-20586: Update memcached to use cb_malloc memory API

For all instances where we control C-style memory allocation, replace
with calls to cb_malloc/cb_realloc etc.

There are a

MB-20586: Update memcached to use cb_malloc memory API

For all instances where we control C-style memory allocation, replace
with calls to cb_malloc/cb_realloc etc.

There are a small number of instances where memory is allocated on our
behalf inside a library function, for example asprintf(). In such
cases we must still use free() to match the (internal) malloc().

Change-Id: I3e93d3a4bc2c8103e7da96ef448df1c226564528
Reviewed-on: http://review.couchbase.org/67087
Well-Formed: buildbot <build@couchbase.com>
Reviewed-by: Daniel Owen <owend@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...


12345678