Use spdlogger for everything

Remove the old stderr and stdout loggers and use the spdlogger
everywhere (and remove the ability to install custom loggers).

Change-Id: Ibd5a5d6775

Use spdlogger for everything

Remove the old stderr and stdout loggers and use the spdlogger
everywhere (and remove the ability to install custom loggers).

Change-Id: Ibd5a5d6775970e33664341f2476dd2dee709abff
Reviewed-on: http://review.couchbase.org/88781
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

Fix compile warnings reported by gerrit

The gerrit configuration was incorrectly configured with
respect to warning detection causing the warning score to
be reported incorrectly. Th

Fix compile warnings reported by gerrit

The gerrit configuration was incorrectly configured with
respect to warning detection causing the warning score to
be reported incorrectly. This patch address those issues.

Change-Id: Iff731a25f1671a9a235ffd1d6678c6c4a046bb8d
Reviewed-on: http://review.couchbase.org/71807
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

MB-21763: Move final C modules to C++

Remove all of the C modules from memcached. Fairly simple and requires
some changes mostly for const and void* usage.

Change-Id: Ib2a741944

MB-21763: Move final C modules to C++

Remove all of the C modules from memcached. Fairly simple and requires
some changes mostly for const and void* usage.

Change-Id: Ib2a7419448448102fe1c6bd61d4b03596166ad1b
Reviewed-on: http://review.couchbase.org/70261
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

MB-20586: Update memcached to use cb_malloc memory API

For all instances where we control C-style memory allocation, replace
with calls to cb_malloc/cb_realloc etc.

There are a

MB-20586: Update memcached to use cb_malloc memory API

For all instances where we control C-style memory allocation, replace
with calls to cb_malloc/cb_realloc etc.

There are a small number of instances where memory is allocated on our
behalf inside a library function, for example asprintf(). In such
cases we must still use free() to match the (internal) malloc().

Change-Id: I3e93d3a4bc2c8103e7da96ef448df1c226564528
Reviewed-on: http://review.couchbase.org/67087
Well-Formed: buildbot <build@couchbase.com>
Reviewed-by: Daniel Owen <owend@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

Do not use 'free' in DTrace probe name

Otherwise dtrace tool on FreeBSD changes 'free' symbol to 'ree' in slab.c.o

--- nm.before.txt 2016-08-18 17:32:59.595067000 +0300
++

Do not use 'free' in DTrace probe name

Otherwise dtrace tool on FreeBSD changes 'free' symbol to 'ree' in slab.c.o

--- nm.before.txt 2016-08-18 17:32:59.595067000 +0300
+++ nm.after.txt 2016-08-18 17:33:24.939326000 +0300
@@ -25,21 +25,21 @@
00000000000000ad r .L.str.9
0000000000000000 r .LCPI1_0
0000000000000010 r .LCPI1_1
- U __dtrace_memcached___slabs__allocate
- U __dtrace_memcached___slabs__allocate__failed
- U __dtrace_memcached___slabs__free
- U __dtrace_memcached___slabs__slabclass__allocate
- U __dtrace_memcached___slabs__slabclass__allocate__failed
+0000000000000000 A __dtrace_memcached___slabs-allocate
+0000000000000000 A __dtrace_memcached___slabs-allocate-failed
+0000000000000000 A __dtrace_memcached___slabs-free
+0000000000000000 A __dtrace_memcached___slabs-slabclass-allocate
+0000000000000000 A __dtrace_memcached___slabs-slabclass-allocate-failed
00000000000002e0 T add_statistics
U atol
U cb_assert_die
U cb_mutex_enter
U cb_mutex_exit
- U free
U getenv
U malloc
U memset
U realloc
+ U ree
0000000000000b90 T slabs_adjust_mem_requested
00000000000004e0 T slabs_alloc
0000000000000000 T slabs_clsid

Change-Id: I58bd531d0fd9fe919510a93de9efb08b96dbd9c4
Reviewed-on: http://review.couchbase.org/66869
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

MB-19605: Check return values from snprintf

snprintf does not return -1 if the buffer is too small
which could lead to buffer overflow.

Change-Id: Iae2ecd1623a69d54d8690d92bdf6e

MB-19605: Check return values from snprintf

snprintf does not return -1 if the buffer is too small
which could lead to buffer overflow.

Change-Id: Iae2ecd1623a69d54d8690d92bdf6e66891142afa
Reviewed-on: http://review.couchbase.org/63966
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Will Gardner <will.gardner@couchbase.com>

show more ...

MB-16056: Replace uses of abort() with close_connection

For abort()s which were used for various logic errors while processing
connection requests, replace with closing the affected conn

MB-16056: Replace uses of abort() with close_connection

For abort()s which were used for various logic errors while processing
connection requests, replace with closing the affected connection (and
logging where appropriate).

In one instance (where the abort() really is fatal), replace with
cb_assert().

Change-Id: Iffbad8fb2f48d6f76817afb4c86ce428ff94285c
Reviewed-on: http://review.couchbase.org/54909
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Drop per-slab stat collection

It was never used (code to report it back was never implemented
and it is purely memcached buckets specific)

Change-Id: I3fb1c085eb2c74aed3c5356a69

Drop per-slab stat collection

It was never used (code to report it back was never implemented
and it is purely memcached buckets specific)

Change-Id: I3fb1c085eb2c74aed3c5356a699bbe74982e2499
Reviewed-on: http://review.couchbase.org/53060
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

Valgrind of default_engine:

Problems identified running basic testsuite.

1) Fix some leaks in the test harness code.
2) Fix a leak in default_engine to ensure global_assoc is fr

Valgrind of default_engine:

Problems identified running basic testsuite.

1) Fix some leaks in the test harness code.
2) Fix a leak in default_engine to ensure global_assoc is free
3) Add a warning so that we know if we are deleting buckets when someone
still has an item reference.

Change-Id: If953a254e6f7f99a970b700f8082162ddf4f7f37
Reviewed-on: http://review.couchbase.org/52545
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Dave Rigby <daver@couchbase.com>

show more ...

Rename create_instance()

This allows for explicit calling the function to create an
instance instead of having to run dlopen.

Change-Id: I79910e29825e976b7fa889a43283a06c6f1f40b

Rename create_instance()

This allows for explicit calling the function to create an
instance instead of having to run dlopen.

Change-Id: I79910e29825e976b7fa889a43283a06c6f1f40bb
Reviewed-on: http://review.couchbase.org/41189
Tested-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

MSVC does not support %zu

Change-Id: Iedc909a654137cd7b471dbc97edeaf6941d02ecb
Reviewed-on: http://review.couchbase.org/40652
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested

MSVC does not support %zu

Change-Id: Iedc909a654137cd7b471dbc97edeaf6941d02ecb
Reviewed-on: http://review.couchbase.org/40652
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

MB-10476: Use cb_assert which is never a noop

Change-Id: Ibf478e0dc55697ea7b9fe1aff1ac18a4ec1ea0c7
Reviewed-on: http://review.couchbase.org/34580
Reviewed-by: Michael Wiederhold <mik

MB-10476: Use cb_assert which is never a noop

Change-Id: Ibf478e0dc55697ea7b9fe1aff1ac18a4ec1ea0c7
Reviewed-on: http://review.couchbase.org/34580
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: buildbot <build@couchbase.com>

show more ...

Remove compile warnings on windows

The code emitted too many warnings making it impossible
to see if there was any serious warnings being reported

Most of the changes are due to

Remove compile warnings on windows

The code emitted too many warnings making it impossible
to see if there was any serious warnings being reported

Most of the changes are due to return values doing conversions
that would cause some sort of data loss.

Change-Id: Ic5bca0a889d70d903baa8377a54b538d16e4edef
Reviewed-on: http://review.couchbase.org/32736
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Revamp build process

* Build using CMake (http://www.cmake.org)
* Link with tcmalloc instead of dlopen
* Build on Windows by using MSVC
* Platform library hiding threads and mute

Revamp build process

* Build using CMake (http://www.cmake.org)
* Link with tcmalloc instead of dlopen
* Build on Windows by using MSVC
* Platform library hiding threads and mutexes
* Dropped support for UDP
* Ensure that the test applications run on windows!

Change-Id: Iecf1aaa81e95564d3c0918a58d041e074e756ab0
Reviewed-on: http://review.couchbase.org/28671
Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

MB-5543 default_engine must release memory during destroy

Change-Id: If3d74e3eae1f31c2a21264801caef0e34d43305f
Reviewed-on: http://review.couchbase.org/17264
Reviewed-by: Dustin Sall

MB-5543 default_engine must release memory during destroy

Change-Id: If3d74e3eae1f31c2a21264801caef0e34d43305f
Reviewed-on: http://review.couchbase.org/17264
Reviewed-by: Dustin Sallings <dustin@spy.net>
Tested-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Use the logger instead of fprintf

Refactor: move default_engine to a separate directory

Issue 163: Buggy mem_requested values

Check for platform specific header files in configure

And include them through config_static.h to avoid a lot of #ifdefs in
the rest of the code.

The engine should not add the stats terminator

Fixed compile failure when using system malloc

Changes to memcached source required for compilation on windows

Engine can control independent stats per thread.

An engine can control the allocation and management around thread
specific stats.

Refactor: don't use global variables in the engine

Fixed the default chunk size