History log of /6.0.3/kv_engine/include/memcached/protocol_binary.h (Results 1 - 25 of 185)
Revision (<<< Hide revision tags) (Show revision tags >>>) Date Author Comments
Revision tags: v7.0.2, v6.6.3, v7.0.1, v7.0.0, v6.6.2, v6.5.2, v6.6.1, v6.0.5, v6.6.0, v6.5.1, v6.0.4, v6.5.0, v6.0.3, v5.5.4, v5.5.5, v5.5.6, v6.0.1, v5.5.3
# e02120a7 12-Nov-2018 Dave Rigby <daver@couchbase.com>

MB-31967: Allow DCP clients to request datatype without value

Add new DCP_OPEN flag DCP_OPEN_NO_VALUE_WITH_UNDERLYING_DATATYPE,
which acts like DCP_OPEN_NO_VALUE (the documents' value is

MB-31967: Allow DCP clients to request datatype without value

Add new DCP_OPEN flag DCP_OPEN_NO_VALUE_WITH_UNDERLYING_DATATYPE,
which acts like DCP_OPEN_NO_VALUE (the documents' value is not sent),
but it returns the underlying documents' datatype instead of returning
the datatype of the payload.

This is a more backwards-compatible flag to the now-removed
STREAM_REQUEST flag DCP_ADD_STREAM_FLAG_NO_VALUE, and allows consumers
(such as the view engine) to obtain the underlying dataytpe of a
document without having to pay the cost of receiving and parsing the
document value.

Note this new flag assumes clients understand the XATTR datatype -
i.e. by specifying DCP_OPEN_NO_VALUE_WITH_UNDERLYING_DATATYPE clients
should expect to handle any combination of the JSON & XATTR datatype
bits.

Change-Id: Ie24a0dbfa4e65c2219f9ab4c1d842be674e952cf
Reviewed-on: http://review.couchbase.org/101634
Tested-by: Build Bot <build@couchbase.com>
Well-Formed: Build Bot <build@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>
Reviewed-by: <ankit.prabhu@couchbase.com>

show more ...


Revision tags: v6.0.0, v5.1.3, v5.5.2, v5.5.1, v5.1.2, v5.1.1
# 2a704553 16-Mar-2018 Dave Rigby <daver@couchbase.com>

MB-28741: UBSan: fix invalid reads of unscoped enums

UBSan reports an error when we (deliberately) encode an invalid value
for in an enum - for example protocol_binary_subdoc_flag in tes

MB-28741: UBSan: fix invalid reads of unscoped enums

UBSan reports an error when we (deliberately) encode an invalid value
for in an enum - for example protocol_binary_subdoc_flag in test code:

kv_engine/protocol/connection/client_mcbp_commands.cc:510:36:
runtime error: load of value 255, which is not a valid value for type 'protocol_binary_subdoc_flag'

This is because we use an unscoped enum (protocol_binary_subdoc_flag)
without an underlying fixed type, and we deliberately assign a value
which is outside the set of defined subdoc_flag values.

As per the C++ standard[1] (and highlighted by INT50-CPP[2]), this
results in undefined behaviour, due to how the valid values of the
enum are defined:

10.2.7: For an enumeration whose underlying type is fixed, the
values of the enumeration are the values of the underlying
type.
Otherwise, for an enumeration where emin is the smallest
enumerator and emax is the largest, the values of the enumeration
are the values in the range bmin to bmax, defined as follows: Let
K be 1 for a two’s complement representation and 0 for a one’s
complement or sign-magnitude representation. bmax is the smallest
value greater than or equal to max(|emin| − K, |emax|) and equal
to 2M − 1, where M is a non-negative integer. bmin is zero if emin
is non-negative and −(bmax + K) otherwise. The size of the
smallest bit-field large enough to hold all the values of the
enumeration type is max(M, 1) if bmin is zero and M + 1
otherwise. It is possible to define an enumeration that has values
not defined by any of its enumerators. If the enumerator-list is
empty, the values of the enumeration are as if the enumeration had
a single enumerator with value 0.

(The above basically says that for an unscoped enum without an
underlying fixed type, the range of valid values are derived from the
set of enumerations in the type).

Additionally, when converting to an enum:

8.2.9.10: A value of integral or enumeration type can be
explicitly converted to an enumeration type. The value is
unchanged if the original value is within the range of the
enumeration values (7.2). Otherwise, the resulting value is
undefined.

To summarise - for an unscoped enum without a fixed type, it is
undefined to assign a value which is outside the range of the defined
enumerations.

The same isn't the case for scoped enums, or for unscoped enums with a
fixed type. While changing to scoped enums is generally a Good Idea,
that's a more invasive change at this point, so instead we choose to
stick with an unscoped enum, specify a fixed underlying type.

[1]: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/n4659.pdf
[2]: https://wiki.sei.cmu.edu/confluence/display/cplusplus/INT50-CPP.+Do+not+cast+to+an+out-of-range+enumeration+value

Change-Id: Ic14fc597ef612fcbf9f5dbc220497571c4a5b103
Reviewed-on: http://review.couchbase.org/91096
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Paolo Cocchi <paolo.cocchi@couchbase.com>

show more ...


# ab711953 07-Mar-2018 Tim Bradgate <tim.bradgate@couchbase.com>

MB-27661 [11/n]: Fix MSVC warnings - C4267

This patch addresses the following generated warnings:

C4267 - var : conversion from 'size_t' to 'type', possible loss of data

MB-27661 [11/n]: Fix MSVC warnings - C4267

This patch addresses the following generated warnings:

C4267 - var : conversion from 'size_t' to 'type', possible loss of data
The compiler detected a conversion from size_t to a smaller type.

This is the second and final commit addressing this error.

Change-Id: If23806c43a2024df2d4103f1b40cbd790957f1f0
Reviewed-on: http://review.couchbase.org/90604
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


# c19807c3 06-Mar-2018 Paolo Cocchi <paolo.cocchi@couchbase.com>

MB-28289: Allow GetFailoverLog on a regular-MCBP connection

Currently GetFailoverLog is a DCP command, thus a client needs to open
a DCP connection to get the failover log for a given VB

MB-28289: Allow GetFailoverLog on a regular-MCBP connection

Currently GetFailoverLog is a DCP command, thus a client needs to open
a DCP connection to get the failover log for a given VBucket.
Also, the DCP GetFailoverLog command requires the client to open a
DcpProducer on the node; the connection is closed otherwise.
We introduce a new MCBP GetFailoverLog command so that a client can
retrieve the Failover Log for a given VBucket via a regular MBCP
(non-DCP) connection. We keep the old DCP command for backward
compatibility.

Change-Id: I21445149f509636dbc20059e1c8d3f36af8b38c0
Reviewed-on: http://review.couchbase.org/90527
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


# 36668eac 26-Jan-2018 Jim Walker <jim@couchbase.com>

MB-27457: [7/n] Update the dcp_deletion protocol and executors/validators

Update the protocol so that the update to DCP deletion has its own
clear packet definition (v2), update the vali

MB-27457: [7/n] Update the dcp_deletion protocol and executors/validators

Update the protocol so that the update to DCP deletion has its own
clear packet definition (v2), update the validators and executor
callbacks so that we can send and receive the new packet definitions.

Note: Externally no client can yet enable 'delete-time' as the
dcp_open command is still stripping that flag from the open command.

Change-Id: I69cdbdafb3b2bcf37e9e7f76ab9ca51b26c0bba0
Reviewed-on: http://review.couchbase.org/88428
Reviewed-by: Paolo Cocchi <paolo.cocchi@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


# f53cb5f9 24-Jan-2018 Jim Walker <jim@couchbase.com>

MB-27457: [6/n] Allow DCP producer to send the delete time

The DCP producer will need to send any delete_time it gets from
disk to clients which have enabled the feature.

1. Add

MB-27457: [6/n] Allow DCP producer to send the delete time

The DCP producer will need to send any delete_time it gets from
disk to clients which have enabled the feature.

1. Add a new DCP open flag to the protocol
1.1 This flag is not yet known to the mcbp validator, so this WIP
feature is disabled to real clients.
2. Have the producer track the state of this flag (on/off)
3. When on, an alternative dcp_delete callback is used which can
accept the delete_time parameter.

This commit only updates KV-engine, subsequent commits will link up
to the real connection.

A test is added using the DcpProducer to show that we can retrieve
the delete-time of backfilled items, in-memory deletes and expired
items. When an expired item is produced (as a dcp-delete) the time
it has is the logical time it expired, i.e. its expiry-time, not
the actual time ep-engine deleted the item.

Change-Id: I76ddbbdbd33f14fcbabde4eb77d29713a1a9fba6
Reviewed-on: http://review.couchbase.org/88302
Reviewed-by: Paolo Cocchi <paolo.cocchi@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


# 0eb99f81 23-Jan-2018 Jim Walker <jim@couchbase.com>

MB-27457: [5/n] Allow KV-engine to set the delete time

1. Update queueDirty so that it assigns a time to all deletions that
don't already have a time assigned (allowing DCP to see the de

MB-27457: [5/n] Allow KV-engine to set the delete time

1. Update queueDirty so that it assigns a time to all deletions that
don't already have a time assigned (allowing DCP to see the delete
time, not just couchstore).

2. Update couch-kvstore so that it no longer assigns the timestamp
to deletes.

3. Update DCP consumer so that a V2 delete interface is available
enabling the consumer to accept a deleteTime and set it into the item.

4. For DeleteWithMeta, the existing protocol 'expiry' field can now be
used to set a delete_time. The old deleteWithMeta packet though just
copied the setWithMeta meta fields, giving it a timestamp field named
exptime, for clarity I've changed the protocol struct just so we have
a more distinct name for the field. With this change a client can
set the tombstone time by passing a deleteWithMeta with a non-zero
delete_time field.

Tests are added covering the DCP consumer API and DeleteWithMeta
showing that both interfaces can set the time when creating a delete.

Change-Id: Id79ec006ee37a62d740827054b8b369933dc3253
Reviewed-on: http://review.couchbase.org/88301
Reviewed-by: Paolo Cocchi <paolo.cocchi@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


# 958396a6 19-Jan-2018 Jim Walker <jim@couchbase.com>

MB-27457: [3/n] Give dcp_expiry its own packet definition

dcp_delete will be updated so that current format loses collections
and a new v2 format added will gain collections/delete-time.

MB-27457: [3/n] Give dcp_expiry its own packet definition

dcp_delete will be updated so that current format loses collections
and a new v2 format added will gain collections/delete-time.

Even though ep-engine doesn't generate expiry DCP messages, there will
be no need to add delete-time to expiry (delete-time only applies to
delete items being streamed back from disk).

It's simpler to make the current delete definition become expiry so
that all of the code (mostly tests) which handles the expiry format
don't need changes too.

Change-Id: Iaa15359608572f862d066c511dc6a8c04c74a2af
Reviewed-on: http://review.couchbase.org/88299
Reviewed-by: Tim Bradgate <tim.bradgate@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


# 2b9cd2be 05-Feb-2018 Dave Rigby <daver@couchbase.com>

Remove ForestKVStore

Remove support for ForestDB in KV-Engine. This code has already
bit-rotted (doesn't currently compile).

Change-Id: I3d4679da46d1b105be0b234f2193033b3edc3866

Remove ForestKVStore

Remove support for ForestDB in KV-Engine. This code has already
bit-rotted (doesn't currently compile).

Change-Id: I3d4679da46d1b105be0b234f2193033b3edc3866
Reviewed-on: http://review.couchbase.org/88863
Reviewed-by: Jim Walker <jim@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


# 3fe022f7 26-Jan-2018 Timofey Barmin <timofey.barmin@gmail.com>

Fix subdoc format description to match code

Change-Id: Ib930b068a0da40555dcad31deac81e30ec484f1c
Reviewed-on: http://review.couchbase.org/88545
Tested-by: Timofey Barmin <timofey.bar

Fix subdoc format description to match code

Change-Id: Ib930b068a0da40555dcad31deac81e30ec484f1c
Reviewed-on: http://review.couchbase.org/88545
Tested-by: Timofey Barmin <timofey.barmin@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


# 9bd5a579 20-Dec-2017 Manu Dhundi <manu@couchbase.com>

MB-27290: Add "STRICT_VBUUID" flag in DCP_ADD_STREAM

Clients can have a diverging (w.r.t producer) branch at start_seqno 0
and in such a case, some of them strictly need a rollback (MB-2

MB-27290: Add "STRICT_VBUUID" flag in DCP_ADD_STREAM

Clients can have a diverging (w.r.t producer) branch at start_seqno 0
and in such a case, some of them strictly need a rollback (MB-25785)
and others strictly don't.

That is, some clients like the backup client in MB-25785, expect a
rollback at seqno 0 upon vb_uuid mismatch. This is because the client
wants to track what snapshot it is building even if that starts from
seqno 0. However, other legacy clients like our own DCP replication
consumer in 4.5.x and lower release versions, are not tuned to
handle rollbacks at seqno 0 upon vb_uuid mismatch (that is, they
will not try to get a matching vb_uuid upon a rollback at seqno 0)
as they don't care about the diverging history at seqno 0.

This commit adds a flag "DCP_ADD_STREAM_STRICT_VBUUID" in the
DCP_ADD_STREAM call so that the clients that demand a rollback when
there is a diverging branch at start_seqno 0 can identify themselves
by setting that flag.

Change-Id: I528d2318bf014c009b5a1c4b4e19a4fd709756ac
Reviewed-on: http://review.couchbase.org/87130
Well-Formed: Build Bot <build@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


Revision tags: v5.0.1
# 901d1ab8 05-Dec-2017 Jim Walker <jim@couchbase.com>

MB-27121: [3/3] Plumb GET_MANIFEST opcode into engines

Add the opcode and required functions so that we can accept and
process a collections get manifest command.

Change-Id: If9

MB-27121: [3/3] Plumb GET_MANIFEST opcode into engines

Add the opcode and required functions so that we can accept and
process a collections get manifest command.

Change-Id: If9be0721d55c6bc233290e370f7c599f1a502fc2
Reviewed-on: http://review.couchbase.org/86442
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


# 9628a0d6 07-Dec-2017 Jim Walker <jim@couchbase.com>

MB-27122: [2/2] Do not initialise the current manifest

As described in the MB, it is risky to initialise the current manifest
to a 'default' state. It is safer to run without a manifest

MB-27122: [2/2] Do not initialise the current manifest

As described in the MB, it is risky to initialise the current manifest
to a 'default' state. It is safer to run without a manifest as we
really should only operate on what the cluster_manager tells us.

This leads to one situation in DcpOpen where we must fail the open
if the manifest hasn't yet been set, this situation is now flagged
by a new error code "no_collections_manifest" allowing what should
be a temporary failure (cluster manager should always push a manifest)
to be observed.

Change-Id: I79804bbc97da6ba00182355815abe53ad1125da1
Reviewed-on: http://review.couchbase.org/86514
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


Revision tags: v5.1.0
# 0a872aae 04-Oct-2017 Trond Norbye <trond.norbye@gmail.com>

Drop unused feature init_complete

The functionality was never enabled as it would require
bigger changes in ns_server to be useful in all scenarios.
As it stands today it is only usa

Drop unused feature init_complete

The functionality was never enabled as it would require
bigger changes in ns_server to be useful in all scenarios.
As it stands today it is only usable in the scenario of
a cold startup of memcached. During other scenarios
(like rebalance) the node is already expected to be
"initialized" and it won't work in such situations.

Change-Id: I5eb098804a00668126c1b4cd3144e7bfaeea8ea3
Reviewed-on: http://review.couchbase.org/84017
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


Revision tags: v5.0.0
# 2ce7d9fe 24-Aug-2017 Paolo Cocchi <paolo.cocchi@couchbase.com>

MB-25427 [2/4] Move GET_META to memcached - Call new engine API

With this change memcached calls the new engine API for
`get_meta()`.

Change-Id: Ife0b58b3f0d31ce43aec1de96af5a23

MB-25427 [2/4] Move GET_META to memcached - Call new engine API

With this change memcached calls the new engine API for
`get_meta()`.

Change-Id: Ife0b58b3f0d31ce43aec1de96af5a2385d01f351
Reviewed-on: http://review.couchbase.org/82702
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...


# 63a664c5 31-Aug-2017 Trond Norbye <trond.norbye@gmail.com>

Refactor: rename Opcode to ClientOpcode

And introduce cb::mcbp::ServerOpcode for requests sent
by the server

Change-Id: I873efdbd13a260c63951d36dc4d481affafd6c78
Reviewed-on

Refactor: rename Opcode to ClientOpcode

And introduce cb::mcbp::ServerOpcode for requests sent
by the server

Change-Id: I873efdbd13a260c63951d36dc4d481affafd6c78
Reviewed-on: http://review.couchbase.org/83025
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


# 39e9bdd4 02-Aug-2017 Trond Norbye <trond.norbye@gmail.com>

Refactor: move mcbp::Feature to cb::mcbp::Feature

Add the features to the new protocol library and make sure
that we detect it at build time if we add a new feature
without updating

Refactor: move mcbp::Feature to cb::mcbp::Feature

Add the features to the new protocol library and make sure
that we detect it at build time if we add a new feature
without updating our code.

Change-Id: I02393958e8ce0d9449db0d86411dc7569d78071f
Reviewed-on: http://review.couchbase.org/81965
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


# f83362ab 01-Aug-2017 Trond Norbye <trond.norbye@gmail.com>

MB-24553: Add unique error code for invalid xattr order

Change-Id: I56164d9bd3f6f30bd2ebf1e5cfd81d93d11da4d0
Reviewed-on: http://review.couchbase.org/81678
Tested-by: Build Bot <buil

MB-24553: Add unique error code for invalid xattr order

Change-Id: I56164d9bd3f6f30bd2ebf1e5cfd81d93d11da4d0
Reviewed-on: http://review.couchbase.org/81678
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Oliver Downard <oliver.downard@couchbase.com>
Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>

show more ...


# 993cb077 26-Jul-2017 olivermd <oliver.downard@couchbase.com>

MB-25422: Remove json datatype on body delete

This patch removes the json & snappy datatypes when the body is
deleted during a subdoc multi mutation body deletion. This is
because an

MB-25422: Remove json datatype on body delete

This patch removes the json & snappy datatypes when the body is
deleted during a subdoc multi mutation body deletion. This is
because an empty document cannot be compressed or be json.

Change-Id: I5ca42fdd457e2e654cfb0f2040ba4461a8ea8035
Reviewed-on: http://review.couchbase.org/81427
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


# 10d3884c 26-Jul-2017 olivermd <oliver.downard@couchbase.com>

MB-25422: Add getMeta to default_engine for tests

This patch implements the getMeta opcode for the default_engine so that
one can find the datatype of a deleted document in memcached_tes

MB-25422: Add getMeta to default_engine for tests

This patch implements the getMeta opcode for the default_engine so that
one can find the datatype of a deleted document in memcached_testapp
tests.

While the getMeta functionality could be moved in to memcached, we
haven't done it at this time as it would disrupt the regular ep-engine
getMeta code path. Which is not something we want to do for spock. The
task to move this functionality in to memcached is tracked by MB-25427.

Change-Id: I1c2ded2cfb38736d9f1c54a2c12d6d0841541f63
Reviewed-on: http://review.couchbase.org/81426
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...


# baf19cfd 19-Jul-2017 Daniel Owen <owend@couchbase.com>

MB-20940: [17/n] Tap Removal - Move TapParam to ReplicationParam

The Tap Parameters consisted of the following:
- tap_keepalive
- replication_throttle_queue_cap
- replication_thr

MB-20940: [17/n] Tap Removal - Move TapParam to ReplicationParam

The Tap Parameters consisted of the following:
- tap_keepalive
- replication_throttle_queue_cap
- replication_throttle_cap_pcnt
- replication_throttle_threshold

With the removal of Tap the tap_keepalive parameter is no longer
required and has been removed.

The remaining three parameters are still required and therefore
have been renamed as replication parameters.

The mc_bin_client has been updated to reflect the rename.

The now unused MAX_TAP_KEEP_ALIVE constant is removed.

Change-Id: I26b637c4a5d8241a7b20018534b41bf14ffcf250
Reviewed-on: http://review.couchbase.org/81106
Reviewed-by: Jim Walker <jim@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


# 05663e9e 14-Jul-2017 Daniel Owen <owend@couchbase.com>

MB-20940: [5/n] Tap Removal - Remove CMD_CHANGE_VB_FILTER

As part of Tap Removal, this patch removes the
PROTOCOL_BINARY_CMD_CHANGE_VB_FILTER command and associated functions.

C

MB-20940: [5/n] Tap Removal - Remove CMD_CHANGE_VB_FILTER

As part of Tap Removal, this patch removes the
PROTOCOL_BINARY_CMD_CHANGE_VB_FILTER command and associated functions.

Change-Id: Ie6466bea4c3c2a55d1d6e9d1ab9c15d7c521f2a9
Reviewed-on: http://review.couchbase.org/80931
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


# 7ccc4695 14-Jul-2017 Daniel Owen <owend@couchbase.com>

MB-20940: [4/n] Tap Removal - Remove CMD_RESET_REPLICATION_CHAIN

As part of Tap Removal, this patch removes the
PROTOCOL_BINARY_CMD_RESET_REPLICATION_CHAIN command and associated
fun

MB-20940: [4/n] Tap Removal - Remove CMD_RESET_REPLICATION_CHAIN

As part of Tap Removal, this patch removes the
PROTOCOL_BINARY_CMD_RESET_REPLICATION_CHAIN command and associated
functions.

Change-Id: I5361cc717c674c12af2a225dba9052cd5155d6dc
Reviewed-on: http://review.couchbase.org/80735
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>

show more ...


# 31a0e770 14-Jul-2017 Daniel Owen <owend@couchbase.com>

MB-20940: [3/n] Tap Removal - Remove CMD_DEREGISTER_TAP_CLIENT

As part of Tap Removal, this patch removes the
PROTOCOL_BINARY_CMD_DEREGISTER_TAP_CLIENT command and associated
functio

MB-20940: [3/n] Tap Removal - Remove CMD_DEREGISTER_TAP_CLIENT

As part of Tap Removal, this patch removes the
PROTOCOL_BINARY_CMD_DEREGISTER_TAP_CLIENT command and associated
functions.

Change-Id: I0b7f99efe6b7467f4c70660f76266baf6a6a9c8f
Reviewed-on: http://review.couchbase.org/80731
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>

show more ...


# 15cbbd3b 22-Jun-2017 Jim Walker <jim@couchbase.com>

MB-24966: Add skip_conflict_resolution flag for with_meta operations

Rename the existing SKIP_CONFLICT_RESOLUTION_FLAG to be
FORCE_WITH_META_OP as it

1) skips conflict checks

MB-24966: Add skip_conflict_resolution flag for with_meta operations

Rename the existing SKIP_CONFLICT_RESOLUTION_FLAG to be
FORCE_WITH_META_OP as it

1) skips conflict checks
2) allows writes to replica and pending vbuckets

Add a new SKIP_CONFLICT_RESOLUTION_FLAG option that only skips
conflict checking.

Change-Id: If7066281ca937786f26c1fe84999ccfa4eea492e
Reviewed-on: http://review.couchbase.org/79883
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...


12345678