Revision tags: v7.0.2, v6.6.3, v7.0.1, v7.0.0, v6.6.2, v6.5.2, v6.6.1, v6.0.5, v6.6.0, v6.5.1, v6.0.4, v6.5.0 |
|
#
3e816d39 |
| 26-Sep-2019 |
Dave Rigby <daver@couchbase.com> |
Configuration: mark if each parameter is dynamic or not Modify genconfig and Configuration class to include if a value is dynamic (can be changed at runtime once initial value set).
Configuration: mark if each parameter is dynamic or not Modify genconfig and Configuration class to include if a value is dynamic (can be changed at runtime once initial value set). Allow instrospection of the dynamic field by adding a visit() method to Configuration which invokes the provided callback for each config parameter currently available. Change-Id: Ie30089eb4c221596bc488ae9b1c18e004c6fc0a3 Reviewed-on: http://review.couchbase.org/115438 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Trond Norbye <trond.norbye@couchbase.com>
show more ...
|
Revision tags: v6.0.3 |
|
#
440f45bc |
| 18-Sep-2019 |
Dave Rigby <daver@couchbase.com> |
Configuration: Add explicit addParameter() method Add an explicit method to add new configuration paramters, instead of having setParameter handle both use-cases (adding a new paramter a
Configuration: Add explicit addParameter() method Add an explicit method to add new configuration paramters, instead of having setParameter handle both use-cases (adding a new paramter and changing an existing parameter's value. This both makes usage more explicit (and avoids runtime code potentially creating a new config parameter unexpectedly), and is also in preparation for including the 'dynamic' field of a config parameter (which should only be specified when creating a new param). Change-Id: I1ad5eb372c5909c867755e74397fa8a04ed47ebe Reviewed-on: http://review.couchbase.org/115412 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Trond Norbye <trond.norbye@couchbase.com>
show more ...
|
#
1c1309fe |
| 18-Sep-2019 |
Dave Rigby <daver@couchbase.com> |
Simplify string literals in genconfig Use C++11 raw string literals to simplify printing the preambles for generated_configuration.{cc,h}. Change-Id: I87528d33b5b84ff1a9d22901bf
Simplify string literals in genconfig Use C++11 raw string literals to simplify printing the preambles for generated_configuration.{cc,h}. Change-Id: I87528d33b5b84ff1a9d22901bf60d680088f7a85 Reviewed-on: http://review.couchbase.org/115411 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Trond Norbye <trond.norbye@couchbase.com>
show more ...
|
Revision tags: v5.5.4, v5.5.5 |
|
#
04c1c8ec |
| 20-Mar-2019 |
Trond Norbye <trond.norbye@gmail.com> |
Remove config.h Change-Id: I79eb8c762971255db9d36a5f6461a8a6d0f29249 Reviewed-on: http://review.couchbase.org/106517 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Dave
Remove config.h Change-Id: I79eb8c762971255db9d36a5f6461a8a6d0f29249 Reviewed-on: http://review.couchbase.org/106517 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Dave Rigby <daver@couchbase.com>
show more ...
|
Revision tags: v5.5.6, v6.0.1 |
|
#
8b3dea0c |
| 18-Jan-2019 |
Ben Huddleston <ben.huddleston@couchbase.com> |
MB-30041: Migrate genconfig to nlohmann::json Whilst doing so, bring the file in line with our current coding standards. Change-Id: I34b2e8419363900c7cfec7a9c5b1ac041e8e4f0a
MB-30041: Migrate genconfig to nlohmann::json Whilst doing so, bring the file in line with our current coding standards. Change-Id: I34b2e8419363900c7cfec7a9c5b1ac041e8e4f0a Reviewed-on: http://review.couchbase.org/103783 Reviewed-by: Dave Rigby <daver@couchbase.com> Tested-by: Build Bot <build@couchbase.com>
show more ...
|
#
ee087db5 |
| 12-Dec-2018 |
Richard de Mellow <richard.demellow@couchbase.com> |
Move KV-Engine to use "#pragma once" exclusively Move KV-Engine to use "#pragma once" exclusively over using header guards using "#ifndef HEADER". For this header_define_once_test.py
Move KV-Engine to use "#pragma once" exclusively Move KV-Engine to use "#pragma once" exclusively over using header guards using "#ifndef HEADER". For this header_define_once_test.py has been updated to FAIL if it does not find "#pragma once". Also removed engines/default_engine/slabs.h's circular dependency on engines/default_engine/default_engine_internal.h. Change-Id: Ic2477e17cb2cb49cb7a28d95f9c003bec2541b3d Reviewed-on: http://review.couchbase.org/102800 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
show more ...
|
Revision tags: v5.5.3, v6.0.0, v5.1.3, v5.5.2, v5.5.1 |
|
#
c08c8d1c |
| 03-Jul-2018 |
Sriram Ganesan <sriram@couchbase.com> |
MB-23266: Ensure dynamic field in configuration.json is handled correctly If the dynamic field is set to false or is not set at all, then the the parameter should be considered read-only
MB-23266: Ensure dynamic field in configuration.json is handled correctly If the dynamic field is set to false or is not set at all, then the the parameter should be considered read-only. But, KV-engine interprets it otherwise. Ensure that it is considered as read-only. The config parameters that are dynamic are explicitly marked true. Change-Id: If658c8401d425a23d17e6edd4bbd5c26a15795ee Reviewed-on: http://review.couchbase.org/97343 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Dave Rigby <daver@couchbase.com>
show more ...
|
Revision tags: v5.1.2, v5.1.1 |
|
#
e0c54f04 |
| 17-Mar-2018 |
Trond Norbye <trond.norbye@gmail.com> |
Cleanup: Replace cJSON_Print* with to_string to_string wraps cJSON_Print and cJSON_Free to make sure that the allocated memory is released. Change-Id: I0248cb780c6f8c6ab2df9682f
Cleanup: Replace cJSON_Print* with to_string to_string wraps cJSON_Print and cJSON_Free to make sure that the allocated memory is released. Change-Id: I0248cb780c6f8c6ab2df9682f430958b37b167ab Reviewed-on: http://review.couchbase.org/91143 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Jim Walker <jim@couchbase.com>
show more ...
|
#
822ea99e |
| 26-Feb-2018 |
Trond Norbye <trond.norbye@gmail.com> |
Refactor: Split cJSON_Number into cJSON_Double We barely use the double code (only in reading in failover log and when we parse the configuration file). Let's handle double's in a sp
Refactor: Split cJSON_Number into cJSON_Double We barely use the double code (only in reading in failover log and when we parse the configuration file). Let's handle double's in a special form there to avoid information loss for integers. Change-Id: Ib402e2e1fa5640199b518ed700b592b2be576969 Reviewed-on: http://review.couchbase.org/90055 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Dave Rigby <daver@couchbase.com>
show more ...
|
#
f93d6427 |
| 13-Feb-2018 |
Dave Rigby <daver@couchbase.com> |
generated_configuration: Don't rebuild if unchanged generated_configuration.{cc,h} are auto-generated at build time from a JSON definition file, using a custom code-generation tool (
generated_configuration: Don't rebuild if unchanged generated_configuration.{cc,h} are auto-generated at build time from a JSON definition file, using a custom code-generation tool (genconfig). Currently we rebuild those two source files whenever either the JSON defintion file changes; or when genconfig changes. Given that most of the time generated_configuration.{cc,h} will be unchanged when platform or cJSON changes, we can skip updating them if they are the same as they were previously. To achieve this, we initially create the generated_configuration files with a .temp suffix; then only replace the actual files if the .temp file is different. This should reduce the amount of work needed in incremental builds. Change-Id: I0d7c1368ec46cff51136b3f5605c273e3dcb8205 Reviewed-on: http://review.couchbase.org/89316 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
show more ...
|
Revision tags: v5.0.1, v5.1.0, v5.0.0 |
|
#
d36551bc |
| 06-Sep-2017 |
Eugen-Alexandru Virtan <eugen.virtan@couchbase.com> |
MB-25884: Audit and remove, where possible, uses of array new[] Replace several dynamic arrays with safer hadlers, such as std::vector, std::string or std::unique_ptr. These prevent
MB-25884: Audit and remove, where possible, uses of array new[] Replace several dynamic arrays with safer hadlers, such as std::vector, std::string or std::unique_ptr. These prevent memory leaks caused by array resources not being freed up, and conform to Couchbase's and C++'s best practices. Change-Id: Iad0686e3749120203d9636b0a2a2622ee7db514d Reviewed-on: http://review.couchbase.org/83147 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Dave Rigby <daver@couchbase.com>
show more ...
|
#
ef22f9b0 |
| 25-May-2017 |
Dave Rigby <daver@couchbase.com> |
Move ep-engine to engines/ep
|
#
68841d59 |
| 07-Apr-2017 |
James Harrison <00jamesh@gmail.com> |
Streamline configuration.h Move more out of configuration.h into configuration_impl.h as configuration.h is large and included in a number of places. Change-Id: I099ab7925337267
Streamline configuration.h Move more out of configuration.h into configuration_impl.h as configuration.h is large and included in a number of places. Change-Id: I099ab79253372675f70d677c13e73a2d9c59d74f Reviewed-on: http://review.couchbase.org/76475 Reviewed-by: David Haikney <david.haikney@couchbase.com> Reviewed-by: Dave Rigby <daver@couchbase.com> Tested-by: Build Bot <build@couchbase.com>
show more ...
|
Revision tags: v4.6.2_ep |
|
#
9a7e1093 |
| 28-Mar-2017 |
James Harrison <00jamesh@gmail.com> |
MB-23267: Add ability to hide inapplicable config options This is expressed by declaring the requirements for a particular config option in configuration.json e.g., "ephemeral_f
MB-23267: Add ability to hide inapplicable config options This is expressed by declaring the requirements for a particular config option in configuration.json e.g., "ephemeral_full_policy": { ... "requirements": { "bucket_type": "ephemeral" } } This example prevents "ephemeral_full_policy" from being listed in stats if "bucket_type" is not "ephemeral". Change-Id: I4c85132612f55a4edb7c5497c9744ef63efbd206 Reviewed-on: http://review.couchbase.org/75961 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Dave Rigby <daver@couchbase.com>
show more ...
|
#
b7591f86 |
| 14-Mar-2017 |
James Harrison <00jamesh@gmail.com> |
[Refactor]: Change configuration.cc to use boost::variant Using variant simplifies some aspects of configuration.cc. It also paved the way to templating a number of methods, reducing cod
[Refactor]: Change configuration.cc to use boost::variant Using variant simplifies some aspects of configuration.cc. It also paved the way to templating a number of methods, reducing code repetition. Change-Id: I625c84dd1daa905d38f6ab0e2d7ee31bf998657b Reviewed-on: http://review.couchbase.org/75210 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Dave Rigby <daver@couchbase.com>
show more ...
|
Revision tags: v4.6.2_mc |
|
#
4781fd61 |
| 06-Mar-2017 |
James Harrison <00jamesh@gmail.com> |
MB-22041 [10/N]: Add config aliasing This will allow renaming of config values while maintaining backwards compatability with, e.g., previously set extra_config_string values. T
MB-22041 [10/N]: Add config aliasing This will allow renaming of config values while maintaining backwards compatability with, e.g., previously set extra_config_string values. This is done by changing `attributes` in configuration.cc to use shared pointers, and extending genconfig.cc to facilitate putting a second key in the map with a pointer to the same value_t. For example, in configuration.jason, to add an alias "cache_size" for the parameter "max_size", one could do: "max_size": { "default": "0", "type": "size_t", + "aliases":["cache_size"] }, Additionally, ... + "aliases": "cache_size" ... would be accepted in the case of a single alias. Change-Id: Icd9e9fe0263f026b7e906b41efaea0e2b79ab676 Reviewed-on: http://review.couchbase.org/74694 Reviewed-by: Dave Rigby <daver@couchbase.com> Tested-by: Build Bot <build@couchbase.com>
show more ...
|
Revision tags: v4.6.1_ep |
|
#
ad594c5e |
| 09-Feb-2017 |
James Harrison <00jamesh@gmail.com> |
MB-22041 [6/N]: Limit worker threads to CPU count Change-Id: I42a42c79ba78cf55c38545912e072396443c224b Reviewed-on: http://review.couchbase.org/73510 Reviewed-by: Daniel Owen <owend@
MB-22041 [6/N]: Limit worker threads to CPU count Change-Id: I42a42c79ba78cf55c38545912e072396443c224b Reviewed-on: http://review.couchbase.org/73510 Reviewed-by: Daniel Owen <owend@couchbase.com> Reviewed-by: Manu Dhundi <manu@couchbase.com> Reviewed-by: Trond Norbye <trond.norbye@gmail.com> Tested-by: Build Bot <build@couchbase.com>
show more ...
|
Revision tags: v4.6.0_ep, v4.5.1-MP1_mc, v4.6.0-DP_mc, v4.6.0-DP_ep, v4.5.1-MP1_ep, v4.1.2-MP2_mc, v4.5.1_mc |
|
#
35d1347a |
| 18-Aug-2016 |
Dave Rigby <daver@couchbase.com> |
MB-20586: Use cJSON_Free() to free allocations made by cJSON_Print Otherwise we can get mismatched malloc/free when using cbmalloc or another custom allocator. Change-Id: Ifdd2f
MB-20586: Use cJSON_Free() to free allocations made by cJSON_Print Otherwise we can get mismatched malloc/free when using cbmalloc or another custom allocator. Change-Id: Ifdd2fe031cb6d6c785a77d552b966fa173de1593 Reviewed-on: http://review.couchbase.org/67069 Well-Formed: buildbot <build@couchbase.com> Tested-by: buildbot <build@couchbase.com> Reviewed-by: Jim Walker <jim@couchbase.com>
show more ...
|
Revision tags: v4.6.0_mc, v4.1.2-MP1_ep, v3.1.6_ep, v4.5.0_mc, v4.5.0_ep, v4.1.1_ep, v3.1.5_ep, v4.1.1_mc, v3.1.4_ep, v3.1.4_mc |
|
#
fc93fa1b |
| 21-Jan-2016 |
Will Gardner <will.gardner@couchbase.com> |
MB-17508 3/4 Add support for float and boundless ranges for configuration * Creates a float range validator based on whether the type of the config option is a float rather than if the v
MB-17508 3/4 Add support for float and boundless ranges for configuration * Creates a float range validator based on whether the type of the config option is a float rather than if the validation range is not a rounded number. * Allows for leaving one of the validation range boundaries unspecified which will result in the validation in that direction being set to maximum. Change-Id: I023175cdd9b5ef0b6170c8124fd433eaa0788190 Reviewed-on: http://review.couchbase.org/58938 Reviewed-by: Dave Rigby <daver@couchbase.com> Tested-by: buildbot <build@couchbase.com> Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
show more ...
|
Revision tags: v3.1.5_mc, v3.1.3_ep, v4.1.0_ep, v3.1.2_ep, v4.1.0_mc, v3.1.2_mc, v3.1.1_mc, v3.1.1_ep, v4.0.0_ep, v4.0.0_mc, v3.1.0_ep, v3.1.0_mc, v3.1.6_mc, v3.0.2-MP2_mc, v3.0.2_ep, v3.0.2_mc, v3.0.1_mc, v3.0.0_ep, v3.0.0-beta3_mc, v3.0.0_mc, v3.0.0-beta2_mc, v3.0.0-beta1_mc |
|
#
c649b2d9 |
| 17-Mar-2014 |
Trond Norbye <trond.norbye@gmail.com> |
MB-10476: Use cb_assert instead of assert If compiled with -DNDEBUG assert is an empty macro Change-Id: I266ddf8a8fe3f1a388a9d8ce3d21f28614c35315 Reviewed-on: http://review.couc
MB-10476: Use cb_assert instead of assert If compiled with -DNDEBUG assert is an empty macro Change-Id: I266ddf8a8fe3f1a388a9d8ce3d21f28614c35315 Reviewed-on: http://review.couchbase.org/34579 Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com> Tested-by: Chiyoung Seo <chiyoung@couchbase.com>
show more ...
|
#
7e078dfa |
| 27-Feb-2014 |
Trond Norbye <trond.norbye@gmail.com> |
Move gencode and genconfig back from memcached Change-Id: Ia711001103a91d50b6601915f6498258e8c1d186 Reviewed-on: http://review.couchbase.org/33980 Reviewed-by: Trond Norbye <trond.no
Move gencode and genconfig back from memcached Change-Id: Ia711001103a91d50b6601915f6498258e8c1d186 Reviewed-on: http://review.couchbase.org/33980 Reviewed-by: Trond Norbye <trond.norbye@gmail.com> Tested-by: Trond Norbye <trond.norbye@gmail.com>
show more ...
|
Revision tags: v2.5.1_ep, v2.5.1-MP1-A_mc, v2.5.0_mc, v2.5.0-dp1_mc |
|
#
1da5886b |
| 11-Oct-2013 |
Trond Norbye <trond.norbye@gmail.com> |
Move genconfig/gencode to ../cmake/memcached be moved back when ep-engine is being built by CMake Change-Id: If7aaca45ec63e0b2aa9cc332873865943758d745 Reviewed-on: http://review
Move genconfig/gencode to ../cmake/memcached be moved back when ep-engine is being built by CMake Change-Id: If7aaca45ec63e0b2aa9cc332873865943758d745 Reviewed-on: http://review.couchbase.org/29577 Tested-by: buildbot <build@couchbase.com> Reviewed-by: Michael Wiederhold <mike@couchbase.com>
show more ...
|
Revision tags: v2.2.0_mc, 2.1.1r_ep, 2.1.0r_ep, 2.0.2r_ep, 2.0.2r_mc, 2.0.1-macosx_ep, 2.0.1-linux_ep |
|
#
66eb94d0 |
| 17-Jan-2013 |
Mike Wiederhold <mike@couchbase.com> |
MB-7728: Add copyright headers to all files This is something that our cpplint tool turns on and it makes our product look a little bit more profesional. I have also enabled the tool
MB-7728: Add copyright headers to all files This is something that our cpplint tool turns on and it makes our product look a little bit more profesional. I have also enabled the tool to begin checking for these headers so it will start complaining if we add a new file without a copyright header. Change-Id: Ie956fdf7027bf56d9665ee455acd3c109fcacc76 Reviewed-on: http://review.couchbase.org/24560 Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com> Reviewed-by: Jin Lim <jin@couchbase.com> Tested-by: Michael Wiederhold <mike@couchbase.com>
show more ...
|
Revision tags: 2.0.1-linux_mc, 2.0.0-couchbase_ep |
|
#
244c0146 |
| 26-Nov-2012 |
Mike Wiederhold <mike@couchbase.com> |
MB-7461: Alphabetize includes to conform with c++ standards Change-Id: I71333dedada6530713b90184857bab9ac49d13df Reviewed-on: http://review.couchbase.org/23515 Reviewed-by: Jin Lim <
MB-7461: Alphabetize includes to conform with c++ standards Change-Id: I71333dedada6530713b90184857bab9ac49d13df Reviewed-on: http://review.couchbase.org/23515 Reviewed-by: Jin Lim <jin@couchbase.com> Tested-by: Michael Wiederhold <mike@couchbase.com>
show more ...
|
#
8f48f64b |
| 23-Nov-2012 |
Mike Wiederhold <mike@couchbase.com> |
MB-7426: Fix all header defines to conform with cpplint Change-Id: I8253b640bc49ee8a0fabbb39ece73c2efdb906d5 Reviewed-on: http://review.couchbase.org/23510 Reviewed-by: Michael Wiede
MB-7426: Fix all header defines to conform with cpplint Change-Id: I8253b640bc49ee8a0fabbb39ece73c2efdb906d5 Reviewed-on: http://review.couchbase.org/23510 Reviewed-by: Michael Wiederhold <mike@couchbase.com> Tested-by: Michael Wiederhold <mike@couchbase.com>
show more ...
|