Refactor SpdloggerTest: Move logger::Config to member var

To allow further customization of the logger::Config parameters (apart
from cycle size & log level), move the Config object to a

Refactor SpdloggerTest: Move logger::Config to member var

To allow further customization of the logger::Config parameters (apart
from cycle size & log level), move the Config object to a
SpdloggerTest member variable and remove the arguments to
setUpLogger(). Tests can now change the config member before calling
setUpLogger() if they want to customize anything.

Change-Id: I893eb613c13d49c6dd465ed6ff0d034ef949ec69
Reviewed-on: http://review.couchbase.org/103779
Reviewed-by: Ben Huddleston <ben.huddleston@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

MB-32061: Lower spdlog buffer size

Between spdlog version 0.14.0 and 1.1.0 the async pool buffer
was changed from being specified in MB to number of items. As we
were passing the sam

MB-32061: Lower spdlog buffer size

Between spdlog version 0.14.0 and 1.1.0 the async pool buffer
was changed from being specified in MB to number of items. As we
were passing the same default parameters we were constructing far
larger buffers than necessary (512MB - 2 million items vs 2MB by
default).

Update the default buffersize to 8192 items (2MB).

Set the default cyclesize in unit tests to the default (100MB).
Unit tests that rely on it already modify it beforehand.

Remove the CB_MAXIMIZE_LOGGER_BUFFER_SIZE environment variable.
Given that we now flush the async logger every second, 8192 items
should be plenty.

Change-Id: I8a0b88faa19df571aa768253aebac80c6108cf9b
Reviewed-on: http://review.couchbase.org/101953
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>

show more ...

Optimise logger.h header

- Move logger::Config into it's own file (logger_config.h), changing
all users which just need the logger Config to #include
logger_config.h instead of l

Optimise logger.h header

- Move logger::Config into it's own file (logger_config.h), changing
all users which just need the logger Config to #include
logger_config.h instead of logger.h

- Minimise includes of logger.h; removing where no longer needed in
header files and moving instead to necessary .cc files.

Clean build times:

$ ninja clean
$ CCACHE_DISABLE=true time ninja kv_engine/all -j6

Before (6a3ec65a7):
254.75 real 1426.10 user 78.62 sys
user+sys: 1504

After (d8e692c45):
243.33 real 1366.29 user 76.51 sys
user+sys: 1442

Results in 4% speedup in user+sys build (62s reduction).

Change-Id: I81625a830c3bd7fb7bd0a62a98138334fc3887f5
Reviewed-on: http://review.couchbase.org/99954
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

MB-30302: Spdlog style formatting for EP Engine

Modification of SERVER_LOG_API and EP Engine to allow for spdlog style
formatting in EP Engine. Requires passing a pointer to the spdlog l

MB-30302: Spdlog style formatting for EP Engine

Modification of SERVER_LOG_API and EP Engine to allow for spdlog style
formatting in EP Engine. Requires passing a pointer to the spdlog logger
object to create a new logger to format the log messages and prepend with
the engine name before using the original spdlog logger to print them.

Change-Id: I3711229fba45002d07bf40e2c6cb7f796e91a7bf
Reviewed-on: http://review.couchbase.org/96605
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Tim Bradgate <tim.bradgate@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...