MB-40126: subdoc CreateAsDeleted: User value shouldn't be '{}'

When using the subdoc API to create docuements in the deleted state
with user XAttrs, the user value _should_ be entirely e

MB-40126: subdoc CreateAsDeleted: User value shouldn't be '{}'

When using the subdoc API to create docuements in the deleted state
with user XAttrs, the user value _should_ be entirely empty (apart
from the XATTRs).

However, the user value can incorrectly end up as '{}' (i.e. an empty
JSON object, but _not_ an empty document) in the following situation:

1. If the document doesn't already exist (but the user specifies
doc_flag::MkDoc or doc_flag::Add).
2. If the subdoc mutation doesn't specify a path to the user value.

This occurs because if a existing document doens't exist (but MkDoc or
Add is specified), then a "empty" JSON object '{}' is assigned to be
the input document. If no futher modification of the document occurs,
then the resulting user body is empty JSON oject '{}'.

The solution is to defer creating the empty template object until the
body phase of subdoc_update; only if there's actually one or more
value paths to be applied.

Change-Id: I466d38ef71bd0345e4c45905d85ebfbb8bda55b6
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/131577
Well-Formed: Build Bot <build@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Paolo Cocchi <paolo.cocchi@couchbase.com>

show more ...

MB-37374: Verify that docs can be created in Deleted state via SyncWrite

Expand the existing XattrNoDocTest to create deleted docs via SyncWrite.
Note that the SDK writes for staged docs

MB-37374: Verify that docs can be created in Deleted state via SyncWrite

Expand the existing XattrNoDocTest to create deleted docs via SyncWrite.
Note that the SDK writes for staged docs are SyncWrites.

Change-Id: Ie4cc27c712e90d68a8b15588822f01104c4f26ef
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/127510
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Well-Formed: Build Bot <build@couchbase.com>

show more ...

MB-37374: Allow to create user-xattr docs in Deleted state

For transactions, the SDK is currently staging mutations in temporary
Alive documents. The SDK inserts the staged payload in so

MB-37374: Allow to create user-xattr docs in Deleted state

For transactions, the SDK is currently staging mutations in temporary
Alive documents. The SDK inserts the staged payload in some user-xattr.
The side effect is that staged (non-committed) docs are visible at read.

Here we allow the SDK to create the same kind of docs in Deleted state.
Deleted docs are not visible at read unless specifically requested.

Change-Id: I3987ed979302d3174424475962c467207f423aaf
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/121498
Well-Formed: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

Refactor: let Cookie inherit from cb::tracing::Traceable

Previously Traceable and Cookie "just looked the same" by using
same memory layout for the two first member variables. Change thi

Refactor: let Cookie inherit from cb::tracing::Traceable

Previously Traceable and Cookie "just looked the same" by using
same memory layout for the two first member variables. Change this
to let Cookie inherit from Traceable.

Change-Id: I102c920dae15104471ecb120414eb2d0fa4fa805
Reviewed-on: http://review.couchbase.org/116513
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

MB-36321: DelWithMeta allowed caller to store whatever

DelWithMeta should only accept a payload containing system
extended attributes. If not it should fail with EINVAL (a
normal del

MB-36321: DelWithMeta allowed caller to store whatever

DelWithMeta should only accept a payload containing system
extended attributes. If not it should fail with EINVAL (a
normal delete will prune the documents value and user attributes
but leave the system attributes behind). DelWithMeta should
work the same way.

As a "chicken bit" the system _may_ accept documents with
user value and attribute and strip those away as part of
DelWithMeta iff the configuration variable
allow_del_with_meta_prune_user_data is set to true.

Change-Id: I1983bb7fa11dd46cad706f81b37ce9a729aeca6e
Reviewed-on: http://review.couchbase.org/115904
Reviewed-by: Jim Walker <jim@couchbase.com>
Tested-by: Trond Norbye <trond.norbye@couchbase.com>

show more ...

[SSL] Use Cookie::sendResponse for small values

For GAT and Get Locked

Change-Id: I2db412433d3287cde5fe60794bffefc3cf850619
Reviewed-on: http://review.couchbase.org/115576
T

[SSL] Use Cookie::sendResponse for small values

For GAT and Get Locked

Change-Id: I2db412433d3287cde5fe60794bffefc3cf850619
Reviewed-on: http://review.couchbase.org/115576
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Add setOpaque to BinprotCommand

Change-Id: Ic8938e8a1e6e486bf3beecc881addf557eee1a04
Reviewed-on: http://review.couchbase.org/110276
Tested-by: Build Bot <build@couchbase.com>
Re

Add setOpaque to BinprotCommand

Change-Id: Ic8938e8a1e6e486bf3beecc881addf557eee1a04
Reviewed-on: http://review.couchbase.org/110276
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Add support for injecting FrameInfo in test client

Allow all 'commands' to take a function-pointer which injects a
set of FrameInfo fields into the commands being sent (and allow
for

Add support for injecting FrameInfo in test client

Allow all 'commands' to take a function-pointer which injects a
set of FrameInfo fields into the commands being sent (and allow
for updating the BinprotCommands to receive such FrameInfo objects)

Change-Id: Id8365f03a414403cc921244b565541dc9444a716
Reviewed-on: http://review.couchbase.org/109702
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>

show more ...

Testapp: Use execute() instead of executeCommand()

Refactor out all use of executeCommand to make sure execute
is used everywhere (as it may be configured to deal with
ETMPFAIL)

Testapp: Use execute() instead of executeCommand()

Refactor out all use of executeCommand to make sure execute
is used everywhere (as it may be configured to deal with
ETMPFAIL)

Change-Id: I29a5a69cd902c96175061bcde4b6cb14f6f16509
Reviewed-on: http://review.couchbase.org/109425
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Refactor: use execute() istead of send&recv in client

This is a preparation for being able to configure the client
to deal with tmpfail internally.

Change-Id: I99ae2619976910f79

Refactor: use execute() istead of send&recv in client

This is a preparation for being able to configure the client
to deal with tmpfail internally.

Change-Id: I99ae2619976910f7904ba52bbe47eac5c8af2cc9
Reviewed-on: http://review.couchbase.org/109420
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

Refactor: Remove BinprotResponse::getPayload()

Use the appropriate method in Response instead

Change-Id: Ia8bd57768a67fc52e505817c1de5a42182b55125
Reviewed-on: http://review.cou

Refactor: Remove BinprotResponse::getPayload()

Use the appropriate method in Response instead

Change-Id: Ia8bd57768a67fc52e505817c1de5a42182b55125
Reviewed-on: http://review.couchbase.org/109419
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

Extend test client with func to set vbucket state

And package definition of DcpAddStream

Change-Id: I2ac24592b30196f3403322337ee1fe884b72956a
Reviewed-on: http://review.couchbas

Extend test client with func to set vbucket state

And package definition of DcpAddStream

Change-Id: I2ac24592b30196f3403322337ee1fe884b72956a
Reviewed-on: http://review.couchbase.org/109104
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

Refactor: make fillHeader private

This change force all users to call writeHeader to insert
the header into the destination vector.

Change-Id: Ic8e14d0b53fa97495d6ddaf04adbf650c

Refactor: make fillHeader private

This change force all users to call writeHeader to insert
the header into the destination vector.

Change-Id: Ic8e14d0b53fa97495d6ddaf04adbf650c4a9859f
Reviewed-on: http://review.couchbase.org/105653
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

Remove unused method setValueBuffers

Change-Id: Ibb9a6343c76e0c26f13b5374735085079373c81a
Reviewed-on: http://review.couchbase.org/105655
Tested-by: Build Bot <build@couchbase.com>

Remove unused method setValueBuffers

Change-Id: Ibb9a6343c76e0c26f13b5374735085079373c81a
Reviewed-on: http://review.couchbase.org/105655
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Richard de Mellow <richard.demellow@couchbase.com>

show more ...

Remove explicit Encoded constructor

The compiler will generate this

Change-Id: Ic01820a5a05505405b0dcb72da3d21899ec4b9aa
Reviewed-on: http://review.couchbase.org/105656
Test

Remove explicit Encoded constructor

The compiler will generate this

Change-Id: Ic01820a5a05505405b0dcb72da3d21899ec4b9aa
Reviewed-on: http://review.couchbase.org/105656
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Richard de Mellow <richard.demellow@couchbase.com>

show more ...

MB-31429: Add support for getting a global cluster config

SetClusterConfig use the bucket name in the key,
and the revision number in the extras section

Change-Id: Icb545cfbc96f

MB-31429: Add support for getting a global cluster config

SetClusterConfig use the bucket name in the key,
and the revision number in the extras section

Change-Id: Icb545cfbc96f2b1a616da46fef6ad8a5f7238828
Reviewed-on: http://review.couchbase.org/103167
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>

show more ...

Set CTRL Token command did not use the provided CAS

Instead it used CAS=0 (override)

Change-Id: I5641798951bcdb9096859c0940787285cc3ce584
Reviewed-on: http://review.couchbase.or

Set CTRL Token command did not use the provided CAS

Instead it used CAS=0 (override)

Change-Id: I5641798951bcdb9096859c0940787285cc3ce584
Reviewed-on: http://review.couchbase.org/104369
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

clang-tidy: Clean up warnings in client-connection

Change-Id: Idb97a074aabf2fd1f7f1033b9ac8d15ea037fb2c
Reviewed-on: http://review.couchbase.org/104368
Tested-by: Build Bot <build@co

clang-tidy: Clean up warnings in client-connection

Change-Id: Idb97a074aabf2fd1f7f1033b9ac8d15ea037fb2c
Reviewed-on: http://review.couchbase.org/104368
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Refactor: move old audit tests to testapp_audit.cc

Change-Id: Ice4c1621270fa7e43d5ac13e827f654d7f786f63
Reviewed-on: http://review.couchbase.org/102532
Tested-by: Build Bot <build@co

Refactor: move old audit tests to testapp_audit.cc

Change-Id: Ice4c1621270fa7e43d5ac13e827f654d7f786f63
Reviewed-on: http://review.couchbase.org/102532
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Cleanup in mcbp_client_commands

* Use cb::mcbp::Request/Response internally and not the old
packet structs

* Delete dead code

* use writeHeader instead of fillHeader

Cleanup in mcbp_client_commands

* Use cb::mcbp::Request/Response internally and not the old
packet structs

* Delete dead code

* use writeHeader instead of fillHeader where we don't
need to change the header.

Change-Id: I1856c825814b24145c5ecd982d1a5a9e95040765
Reviewed-on: http://review.couchbase.org/102476
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Remove unused class BinprotDcpMutationCommand

Change-Id: I6cf76f5ea539dcfab6ff934aa382d6c90095944d
Reviewed-on: http://review.couchbase.org/102429
Tested-by: Trond Norbye <trond.norb

Remove unused class BinprotDcpMutationCommand

Change-Id: I6cf76f5ea539dcfab6ff934aa382d6c90095944d
Reviewed-on: http://review.couchbase.org/102429
Tested-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Refactor: Use the get/set methods to update Request

Change-Id: I60c7523adb963fa948c93503f5c183ac04c8e35c
Reviewed-on: http://review.couchbase.org/102428
Tested-by: Build Bot <build@c

Refactor: Use the get/set methods to update Request

Change-Id: I60c7523adb963fa948c93503f5c183ac04c8e35c
Reviewed-on: http://review.couchbase.org/102428
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Refactor: Prepare DCP Mutations for framing extras

Change-Id: Ica4065d2019836cd8fedfcfcc9d9370f9e01627e
Reviewed-on: http://review.couchbase.org/102142
Tested-by: Build Bot <build@co

Refactor: Prepare DCP Mutations for framing extras

Change-Id: Ica4065d2019836cd8fedfcfcc9d9370f9e01627e
Reviewed-on: http://review.couchbase.org/102142
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>

show more ...

Refactor: Move Dcp Open Flag #defines to constants with limited scope

Change-Id: Ie1f3b67e6e20466fb47ff1882de24d12644e4717
Reviewed-on: http://review.couchbase.org/102114
Tested-by:

Refactor: Move Dcp Open Flag #defines to constants with limited scope

Change-Id: Ie1f3b67e6e20466fb47ff1882de24d12644e4717
Reviewed-on: http://review.couchbase.org/102114
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Refactor: prepare Touch/GAT/GetLocked for flex extras

Remove the old binprot definitions

Change-Id: I6426ffed66023e1894c87df2100d78795c82b93c
Reviewed-on: http://review.couchbas

Refactor: prepare Touch/GAT/GetLocked for flex extras

Remove the old binprot definitions

Change-Id: I6426ffed66023e1894c87df2100d78795c82b93c
Reviewed-on: http://review.couchbase.org/101893
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...