Replace Sentinel with ChunkLock (re-apply)

(Re-apply - previous version 9eb4d31 failed on gcc 4.9
environments. Fixed by making the failing static_assert
Apple-only).

Replace Sentinel with ChunkLock (re-apply)

(Re-apply - previous version 9eb4d31 failed on gcc 4.9
environments. Fixed by making the failing static_assert
Apple-only).

This patch replaces the Sentinel with the ChunkLock

This is to account for fundamental limitations with the way the
Sentinel synchronisation type works in terms of invalidating
the reference to the buffer.

Change-Id: I940b0629c8973c3d3693d2df9ef61a976fcae225
Reviewed-on: http://review.couchbase.org/80555
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

show more ...

Revert "Replace Sentinel with ChunkLock"

This patch fails to build on a number of GCC 4.9 architectures:

phosphor/include/phosphor/chunk_lock.h>:206:15: error:
'is_trivi

Revert "Replace Sentinel with ChunkLock"

This patch fails to build on a number of GCC 4.9 architectures:

phosphor/include/phosphor/chunk_lock.h>:206:15: error:
'is_trivially_constructible' is not a member of 'std'

This reverts commit 9eb4d31ebf1501e97aa8a3b353b628934d81e14c.

Change-Id: Ied9ebdbdb341d33eb3e02ed92b14a7246b2a4f29
Reviewed-on: http://review.couchbase.org/80553
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Dave Rigby <daver@couchbase.com>

show more ...

Replace Sentinel with ChunkLock

This patch replaces the Sentinel with the ChunkLock

This is to account for fundamental limitations with the way the
Sentinel synchronisation type

Replace Sentinel with ChunkLock

This patch replaces the Sentinel with the ChunkLock

This is to account for fundamental limitations with the way the
Sentinel synchronisation type works in terms of invalidating
the reference to the buffer.

Change-Id: If0df4dca07b11037aa121ffc8c93167d5923f31b
Reviewed-on: http://review.couchbase.org/79895
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...

Introduce ChunkLock as a Sentinel replacement

This adds phosphor::ChunkLock as a replacement to phosphor::Sentinel
in an upcoming patch. It uses a different name for two reasons:

Introduce ChunkLock as a Sentinel replacement

This adds phosphor::ChunkLock as a replacement to phosphor::Sentinel
in an upcoming patch. It uses a different name for two reasons:

a) The old name could be confused with a sentinel value
b) It allows replacing Sentinel over multiple patches

Change-Id: I4e34f30ca674601eebf975be1b99625a68b8a87d
Reviewed-on: http://review.couchbase.org/72287
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

show more ...